)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5f44f2a7095b5ad720e6177e2f894b05ba1340e6","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[IBM SVf driver] Adding support for callhome plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"[Storage Virtualize family] Added SVC callhome plugin registration for Cinder driver"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"To gain deeper insights into customer adoption of IBM Storage with OpenStack, we have enabled the Call Home feature on the IBM Spectrum Virtualize Family (SVf) driver. This enhancement allows us to collect telemetry data, enabling IBM to better understand how many customers are actively utilizing IBM storage systems in OpenStack environments."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"b1029a7a_b2e1499c","line":9,"updated":"2025-07-03 12:36:33.000000000","message":"This and subsequent lines should be wrapped at 72 chars\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"1a76aa93af17b0c08cea4ead5978d409f3d00e82"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"3ee415c83c85b07b9edbebcc6e7175556d824285","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[IBM SVf driver] Adding support for callhome plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"[Storage Virtualize family] Added SVC callhome plugin registration for Cinder driver"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"To gain deeper insights into customer adoption of IBM Storage with OpenStack, we have enabled the Call Home feature on the IBM Spectrum Virtualize Family (SVf) driver. This enhancement allows us to collect telemetry data, enabling IBM to better understand how many customers are actively utilizing IBM storage systems in OpenStack environments."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"a6406616_dfdf083d","line":9,"in_reply_to":"b1029a7a_b2e1499c","updated":"2025-07-04 18:33:02.000000000","message":"Yes, modified as suggested.","commit_id":"1a76aa93af17b0c08cea4ead5978d409f3d00e82"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"84d9b32f1cdb476b5ef28e5fb92f73a356149038","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d6347b89_851c89f3","updated":"2025-06-09 11:06:14.000000000","message":"1. Commit message needs to be more explanatory about the capability of callhome plugin and why is it being integrated in this driver.\n\n2. UTs need to be added.","commit_id":"700c3c3278fddbd95156716c24c5e19870f07793"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"0961b903cf21898d64906ec177a5818f26039070","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cd0ab5c7_4cd99e83","updated":"2025-06-11 12:32:01.000000000","message":"run-quobyteci","commit_id":"f5f7fff349b46f5547d80fca6cc776414b9c28e1"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"12abf7e6c6b4d5a13c071ab065aadbbdd2197e0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"201989d5_07e811c6","updated":"2025-06-13 05:41:05.000000000","message":"recheck","commit_id":"d36805d24d11a847508bf210fe45d8b41d233495"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"23e66e992a1d2fc5fb0b25d2eb2ce19d43fbc967","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7c4d9ce5_e81c8dc8","updated":"2025-06-12 06:34:48.000000000","message":"recheck","commit_id":"d36805d24d11a847508bf210fe45d8b41d233495"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"72f0308f05dcfe04dcb90e02cb7a777be3996543","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c4c12d95_5ddce30f","updated":"2025-06-30 07:12:42.000000000","message":"recheck","commit_id":"f38ccd31bfc64b3e5ae0b4ea929971ced817cbb5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5f44f2a7095b5ad720e6177e2f894b05ba1340e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"1690fd10_13a5859d","updated":"2025-07-03 12:36:33.000000000","message":"This patch is freaking some people out because from the commit message and release note, it sounds like you are introducing a dependency on a proprietary call-home feature into an open-source product.  I\u0027m assuming that the call-home support you are adding is optional?  If so, please state that clearly in the commit message and release note, and mention that the driver is fully functional as a cinder driver when call-home is not enabled.","commit_id":"1a76aa93af17b0c08cea4ead5978d409f3d00e82"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"a3c2b4ecc78f6e77c88af46d2824a7833809fe7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"202fcd75_5563cd54","in_reply_to":"1690fd10_13a5859d","updated":"2025-07-04 18:32:00.000000000","message":"@rosmaita.fossdev@gmail.com, Thank you for bringing up this important point.\nCall-home support added for the IBM SVC driver is entirely optional and does not introduce any dependency on proprietary features.\nThe commit message has been updated to clarify call-home only collects non-sensitive information such as the OS version, Cinder version, and SVC-specific features like PBHA and PBR.\nAdditionally, the driver remains fully functional as a Cinder driver even if call-home is not enabled.","commit_id":"1a76aa93af17b0c08cea4ead5978d409f3d00e82"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"647233414340e6aaec2cdc62de3d0d15ee8540cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"86ae8fb2_50690615","updated":"2025-07-08 19:02:01.000000000","message":"See comment inline.","commit_id":"521d7e1c4f7e2eb14bb483e7f6d56d798f5c11b5"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"9f9b1106388367677a1abcc73ad9f4dc91fb2e90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"02131b17_0a19730c","updated":"2025-07-16 08:34:17.000000000","message":"recheck","commit_id":"0d9b70c596c6c6e11896f95fb34fc681213fd6b9"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"f067d9426902339ea3ed90ec5fb402f8ce08b0d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"24fddcd1_34774833","updated":"2025-07-22 15:14:48.000000000","message":"recheck","commit_id":"0d9b70c596c6c6e11896f95fb34fc681213fd6b9"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"0012ede90c077cf077de872ec392ff97ee81a0a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"29dd8f6e_66dc8396","updated":"2025-07-12 08:54:03.000000000","message":"recheck","commit_id":"0d9b70c596c6c6e11896f95fb34fc681213fd6b9"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"6e6b6f87268a5a20f6c3880d436daccf2b709f6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"5c48f225_8c59011c","updated":"2025-07-13 05:22:21.000000000","message":"recheck","commit_id":"0d9b70c596c6c6e11896f95fb34fc681213fd6b9"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"5210d06bfafec3df665d7fd9c147e0c287c7ec92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"9611f602_46f4e10b","updated":"2025-07-14 04:15:07.000000000","message":"recheck","commit_id":"0d9b70c596c6c6e11896f95fb34fc681213fd6b9"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"e6a54f0313393e84c25c3993fd80f6d0d536ec4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"b094a420_47007192","updated":"2025-07-12 12:09:25.000000000","message":"recheck","commit_id":"0d9b70c596c6c6e11896f95fb34fc681213fd6b9"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"d17c0a76f083b7e288a3dfb9847f5c10de8ef161","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"80d39180_f77e87b8","updated":"2025-07-25 07:57:44.000000000","message":"run-IBM-CI","commit_id":"0d9b70c596c6c6e11896f95fb34fc681213fd6b9"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"fa517089cf703cfba6a46b23af833d7edee7d3e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"c0c99275_2bcf0205","updated":"2025-07-22 15:04:29.000000000","message":"run-IBM-CI","commit_id":"0d9b70c596c6c6e11896f95fb34fc681213fd6b9"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"a05c6be3d603d684b9186d148d1f2be1ed3cc0df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"cb2e5180_e66f9992","updated":"2025-07-28 10:02:05.000000000","message":"run-IBM-CI","commit_id":"0d9b70c596c6c6e11896f95fb34fc681213fd6b9"},{"author":{"_account_id":36439,"name":"Vivek Pandey","email":"vivek.pandey11@ibm.com","username":"vivek.pandey11"},"change_message_id":"3431196ae7226eb62b1f4f33b3245863cdde1153","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"d49fecec_c361d628","updated":"2025-07-21 06:09:38.000000000","message":"run-IBM-CI","commit_id":"0d9b70c596c6c6e11896f95fb34fc681213fd6b9"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"547057a598349b6d5ae5a8eee21cc292837e6608","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"e5338e63_7a419365","updated":"2025-07-28 11:16:29.000000000","message":"run-IBM-CI","commit_id":"0d9b70c596c6c6e11896f95fb34fc681213fd6b9"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"f01720a3ee7aec29774306d112e1d68665e98ab5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"1e5759b7_59a89336","updated":"2025-08-08 10:44:15.000000000","message":"recheck","commit_id":"9762092524a2134147ad646b9e9946030aec45cd"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"094287613fd2d7e8bb4c9b5d0bf2f68b67fae03b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"7709bf73_f0bc09f1","updated":"2025-08-08 06:41:58.000000000","message":"recheck","commit_id":"9762092524a2134147ad646b9e9946030aec45cd"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"8c16ac3de639f2d2d175c50f7c274cad9214d7ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"f3ffa6fc_6efa0360","updated":"2025-08-11 05:27:35.000000000","message":"run-IBM-CI","commit_id":"9762092524a2134147ad646b9e9946030aec45cd"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"aff60a8b7c20a30a2c8507e5f92f5debc3264b78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"18b62dcd_e5124045","updated":"2025-08-14 06:46:01.000000000","message":"LGTM","commit_id":"bf2c9d03a2d89f81e2a776f9da3271328de5cabe"},{"author":{"_account_id":37328,"name":"Nimesh Desai","display_name":"Nimesh Desai","email":"nimesh.desai@ibm.com","username":"nimeshdesai"},"change_message_id":"c7a8547d6ae6201f75010b94d95114c924d3b62f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"5613cce3_8008c70b","updated":"2025-08-14 06:32:13.000000000","message":"LGTM","commit_id":"bf2c9d03a2d89f81e2a776f9da3271328de5cabe"},{"author":{"_account_id":37328,"name":"Nimesh Desai","display_name":"Nimesh Desai","email":"nimesh.desai@ibm.com","username":"nimeshdesai"},"change_message_id":"a534a41174ed5c39d8897008e21f68ade1fed392","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"c0ebed67_a3565ac4","updated":"2025-08-14 06:31:37.000000000","message":"LGTM","commit_id":"bf2c9d03a2d89f81e2a776f9da3271328de5cabe"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"f56cb5255f4758301216d7e099117cc468a7d9d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"d46439b9_c5be9165","updated":"2025-08-13 12:53:17.000000000","message":"recheck","commit_id":"bf2c9d03a2d89f81e2a776f9da3271328de5cabe"},{"author":{"_account_id":37328,"name":"Nimesh Desai","display_name":"Nimesh Desai","email":"nimesh.desai@ibm.com","username":"nimeshdesai"},"change_message_id":"c7a520e74cd638ca311f888f245d32f8394d552a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"8e20e6f6_3d98e06d","updated":"2025-08-18 13:29:20.000000000","message":"LGTM","commit_id":"2c376cc4a0d1cba317c6cc0baa18593f24e5ed30"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"83bc0942ca5c2fa83331ebcc9ee0a544b4b65113","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"0eb50563_24b8a797","updated":"2025-08-18 14:48:50.000000000","message":"Ultimately the switch lies in customer\u0027s hand so enabling by default is not an issue for me.\nAlso, the data collected is not sensitive.\n\nLGTM","commit_id":"2c376cc4a0d1cba317c6cc0baa18593f24e5ed30"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"f28afa16c396549a70533c5871c02e98efca15f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"17efe84c_a1fafa33","updated":"2025-08-18 09:34:12.000000000","message":"recheck","commit_id":"2c376cc4a0d1cba317c6cc0baa18593f24e5ed30"},{"author":{"_account_id":37328,"name":"Nimesh Desai","display_name":"Nimesh Desai","email":"nimesh.desai@ibm.com","username":"nimeshdesai"},"change_message_id":"bd2ec91947196780b2f7a925d03b21b9e91c8f12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"10ebd8bf_01d1cabe","updated":"2025-09-03 06:21:30.000000000","message":"Approving again as the votes got reset.","commit_id":"99737201710c439b7e2865d24a158c493e4db5c3"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"e3afbc81affdb729137b962dd2a51c98eef8d568","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"baa3f006_4470cfad","updated":"2025-09-04 18:26:39.000000000","message":"I\u0027m fine with the code itself, please make it default to disabled.  Packagers and/or operators can change this, but my personal stance is that it should be opt-in.","commit_id":"99737201710c439b7e2865d24a158c493e4db5c3"},{"author":{"_account_id":36439,"name":"Vivek Pandey","email":"vivek.pandey11@ibm.com","username":"vivek.pandey11"},"change_message_id":"15a9350b3c3a10fdcb9728b042ef840f08912e21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"01cd7678_d8c26ebd","updated":"2025-09-10 10:23:05.000000000","message":"We have found a means to ensure that the register plugin is not turned on by default. What we can do is to keep it disabled by default in the cinder.conf file. Upon initialisation of the Cinder driver, we will check with the IBM Storage to which it is connected and based on the configuration setting already selected by the FlashSystem administrator with respect to Callhome i.e. it is either enabled or disabled, we turn on plugin registration and if the admin hasn\u0027t enabled CallHome for the IBM storage, then we don\u0027t turn on plugin registration. This should be acceptable to the admin because they have already agreed to enable CallHome support for FlashSystems for better support purposes and hence turning on plugin registration should be fine.\n- If CallHome is enabled, the plugin will register automatically and log an INFO message indicating that telemetry data will be sent to the vendor. \n- If CallHome is disabled, registration will be skipped and an INFO message will clarify that CallHome is turned off. \n- Should CallHome be enabled later, a WARNING will be logged to inform the operator that a driver restart is required to register the plugin.\n\nHere is the output of the CLI that displays whether CallHome has been turned on in FlashSystems or not:\n\"[09:53:30] Ansible-FS5200-2-n2:~ # lscloudcallhome\nstatus enabled\nconnection active\nerror_sequence_number \nlast_success 250910095534\nlast_failure \nsi_tenant_id \napikey_configured no\n[09:57:29] Ansible-FS5200-2-n2:~ # \"\n\nThanks,\nVivek","commit_id":"99737201710c439b7e2865d24a158c493e4db5c3"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"370b4844e16defaa99af726351d327dff76eb706","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"e36d6cce_26d30560","updated":"2025-11-01 01:18:44.000000000","message":"I may be wrong, but I don\u0027t believe that the looping call for registering the service will exit ever, which is why I\u0027ve issued a -1.  I do not have other complaints.","commit_id":"e12afd5be50eab814c541b8aa343faf8e5d0c7ff"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"c498b05228ca58b5bae93950279feb0184d1a876","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"528ccce8_b6861eb3","updated":"2025-10-03 11:19:53.000000000","message":"recheck","commit_id":"e12afd5be50eab814c541b8aa343faf8e5d0c7ff"},{"author":{"_account_id":36439,"name":"Vivek Pandey","email":"vivek.pandey11@ibm.com","username":"vivek.pandey11"},"change_message_id":"8884e5d61d78d59404622b73ce3f28c9016ccc6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"b717a780_5e34f6a8","updated":"2025-11-24 09:44:01.000000000","message":"LGTM","commit_id":"8299dc3a52ee41a7a65b933fa8005584376e9180"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"b61b34bd3973365acc69edf822f72b01b308c1e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"dc1535f0_29cbffa9","updated":"2025-11-05 15:56:40.000000000","message":"My concern about the looping call was addressed and I have no further suggestions.","commit_id":"8299dc3a52ee41a7a65b933fa8005584376e9180"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"0e09c77c7696972a9cef1baa84bf204e79a78834","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"5e846842_a37cdc71","updated":"2025-11-05 11:30:42.000000000","message":"recheck","commit_id":"8299dc3a52ee41a7a65b933fa8005584376e9180"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a3fbbf8eefcf76f60e66ee22e14d913258194441","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"ebb799f1_acc2f848","updated":"2026-02-11 15:27:10.000000000","message":"A couple of code points noted inline.  I think I\u0027m OK with the concept now and am looking forward to discussing at today\u0027s cinder project midcycle.","commit_id":"c7f7328eb5822794bc692cea9ba641e93659a6b0"},{"author":{"_account_id":37328,"name":"Nimesh Desai","display_name":"Nimesh Desai","email":"nimesh.desai@ibm.com","username":"nimeshdesai"},"change_message_id":"2026d8a4519fc9de1a89e536e94fbeb2cfe23b7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"384b2aee_f1426f82","updated":"2026-02-02 08:31:00.000000000","message":"LGTM","commit_id":"c7f7328eb5822794bc692cea9ba641e93659a6b0"},{"author":{"_account_id":37888,"name":"Akshay Ranade","display_name":"Akshay Ranade","email":"akshay.ranade@ibm.com","username":"rakshay"},"change_message_id":"7590b4767ad6b22ec69281a2d335a72b49eedda6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"f99ee878_186d4f99","updated":"2026-02-02 09:08:22.000000000","message":"LGTM","commit_id":"c7f7328eb5822794bc692cea9ba641e93659a6b0"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a4e694fa815ad29fd383f98a37f3114410da2c48","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":42,"id":"ebfdb774_43a651e1","updated":"2026-02-19 23:19:32.000000000","message":"Apologies for dropping a deuce on this without a comment earlier, but I wanted to stop the gate.  Here\u0027s what is going on.\n\nI\u0027ve been looking at the intermittent failures in the py313 job, and there may be an issue with this patch.  In any case, you need to investigate it.\n\nThese are the failures on the py313 job for this patch:\nhttps://zuul.opendev.org/t/openstack/builds?job_name\u003dopenstack-tox-py313\u0026project\u003dopenstack%2Fcinder\u0026change\u003d951829\u0026result\u003dFAILURE\u0026skip\u003d0\n\n1. https://zuul.opendev.org/t/openstack/build/a14c7b165be841c2ae02edb54ce654ee\nThe following tests exited without returning a status\nand likely segfaulted or crashed Python:\n\t* cinder.tests.unit.volume.drivers.ibm.test_xiv_proxy.XIVProxyTest.test_create_volume_with_consistency_group\n\n2. https://zuul.opendev.org/t/openstack/build/8f73228ca87f4531ae108d440b7e5cd8\nThe following tests exited without returning a status\nand likely segfaulted or crashed Python:\n\t* cinder.tests.unit.volume.drivers.ibm.test_storwize_svc.StorwizeSVCCommonDriverTestCase.test_storwize_svc_retype_no_copy_4___500____iops_per_gb____2000____mbps___False_\n\t* cinder.tests.unit.volume.drivers.ibm.test_storwize_svc.StorwizeSVCCommonDriverTestCase.test_storwize_svc_retype_need_copy_1___5000____iops___500___iops_per_gb___True_\n\n3. https://zuul.opendev.org/t/openstack/build/d1bb54a7c8b34119bf64705491acea31\nThe following tests exited without returning a status\nand likely segfaulted or crashed Python:\n\t* cinder.tests.unit.volume.drivers.ibm.test_storwize_svc.StorwizeSVCReplicationTestCase.test_create_group_from_src_with_gmcv_volume_with_childpool_3___openstack2___None_\n\nHere\u0027s the list of all failing py313 jobs:\nhttps://zuul.opendev.org/t/openstack/builds?job_name\u003dopenstack-tox-py313\u0026project\u003dopenstack%2Fcinder\u0026result\u003dFAILURE\u0026skip\u003d0\n\nI spot checked a few of the failing jobs that didn\u0027t occur on runs of this patch, and the failures seem to be regular unit test failures.  In particular, I looked at these other IBM SVf patches, and they don\u0027t show the tests-returning-without-a-status issue:\n\nhttps://review.opendev.org/c/openstack/cinder/+/958465\nhttps://zuul.opendev.org/t/openstack/build/d7dfcd5dfbfc49afa942fab8baf314a4\n- regular unit test failure\n\nhttps://review.opendev.org/c/openstack/cinder/+/951157\nhttps://zuul.opendev.org/t/openstack/build/cf5a59d629704001bf96b8f1e98e784a\n- regular unit test failure\n\nThat\u0027s what\u0027s making me suspect there may be something weird going on with https://review.opendev.org/c/openstack/cinder/+/951829 ... in any case, please take a look and see what you think.","commit_id":"3ec3d0eeff877eb912ec134bae6c62a72e6891f2"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"f8985f72fcd3939bcfa9f2efb772b447c012dc8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"6655c725_4f313f98","updated":"2026-02-24 05:42:25.000000000","message":"Do we need to re-run the +1 workflow for the gate job in order to merge this patch, or what’s the next step for moving it forward?","commit_id":"3ec3d0eeff877eb912ec134bae6c62a72e6891f2"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"15aa1df1b612e5930a1d1ed404bb2f4498357957","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"af9ab39c_6e9f605e","updated":"2026-03-05 11:34:42.000000000","message":"Hi @rosmaita.fossdev@gmail.com @jobernar@redhat.com\n\nWe have encountered this error multiple times, but we have been unable to reproduce it on the local machine despite conducting several experiments. Additionally, the same issue has not been observed in other IBM patches.\n\nOne possible reason could be that although loopcalldone is present, the loop may still not be terminating as expected.\n\nTherefore, I am considering adding a cleanup for callhome_loop, if present, at the end of the setUp method, because whenever the driver is initialized, the loop gets triggered.","commit_id":"3ec3d0eeff877eb912ec134bae6c62a72e6891f2"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"5dbb7b95c13f31bba2e1ff57d2e84f6a5653338c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"56ed4033_f8030a66","updated":"2026-02-20 15:43:47.000000000","message":"Looks good to me - thank you!","commit_id":"3ec3d0eeff877eb912ec134bae6c62a72e6891f2"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"624783e1354459abeea4540d58dce0f0952980de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"6d6714d7_45a5a059","updated":"2026-02-18 13:29:14.000000000","message":"Revision LGTM. Only a +1 because I\u0027d really like to see a successful SVf CI run with this code, particularly because of the loopingcall changes that were going in and out of the rebases.  Visually, it looks like everything is OK, and there are unit tests, but there is no substitute for a real tempest run.","commit_id":"3ec3d0eeff877eb912ec134bae6c62a72e6891f2"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"917310a9ab07dfd843a373af6710696ca9daeedc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"565fe7bc_f29c966d","updated":"2026-02-20 14:35:54.000000000","message":"Thanks for looking into the issue; it does look to be like some kind of transient thing, and more importantly, the patch has passed the third party CI, which would have exercised the code path.  So I\u0027m back to +2 on this.","commit_id":"3ec3d0eeff877eb912ec134bae6c62a72e6891f2"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fb97f1a0cd63b572ec6220823dbe5433e908cd33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"6dab6779_c7d6b71f","updated":"2026-02-18 17:19:01.000000000","message":"Third party CI reports success, so I think we are OK here.","commit_id":"3ec3d0eeff877eb912ec134bae6c62a72e6891f2"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"e6c7b73a85751247429067a92a6668dedc768712","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"2dce6194_570370b3","updated":"2026-02-20 07:18:35.000000000","message":"check if rebase will help in resolving py13","commit_id":"3ec3d0eeff877eb912ec134bae6c62a72e6891f2"},{"author":{"_account_id":36439,"name":"Vivek Pandey","email":"vivek.pandey11@ibm.com","username":"vivek.pandey11"},"change_message_id":"b28a0033b3bc31f9ae901bcce52084b97a79aa03","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":42,"id":"03ca24c7_63ead87d","updated":"2026-02-20 07:13:25.000000000","message":"recheck","commit_id":"3ec3d0eeff877eb912ec134bae6c62a72e6891f2"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"49e15df5c63a9da92e6614ac7f6143e72add1313","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"198a2ceb_6cebd8e4","updated":"2026-02-19 05:56:11.000000000","message":"recheck","commit_id":"3ec3d0eeff877eb912ec134bae6c62a72e6891f2"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"710c0ff6a369ccfdc17f53225749f4465d2fbd2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"369bb361_a922f07b","updated":"2026-03-05 07:19:39.000000000","message":"recheck","commit_id":"3ec3d0eeff877eb912ec134bae6c62a72e6891f2"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"c7b3f7765b9482633dcec56126ae81b29936440a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"43d560c9_977af401","updated":"2026-02-19 19:43:13.000000000","message":"recheck","commit_id":"3ec3d0eeff877eb912ec134bae6c62a72e6891f2"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"b3d7045e6c2798970a8323036c0f72753e2cfe92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"6bf0dc0a_3b5e777f","updated":"2026-02-19 03:07:14.000000000","message":"recheck","commit_id":"3ec3d0eeff877eb912ec134bae6c62a72e6891f2"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"cecf6b8e3046756ef865787beb2cdea105b206c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"f1f8584a_16434023","updated":"2026-02-17 11:55:21.000000000","message":"recheck","commit_id":"3ec3d0eeff877eb912ec134bae6c62a72e6891f2"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5bc4ffe7515e4fb33a9a3cee83d509cf91c7d1f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"96320b54_40111ea2","updated":"2026-02-18 22:51:59.000000000","message":"recheck cinder-plugin-ceph-tempest - problem installing cephadm, no tests were run","commit_id":"3ec3d0eeff877eb912ec134bae6c62a72e6891f2"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"9a8c463edae4b3e95d91ed2f9c7d823bdb8b2845","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"17b62eaa_cfe95167","updated":"2026-02-18 15:36:04.000000000","message":"run-Quobyte CI","commit_id":"3ec3d0eeff877eb912ec134bae6c62a72e6891f2"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"56b12cb70d984d39116642859788f79fd6e6917b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"b6794303_242884f3","in_reply_to":"03ca24c7_63ead87d","updated":"2026-02-20 15:03:50.000000000","message":"Done","commit_id":"3ec3d0eeff877eb912ec134bae6c62a72e6891f2"},{"author":{"_account_id":36439,"name":"Vivek Pandey","email":"vivek.pandey11@ibm.com","username":"vivek.pandey11"},"change_message_id":"75ae4d509e670cdbf25e25858dc351b4417f6b55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"ae3b9d83_4ee621c0","in_reply_to":"ebfdb774_43a651e1","updated":"2026-02-20 13:57:06.000000000","message":"We have attempted to reproduce the reported failure using the Zuul suite locally, including running tests with 32 workers and the --until-failure flag, but the suite passed consistently. We also explored several manual scenarios, none of which triggered the issue.\n\nAt this stage, we suspect the failure(transient) may be environment-specific. I am re-verifying(recheck) the patch to ensure no regressions were missed; however, if you has insights on specific environmental constraints or configurations needed to reproduce this, your guidance would be appreciated.\n\n1st try:\n/usr/local/bin/tox -epy313  -vv --skip-missing-interpreters\u003dfalse --  --concurrency\u003d32 --until-failure\n2nd try:\nstress --cpu 8\n/usr/local/bin/tox -epy313  -vv --skip-missing-interpreters\u003dfalse --  --concurrency\u003d32 --until-failure\n3rd try:\nstress --cpu 4 --io 2 --vm 2 --vm-bytes 128M\n/usr/local/bin/tox -epy313  -vv --skip-missing-interpreters\u003dfalse --  --concurrency\u003d32 --until-failure\nThis we tried for more than 3 hrs","commit_id":"3ec3d0eeff877eb912ec134bae6c62a72e6891f2"},{"author":{"_account_id":37328,"name":"Nimesh Desai","display_name":"Nimesh Desai","email":"nimesh.desai@ibm.com","username":"nimeshdesai"},"change_message_id":"6b74b703d903ae4dedce82b82210d73c3826cc16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"063a5fe5_faa903f7","updated":"2026-03-06 03:53:38.000000000","message":"@rosmaita.fossdev@gmail.com @jobernar@redhat.com The patch is updated to handle merge conflicts and workflow error. Need +2s and workflow again.","commit_id":"1de31e7555caaba2be73e450db206b5758fdf5b1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"cf7bfb691a28a440e3d47d590c7570490938348f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"4f8a34c0_a339d799","updated":"2026-03-06 16:00:05.000000000","message":"Changes since PS42 LGTM.","commit_id":"1de31e7555caaba2be73e450db206b5758fdf5b1"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"a1def84692cedebe025d28763c85187716be539f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"16056b12_dd9fe593","updated":"2026-03-06 15:17:26.000000000","message":"Code looks good. Loop seems to be stoping fairly after the plugin is registered.","commit_id":"1de31e7555caaba2be73e450db206b5758fdf5b1"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"1c9492b080d7f356c6deb109021b3575e99af9d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"7f32b490_e38d611d","updated":"2026-03-05 22:20:44.000000000","message":"recheck","commit_id":"1de31e7555caaba2be73e450db206b5758fdf5b1"}],"cinder/tests/unit/volume/drivers/ibm/test_storwize_svc.py":[{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"72f0308f05dcfe04dcb90e02cb7a777be3996543","unresolved":false,"context_lines":[{"line_number":5129,"context_line":"        mock_cli.return_value \u003d \"Cinder 24.0.0\""},{"line_number":5130,"context_line":"        mock_callhome.return_value \u003d \"success\""},{"line_number":5131,"context_line":"        driver_version \u003d self.driver.VERSION"},{"line_number":5132,"context_line":"        "},{"line_number":5133,"context_line":"        self.driver.check_for_setup_error()"},{"line_number":5134,"context_line":"        # Assertions"},{"line_number":5135,"context_line":"        mock_callhome.assert_called_once()"}],"source_content_type":"text/x-python","patch_set":7,"id":"44dbd4a7_809f6e6f","line":5132,"in_reply_to":"44649eb4_867efd40","updated":"2025-06-30 07:12:42.000000000","message":"This is resolved in latest patch","commit_id":"e52f2207f6f08df5938288e2ee79ea0669dee097"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":37328,"name":"Nimesh Desai","display_name":"Nimesh Desai","email":"nimesh.desai@ibm.com","username":"nimeshdesai"},"change_message_id":"4086993ba8bdfcc9807cf9dd96216345f2d262a9","unresolved":true,"context_lines":[{"line_number":3712,"context_line":"        if \"powervc\" in (volume_driver, \u0027\u0027):"},{"line_number":3713,"context_line":"            deployment \u003d \"PowerVC\""},{"line_number":3714,"context_line":"        else:"},{"line_number":3715,"context_line":"            deployment \u003d \"Cinder\""},{"line_number":3716,"context_line":"        callhome_metadata \u003d f\"ispbhaenabled - {ispbhaenabled}, \" \\"},{"line_number":3717,"context_line":"            f\"isreplication - {isreplication}, \" \\"},{"line_number":3718,"context_line":"            f\"deployment - {deployment}, \""}],"source_content_type":"text/x-python","patch_set":10,"id":"b90d94b7_6b3a9c09","line":3715,"range":{"start_line":3715,"start_character":12,"end_line":3715,"end_character":33},"updated":"2025-07-02 05:55:37.000000000","message":"initialise deployment with the default value of \u0027Community\u0027","commit_id":"21349e010c9d7e1fda9ef6651ee1e3d63fedd4c8"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"a5f217bc4c2ce2ed778fa5ccd01ff261f5985750","unresolved":false,"context_lines":[{"line_number":3712,"context_line":"        if \"powervc\" in (volume_driver, \u0027\u0027):"},{"line_number":3713,"context_line":"            deployment \u003d \"PowerVC\""},{"line_number":3714,"context_line":"        else:"},{"line_number":3715,"context_line":"            deployment \u003d \"Cinder\""},{"line_number":3716,"context_line":"        callhome_metadata \u003d f\"ispbhaenabled - {ispbhaenabled}, \" \\"},{"line_number":3717,"context_line":"            f\"isreplication - {isreplication}, \" \\"},{"line_number":3718,"context_line":"            f\"deployment - {deployment}, \""}],"source_content_type":"text/x-python","patch_set":10,"id":"e9f37ebb_e8e71aa3","line":3715,"range":{"start_line":3715,"start_character":12,"end_line":3715,"end_character":33},"in_reply_to":"b90d94b7_6b3a9c09","updated":"2025-07-02 12:11:37.000000000","message":"Done","commit_id":"21349e010c9d7e1fda9ef6651ee1e3d63fedd4c8"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"7746cdb2e8d1dbcb76d2ad10ffa50ce636a2e707","unresolved":true,"context_lines":[{"line_number":3705,"context_line":""},{"line_number":3706,"context_line":"        opts \u003d self._helpers.build_default_opts(self.configuration)"},{"line_number":3707,"context_line":"        self._helpers.check_vdisk_opts(self._state, opts)"},{"line_number":3708,"context_line":"        if self.configuration.safe_get(\u0027callhome\u0027) !\u003d \"disable\":"},{"line_number":3709,"context_line":"            callhome_metadata \u003d \u0027\u0027"},{"line_number":3710,"context_line":"            ispbhaenabled \u003d bool(getattr(self, \u0027is_pbha_partition\u0027, None))"},{"line_number":3711,"context_line":"            isreplication \u003d bool("}],"source_content_type":"text/x-python","patch_set":18,"id":"c6b5df57_40862bcc","line":3708,"updated":"2025-07-08 18:05:32.000000000","message":"As written, this configuration option is not set and has no default, so unless the admin explicitly sets this to \u0027disable\u0027, the call home feature will default to enabled.  I don\u0027t think we want it this way.","commit_id":"521d7e1c4f7e2eb14bb483e7f6d56d798f5c11b5"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"8497103fcb1076fb4788fb986a94f342234fa844","unresolved":false,"context_lines":[{"line_number":3705,"context_line":""},{"line_number":3706,"context_line":"        opts \u003d self._helpers.build_default_opts(self.configuration)"},{"line_number":3707,"context_line":"        self._helpers.check_vdisk_opts(self._state, opts)"},{"line_number":3708,"context_line":"        if self.configuration.safe_get(\u0027callhome\u0027) !\u003d \"disable\":"},{"line_number":3709,"context_line":"            callhome_metadata \u003d \u0027\u0027"},{"line_number":3710,"context_line":"            ispbhaenabled \u003d bool(getattr(self, \u0027is_pbha_partition\u0027, None))"},{"line_number":3711,"context_line":"            isreplication \u003d bool("}],"source_content_type":"text/x-python","patch_set":18,"id":"c09a1f86_96f19ddf","line":3708,"in_reply_to":"036b3fc1_0adb6857","updated":"2025-08-06 09:19:54.000000000","message":"Hi @rosmaita.fossdev@gmail.com and @jobernar@redhat.com,\nThere appears to be some confusion regarding the term \u0027Callhome\u0027. In this patch, we are registering the plugin on the backend to determine whether IBM SVC is being used by the Cinder plugin. This registration occurs locally on the backend. I renamed the patch and changed the description which will describe this is just a registration of plugin on backend, Please check the commit message. Also I have modified the code.\nCallhome is a separate feature that must be configured by the user to get support from IBM. Data from the registered plugin will not be visible to IBM until Callhome is enabled. One more thing Callhome is not configured by Cinder driver code, it is configured separately by the customer.","commit_id":"521d7e1c4f7e2eb14bb483e7f6d56d798f5c11b5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"647233414340e6aaec2cdc62de3d0d15ee8540cc","unresolved":true,"context_lines":[{"line_number":3705,"context_line":""},{"line_number":3706,"context_line":"        opts \u003d self._helpers.build_default_opts(self.configuration)"},{"line_number":3707,"context_line":"        self._helpers.check_vdisk_opts(self._state, opts)"},{"line_number":3708,"context_line":"        if self.configuration.safe_get(\u0027callhome\u0027) !\u003d \"disable\":"},{"line_number":3709,"context_line":"            callhome_metadata \u003d \u0027\u0027"},{"line_number":3710,"context_line":"            ispbhaenabled \u003d bool(getattr(self, \u0027is_pbha_partition\u0027, None))"},{"line_number":3711,"context_line":"            isreplication \u003d bool("}],"source_content_type":"text/x-python","patch_set":18,"id":"036b3fc1_0adb6857","line":3708,"in_reply_to":"c6b5df57_40862bcc","updated":"2025-07-08 19:02:01.000000000","message":"Agree with Jon.  Is there a reason why the option isn\u0027t defined along with the other storwize options in lines 61-186?  Also, any reason not to name it \u0027storwize_svc_callhome\u0027 to be consistent with the other options?\n\nThe oslo config BoolOpt recognizes \"on\" and \"off\" [0], so that could be a good choice for an option type.  Or the StrOpt allows you to specify a \u0027choices\u0027 parameter, that could be (\u0027enabled\u0027, \u0027disabled\u0027).\n\nRegardless of the type you pick, the \u0027help\u0027 parameter allows you to provide some text describing what the implications of enabling callhome are.\n\nFinally, I think that the default value should be \u0027off\u0027 or \u0027disabled\u0027, and operators can turn it on either at the direction of the vendor or once they understand the implications of using callhome by reading your help text.\n\n\n[0] https://docs.openstack.org/oslo.config/2025.1/reference/api/oslo_config.html#oslo_config.types.Boolean","commit_id":"521d7e1c4f7e2eb14bb483e7f6d56d798f5c11b5"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"370b4844e16defaa99af726351d327dff76eb706","unresolved":true,"context_lines":[{"line_number":1695,"context_line":"                                        registerplugin_metadata)"},{"line_number":1696,"context_line":"            LOG.info(\"CINDER plugin is registered successfully on SVC \""},{"line_number":1697,"context_line":"                     \"backend.\")"},{"line_number":1698,"context_line":"            return False"},{"line_number":1699,"context_line":"        else:"},{"line_number":1700,"context_line":"            LOG.warning(\"Callhome service is disabled on the backend.\")"},{"line_number":1701,"context_line":""}],"source_content_type":"text/x-python","patch_set":33,"id":"cf10af8e_859e6173","line":1698,"updated":"2025-11-01 01:18:44.000000000","message":"Are we sure this will force the looping call to exit? (I am guessing this False return is meant for that).\n\nIt would not surprise me, but I cannot find it documented anywhere what the return value for the FixedIntervalLoopingCall does.  The source for it is not clear ( https://opendev.org/openstack/oslo.service/src/branch/master/oslo_service/backend/_threading/loopingcall.py ) what the particular idle_for_func() call would do for a FixedIntervalLoopingCall either.\n\nFurther, I know you can exit it by raising loopingcall.LoopingCallDone().","commit_id":"e12afd5be50eab814c541b8aa343faf8e5d0c7ff"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"b23fe97d94164280fa37eb3e6d0e1f4e797d8011","unresolved":false,"context_lines":[{"line_number":1695,"context_line":"                                        registerplugin_metadata)"},{"line_number":1696,"context_line":"            LOG.info(\"CINDER plugin is registered successfully on SVC \""},{"line_number":1697,"context_line":"                     \"backend.\")"},{"line_number":1698,"context_line":"            return False"},{"line_number":1699,"context_line":"        else:"},{"line_number":1700,"context_line":"            LOG.warning(\"Callhome service is disabled on the backend.\")"},{"line_number":1701,"context_line":""}],"source_content_type":"text/x-python","patch_set":33,"id":"a379e87d_a96bf5d2","line":1698,"in_reply_to":"cf10af8e_859e6173","updated":"2025-11-05 07:21:26.000000000","message":"@anthony.galica@hitachivantara.com Thank you for reviewing,\nI agree that using loopingcall.LoopingCallDone() is the correct approach to terminate the loop instead of returning False. I’ve updated the latest patch accordingly.","commit_id":"e12afd5be50eab814c541b8aa343faf8e5d0c7ff"},{"author":{"_account_id":37328,"name":"Nimesh Desai","display_name":"Nimesh Desai","email":"nimesh.desai@ibm.com","username":"nimeshdesai"},"change_message_id":"f42880dada3e88861d90dc8e1eb9e6f036ec3d75","unresolved":true,"context_lines":[{"line_number":3770,"context_line":"            self._helpers.check_for_callhome_enabled,"},{"line_number":3771,"context_line":"            self.configuration,"},{"line_number":3772,"context_line":"            self.VERSION)"},{"line_number":3773,"context_line":"        self._check_callhome_loop.start(interval\u003d86400)"},{"line_number":3774,"context_line":""},{"line_number":3775,"context_line":"        LOG.debug(\u0027leave: check_for_setup_error\u0027)"},{"line_number":3776,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"53791f15_5c16cbed","line":3773,"range":{"start_line":3773,"start_character":49,"end_line":3773,"end_character":54},"updated":"2025-12-19 14:38:48.000000000","message":"remove the hard-coding of interval value. Instead define a constant.","commit_id":"8299dc3a52ee41a7a65b933fa8005584376e9180"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"50a2f7a035d075e023b54f643e459bdee7adb082","unresolved":false,"context_lines":[{"line_number":3770,"context_line":"            self._helpers.check_for_callhome_enabled,"},{"line_number":3771,"context_line":"            self.configuration,"},{"line_number":3772,"context_line":"            self.VERSION)"},{"line_number":3773,"context_line":"        self._check_callhome_loop.start(interval\u003d86400)"},{"line_number":3774,"context_line":""},{"line_number":3775,"context_line":"        LOG.debug(\u0027leave: check_for_setup_error\u0027)"},{"line_number":3776,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"66a79202_93ca112f","line":3773,"range":{"start_line":3773,"start_character":49,"end_line":3773,"end_character":54},"in_reply_to":"53791f15_5c16cbed","updated":"2026-01-28 12:44:55.000000000","message":"@nimesh.desai@ibm.com,\nThanks for the review, I have made the changes is latest patch.","commit_id":"8299dc3a52ee41a7a65b933fa8005584376e9180"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a3fbbf8eefcf76f60e66ee22e14d913258194441","unresolved":true,"context_lines":[{"line_number":1676,"context_line":"                return True"},{"line_number":1677,"context_line":"        return False"},{"line_number":1678,"context_line":""},{"line_number":1679,"context_line":"    def check_for_callhome_enalbed(self, configuration, VERSION):"},{"line_number":1680,"context_line":"        callhome_data \u003d self.ssh.lscloudcallhome()"},{"line_number":1681,"context_line":"        if callhome_data[0][\u0027status\u0027] \u003d\u003d \"enabled\":"},{"line_number":1682,"context_line":"            registerplugin_metadata \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":36,"id":"e447f094_ad2c80cd","line":1679,"range":{"start_line":1679,"start_character":27,"end_line":1679,"end_character":34},"updated":"2026-02-11 15:27:10.000000000","message":"I think it would be better to spell \u0027enabled\u0027 correctly in the function name, it may avert some unpleasantness later.","commit_id":"c7f7328eb5822794bc692cea9ba641e93659a6b0"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"2f36171764b125e3641063777ee4d7862d058023","unresolved":false,"context_lines":[{"line_number":1676,"context_line":"                return True"},{"line_number":1677,"context_line":"        return False"},{"line_number":1678,"context_line":""},{"line_number":1679,"context_line":"    def check_for_callhome_enalbed(self, configuration, VERSION):"},{"line_number":1680,"context_line":"        callhome_data \u003d self.ssh.lscloudcallhome()"},{"line_number":1681,"context_line":"        if callhome_data[0][\u0027status\u0027] \u003d\u003d \"enabled\":"},{"line_number":1682,"context_line":"            registerplugin_metadata \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":36,"id":"2d91434c_1bdd9792","line":1679,"range":{"start_line":1679,"start_character":27,"end_line":1679,"end_character":34},"in_reply_to":"61dfd697_c0d13ae5","updated":"2026-02-12 17:07:23.000000000","message":"Done","commit_id":"c7f7328eb5822794bc692cea9ba641e93659a6b0"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"534de3522a1695eb5ba6e4ae7b3a2fd737277c9d","unresolved":true,"context_lines":[{"line_number":1676,"context_line":"                return True"},{"line_number":1677,"context_line":"        return False"},{"line_number":1678,"context_line":""},{"line_number":1679,"context_line":"    def check_for_callhome_enalbed(self, configuration, VERSION):"},{"line_number":1680,"context_line":"        callhome_data \u003d self.ssh.lscloudcallhome()"},{"line_number":1681,"context_line":"        if callhome_data[0][\u0027status\u0027] \u003d\u003d \"enabled\":"},{"line_number":1682,"context_line":"            registerplugin_metadata \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":36,"id":"61dfd697_c0d13ae5","line":1679,"range":{"start_line":1679,"start_character":27,"end_line":1679,"end_character":34},"in_reply_to":"e447f094_ad2c80cd","updated":"2026-02-11 15:53:21.000000000","message":"Thank you\nActually code is rebased to older patch, I\u0027ll modify it.","commit_id":"c7f7328eb5822794bc692cea9ba641e93659a6b0"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a3fbbf8eefcf76f60e66ee22e14d913258194441","unresolved":true,"context_lines":[{"line_number":1693,"context_line":"                f\"deployment - {deployment}, \""},{"line_number":1694,"context_line":"            self.register_cinder_plugin(VERSION,"},{"line_number":1695,"context_line":"                                        registerplugin_metadata)"},{"line_number":1696,"context_line":"            return False"},{"line_number":1697,"context_line":"        else:"},{"line_number":1698,"context_line":"            LOG.warning(\"Callhome service is disabled on the backend.\")"},{"line_number":1699,"context_line":""}],"source_content_type":"text/x-python","patch_set":36,"id":"acf90ed1_2a20cc73","line":1696,"range":{"start_line":1696,"start_character":12,"end_line":1696,"end_character":24},"updated":"2026-02-11 15:27:10.000000000","message":"I thought you had agreed on PS 33 that this would be better as raising loopingcall.LoopingCallDone(), and you even made the change in PS 34.  Did you change it back to \u0027return False\u0027 on purpose?  (And if so, can you explain why?)","commit_id":"c7f7328eb5822794bc692cea9ba641e93659a6b0"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"2f36171764b125e3641063777ee4d7862d058023","unresolved":false,"context_lines":[{"line_number":1693,"context_line":"                f\"deployment - {deployment}, \""},{"line_number":1694,"context_line":"            self.register_cinder_plugin(VERSION,"},{"line_number":1695,"context_line":"                                        registerplugin_metadata)"},{"line_number":1696,"context_line":"            return False"},{"line_number":1697,"context_line":"        else:"},{"line_number":1698,"context_line":"            LOG.warning(\"Callhome service is disabled on the backend.\")"},{"line_number":1699,"context_line":""}],"source_content_type":"text/x-python","patch_set":36,"id":"39621aa0_a51068d9","line":1696,"range":{"start_line":1696,"start_character":12,"end_line":1696,"end_character":24},"in_reply_to":"a0ab8169_5456c782","updated":"2026-02-12 17:07:23.000000000","message":"Done","commit_id":"c7f7328eb5822794bc692cea9ba641e93659a6b0"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"534de3522a1695eb5ba6e4ae7b3a2fd737277c9d","unresolved":true,"context_lines":[{"line_number":1693,"context_line":"                f\"deployment - {deployment}, \""},{"line_number":1694,"context_line":"            self.register_cinder_plugin(VERSION,"},{"line_number":1695,"context_line":"                                        registerplugin_metadata)"},{"line_number":1696,"context_line":"            return False"},{"line_number":1697,"context_line":"        else:"},{"line_number":1698,"context_line":"            LOG.warning(\"Callhome service is disabled on the backend.\")"},{"line_number":1699,"context_line":""}],"source_content_type":"text/x-python","patch_set":36,"id":"a0ab8169_5456c782","line":1696,"range":{"start_line":1696,"start_character":12,"end_line":1696,"end_character":24},"in_reply_to":"acf90ed1_2a20cc73","updated":"2026-02-11 15:53:21.000000000","message":"Because of the same reason as mentioned above this happened, I\u0027ll replace return False with loopingcall.LoopingCallDone()","commit_id":"c7f7328eb5822794bc692cea9ba641e93659a6b0"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"822bd21ce1f5f01edb46722c7ef10bf7c69ed4a2","unresolved":true,"context_lines":[{"line_number":3389,"context_line":"        result \u003d run(cmd, capture_output\u003dTrue, text\u003dTrue)"},{"line_number":3390,"context_line":"        if result.returncode \u003d\u003d 0:"},{"line_number":3391,"context_line":"            out \u003d result.stdout.strip()"},{"line_number":3392,"context_line":"        return out"},{"line_number":3393,"context_line":""},{"line_number":3394,"context_line":"    def register_cinder_plugin(self, driver_version, metadata):"},{"line_number":3395,"context_line":"        ret \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":39,"id":"3b7dd65e_0a6d00a9","line":3392,"updated":"2026-02-12 15:28:55.000000000","message":"dont you want to at least log the error in case something failed?","commit_id":"a96b03f2c4ff0a07ec35d23fc73650ad8cf37a99"},{"author":{"_account_id":38067,"name":"Sandip Rajbanshi","display_name":"Sandip27","email":"sandip.rajbanshi@ibm.com","username":"sandip-rajbanshi-27"},"change_message_id":"2f36171764b125e3641063777ee4d7862d058023","unresolved":false,"context_lines":[{"line_number":3389,"context_line":"        result \u003d run(cmd, capture_output\u003dTrue, text\u003dTrue)"},{"line_number":3390,"context_line":"        if result.returncode \u003d\u003d 0:"},{"line_number":3391,"context_line":"            out \u003d result.stdout.strip()"},{"line_number":3392,"context_line":"        return out"},{"line_number":3393,"context_line":""},{"line_number":3394,"context_line":"    def register_cinder_plugin(self, driver_version, metadata):"},{"line_number":3395,"context_line":"        ret \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":39,"id":"99b6ae35_743c5054","line":3392,"in_reply_to":"3b7dd65e_0a6d00a9","updated":"2026-02-12 17:07:23.000000000","message":"Hello @yuval@lightbitslabs.com\n\nThis functionality is designed to be non-blocking. Even if it fails, it should not impact the driver initialization process. Therefore, we did not log it as an error.","commit_id":"a96b03f2c4ff0a07ec35d23fc73650ad8cf37a99"}]}