)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":37798,"name":"Sam Clippinger","display_name":"samatwork","email":"sam.clippinger@garmin.com","username":"samatwork","status":"Garmin International"},"change_message_id":"b1412ef5b366cccd870927d8442cc59482d9fe1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"424e19c8_11efd2c5","updated":"2025-07-09 04:01:07.000000000","message":"recheck Completely unrelated failures","commit_id":"05848c69d2b9e5d8c5b13a6f78f8575b66a5eb28"},{"author":{"_account_id":37798,"name":"Sam Clippinger","display_name":"samatwork","email":"sam.clippinger@garmin.com","username":"samatwork","status":"Garmin International"},"change_message_id":"d11ea27d1b5fade4d5870b605c19e9aded8d9513","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"23f1c696_7c0245ff","updated":"2026-05-22 01:05:01.000000000","message":"recheck","commit_id":"81e189071c30e3d303adf293d4ef08ade3b12e33"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"a88dd8532a2987450db44fe60f0e30d5e3ce44d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"397d37e8_9d978cc4","updated":"2026-05-22 15:34:24.000000000","message":"This was fixed in: https://review.opendev.org/c/openstack/cinder/+/658283","commit_id":"638d292a05968e66deed55db5fb53b90db14856a"},{"author":{"_account_id":37798,"name":"Sam Clippinger","display_name":"samatwork","email":"sam.clippinger@garmin.com","username":"samatwork","status":"Garmin International"},"change_message_id":"dd067f6a818d7dbc2506d5199997a0b40964b96d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":16,"id":"db741069_c86c3043","in_reply_to":"397d37e8_9d978cc4","updated":"2026-05-22 15:52:54.000000000","message":"Ah, of course.  We still have a need to control geometry per volume or per image, a single region-wide setting in the config file isn\u0027t suitable for us.  I\u0027ll rebase my work on top of the February change and add the additional config options.","commit_id":"638d292a05968e66deed55db5fb53b90db14856a"}],"cinder/volume/driver.py":[{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"17731432fbeabef4b3848ec926957fdb96851a0d","unresolved":true,"context_lines":[{"line_number":245,"context_line":"               help\u003d\u0027Availability zone for this volume backend. If not set, \u0027"},{"line_number":246,"context_line":"                    \u0027the storage_availability_zone option value is used as \u0027"},{"line_number":247,"context_line":"                    \u0027the default for all backends.\u0027),"},{"line_number":248,"context_line":"    cfg.StrOpt(\u0027disk_geometry\u0027, default\u003dNone,"},{"line_number":249,"context_line":"               choices\u003d[(None,"},{"line_number":250,"context_line":"                         \u0027Do not hint disk geometry\u0027),"},{"line_number":251,"context_line":"                        (\u0027512\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"6de65832_37f6ad03","side":"PARENT","line":248,"updated":"2026-05-23 17:38:33.000000000","message":"any reason this config attribute is removed and added to RBD only? same config is applicable for RBD only?","commit_id":"7f6a196c65cbf3cc4952a9e80c1a1965c6699aad"},{"author":{"_account_id":37798,"name":"Sam Clippinger","display_name":"samatwork","email":"sam.clippinger@garmin.com","username":"samatwork","status":"Garmin International"},"change_message_id":"43bce53dc9c10df018c04ae2adfc2728a769e8fe","unresolved":true,"context_lines":[{"line_number":245,"context_line":"               help\u003d\u0027Availability zone for this volume backend. If not set, \u0027"},{"line_number":246,"context_line":"                    \u0027the storage_availability_zone option value is used as \u0027"},{"line_number":247,"context_line":"                    \u0027the default for all backends.\u0027),"},{"line_number":248,"context_line":"    cfg.StrOpt(\u0027disk_geometry\u0027, default\u003dNone,"},{"line_number":249,"context_line":"               choices\u003d[(None,"},{"line_number":250,"context_line":"                         \u0027Do not hint disk geometry\u0027),"},{"line_number":251,"context_line":"                        (\u0027512\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"f9ece2da_fa346020","side":"PARENT","line":248,"in_reply_to":"6de65832_37f6ad03","updated":"2026-05-26 14:02:48.000000000","message":"I started working on my patch last June, long before the other patch was added.  The other patch does not fully meet my needs, I\u0027m going to rebase this work on top of it and resubmit.","commit_id":"7f6a196c65cbf3cc4952a9e80c1a1965c6699aad"}],"cinder/volume/drivers/rbd.py":[{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"17731432fbeabef4b3848ec926957fdb96851a0d","unresolved":true,"context_lines":[{"line_number":1915,"context_line":"        # volume metadata, as/if desired."},{"line_number":1916,"context_line":"        disk_geometry_value \u003d None"},{"line_number":1917,"context_line":"        disk_geometry_config \u003d ("},{"line_number":1918,"context_line":"            volume.get(\u0027metadata\u0027).get(\u0027disk_geometry\u0027) or"},{"line_number":1919,"context_line":"            volume.get(\u0027glance_metadata\u0027).get(\u0027disk_geometry\u0027) or"},{"line_number":1920,"context_line":"            self.configuration.safe_get(\"disk_geometry\") or"},{"line_number":1921,"context_line":"            None"}],"source_content_type":"text/x-python","patch_set":16,"id":"66823999_4d06f896","line":1918,"updated":"2026-05-23 17:38:33.000000000","message":"disk_geometry default value in None in config definition. AttributeError possible.","commit_id":"638d292a05968e66deed55db5fb53b90db14856a"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"17731432fbeabef4b3848ec926957fdb96851a0d","unresolved":true,"context_lines":[{"line_number":1948,"context_line":"                )"},{"line_number":1949,"context_line":"                disk_geometry_value \u003d None"},{"line_number":1950,"context_line":""},{"line_number":1951,"context_line":"        if disk_geometry_value is not None:"},{"line_number":1952,"context_line":"            if disk_geometry_value \u003d\u003d \u0027512\u0027:"},{"line_number":1953,"context_line":"                data[\u0027data\u0027][\u0027physical_block_size\u0027] \u003d \u0027512\u0027  # type: ignore"},{"line_number":1954,"context_line":"                data[\u0027data\u0027][\u0027logical_block_size\u0027] \u003d \u0027512\u0027  # type: ignore"}],"source_content_type":"text/x-python","patch_set":16,"id":"5eb527e5_fc372671","line":1951,"updated":"2026-05-23 17:38:33.000000000","message":"i can find similar logic in cinder/volume/manager.py. Can you reuse same logic hear as well.","commit_id":"638d292a05968e66deed55db5fb53b90db14856a"}]}
