)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"4c9588ab246ac972211ff3ffafddcea07784bd3c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Saikumar Pulluri \u003csaikumar1016@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-06-25 07:25:18 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Netapp: iSCSI/FC detach operation fails when multiple initiators connected"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During the detach operation of iSCSI and Fibre Channel (FC) sessions,"},{"line_number":10,"context_line":"the process fails when multiple initiators are connected to the Device"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"03404e5b_6fe0bc72","line":7,"updated":"2025-06-25 22:34:03.000000000","message":"nit: s/Netapp/NetApp/","commit_id":"7d8da036d22ba4f53ac82d28de3a87fc647114f2"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"91de429ecb44ed4fcbfe076be8055742238ca88f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Saikumar Pulluri \u003csaikumar1016@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-06-25 07:25:18 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Netapp: iSCSI/FC detach operation fails when multiple initiators connected"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During the detach operation of iSCSI and Fibre Channel (FC) sessions,"},{"line_number":10,"context_line":"the process fails when multiple initiators are connected to the Device"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"2a54fcd6_b9798e43","line":7,"in_reply_to":"03404e5b_6fe0bc72","updated":"2025-06-26 03:31:40.000000000","message":"Addressed.","commit_id":"7d8da036d22ba4f53ac82d28de3a87fc647114f2"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"4c9588ab246ac972211ff3ffafddcea07784bd3c","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During the detach operation of iSCSI and Fibre Channel (FC) sessions,"},{"line_number":10,"context_line":"the process fails when multiple initiators are connected to the Device"},{"line_number":11,"context_line":"Under Test (DUT). Investigation reveals that the root cause is related"},{"line_number":12,"context_line":"to improper handling of initiator identifiers due to the use of a space"},{"line_number":13,"context_line":"character as a delimiter."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"22d3076a_484f31e7","line":11,"updated":"2025-06-25 22:34:03.000000000","message":"nit: I\u0027m not sure \"DUT\" is an useful info and may cause some confusion. Maybe LUNs would be more accurate for this case?","commit_id":"7d8da036d22ba4f53ac82d28de3a87fc647114f2"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"91de429ecb44ed4fcbfe076be8055742238ca88f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During the detach operation of iSCSI and Fibre Channel (FC) sessions,"},{"line_number":10,"context_line":"the process fails when multiple initiators are connected to the Device"},{"line_number":11,"context_line":"Under Test (DUT). Investigation reveals that the root cause is related"},{"line_number":12,"context_line":"to improper handling of initiator identifiers due to the use of a space"},{"line_number":13,"context_line":"character as a delimiter."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"acd549e7_4df65c68","line":11,"in_reply_to":"22d3076a_484f31e7","updated":"2025-06-26 03:31:40.000000000","message":"Addressed","commit_id":"7d8da036d22ba4f53ac82d28de3a87fc647114f2"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"4c9588ab246ac972211ff3ffafddcea07784bd3c","unresolved":true,"context_lines":[{"line_number":12,"context_line":"to improper handling of initiator identifiers due to the use of a space"},{"line_number":13,"context_line":"character as a delimiter."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Specifically, the system expects initiator IDs to be parsed and processed"},{"line_number":16,"context_line":"as distinct entities. However, when multiple initiators are listed or"},{"line_number":17,"context_line":"passed as a single string separated by spaces, the parsing logic incorrectly"},{"line_number":18,"context_line":"splits or merges these identifiers. This results in failure to correctly"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"16c97e06_2922e1fc","line":15,"updated":"2025-06-25 22:34:03.000000000","message":"which system? The NetApp\u0027s REST API you mean?","commit_id":"7d8da036d22ba4f53ac82d28de3a87fc647114f2"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"91de429ecb44ed4fcbfe076be8055742238ca88f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"to improper handling of initiator identifiers due to the use of a space"},{"line_number":13,"context_line":"character as a delimiter."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Specifically, the system expects initiator IDs to be parsed and processed"},{"line_number":16,"context_line":"as distinct entities. However, when multiple initiators are listed or"},{"line_number":17,"context_line":"passed as a single string separated by spaces, the parsing logic incorrectly"},{"line_number":18,"context_line":"splits or merges these identifiers. This results in failure to correctly"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"4e4c0c52_494c1c03","line":15,"in_reply_to":"16c97e06_2922e1fc","updated":"2025-06-26 03:31:40.000000000","message":"Addressed","commit_id":"7d8da036d22ba4f53ac82d28de3a87fc647114f2"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"160a05ffa46c03c06a9a9acf51fb361ed43045fd","unresolved":true,"context_lines":[{"line_number":7,"context_line":"NetApp: iSCSI/FC detach operation fails when multiple initiators connected"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During the detach operation of iSCSI and Fibre Channel (FC) sessions,"},{"line_number":10,"context_line":"the process fails when multiple initiators are connected to LUNS."},{"line_number":11,"context_line":"Investigation reveals that the root cause is related to improper"},{"line_number":12,"context_line":"handling of initiator identifiers due to the use of a space character"},{"line_number":13,"context_line":"as a delimiter."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"d67fec22_71397a3e","line":10,"updated":"2025-06-26 17:27:07.000000000","message":"nit: The correct pluralization is LUNs instead of LUNS, but I would suggest changing it to the following \"fails when multiple initiators are connected to a LUN.\".","commit_id":"4addad4baf3d6978d6fc597737bdd7f8fe697479"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"86a360b2b23f99947164a616340b9cdfca845394","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"55363a0b_4061ccd3","updated":"2025-06-23 15:02:28.000000000","message":"Looks good.","commit_id":"571f5ed7e36a9730258b0708f17208f0502e3cb4"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"b2f0e5b0172c13c38739f06ffe17fede38975dfa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"438c3e14_02705627","updated":"2025-06-25 04:05:52.000000000","message":"Please add the below things \n- Add the release notes \n- Add the bug in commit summary","commit_id":"571f5ed7e36a9730258b0708f17208f0502e3cb4"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"976bb5e7feddbd7be8fc237d04569ce988faf0b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"97fa73c6_3aec72e3","updated":"2025-06-24 03:38:12.000000000","message":"recheck","commit_id":"571f5ed7e36a9730258b0708f17208f0502e3cb4"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"be81824e36c66424234aa1843e4160b4b8371943","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fe1eed36_445b9603","updated":"2025-06-23 04:53:01.000000000","message":"recheck","commit_id":"571f5ed7e36a9730258b0708f17208f0502e3cb4"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"0fa334ea08db75f9ccfa5eb4c7e1742bbe46c1ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dd9a417f_e6f10293","in_reply_to":"438c3e14_02705627","updated":"2025-06-25 11:31:36.000000000","message":"Thank you Gireesh. Added release notes and bug was already present in commit message.","commit_id":"571f5ed7e36a9730258b0708f17208f0502e3cb4"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"0fa334ea08db75f9ccfa5eb4c7e1742bbe46c1ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3880bbaa_bf371275","updated":"2025-06-25 11:31:36.000000000","message":"Addressed Gireesh\u0027s comments. \n\nJust mention, Performed regression testing by executing few volume workflows like create volume, create a server and attach server to volume, detach server from volume, delete volume and the code is from NetApp driver. This shouldn\u0027t have any impact for any other workflows. As Gireesh mentioned in one of his patches(https://review.opendev.org/c/openstack/cinder/+/951485), we are working on bringing up NetApp CI actively and meanwhile enough testing is done for the changes. Please review and look at providing approval. Thanks for the support!","commit_id":"7d8da036d22ba4f53ac82d28de3a87fc647114f2"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"c99f6d7b8e201976872b58860ce0795879d210c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e0852ee5_cd3efc1c","updated":"2025-06-25 22:42:15.000000000","message":"Hi Saikumar, please see my comments below.","commit_id":"7d8da036d22ba4f53ac82d28de3a87fc647114f2"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"73334c037ad0d6b637ab6ee86d35ca131e3e96cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f0b7ebda_2c2baff2","updated":"2025-06-25 11:33:11.000000000","message":"Please do review and provide your feedback. Thank you!!","commit_id":"7d8da036d22ba4f53ac82d28de3a87fc647114f2"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"4b4b9b450a8fc11d9994027ee23fc23699e82446","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3aea26cb_624f3094","updated":"2025-06-25 15:17:33.000000000","message":"recheck","commit_id":"7d8da036d22ba4f53ac82d28de3a87fc647114f2"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"185b865413b113192cba3d850c7025f1213de23e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d164877e_14cf75fe","updated":"2025-07-07 16:59:16.000000000","message":"Changes look okay to me.  Sai and Gireesh have confirmed that internal testing was thorough and successful.  NetApp CI is being worked on currently, I think this can move forward in the mean time.","commit_id":"4addad4baf3d6978d6fc597737bdd7f8fe697479"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"ebd09cd7e64ba7430f165be6384f374960ca9309","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"046af4e1_b90b27ee","updated":"2025-06-26 08:48:41.000000000","message":"Hi @rajatdhasmana@gmail.com/ @jobernar@redhat.com, \n\nThis patch has very minimal changes related to initiators(Only for REST API workflow) and it shouldn\u0027t impact any other workflows. This is request from a specific customer and we have been getting reminders to push this ASAP. Please consider to review this ASAP and provide approvals. The regression testing has been performed locally and it\u0027s not impacting any workflows. \n\nNote: Like Gireesh mentioned in one of his patches(https://review.opendev.org/c/openstack/cinder/+/951485), we have some infra issues with NetApp CI and it will take some time fix but we are working on it actively, \n\nThank you so much for your understanding and continuous support.","commit_id":"4addad4baf3d6978d6fc597737bdd7f8fe697479"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"16aebc9fe30f902994b55a4b0456418377831b88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"985169cb_0c0a6cb6","updated":"2025-06-26 08:56:24.000000000","message":"LGTM ..!","commit_id":"4addad4baf3d6978d6fc597737bdd7f8fe697479"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"faacbc0b07925dcf4476e0acb687c2a46d32c1d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cbcaa1ed_8c3da612","updated":"2025-06-26 14:24:40.000000000","message":"Looks good.","commit_id":"4addad4baf3d6978d6fc597737bdd7f8fe697479"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"91de429ecb44ed4fcbfe076be8055742238ca88f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"688b45f4_76087f7a","updated":"2025-06-26 03:31:40.000000000","message":"Thank you Fernando for the comments. Addressed all of them.","commit_id":"4addad4baf3d6978d6fc597737bdd7f8fe697479"}],"cinder/tests/unit/volume/drivers/netapp/dataontap/client/test_client_cmode_rest.py":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"c99f6d7b8e201976872b58860ce0795879d210c5","unresolved":true,"context_lines":[{"line_number":1884,"context_line":"        self.assertEqual([], igroup_list)"},{"line_number":1885,"context_line":""},{"line_number":1886,"context_line":"    def test_get_igroup_by_initiators(self):"},{"line_number":1887,"context_line":"        initiators \u003d [\u0027iqn.1993-08.org.fake:01:5b67769f5c5e\u0027]"},{"line_number":1888,"context_line":"        expected_igroup \u003d [{"},{"line_number":1889,"context_line":"            \u0027initiator-group-os-type\u0027: \u0027linux\u0027,"},{"line_number":1890,"context_line":"            \u0027initiator-group-type\u0027: \u0027iscsi\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"0260a3b3_9cea488e","line":1887,"updated":"2025-06-25 22:42:15.000000000","message":"There are no tests to validate the scenario of multiple initiators. That is why we\u0027ve never caught this issue beforehand.","commit_id":"7d8da036d22ba4f53ac82d28de3a87fc647114f2"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"91de429ecb44ed4fcbfe076be8055742238ca88f","unresolved":false,"context_lines":[{"line_number":1884,"context_line":"        self.assertEqual([], igroup_list)"},{"line_number":1885,"context_line":""},{"line_number":1886,"context_line":"    def test_get_igroup_by_initiators(self):"},{"line_number":1887,"context_line":"        initiators \u003d [\u0027iqn.1993-08.org.fake:01:5b67769f5c5e\u0027]"},{"line_number":1888,"context_line":"        expected_igroup \u003d [{"},{"line_number":1889,"context_line":"            \u0027initiator-group-os-type\u0027: \u0027linux\u0027,"},{"line_number":1890,"context_line":"            \u0027initiator-group-type\u0027: \u0027iscsi\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"f62d21e3_5be52c91","line":1887,"in_reply_to":"0260a3b3_9cea488e","updated":"2025-06-26 03:31:40.000000000","message":"Actually I see we have this \"test_get_igroup_by_initiators_multiple\" test.","commit_id":"7d8da036d22ba4f53ac82d28de3a87fc647114f2"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"3269de6282c0c710de90c4c44c5f90f13e635a44","unresolved":false,"context_lines":[{"line_number":1884,"context_line":"        self.assertEqual([], igroup_list)"},{"line_number":1885,"context_line":""},{"line_number":1886,"context_line":"    def test_get_igroup_by_initiators(self):"},{"line_number":1887,"context_line":"        initiators \u003d [\u0027iqn.1993-08.org.fake:01:5b67769f5c5e\u0027]"},{"line_number":1888,"context_line":"        expected_igroup \u003d [{"},{"line_number":1889,"context_line":"            \u0027initiator-group-os-type\u0027: \u0027linux\u0027,"},{"line_number":1890,"context_line":"            \u0027initiator-group-type\u0027: \u0027iscsi\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"736cadc9_83b21e1d","line":1887,"in_reply_to":"f62d21e3_5be52c91","updated":"2025-06-26 17:22:25.000000000","message":"Oh, that\u0027s right. This can be marked as resolved then.","commit_id":"7d8da036d22ba4f53ac82d28de3a87fc647114f2"}],"releasenotes/notes/bug-2114993-iscsi-fc-detach-operation-fails-when-multiple-initiators-connected-b1069bab32d86027.yaml":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"4c9588ab246ac972211ff3ffafddcea07784bd3c","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp Driver `bug #2114993"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2114993\u003e`_: Fixed iSCSI and FC "},{"line_number":6,"context_line":"    detach operation failure issue when multiple initiators are connected."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"cdb87064_e12a80bb","line":5,"updated":"2025-06-25 22:34:03.000000000","message":"Remove trailing space at the end of line.","commit_id":"7d8da036d22ba4f53ac82d28de3a87fc647114f2"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"91de429ecb44ed4fcbfe076be8055742238ca88f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    NetApp Driver `bug #2114993"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/2114993\u003e`_: Fixed iSCSI and FC "},{"line_number":6,"context_line":"    detach operation failure issue when multiple initiators are connected."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6df3c155_c7ac5eb5","line":5,"in_reply_to":"cdb87064_e12a80bb","updated":"2025-06-26 03:31:40.000000000","message":"Addressed","commit_id":"7d8da036d22ba4f53ac82d28de3a87fc647114f2"}]}