)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"5bcd2e973d63221074fadbf3e8b70da481f6e521","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"928b08b7_7d6d17ab","updated":"2025-07-16 19:43:43.000000000","message":"looks reasonable.  needs unit tests","commit_id":"df2edb1c613c3c9c625b354d231a04f868d982fd"},{"author":{"_account_id":38252,"name":"HPE AlletraMP NVMeTCP CI","display_name":"HPE AlletraMP NVMeTCP CI","email":"yogeshwari.gitte-ext@hpe.com","username":"yogeshwarigitte"},"change_message_id":"a2fc9f46d204e9757c56b29f58799f47da1d7b09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"91620fc5_c8303f25","updated":"2025-08-06 04:26:11.000000000","message":"run-HPE NVMeTCP Storage CI","commit_id":"5d24c676e0b920e07768b9cd11d20391bf12f7ba"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"e2033ea27183b2dd023f766a5777c581f753f681","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"82dc3f75_15f7dcdb","updated":"2025-08-06 06:39:16.000000000","message":"run-HPE NVMeTCP Storage CI","commit_id":"7f8af6735f0e8b9dae43bb09c968118beaee159d"},{"author":{"_account_id":38252,"name":"HPE AlletraMP NVMeTCP CI","display_name":"HPE AlletraMP NVMeTCP CI","email":"yogeshwari.gitte-ext@hpe.com","username":"yogeshwarigitte"},"change_message_id":"6fa94c0d045de1a8ebfa760ae246854bb8e58837","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"43fc3948_2e6821c1","updated":"2025-08-11 06:32:40.000000000","message":"run-HPE NVMeTCP Storage CI","commit_id":"05a7dadbf367b1614c7c9659eae1e83118e1c7b6"},{"author":{"_account_id":38252,"name":"HPE AlletraMP NVMeTCP CI","display_name":"HPE AlletraMP NVMeTCP CI","email":"yogeshwari.gitte-ext@hpe.com","username":"yogeshwarigitte"},"change_message_id":"1b5973f3e192c850ac24f2f2835559049cea2f16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"68a582dc_457abc49","updated":"2025-08-11 06:17:44.000000000","message":"run-HPE NVMeTCP Storage CI","commit_id":"05a7dadbf367b1614c7c9659eae1e83118e1c7b6"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"dedab0321cbbfecf63feba9d8e0b9a9ff5f2d062","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"08979995_e34df611","updated":"2025-08-12 11:21:15.000000000","message":"Hi Hemna,\nZuul has passed. We are still working on HPE NVMeTCP CI.\nIn the meanwhile if we could receive any review comments; that would be great.\nAppreciate your feedback.","commit_id":"079e2f2ed00d9fe6bbb99711059784a9cef0a977"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"5c766c57a98e2f2c3136fbdb22e965db484f8c31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"da83c1fa_a868bec3","updated":"2025-08-11 15:27:37.000000000","message":"recheck devstack-plugin-nfs-tempest-full","commit_id":"079e2f2ed00d9fe6bbb99711059784a9cef0a977"},{"author":{"_account_id":35822,"name":"Senthil Vasudevan","display_name":"HPE AlletraMP FC CI","email":"senthil.vasudevan@hpe.com","username":"senthilv"},"change_message_id":"fddcfd3c843d466dc78d4ccc5113af8ddbb2afef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"20de7805_b7433cc0","updated":"2025-08-18 10:46:07.000000000","message":"run-HPE NVMeTCP Storage CI","commit_id":"079e2f2ed00d9fe6bbb99711059784a9cef0a977"},{"author":{"_account_id":35822,"name":"Senthil Vasudevan","display_name":"HPE AlletraMP FC CI","email":"senthil.vasudevan@hpe.com","username":"senthilv"},"change_message_id":"45ecc8e931e05ee69c4fc221af1bc69425ae72d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"5563f4b4_29b4784b","updated":"2025-08-18 11:36:26.000000000","message":"run-HPE NVMeTCP Storage CI","commit_id":"079e2f2ed00d9fe6bbb99711059784a9cef0a977"},{"author":{"_account_id":35822,"name":"Senthil Vasudevan","display_name":"HPE AlletraMP FC CI","email":"senthil.vasudevan@hpe.com","username":"senthilv"},"change_message_id":"a75cf3e30291f4b468c136251836a81eec953d2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"57c3d0b0_dbf7ade1","updated":"2025-08-13 16:52:00.000000000","message":"run-HPE NVMeTCP Storage CI","commit_id":"079e2f2ed00d9fe6bbb99711059784a9cef0a977"},{"author":{"_account_id":35822,"name":"Senthil Vasudevan","display_name":"HPE AlletraMP FC CI","email":"senthil.vasudevan@hpe.com","username":"senthilv"},"change_message_id":"105d15ae8b86c6ae4f355a244530e1fd4bce5cd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"fdf9d30f_c58ab65e","updated":"2025-08-18 12:14:28.000000000","message":"run-HPE NVMeTCP Storage CI","commit_id":"079e2f2ed00d9fe6bbb99711059784a9cef0a977"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a71ac3a493312805d6a1665190e7c733ef0bc859","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"75f07efb_0c9f5061","updated":"2025-09-07 19:28:22.000000000","message":"Along with inline comments, We will require a release note mentioning the new driver in the \"features\" section","commit_id":"913dede5cda3f96328e195a527b4f213a0452333"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"526e433b2fccf6902f569325f5307acff5bc49d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"bacedf24_0bfcee1e","updated":"2025-09-02 12:19:34.000000000","message":"Hi Hemna,\nIt would be great to receive any review comments.\nThanks.","commit_id":"913dede5cda3f96328e195a527b4f213a0452333"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"53ab22b2910945706a97efcab7675fcf2a4c8166","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"d5b44837_4c56c03a","updated":"2025-09-08 05:33:22.000000000","message":"Thank you Rajat for the review.\ni will work on the review comments.","commit_id":"913dede5cda3f96328e195a527b4f213a0452333"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"009bd101ba37e0f57f94f3ecbc6fbdcd80e64847","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"79e052ef_0f2fd2ad","updated":"2025-10-08 12:44:37.000000000","message":"cinder-flamingo-features","commit_id":"913dede5cda3f96328e195a527b4f213a0452333"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"8d2dfb9ae76463797b5edb8f484e4235bebbe2f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"bea3154c_09079a6d","updated":"2025-08-19 09:27:26.000000000","message":"recheck devstack-plugin-nfs-tempest-full failed","commit_id":"913dede5cda3f96328e195a527b4f213a0452333"},{"author":{"_account_id":35822,"name":"Senthil Vasudevan","display_name":"HPE AlletraMP FC CI","email":"senthil.vasudevan@hpe.com","username":"senthilv"},"change_message_id":"8b4c7703d6b080e5b143b6842b950f24f4e78761","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"01bafde4_150aaa55","updated":"2025-08-19 10:50:08.000000000","message":"run-HPE NVMeTCP Storage CI","commit_id":"913dede5cda3f96328e195a527b4f213a0452333"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"a63c07391b97322a6a4f21998a9d6e1b009559e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"25582cb6_319c6226","updated":"2025-08-18 15:36:50.000000000","message":"run-HPE NVMeTCP Storage CI","commit_id":"913dede5cda3f96328e195a527b4f213a0452333"},{"author":{"_account_id":35822,"name":"Senthil Vasudevan","display_name":"HPE AlletraMP FC CI","email":"senthil.vasudevan@hpe.com","username":"senthilv"},"change_message_id":"446a953d0304d28e83be01f031a6aed506f2138c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"f6da35cb_235a8469","updated":"2025-08-19 09:24:48.000000000","message":"run-HPE NVMeTCP Storage CI","commit_id":"913dede5cda3f96328e195a527b4f213a0452333"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"a72639f0a148ac7437b3d7e6ae1aafa7921429b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"6aa3f2b4_df57a0d2","updated":"2026-01-09 09:47:28.000000000","message":"Added release notes. Tried to address review comments","commit_id":"6b3381bd4c3442cb45a64ae9c07292ee917c2b27"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"be0428cc99592cd892ee6a03fe1a2b46e998ce32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"e57f14d7_0cf65653","updated":"2026-01-13 14:39:22.000000000","message":"Hi Rajat/Hemna,\nit would great if you could revisit this patch \u0026 provide comments (if any).\nThanks","commit_id":"6b3381bd4c3442cb45a64ae9c07292ee917c2b27"}],"cinder/volume/drivers/hpe/hpe_3par_nvme_tcp.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a71ac3a493312805d6a1665190e7c733ef0bc859","unresolved":true,"context_lines":[{"line_number":30,"context_line":"from cinder import interface"},{"line_number":31,"context_line":"from cinder.volume.drivers.hpe import hpe_3par_base as hpebasedriver"},{"line_number":32,"context_line":"from cinder.volume import volume_utils"},{"line_number":33,"context_line":"# from os_brick.initiator.connectors.nvmeof import NVMeOFConnector,"},{"line_number":34,"context_line":"# NVMeOFConnProps"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"4777c9fa_8fe84172","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":17},"updated":"2025-09-07 19:28:22.000000000","message":"looks like this is not needed so we can remove this?","commit_id":"913dede5cda3f96328e195a527b4f213a0452333"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"a72639f0a148ac7437b3d7e6ae1aafa7921429b8","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from cinder import interface"},{"line_number":31,"context_line":"from cinder.volume.drivers.hpe import hpe_3par_base as hpebasedriver"},{"line_number":32,"context_line":"from cinder.volume import volume_utils"},{"line_number":33,"context_line":"# from os_brick.initiator.connectors.nvmeof import NVMeOFConnector,"},{"line_number":34,"context_line":"# NVMeOFConnProps"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"738d69fd_639262e7","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":17},"in_reply_to":"4777c9fa_8fe84172","updated":"2026-01-09 09:47:28.000000000","message":"Done","commit_id":"913dede5cda3f96328e195a527b4f213a0452333"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a71ac3a493312805d6a1665190e7c733ef0bc859","unresolved":true,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def initialize_nvme_ips_and_ports(self, common):"},{"line_number":70,"context_line":"        # map nvme_ip -\u003e ip_port"},{"line_number":71,"context_line":"        #             -\u003e nsp"},{"line_number":72,"context_line":"        cinder_conf \u003d common._client_conf"},{"line_number":73,"context_line":"        hpe3par_client \u003d common.client"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"13e2d6ae_a4898221","line":71,"range":{"start_line":71,"start_character":8,"end_line":71,"end_character":28},"updated":"2025-09-07 19:28:22.000000000","message":"is this comment incomplete?","commit_id":"913dede5cda3f96328e195a527b4f213a0452333"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"a72639f0a148ac7437b3d7e6ae1aafa7921429b8","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def initialize_nvme_ips_and_ports(self, common):"},{"line_number":70,"context_line":"        # map nvme_ip -\u003e ip_port"},{"line_number":71,"context_line":"        #             -\u003e nsp"},{"line_number":72,"context_line":"        cinder_conf \u003d common._client_conf"},{"line_number":73,"context_line":"        hpe3par_client \u003d common.client"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"1df06a1f_39f9d58e","line":71,"range":{"start_line":71,"start_character":8,"end_line":71,"end_character":28},"in_reply_to":"13e2d6ae_a4898221","updated":"2026-01-09 09:47:28.000000000","message":"now this comment is removed","commit_id":"913dede5cda3f96328e195a527b4f213a0452333"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a71ac3a493312805d6a1665190e7c733ef0bc859","unresolved":true,"context_lines":[{"line_number":147,"context_line":"            vol_name_3par \u003d common._get_3par_vol_name(volume)"},{"line_number":148,"context_line":"            host \u003d hpe3par_client.getHostByNqn(host_nqn)"},{"line_number":149,"context_line":"            hostname \u003d host[\u0027name\u0027]"},{"line_number":150,"context_line":"            hpe3par_client.remove_vlun_nvme(vol_name_3par, hostname, host_nqn)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        finally:"},{"line_number":153,"context_line":"            self._logout(common)"}],"source_content_type":"text/x-python","patch_set":16,"id":"d4c014dd_41a31495","line":150,"range":{"start_line":150,"start_character":0,"end_line":150,"end_character":78},"updated":"2025-09-07 19:28:22.000000000","message":"we aren\u0027t handling any of the special cases here\n\n1. If the connector is None, we should disconnect from all hosts, netapp example[1]\n2. If the volume is multiattach and we have the volume attached to multiple guests on same compute host, we shouldn\u0027t disconnect the volume\n\n\nreference for lvm[2] and fix for netapp[3]\n[1] https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/netapp/dataontap/block_base.py#L1004-L1007\n[2] https://opendev.org/openstack/cinder/src/branch/master/cinder/volume/drivers/lvm.py#L881-L884\n[3] https://review.opendev.org/c/openstack/cinder/+/957227","commit_id":"913dede5cda3f96328e195a527b4f213a0452333"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"a72639f0a148ac7437b3d7e6ae1aafa7921429b8","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            vol_name_3par \u003d common._get_3par_vol_name(volume)"},{"line_number":148,"context_line":"            host \u003d hpe3par_client.getHostByNqn(host_nqn)"},{"line_number":149,"context_line":"            hostname \u003d host[\u0027name\u0027]"},{"line_number":150,"context_line":"            hpe3par_client.remove_vlun_nvme(vol_name_3par, hostname, host_nqn)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        finally:"},{"line_number":153,"context_line":"            self._logout(common)"}],"source_content_type":"text/x-python","patch_set":16,"id":"4b02f5af_f1124c4c","line":150,"range":{"start_line":150,"start_character":0,"end_line":150,"end_character":78},"in_reply_to":"d4c014dd_41a31495","updated":"2026-01-09 09:47:28.000000000","message":"Done","commit_id":"913dede5cda3f96328e195a527b4f213a0452333"}]}