)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"c5a7a2fa085f8bb8ae74a5a69fb41f23b7d9fc5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d302f043_2166c537","updated":"2025-10-31 15:46:21.000000000","message":"I do have a question as a double-check, but the -1 is due to no release notes.","commit_id":"22be92432572118c70a5e8ad6b6f2e87922836fa"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"06d5620fe3400d05917c33588064dc03344a224b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"98131969_b88e3b0d","updated":"2025-11-01 20:08:38.000000000","message":"I may have forgotten to mention this as well for the review (or I left the \"resolved\" checkbox checked), but you need release notes since these values should be customer-facing.  That\u0027s why I gave the -1.\n\nSee this for the release notes:\nhttps://docs.openstack.org/cinder/latest/contributor/releasenotes.html\n\nOnce that\u0027s done I\u0027ll issue a +1 for my review.","commit_id":"22be92432572118c70a5e8ad6b6f2e87922836fa"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"f0286301f4fcbb39551c996fa7b51d818fc16795","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"35905b3f_e6e31ef7","in_reply_to":"7700b658_04599958","updated":"2025-11-03 21:05:48.000000000","message":"Acknowledged","commit_id":"22be92432572118c70a5e8ad6b6f2e87922836fa"},{"author":{"_account_id":37686,"name":"Alireza","display_name":"Alireza Rahmani","email":"a.rahnam78@gmail.com","username":"alirezarm"},"change_message_id":"dd49d43a83dbec65e1d2664fd8979d951a852860","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7700b658_04599958","in_reply_to":"98131969_b88e3b0d","updated":"2025-11-03 08:40:48.000000000","message":"\u003e I may have forgotten to mention this as well for the review (or I left the \"resolved\" checkbox checked), but you need release notes since these values should be customer-facing.  That\u0027s why I gave the -1.\n\u003e \n\u003e See this for the release notes:\n\u003e https://docs.openstack.org/cinder/latest/contributor/releasenotes.html\n\u003e \n\u003e Once that\u0027s done I\u0027ll issue a +1 for my review.\n\nDone.","commit_id":"22be92432572118c70a5e8ad6b6f2e87922836fa"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"51fb037517e13a43f4cfa1c9d14734390dbdd912","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e86bb1dd_4c151783","updated":"2025-11-07 16:13:10.000000000","message":"Change looks good, release note has a typo (off instead of \u0027of\u0027) and the formatting needs to be improved - See https://3430dcb59d7165aaab3d-6b8b23b3ffc5f49b6a6d91eabcb2ca0e.ssl.cf2.rackcdn.com/openstack/ca4834eefad84932b64f8df6a901d258/docs/unreleased.html for the rendered result.  You\u0027re able to use formatting to make the list show up correctly, here\u0027s an example: https://github.com/openstack/cinder/blob/master/releasenotes/notes/netapp-asar2-disaggregated-platform-support-a1b2c3d4e5f6g7h8.yaml","commit_id":"1ea464d980ab4cd7893391231e170d393be55262"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"f0286301f4fcbb39551c996fa7b51d818fc16795","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"456a2cad_fa88afa0","updated":"2025-11-03 21:05:48.000000000","message":"Patch looks good to me with release notes and confirmation on the defaults.","commit_id":"1ea464d980ab4cd7893391231e170d393be55262"},{"author":{"_account_id":37686,"name":"Alireza","display_name":"Alireza Rahmani","email":"a.rahnam78@gmail.com","username":"alirezarm"},"change_message_id":"d00525da9a471ec4233c18eb31e5608a8c49e8fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"14a87754_1f6f4cf2","in_reply_to":"b1851a19_87178d83","updated":"2025-11-11 07:51:10.000000000","message":"Done","commit_id":"1ea464d980ab4cd7893391231e170d393be55262"},{"author":{"_account_id":37686,"name":"Alireza","display_name":"Alireza Rahmani","email":"a.rahnam78@gmail.com","username":"alirezarm"},"change_message_id":"395344358c4cda7f2c12a26bd03fe64802c89320","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b1851a19_87178d83","in_reply_to":"e86bb1dd_4c151783","updated":"2025-11-08 09:33:46.000000000","message":"I fixed formatting but i didn\u0027t saw any typos in release note.","commit_id":"1ea464d980ab4cd7893391231e170d393be55262"}],"cinder/volume/drivers/rbd.py":[{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"c5a7a2fa085f8bb8ae74a5a69fb41f23b7d9fc5f","unresolved":true,"context_lines":[{"line_number":192,"context_line":"        \u0027ceph_key\u0027: \u0027rbd_qos_write_bps_burst\u0027,"},{"line_number":193,"context_line":"        \u0027default\u0027: 0"},{"line_number":194,"context_line":"    },"},{"line_number":195,"context_line":"    \u0027total_iops_max_seconds\u0027: {"},{"line_number":196,"context_line":"        \u0027ceph_key\u0027: \u0027rbd_qos_iops_burst_seconds\u0027,"},{"line_number":197,"context_line":"        \u0027default\u0027: 1"},{"line_number":198,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":1,"id":"a246a115_12422d98","line":195,"updated":"2025-10-31 15:46:21.000000000","message":"Just to make sure that the defaults here are all meant to be 1 (since everything else is 0).\n\nI looked through the code to see where this is used, and it seems to be for comparing what needs removing","commit_id":"22be92432572118c70a5e8ad6b6f2e87922836fa"},{"author":{"_account_id":37686,"name":"Alireza","display_name":"Alireza Rahmani","email":"a.rahnam78@gmail.com","username":"alirezarm"},"change_message_id":"ecaed9ad423869fdf564db8bb40234a92443f76f","unresolved":true,"context_lines":[{"line_number":192,"context_line":"        \u0027ceph_key\u0027: \u0027rbd_qos_write_bps_burst\u0027,"},{"line_number":193,"context_line":"        \u0027default\u0027: 0"},{"line_number":194,"context_line":"    },"},{"line_number":195,"context_line":"    \u0027total_iops_max_seconds\u0027: {"},{"line_number":196,"context_line":"        \u0027ceph_key\u0027: \u0027rbd_qos_iops_burst_seconds\u0027,"},{"line_number":197,"context_line":"        \u0027default\u0027: 1"},{"line_number":198,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":1,"id":"fb3e5c4f_feb6ed70","line":195,"in_reply_to":"a246a115_12422d98","updated":"2025-11-01 19:27:02.000000000","message":"\u003e Just to make sure that the defaults here are all meant to be 1 (since everything else is 0).\n\u003e \n\u003e I looked through the code to see where this is used, and it seems to be for comparing what needs removing\n\nJust to know every default values for burst time is rbd side is 1.","commit_id":"22be92432572118c70a5e8ad6b6f2e87922836fa"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"06d5620fe3400d05917c33588064dc03344a224b","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        \u0027ceph_key\u0027: \u0027rbd_qos_write_bps_burst\u0027,"},{"line_number":193,"context_line":"        \u0027default\u0027: 0"},{"line_number":194,"context_line":"    },"},{"line_number":195,"context_line":"    \u0027total_iops_max_seconds\u0027: {"},{"line_number":196,"context_line":"        \u0027ceph_key\u0027: \u0027rbd_qos_iops_burst_seconds\u0027,"},{"line_number":197,"context_line":"        \u0027default\u0027: 1"},{"line_number":198,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":1,"id":"89ac6232_5b1ee3e8","line":195,"in_reply_to":"fb3e5c4f_feb6ed70","updated":"2025-11-01 20:08:38.000000000","message":"Acknowledged","commit_id":"22be92432572118c70a5e8ad6b6f2e87922836fa"}]}