)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d6f5a7b72d0071892ace64ff8396c1066c1c9bed","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Younghwan Yoo \u003cyyhlkas21@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-08-19 09:17:34 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix mismatch requested and created volume capacity"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There was a discrepancy between the requested and created volume"},{"line_number":10,"context_line":"capacities when creating a volume from an image with"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"8682c5c5_ba96a15f","line":7,"updated":"2025-09-10 17:39:26.000000000","message":"The commit message subject is not very clear. How about something like:\n\n\"Fix reported size of image cache volumes\"","commit_id":"96c8da874c2cee66e1d1a29a236a0a3309e3d114"},{"author":{"_account_id":38249,"name":"Younghwan Yoo","email":"yyhlkas21@gmail.com","username":"b-501"},"change_message_id":"79cd5701c05b1ca8424a05dd8cded1f40cb86296","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Younghwan Yoo \u003cyyhlkas21@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-08-19 09:17:34 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix mismatch requested and created volume capacity"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There was a discrepancy between the requested and created volume"},{"line_number":10,"context_line":"capacities when creating a volume from an image with"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"cc21906c_d6330448","line":7,"in_reply_to":"8682c5c5_ba96a15f","updated":"2025-10-26 13:09:35.000000000","message":"Done","commit_id":"96c8da874c2cee66e1d1a29a236a0a3309e3d114"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d6f5a7b72d0071892ace64ff8396c1066c1c9bed","unresolved":true,"context_lines":[{"line_number":28,"context_line":"To resolve this, we added logic to update the model_update[\u0027size\u0027]"},{"line_number":29,"context_line":"with the original_size value."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Bug:"},{"line_number":32,"context_line":"- https://bugs.launchpad.net/cinder/+bug/2088132"},{"line_number":33,"context_line":"- https://bugs.launchpad.net/cinder/+bug/2120896"},{"line_number":34,"context_line":"Change-Id: I731cb156ce5d21e29af1b6f88de6d8635712405e"},{"line_number":35,"context_line":"Signed-off-by: Younghwan Yoo \u003cyyhlkas21@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"4de6e867_d55b0a07","line":34,"range":{"start_line":31,"start_character":0,"end_line":34,"end_character":0},"updated":"2025-09-10 17:39:26.000000000","message":"The correct syntax for these are:\n\nCloses-bug: #2088132\nCloses-bug: #2120896","commit_id":"96c8da874c2cee66e1d1a29a236a0a3309e3d114"},{"author":{"_account_id":38249,"name":"Younghwan Yoo","email":"yyhlkas21@gmail.com","username":"b-501"},"change_message_id":"79cd5701c05b1ca8424a05dd8cded1f40cb86296","unresolved":false,"context_lines":[{"line_number":28,"context_line":"To resolve this, we added logic to update the model_update[\u0027size\u0027]"},{"line_number":29,"context_line":"with the original_size value."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Bug:"},{"line_number":32,"context_line":"- https://bugs.launchpad.net/cinder/+bug/2088132"},{"line_number":33,"context_line":"- https://bugs.launchpad.net/cinder/+bug/2120896"},{"line_number":34,"context_line":"Change-Id: I731cb156ce5d21e29af1b6f88de6d8635712405e"},{"line_number":35,"context_line":"Signed-off-by: Younghwan Yoo \u003cyyhlkas21@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"c230df81_2880ecc2","line":34,"range":{"start_line":31,"start_character":0,"end_line":34,"end_character":0},"in_reply_to":"4de6e867_d55b0a07","updated":"2025-10-26 13:09:35.000000000","message":"Done","commit_id":"96c8da874c2cee66e1d1a29a236a0a3309e3d114"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"fbfeae6a23572b2d884a7b7bedf16a91de159c83","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Younghwan Yoo \u003cyyhlkas21@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-10-26 23:27:54 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix reported size of image cache volumes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There was a discrepancy between the requested and created volume"},{"line_number":10,"context_line":"capacities when creating a volume from an image with"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"c5aad2fd_93e4e833","line":7,"updated":"2025-10-27 22:04:54.000000000","message":"Now that I know the bug only affects drivers that return a \u0027size\u0027 field in the create_volume model_updates, AND that PowerFlex may be the only driver that does this, I think it would be clearer if you added \"PowerFlex: \" to the beginning of the subject line. That will make it clearer the patch isn\u0027t fixing a problem affecting all drivers.","commit_id":"d08b5b5f0f2e2fc62b8b73d64121a48c0e2181d8"},{"author":{"_account_id":38249,"name":"Younghwan Yoo","email":"yyhlkas21@gmail.com","username":"b-501"},"change_message_id":"9e420fed9ea80460f835c28d43493b3eb575a74c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Younghwan Yoo \u003cyyhlkas21@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-10-26 23:27:54 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix reported size of image cache volumes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There was a discrepancy between the requested and created volume"},{"line_number":10,"context_line":"capacities when creating a volume from an image with"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"3ae477b1_504b8620","line":7,"in_reply_to":"c5aad2fd_93e4e833","updated":"2025-10-27 23:43:05.000000000","message":"Done","commit_id":"d08b5b5f0f2e2fc62b8b73d64121a48c0e2181d8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"5e3c0f7472046e8f28a8a64a4b5b4400eb11dcb1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7ca28af1_b12bb156","updated":"2025-08-07 09:01:08.000000000","message":"Looks good to me","commit_id":"e32d1070014a6ca68b1fb4681a87b82f927d0e2e"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"d6f5a7b72d0071892ace64ff8396c1066c1c9bed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"53ac2929_dd8e0352","updated":"2025-09-10 17:39:26.000000000","message":"The code changes look good (thank you!) but in addition to fixing the commit message, you also need to supply:\n\n- Unit test coverage\n- A release note that references both bugs","commit_id":"96c8da874c2cee66e1d1a29a236a0a3309e3d114"},{"author":{"_account_id":38249,"name":"Younghwan Yoo","email":"yyhlkas21@gmail.com","username":"b-501"},"change_message_id":"9e420fed9ea80460f835c28d43493b3eb575a74c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"d789b592_6f47da30","in_reply_to":"4744a4fd_ef9c5907","updated":"2025-10-27 23:43:05.000000000","message":"Done","commit_id":"96c8da874c2cee66e1d1a29a236a0a3309e3d114"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"c80ffb10bcf2407b0af71608f75138eb197f684a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4744a4fd_ef9c5907","in_reply_to":"500186dc_89e820dd","updated":"2025-10-27 22:17:37.000000000","message":"This is an unusual situation where I think this patch is OK without adding unit test coverage.\n\nThe function it touches (_create_from_image_cache_or_download) is fairly complex, doesn\u0027t have good tests to start with, and would require a lot of mocking. It would be great to add more unit tests to the image volume cache code, but that shouldn\u0027t hold up this patch.","commit_id":"96c8da874c2cee66e1d1a29a236a0a3309e3d114"},{"author":{"_account_id":38249,"name":"Younghwan Yoo","email":"yyhlkas21@gmail.com","username":"b-501"},"change_message_id":"79cd5701c05b1ca8424a05dd8cded1f40cb86296","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"500186dc_89e820dd","in_reply_to":"53ac2929_dd8e0352","updated":"2025-10-26 13:09:35.000000000","message":"I am searching how to valid this code. but I don\u0027t think a way. This bug is occured when creating a volume with a cinder volume driver using an image cache function. For this test case, I need a created cinder volume info and a real volume info created by cinder driver. Can I have a hint for writing test case?","commit_id":"96c8da874c2cee66e1d1a29a236a0a3309e3d114"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"fbfeae6a23572b2d884a7b7bedf16a91de159c83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"b3765aaf_f56d4373","updated":"2025-10-27 22:04:54.000000000","message":"This patch is very close! The trailing space in the release note needs to be fixed, and I realized when re-reviewing the change that it would be good to mention PowerFlex in the commit message and release note.","commit_id":"d08b5b5f0f2e2fc62b8b73d64121a48c0e2181d8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4c74229c85bb51aaa2bb63367802a02ff9d77fb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"67774b28_927517e5","updated":"2025-11-07 09:53:18.000000000","message":"one question inline","commit_id":"443d71a5cd0af6e12bfd4b2b39538d2049d7a760"},{"author":{"_account_id":38249,"name":"Younghwan Yoo","email":"yyhlkas21@gmail.com","username":"b-501"},"change_message_id":"4cdbbc63d1310780c3d750e9405b903d339315aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"d4441e20_1f2c4940","updated":"2026-01-06 12:13:48.000000000","message":"All tests passed and CR+2 received. Could you please take a look for the final workflow approval?","commit_id":"165ce07c1548fd6e0170ddcf29aec447463ec2aa"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"177b267d727dc16035a0b7f2eac15df74d0c7515","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"de6973a9_217a8587","updated":"2026-07-02 15:02:15.000000000","message":"I don\u0027t think this patch is necessary any more; it\u0027s handled in a different way in change I746343e8f9f4728a26fc753ba5189ca822493df6 at cinder/volume/drivers/dell_emc/powerflex/driver.py lines 678-685","commit_id":"165ce07c1548fd6e0170ddcf29aec447463ec2aa"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"59dc2223318b43a8f9ec3eac63bb454f0de6bcbb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"aa6d3e9a_3ec837be","updated":"2025-11-17 13:57:13.000000000","message":"LGTM, thanks!","commit_id":"165ce07c1548fd6e0170ddcf29aec447463ec2aa"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4cc2ca1c2b92d96f7cd3270832b97841703b71dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"1872a783_cbcb3042","updated":"2026-06-30 16:47:15.000000000","message":"Question/comment inline.","commit_id":"165ce07c1548fd6e0170ddcf29aec447463ec2aa"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"79dad08128cbc816b29a2af18b5e0fe6f5e68fcc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"f1da23b6_9efd4a4c","updated":"2026-07-01 13:34:20.000000000","message":"resetting my vote until the end user expectation is figured out (as per Brian\u0027s comment)","commit_id":"165ce07c1548fd6e0170ddcf29aec447463ec2aa"}],"cinder/releasenotes/notes/bug-2120896-fix_reported_size_of_image_cache_volumes-b4df557cb0616baf.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"fbfeae6a23572b2d884a7b7bedf16a91de159c83","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #2120896 \u003chttps://bugs.launchpad.net/cinder/+bug/2088132\u003e`_: Fixed "},{"line_number":5,"context_line":"    a difference between openstack cinder volume size and backend storage"},{"line_number":6,"context_line":"    volume size when you create an image cache volume."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"4b701ac2_6fbf35d6","line":4,"updated":"2025-10-27 22:04:54.000000000","message":"You\u0027ll need to remove the trailing space at the end of this line.\n\nAs I mentioned in the commit message, I also think you could add \"PowerFlex: \" to the beginning of the release note so that admins don\u0027t think the bug affected all cinder drivers.","commit_id":"d08b5b5f0f2e2fc62b8b73d64121a48c0e2181d8"},{"author":{"_account_id":38249,"name":"Younghwan Yoo","email":"yyhlkas21@gmail.com","username":"b-501"},"change_message_id":"9e420fed9ea80460f835c28d43493b3eb575a74c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #2120896 \u003chttps://bugs.launchpad.net/cinder/+bug/2088132\u003e`_: Fixed "},{"line_number":5,"context_line":"    a difference between openstack cinder volume size and backend storage"},{"line_number":6,"context_line":"    volume size when you create an image cache volume."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"efb6548c_4e9b2de1","line":4,"in_reply_to":"4b701ac2_6fbf35d6","updated":"2025-10-27 23:43:05.000000000","message":"Done","commit_id":"d08b5b5f0f2e2fc62b8b73d64121a48c0e2181d8"}],"cinder/volume/flows/manager/create_volume.py":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"0e39d3b249a98a6a1a19b5cf6b1fb49c90426df8","unresolved":true,"context_lines":[{"line_number":1062,"context_line":"            # letting it be raised further up the stack."},{"line_number":1063,"context_line":"            if volume.size !\u003d original_size:"},{"line_number":1064,"context_line":"                try:"},{"line_number":1065,"context_line":"                    if model_update is None:"},{"line_number":1066,"context_line":"                        model_update \u003d {}"},{"line_number":1067,"context_line":"                    model_update[\u0027size\u0027] \u003d original_size"},{"line_number":1068,"context_line":"                    self.driver.extend_volume(volume, original_size)"},{"line_number":1069,"context_line":"                finally:"},{"line_number":1070,"context_line":"                    volume.size \u003d original_size"},{"line_number":1071,"context_line":"                    volume.save()"}],"source_content_type":"text/x-python","patch_set":10,"id":"cdbe4209_5f7ea634","line":1068,"range":{"start_line":1065,"start_character":0,"end_line":1068,"end_character":0},"updated":"2025-10-22 16:43:44.000000000","message":"I looked into this further and now I understand why this issue is (probably) unique to PowerFlex. The PowerFlex driver always includes the \u0027size\u0027 in its model_updates because of the modulo-8GB constraint. I don\u0027t believe any other drivers include \u0027size\u0027 in their model_updates.\n\nWith this in mind, I don\u0027t think it\u0027s appropriate to always add the \u0027size\u0027. I think this would be a better approach:\n\n                    if model_update and \u0027size\u0027 in model_update:\n                        model_update[\u0027size\u0027] \u003d original_size\n                        \nThat will fix the \u0027size\u0027 value in PowerFlex\u0027s model_update without adding a \u0027size\u0027 field.","commit_id":"96c8da874c2cee66e1d1a29a236a0a3309e3d114"},{"author":{"_account_id":38249,"name":"Younghwan Yoo","email":"yyhlkas21@gmail.com","username":"b-501"},"change_message_id":"79cd5701c05b1ca8424a05dd8cded1f40cb86296","unresolved":false,"context_lines":[{"line_number":1062,"context_line":"            # letting it be raised further up the stack."},{"line_number":1063,"context_line":"            if volume.size !\u003d original_size:"},{"line_number":1064,"context_line":"                try:"},{"line_number":1065,"context_line":"                    if model_update is None:"},{"line_number":1066,"context_line":"                        model_update \u003d {}"},{"line_number":1067,"context_line":"                    model_update[\u0027size\u0027] \u003d original_size"},{"line_number":1068,"context_line":"                    self.driver.extend_volume(volume, original_size)"},{"line_number":1069,"context_line":"                finally:"},{"line_number":1070,"context_line":"                    volume.size \u003d original_size"},{"line_number":1071,"context_line":"                    volume.save()"}],"source_content_type":"text/x-python","patch_set":10,"id":"4810a587_322f3f45","line":1068,"range":{"start_line":1065,"start_character":0,"end_line":1068,"end_character":0},"in_reply_to":"cdbe4209_5f7ea634","updated":"2025-10-26 13:09:35.000000000","message":"Done","commit_id":"96c8da874c2cee66e1d1a29a236a0a3309e3d114"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"2ddddfd948a2d6260f21f849d201feebb99daa3c","unresolved":true,"context_lines":[{"line_number":1064,"context_line":"                try:"},{"line_number":1065,"context_line":"                    if model_update and \u0027size\u0027 in model_update:"},{"line_number":1066,"context_line":"                      model_update[\u0027size\u0027] \u003d original_size"},{"line_number":1067,"context_line":"                    model_update[\u0027size\u0027] \u003d original_size"},{"line_number":1068,"context_line":"                    self.driver.extend_volume(volume, original_size)"},{"line_number":1069,"context_line":"                finally:"},{"line_number":1070,"context_line":"                    volume.size \u003d original_size"}],"source_content_type":"text/x-python","patch_set":12,"id":"15a5e5f9_dbc6066e","line":1067,"updated":"2025-10-26 12:38:20.000000000","message":"is this a mistake/typo? why there is an \"if\" block? anyway model_update is being assigned with original_size","commit_id":"28f1314bee02357ca521247b8bd67341d70e92fe"},{"author":{"_account_id":38249,"name":"Younghwan Yoo","email":"yyhlkas21@gmail.com","username":"b-501"},"change_message_id":"79cd5701c05b1ca8424a05dd8cded1f40cb86296","unresolved":false,"context_lines":[{"line_number":1064,"context_line":"                try:"},{"line_number":1065,"context_line":"                    if model_update and \u0027size\u0027 in model_update:"},{"line_number":1066,"context_line":"                      model_update[\u0027size\u0027] \u003d original_size"},{"line_number":1067,"context_line":"                    model_update[\u0027size\u0027] \u003d original_size"},{"line_number":1068,"context_line":"                    self.driver.extend_volume(volume, original_size)"},{"line_number":1069,"context_line":"                finally:"},{"line_number":1070,"context_line":"                    volume.size \u003d original_size"}],"source_content_type":"text/x-python","patch_set":12,"id":"cb99f082_3ebe7402","line":1067,"in_reply_to":"15a5e5f9_dbc6066e","updated":"2025-10-26 13:09:35.000000000","message":"some driver(ex. powerflex) has a bug that image cache volume size applied on original volume size. if you create a 16gib volume with an image on no image cache volume, the volume is created with 8gib.","commit_id":"28f1314bee02357ca521247b8bd67341d70e92fe"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4c74229c85bb51aaa2bb63367802a02ff9d77fb7","unresolved":true,"context_lines":[{"line_number":1062,"context_line":"            # letting it be raised further up the stack."},{"line_number":1063,"context_line":"            if volume.size !\u003d original_size:"},{"line_number":1064,"context_line":"                try:"},{"line_number":1065,"context_line":"                    if model_update and \u0027size\u0027 in model_update:"},{"line_number":1066,"context_line":"                        model_update[\u0027size\u0027] \u003d original_size"},{"line_number":1067,"context_line":"                    self.driver.extend_volume(volume, original_size)"},{"line_number":1068,"context_line":"                finally:"},{"line_number":1069,"context_line":"                    volume.size \u003d original_size"}],"source_content_type":"text/x-python","patch_set":16,"id":"a7a09a80_357874f7","line":1066,"range":{"start_line":1065,"start_character":20,"end_line":1066,"end_character":60},"updated":"2025-11-07 09:53:18.000000000","message":"I have a different approach in mind. If we already know the correct size (original_size) and we have already updated it after the extend_volume call (L#1070) why don\u0027t we just pop out the \u0027size\u0027 field from the model update and avoid updating it two times?\n\n    # \u0027size\u0027 in model_update\n    \u003e\u003e\u003e model_update \u003d {\u0027name\u0027: \u0027powerflex_vol\u0027, \u0027size\u0027: 5}\n    \u003e\u003e\u003e model_update.pop(\u0027size\u0027, None)\n    5\n    \u003e\u003e\u003e model_update\n    {\u0027name\u0027: \u0027powerflex_vol\u0027}\n\n    # \u0027size\u0027 not in model_update\n    \u003e\u003e\u003e model_update \u003d {\u0027name\u0027: \u0027powerflex_vol\u0027}\n    \u003e\u003e\u003e model_update.pop(\u0027size\u0027, None)\n    \u003e\u003e\u003e model_update\n    {\u0027name\u0027: \u0027powerflex_vol\u0027}","commit_id":"443d71a5cd0af6e12bfd4b2b39538d2049d7a760"},{"author":{"_account_id":38249,"name":"Younghwan Yoo","email":"yyhlkas21@gmail.com","username":"b-501"},"change_message_id":"b161f291729cd72de935d8cfb1fbd4c742d64589","unresolved":false,"context_lines":[{"line_number":1062,"context_line":"            # letting it be raised further up the stack."},{"line_number":1063,"context_line":"            if volume.size !\u003d original_size:"},{"line_number":1064,"context_line":"                try:"},{"line_number":1065,"context_line":"                    if model_update and \u0027size\u0027 in model_update:"},{"line_number":1066,"context_line":"                        model_update[\u0027size\u0027] \u003d original_size"},{"line_number":1067,"context_line":"                    self.driver.extend_volume(volume, original_size)"},{"line_number":1068,"context_line":"                finally:"},{"line_number":1069,"context_line":"                    volume.size \u003d original_size"}],"source_content_type":"text/x-python","patch_set":16,"id":"b47a6f8e_0affbea6","line":1066,"range":{"start_line":1065,"start_character":20,"end_line":1066,"end_character":60},"in_reply_to":"a7a09a80_357874f7","updated":"2025-11-11 07:11:52.000000000","message":"Right! I didn\u0027t think that pop out \u0027size\u0027 in model_update created by powerflex driver. Currently, a driver returning a wrong size is only powerflex driver and the \u0027size\u0027 doesn\u0027t affect a real volume on powerflex. So, I think you are right. I wonder what you think, bishop.","commit_id":"443d71a5cd0af6e12bfd4b2b39538d2049d7a760"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"e4d418c9ec697a2f407a35a135521ca43d280f53","unresolved":true,"context_lines":[{"line_number":1062,"context_line":"            # letting it be raised further up the stack."},{"line_number":1063,"context_line":"            if volume.size !\u003d original_size:"},{"line_number":1064,"context_line":"                try:"},{"line_number":1065,"context_line":"                    if model_update and \u0027size\u0027 in model_update:"},{"line_number":1066,"context_line":"                        model_update.pop(\u0027size\u0027, None)"},{"line_number":1067,"context_line":"                    self.driver.extend_volume(volume, original_size)"},{"line_number":1068,"context_line":"                finally:"}],"source_content_type":"text/x-python","patch_set":17,"id":"62970dee_de4d3ae4","line":1065,"updated":"2025-11-12 15:26:02.000000000","message":"I agree that popping the \u0027size\u0027 is a good approach. Nit, though: \n\nYou don\u0027t need to check whether \u0027size\u0027 is in the dict. This should work:\n\n                    if model_update:\n                        model_update.pop(\u0027size\u0027, None)\n                        \nI\u0027ll +1 this version, but another thought if you have to post another update is you could move the two lines down below the \"finally\" clause (L1068). And a comment would be nice, perhaps something like this:\n\n               try:\n                    self.driver.extend_volume(volume, original_size)\n                finally:\n                    volume.size \u003d original_size\n                    volume.save()\n                    # The volume\u0027s size has been saved, so it can be removed\n                    # from the model_update.\n                    if model_update:\n                        model_update.pop(\u0027size\u0027, None)","commit_id":"8947183488c20b5b6fc0ab40317ef48f7388c665"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1f9e666faee3fb4c14092e730a9a30bd31735b49","unresolved":true,"context_lines":[{"line_number":1062,"context_line":"            # letting it be raised further up the stack."},{"line_number":1063,"context_line":"            if volume.size !\u003d original_size:"},{"line_number":1064,"context_line":"                try:"},{"line_number":1065,"context_line":"                    if model_update and \u0027size\u0027 in model_update:"},{"line_number":1066,"context_line":"                        model_update.pop(\u0027size\u0027, None)"},{"line_number":1067,"context_line":"                    self.driver.extend_volume(volume, original_size)"},{"line_number":1068,"context_line":"                finally:"}],"source_content_type":"text/x-python","patch_set":17,"id":"c862c433_091ebb77","line":1065,"in_reply_to":"62970dee_de4d3ae4","updated":"2025-11-14 18:29:48.000000000","message":"I agree with Alan that this is a more cleaner way to write the code with proper comment that will help us in the future to understand the reasoning behind this *strange* looking code.","commit_id":"8947183488c20b5b6fc0ab40317ef48f7388c665"},{"author":{"_account_id":38249,"name":"Younghwan Yoo","email":"yyhlkas21@gmail.com","username":"b-501"},"change_message_id":"9a8da2df7cb120923067204e973017fd24f626a3","unresolved":false,"context_lines":[{"line_number":1062,"context_line":"            # letting it be raised further up the stack."},{"line_number":1063,"context_line":"            if volume.size !\u003d original_size:"},{"line_number":1064,"context_line":"                try:"},{"line_number":1065,"context_line":"                    if model_update and \u0027size\u0027 in model_update:"},{"line_number":1066,"context_line":"                        model_update.pop(\u0027size\u0027, None)"},{"line_number":1067,"context_line":"                    self.driver.extend_volume(volume, original_size)"},{"line_number":1068,"context_line":"                finally:"}],"source_content_type":"text/x-python","patch_set":17,"id":"23d1a05f_8d2b7723","line":1065,"in_reply_to":"c862c433_091ebb77","updated":"2025-11-17 09:00:44.000000000","message":"Done","commit_id":"8947183488c20b5b6fc0ab40317ef48f7388c665"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4cc2ca1c2b92d96f7cd3270832b97841703b71dc","unresolved":true,"context_lines":[{"line_number":1069,"context_line":"                    # The volume\u0027s size has been saved, so it can be removed"},{"line_number":1070,"context_line":"                    # from the model_update."},{"line_number":1071,"context_line":"                    if model_update:"},{"line_number":1072,"context_line":"                        model_update.pop(\u0027size\u0027, None)"},{"line_number":1073,"context_line":""},{"line_number":1074,"context_line":"        return model_update"},{"line_number":1075,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"ce1c2694_26b63c87","line":1072,"updated":"2026-06-30 16:47:15.000000000","message":"Please re-check the logic.  I\u0027m not sure that this change by itself fixes the bug.\n\noriginal_size used at line 1067 is set at line 983 from volume.size\n\nat that point, is volume.size the requested size (for example 5GB) or the powerflex size (which would be 8GB)?  (I think the requested size because the volume hasn\u0027t been created yet?)\n\nthe driver.extend_volume call at line 1065 will silently increase the volume size if necessary\n\nso if original_size is the requested size, then line 1067 will set an incorrect value unless the requested size just happened to be a multiple of 8\n\nThis change is an improvement because we won\u0027t be using the size of the cached volume any more when the model_update gets applied at line 1265, but it looks like the cinder size and the powerflex size will still diverge","commit_id":"165ce07c1548fd6e0170ddcf29aec447463ec2aa"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"79dad08128cbc816b29a2af18b5e0fe6f5e68fcc","unresolved":true,"context_lines":[{"line_number":1069,"context_line":"                    # The volume\u0027s size has been saved, so it can be removed"},{"line_number":1070,"context_line":"                    # from the model_update."},{"line_number":1071,"context_line":"                    if model_update:"},{"line_number":1072,"context_line":"                        model_update.pop(\u0027size\u0027, None)"},{"line_number":1073,"context_line":""},{"line_number":1074,"context_line":"        return model_update"},{"line_number":1075,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"fe32d1ad_d23b6ad3","line":1072,"in_reply_to":"ce1c2694_26b63c87","updated":"2026-07-01 13:34:20.000000000","message":"I think it depends on what the expectations are from the end user side:\nIf user requests X GB volume and powerflex creates volume size X+\u003cvalue to make it multiple of 8\u003e, will the user want the size on the volume to be\n1. what they originally requested X\n2. the actual size on the storage array side (X+\u003cvalue to make it multiple of 8\u003e)\n\nRegarding 1., there will be some discrepency (\u003c 8GB) between the backend volume and cinder reported size\n\nRegarding 2., I think this might be confusing to the user since they requested 20GB volume but now they see 24GB volume?","commit_id":"165ce07c1548fd6e0170ddcf29aec447463ec2aa"}]}