)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"c291bb323a01a46e296c0d33ceb953578b9b9728","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3da16123_3f41fe6f","updated":"2025-08-08 04:58:28.000000000","message":"Hi Team, \n\nCould you please quickly review this patch. We have a customer eagerly awaiting the backport of this fix. Your attention to this is highly appreciated and thanks for all the support. \n\nNote: A thorough testing has been done on this for both ZAPI/REST calls.","commit_id":"199cc0d205e1d091d9fea730f6e0f996f6e375b1"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"2573a2e155935d6ef91cd160b3c683173d94de8e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"01710961_fc0ed848","updated":"2025-08-10 10:17:26.000000000","message":"LGTM","commit_id":"199cc0d205e1d091d9fea730f6e0f996f6e375b1"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"54805cfaa75a50383ef128e7351bf7617e4c2522","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"816e6424_51d4741e","updated":"2025-08-10 04:59:50.000000000","message":"LGTM","commit_id":"199cc0d205e1d091d9fea730f6e0f996f6e375b1"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"aab1f9039a3710820e7b0bcedd29d87e58b99290","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"61ee57d5_776272e7","updated":"2025-08-07 11:26:16.000000000","message":"recheck","commit_id":"199cc0d205e1d091d9fea730f6e0f996f6e375b1"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"c0358fa7f14f872f5ec8b17c11a87e9bbf1cfcba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a0a74fa2_fdaf9bcc","updated":"2025-08-07 16:42:42.000000000","message":"recheck","commit_id":"199cc0d205e1d091d9fea730f6e0f996f6e375b1"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"6d50b00fa6cb996896df1d0d8457ac3baad01d0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"34d9072f_7e755f1a","updated":"2025-08-14 09:46:24.000000000","message":"Looks good!","commit_id":"19c58421a239651527a71f149eb881313e1d1368"},{"author":{"_account_id":38290,"deleted":true},"change_message_id":"2d4ad59f137039fc3f1b4e08486e7dd1ffe104fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b29212e6_ed40a1f8","updated":"2025-08-21 18:58:37.000000000","message":"Run-NetApp CI","commit_id":"19c58421a239651527a71f149eb881313e1d1368"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"8f22d51419e397b0531b7370009c22083d66a99c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2c2e0355_bdd1ef74","updated":"2025-08-12 12:05:01.000000000","message":"Thank you Alan for your valuable comments and they helped in making this patch better. Thanks for the support as always!! Please review and provide your feedback/approval.","commit_id":"19c58421a239651527a71f149eb881313e1d1368"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"91fa57eddd9d8c6021a997b088841150c7365748","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"22e39b1f_17485f02","updated":"2025-08-28 07:26:29.000000000","message":"Addressed comment from Eric. Thanks.","commit_id":"b0445c90c4c9d6217300c17777bfbe401c03a4a0"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"b5703aba8b8d2928d7d020eda6aab0d2f5991e70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"73925075_b938c7ed","updated":"2025-09-11 13:55:11.000000000","message":"Hey Saikumar, some suggestions to reno inline.","commit_id":"b0445c90c4c9d6217300c17777bfbe401c03a4a0"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"c561371b14efc87df3580794c4b3e1f801002431","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"08b3908c_53c64201","updated":"2025-08-28 12:45:19.000000000","message":"LGTM","commit_id":"b0445c90c4c9d6217300c17777bfbe401c03a4a0"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"5ed2121d0edd7ff1e1f656a5e1dfe82babac3c60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2317141f_90a29d8a","updated":"2025-08-28 07:42:44.000000000","message":"Marked Alan\u0027s comments to resolved as we had +1 from Alan after addressing the changes. Thank you!","commit_id":"b0445c90c4c9d6217300c17777bfbe401c03a4a0"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"418cb8f16d1a480c514ece0b3cf6433dac355195","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"60213a81_1b35dfce","updated":"2025-08-29 05:17:08.000000000","message":"Run-NetApp CI","commit_id":"b0445c90c4c9d6217300c17777bfbe401c03a4a0"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"5b45fd986a5bc1b787c1ae2f277fdd0d2529b160","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ad3799b7_272af616","updated":"2025-08-28 09:39:13.000000000","message":"recheck","commit_id":"b0445c90c4c9d6217300c17777bfbe401c03a4a0"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"54c16b996d928e189a9c1b882ae6df6fd33a574b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"96dbd4eb_48341f4f","updated":"2025-09-11 14:32:57.000000000","message":"Thank you @fesilva@redhat.com, made changes to reno as you suggested.","commit_id":"e2d56abb0cd4f696f2cb7675bd4bfb15e4c258d0"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"b9e85600d8b48317c6242cd0deff72774b64d5f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"33079cbd_aceb5a5c","updated":"2025-09-11 15:55:21.000000000","message":"Run-NetApp CI","commit_id":"d623a9d3a96c159e3ce57584aa059e4dd30ddfe3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"476e34400be6039d672fd635d9e7faa39c4befcb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a1778bb6_d45ced56","updated":"2025-09-12 16:08:55.000000000","message":"The NetApp CI doesn\u0027t provide job for NFS. The generic nfs job is passing which provides some level of testing. In any case, this should be already tested manually by the netapp team. LGTM.","commit_id":"d623a9d3a96c159e3ce57584aa059e4dd30ddfe3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"be473855a501d907b662640a62dcf92eb45ce3a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1ef848bf_f421c04d","updated":"2025-09-12 19:45:06.000000000","message":"Carrying over the votes from Jon, Hemna and myself to approve this since the tempest dependency wasn\u0027t merged, it was blocking this patch from merging. We\u0027ve verified that apart from the tempest fix, the netapp CI is working fine. LGTM.","commit_id":"2322ceb1999ad794f5af06bfd7fc8f0cb0fc829a"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"dbec1096e607f3fb75241cb5f21388df551f8f91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0bec2802_4d259894","updated":"2025-09-15 08:40:03.000000000","message":"recheck","commit_id":"2322ceb1999ad794f5af06bfd7fc8f0cb0fc829a"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"797f146c3373a29da31dbdd154b7b00eb8394d94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0d52ff45_eb8508a8","updated":"2025-09-13 06:35:58.000000000","message":"recheck","commit_id":"2322ceb1999ad794f5af06bfd7fc8f0cb0fc829a"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"6e5c6fbc93ee7d2eb0ad9c247870ce68e2593b97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0d5ba989_7b0bc021","updated":"2025-09-13 12:03:59.000000000","message":"recheck","commit_id":"2322ceb1999ad794f5af06bfd7fc8f0cb0fc829a"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"d3d32caa7621af470f3390fcd9326a12d38bdf35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"29d158c1_67ac599b","updated":"2025-09-13 22:38:56.000000000","message":"recheck","commit_id":"2322ceb1999ad794f5af06bfd7fc8f0cb0fc829a"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"cb6aa7dc8dc70cee09d19c31f82cbbeff8b8c767","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f311e0e8_bde136e0","updated":"2025-09-13 14:18:06.000000000","message":"recheck","commit_id":"2322ceb1999ad794f5af06bfd7fc8f0cb0fc829a"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"8ef0432943daa5676da3dc9f0c59c602b46115a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f444fe7d_38dbc823","updated":"2025-09-13 19:22:32.000000000","message":"recheck","commit_id":"2322ceb1999ad794f5af06bfd7fc8f0cb0fc829a"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"8b42c45299849355e3cdb1875ac41461e03cfc8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ffe06a7a_d731b8a6","updated":"2025-09-15 11:53:52.000000000","message":"recheck","commit_id":"2322ceb1999ad794f5af06bfd7fc8f0cb0fc829a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3dc6b114deb35b9dabffa5ffda4d6986fd5cec03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"dad91034_f4ee1040","updated":"2025-09-12 23:04:17.000000000","message":"recheck devstack-plugin-nfs-tempest-full post failure","commit_id":"2322ceb1999ad794f5af06bfd7fc8f0cb0fc829a"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"aad450e2ac2ae1a7d4cfd71bcd763f04e321aa5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bab5f6a9_501a90df","updated":"2025-09-15 05:07:33.000000000","message":"recheck- failure is random","commit_id":"2322ceb1999ad794f5af06bfd7fc8f0cb0fc829a"}],"cinder/tests/unit/volume/drivers/netapp/dataontap/test_nfs_base.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0da618ef96fc6d3f5015a4ac64ed2352878313cd","unresolved":true,"context_lines":[{"line_number":368,"context_line":"                          fake.EXTRA_SPECS)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    @ddt.data((True, False),"},{"line_number":371,"context_line":"              (True, False))"},{"line_number":372,"context_line":"    @ddt.unpack"},{"line_number":373,"context_line":"    def test_create_snapshot(self, is_flexgroup,"},{"line_number":374,"context_line":"                             is_flexgroup_clone_file_supported):"}],"source_content_type":"text/x-python","patch_set":2,"id":"062e5990_9e832c9e","line":371,"range":{"start_line":371,"start_character":14,"end_line":371,"end_character":27},"updated":"2025-08-26 17:41:27.000000000","message":"This seems to duplicate the same test with each @ddt.data set -- I think the intent was to add different values here?","commit_id":"19c58421a239651527a71f149eb881313e1d1368"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"91fa57eddd9d8c6021a997b088841150c7365748","unresolved":false,"context_lines":[{"line_number":368,"context_line":"                          fake.EXTRA_SPECS)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    @ddt.data((True, False),"},{"line_number":371,"context_line":"              (True, False))"},{"line_number":372,"context_line":"    @ddt.unpack"},{"line_number":373,"context_line":"    def test_create_snapshot(self, is_flexgroup,"},{"line_number":374,"context_line":"                             is_flexgroup_clone_file_supported):"}],"source_content_type":"text/x-python","patch_set":2,"id":"82c94753_8c8df062","line":371,"range":{"start_line":371,"start_character":14,"end_line":371,"end_character":27},"in_reply_to":"062e5990_9e832c9e","updated":"2025-08-28 07:26:29.000000000","message":"Hi Eric, \n\nThanks for pointing out. The intention was to add (False, True) and by mistakenly, it got duplicated. I have updated @ddt.data set now to possible values.","commit_id":"19c58421a239651527a71f149eb881313e1d1368"}],"cinder/volume/drivers/netapp/dataontap/client/client_cmode_rest.py":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"2573a2e155935d6ef91cd160b3c683173d94de8e","unresolved":true,"context_lines":[{"line_number":176,"context_line":"        self.features.add_feature(\u0027FLEXVOL_ENCRYPTION\u0027, supported\u003dontap_9_0)"},{"line_number":177,"context_line":"        self.features.add_feature(\u0027FLEXGROUP\u0027, supported\u003dontap_9_8)"},{"line_number":178,"context_line":"        self.features.add_feature(\u0027FLEXGROUP_CLONE_FILE\u0027,"},{"line_number":179,"context_line":"                                  supported\u003dontap_9_14)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        self.features.add_feature(\u0027ADAPTIVE_QOS\u0027, supported\u003dontap_9_4)"},{"line_number":182,"context_line":"        self.features.add_feature(\u0027ADAPTIVE_QOS_BLOCK_SIZE\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"37d3c4ce_b3436fb8","line":179,"updated":"2025-08-10 10:17:26.000000000","message":"Please add a comment here on why we have moved this support to 9.14 along with the ONTAP but reference.","commit_id":"199cc0d205e1d091d9fea730f6e0f996f6e375b1"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"8f22d51419e397b0531b7370009c22083d66a99c","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        self.features.add_feature(\u0027FLEXVOL_ENCRYPTION\u0027, supported\u003dontap_9_0)"},{"line_number":177,"context_line":"        self.features.add_feature(\u0027FLEXGROUP\u0027, supported\u003dontap_9_8)"},{"line_number":178,"context_line":"        self.features.add_feature(\u0027FLEXGROUP_CLONE_FILE\u0027,"},{"line_number":179,"context_line":"                                  supported\u003dontap_9_14)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        self.features.add_feature(\u0027ADAPTIVE_QOS\u0027, supported\u003dontap_9_4)"},{"line_number":182,"context_line":"        self.features.add_feature(\u0027ADAPTIVE_QOS_BLOCK_SIZE\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"08379af8_6b537166","line":179,"in_reply_to":"37d3c4ce_b3436fb8","updated":"2025-08-12 12:05:01.000000000","message":"Anoop was referring to an internal reference which we can\u0027t put here. I discussed with him and added a comment here. Thank you Anoop.","commit_id":"199cc0d205e1d091d9fea730f6e0f996f6e375b1"}],"cinder/volume/drivers/netapp/dataontap/nfs_base.py":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"2aca16dd91b42c12bf83c0b57f4642cf1626b937","unresolved":true,"context_lines":[{"line_number":326,"context_line":"        clone API."},{"line_number":327,"context_line":"        \"\"\""},{"line_number":328,"context_line":"        if self._is_flexgroup(vol_id\u003dsnapshot[\u0027volume_id\u0027]):"},{"line_number":329,"context_line":"            if (self.configuration.safe_get(\u0027netapp_use_legacy_client\u0027) or"},{"line_number":330,"context_line":"                    not self._is_flexgroup_clone_file_supported()):"},{"line_number":331,"context_line":"                self._create_snapshot_for_flexgroup(snapshot)"},{"line_number":332,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"2f5aec2f_28052124","line":329,"updated":"2025-08-11 15:15:01.000000000","message":"This nested logic is unnecessary and (to me) makes it harder to understand, and it results in duplicated code (L333 and L338). Consider this:\n\n        if (self._is_flexgroup(vol_id\u003dsnapshot[\u0027volume_id\u0027]) and\n                (self.configuration.safe_get(\u0027netapp_use_legacy_client\u0027) or\n                 not self._is_flexgroup_clone_file_supported())):\n            self._create_snapshot_for_flexgroup(snapshot)\n        else:\n            self._clone_backing_file_for_volume(snapshot[\u0027volume_name\u0027],\n                                                snapshot[\u0027name\u0027],\n                                                snapshot[\u0027volume_id\u0027],\n                                                is_snapshot\u003dTrue)","commit_id":"199cc0d205e1d091d9fea730f6e0f996f6e375b1"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"8f22d51419e397b0531b7370009c22083d66a99c","unresolved":true,"context_lines":[{"line_number":326,"context_line":"        clone API."},{"line_number":327,"context_line":"        \"\"\""},{"line_number":328,"context_line":"        if self._is_flexgroup(vol_id\u003dsnapshot[\u0027volume_id\u0027]):"},{"line_number":329,"context_line":"            if (self.configuration.safe_get(\u0027netapp_use_legacy_client\u0027) or"},{"line_number":330,"context_line":"                    not self._is_flexgroup_clone_file_supported()):"},{"line_number":331,"context_line":"                self._create_snapshot_for_flexgroup(snapshot)"},{"line_number":332,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"f96e57ad_add2f1c1","line":329,"in_reply_to":"2f5aec2f_28052124","updated":"2025-08-12 12:05:01.000000000","message":"Yes, this makes sense. Thank you Alan. Updated the code.","commit_id":"199cc0d205e1d091d9fea730f6e0f996f6e375b1"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"5ed2121d0edd7ff1e1f656a5e1dfe82babac3c60","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        clone API."},{"line_number":327,"context_line":"        \"\"\""},{"line_number":328,"context_line":"        if self._is_flexgroup(vol_id\u003dsnapshot[\u0027volume_id\u0027]):"},{"line_number":329,"context_line":"            if (self.configuration.safe_get(\u0027netapp_use_legacy_client\u0027) or"},{"line_number":330,"context_line":"                    not self._is_flexgroup_clone_file_supported()):"},{"line_number":331,"context_line":"                self._create_snapshot_for_flexgroup(snapshot)"},{"line_number":332,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"445a5572_3f0090c7","line":329,"in_reply_to":"f96e57ad_add2f1c1","updated":"2025-08-28 07:42:44.000000000","message":"Done.","commit_id":"199cc0d205e1d091d9fea730f6e0f996f6e375b1"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"476e34400be6039d672fd635d9e7faa39c4befcb","unresolved":true,"context_lines":[{"line_number":326,"context_line":"        clone API."},{"line_number":327,"context_line":"        \"\"\""},{"line_number":328,"context_line":"        if (self._is_flexgroup(vol_id\u003dsnapshot[\u0027volume_id\u0027]) and"},{"line_number":329,"context_line":"                (self.configuration.safe_get(\u0027netapp_use_legacy_client\u0027) or"},{"line_number":330,"context_line":"                 not self._is_flexgroup_clone_file_supported())):"},{"line_number":331,"context_line":"            self._create_snapshot_for_flexgroup(snapshot)"},{"line_number":332,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8a5db8_a8944f28","line":329,"range":{"start_line":329,"start_character":46,"end_line":329,"end_character":70},"updated":"2025-09-12 16:08:55.000000000","message":"it\u0027s strange why ONTAP requires ZAPI support to perform this and not provide API for it in REST client?","commit_id":"d623a9d3a96c159e3ce57584aa059e4dd30ddfe3"}],"releasenotes/notes/bug-2119644-enable-snapshot-creation-for-flexgroup-pool-zapi-4a6af85888a99a02.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"2aca16dd91b42c12bf83c0b57f4642cf1626b937","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Currently, we don\u0027t have provision to create a snapshot for flexgroup pool"},{"line_number":5,"context_line":"    through ZAPI, with this change we will have the support for the same."},{"line_number":6,"context_line":"    So after these changes, this is how it looks. For a FlexGroup pool, the"},{"line_number":7,"context_line":"    ZAPI operation uses the NFS generic driver. When it comes to REST, if the"},{"line_number":8,"context_line":"    ONTAP version is below 9.14, the operation depends on the NFS generic"},{"line_number":9,"context_line":"    driver. However, for ONTAP versions 9.14 and above, it relies on the ONTAP"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"46b002e4_c6528923","line":6,"range":{"start_line":4,"start_character":4,"end_line":6,"end_character":49},"updated":"2025-08-11 15:15:01.000000000","message":"This is an awkward way of starting a release note, and doesn\u0027t even mention that it applies to the NetApp driver. It seems to just be a copy of the commit message, which contains internal details that probably aren\u0027t relevant to cloud admins.","commit_id":"199cc0d205e1d091d9fea730f6e0f996f6e375b1"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"8f22d51419e397b0531b7370009c22083d66a99c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Currently, we don\u0027t have provision to create a snapshot for flexgroup pool"},{"line_number":5,"context_line":"    through ZAPI, with this change we will have the support for the same."},{"line_number":6,"context_line":"    So after these changes, this is how it looks. For a FlexGroup pool, the"},{"line_number":7,"context_line":"    ZAPI operation uses the NFS generic driver. When it comes to REST, if the"},{"line_number":8,"context_line":"    ONTAP version is below 9.14, the operation depends on the NFS generic"},{"line_number":9,"context_line":"    driver. However, for ONTAP versions 9.14 and above, it relies on the ONTAP"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"96057928_cb11c1f3","line":6,"range":{"start_line":4,"start_character":4,"end_line":6,"end_character":49},"in_reply_to":"46b002e4_c6528923","updated":"2025-08-12 12:05:01.000000000","message":"Thank you so much Alan pointing out this, it was not intentional. I thought of editing and by mistakenly pushed. Sorry for this. Updated the release notes. Please see if this makes sense.","commit_id":"199cc0d205e1d091d9fea730f6e0f996f6e375b1"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"5ed2121d0edd7ff1e1f656a5e1dfe82babac3c60","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Currently, we don\u0027t have provision to create a snapshot for flexgroup pool"},{"line_number":5,"context_line":"    through ZAPI, with this change we will have the support for the same."},{"line_number":6,"context_line":"    So after these changes, this is how it looks. For a FlexGroup pool, the"},{"line_number":7,"context_line":"    ZAPI operation uses the NFS generic driver. When it comes to REST, if the"},{"line_number":8,"context_line":"    ONTAP version is below 9.14, the operation depends on the NFS generic"},{"line_number":9,"context_line":"    driver. However, for ONTAP versions 9.14 and above, it relies on the ONTAP"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"eaa2fdc2_e1ee1853","line":6,"range":{"start_line":4,"start_character":4,"end_line":6,"end_character":49},"in_reply_to":"96057928_cb11c1f3","updated":"2025-08-28 07:42:44.000000000","message":"Done.","commit_id":"199cc0d205e1d091d9fea730f6e0f996f6e375b1"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"b5703aba8b8d2928d7d020eda6aab0d2f5991e70","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The NetApp driver now supports creating snapshots for flexgroup pools"},{"line_number":5,"context_line":"    through ZAPI client and it utilizes the NFS generic driver. When it"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"504c49ac_68465c24","line":2,"updated":"2025-09-11 13:55:11.000000000","message":"The first bullet seems out of context in ``fixes`` section. I suggest moving it to the ``features`` instead.","commit_id":"b0445c90c4c9d6217300c17777bfbe401c03a4a0"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"54c16b996d928e189a9c1b882ae6df6fd33a574b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The NetApp driver now supports creating snapshots for flexgroup pools"},{"line_number":5,"context_line":"    through ZAPI client and it utilizes the NFS generic driver. When it"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"68a77ed3_48286c50","line":2,"in_reply_to":"504c49ac_68465c24","updated":"2025-09-11 14:32:57.000000000","message":"Done.","commit_id":"b0445c90c4c9d6217300c17777bfbe401c03a4a0"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"b5703aba8b8d2928d7d020eda6aab0d2f5991e70","unresolved":true,"context_lines":[{"line_number":8,"context_line":"    and above, it relies on the ONTAP file clone API."},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    `Bug #2119644 \u003chttps://bugs.launchpad.net/cinder/+bug/2119644\u003e`_:"},{"line_number":11,"context_line":"    [NetApp] [ZAPI] Unable to create snapshot for cinder volume that belongs"},{"line_number":12,"context_line":"    to flexgroup pool."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"d9e5fc92_6256a38b","line":11,"updated":"2025-09-11 13:55:11.000000000","message":"In order to ensure format is consistent with other NetApp patches in this release. I would recommend updating this bullet to the following:\n\n```\nNetApp driver `bug #2119644 \n\u003chttps://bugs.launchpad.net/cinder/+bug/2119644\u003e`_: Fixed\nunable to create snapshots for Cinder volume that belongs \nto FlexGroup pool.\n```","commit_id":"b0445c90c4c9d6217300c17777bfbe401c03a4a0"},{"author":{"_account_id":36179,"name":"Saikumar Pulluri","display_name":"Saikumar Pulluri","email":"saikumar1016@gmail.com","username":"pulluri"},"change_message_id":"54c16b996d928e189a9c1b882ae6df6fd33a574b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    and above, it relies on the ONTAP file clone API."},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    `Bug #2119644 \u003chttps://bugs.launchpad.net/cinder/+bug/2119644\u003e`_:"},{"line_number":11,"context_line":"    [NetApp] [ZAPI] Unable to create snapshot for cinder volume that belongs"},{"line_number":12,"context_line":"    to flexgroup pool."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"750999d4_244b8566","line":11,"in_reply_to":"d9e5fc92_6256a38b","updated":"2025-09-11 14:32:57.000000000","message":"Done.","commit_id":"b0445c90c4c9d6217300c17777bfbe401c03a4a0"}]}
