)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4cbaa9dafb0ae0189d169bc4496ccbc0406e0f11","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2025-08-30 08:57:42 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Dell PowerMax: NVMe/TCP suuport (follow-up)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7ab8f7b57e13079f3d35354691c02e1f1ad930f4"},{"line_number":10,"context_line":"Signed-off-by: Nilesh Thathagar \u003cnilesh.thathagar@dell.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e9d5e87b_67929910","line":8,"updated":"2025-09-01 08:47:57.000000000","message":"it\u0027s good to add the patch reference in commit so it\u0027s easier to know what we are following up on.\n\nhttps://review.opendev.org/c/openstack/cinder/+/924902","commit_id":"7926029d07f7de68f68c7468a85c48aedc238b1f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"f4171c1fce2a26bf0cdf890fae4ff3003c6e3254","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"eba8f85b_214b45d3","updated":"2025-08-31 04:25:11.000000000","message":"@rajatdhasmana@gmail.com and @rosmaita.fossdev@gmail.com\n\nHave created follow up patch. please do a review.","commit_id":"7926029d07f7de68f68c7468a85c48aedc238b1f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4cbaa9dafb0ae0189d169bc4496ccbc0406e0f11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"648734ea_be9d4b69","updated":"2025-09-01 08:47:57.000000000","message":"Since this patch specifically addresses my comments on the NVMe-TCP driver, should be good ninja approve to make it into this cycle.\nPowermax CI is passing for iSCSI, FC and NVMe-TCP.","commit_id":"7926029d07f7de68f68c7468a85c48aedc238b1f"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"f5e49f977057c113b066b066f433fd7dbebcee9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5f83213d_f1177598","updated":"2025-08-30 11:08:14.000000000","message":"recheck - cinder-plugin-ceph-tempest got failed.","commit_id":"7926029d07f7de68f68c7468a85c48aedc238b1f"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"38286daaa9cf668b21e452b0f837d6ff2e7f5857","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6298526b_c4b05abd","updated":"2025-08-30 16:47:06.000000000","message":"recheck - post-failure in multiple job.","commit_id":"7926029d07f7de68f68c7468a85c48aedc238b1f"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"38eccc09354e5ce6130e8c236c7d1932d33acedb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2924d55d_d70239cd","updated":"2025-08-30 16:47:51.000000000","message":"run-DellEMC PowerMax CI","commit_id":"7926029d07f7de68f68c7468a85c48aedc238b1f"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"5afd963eec68c4f47be0b53af579491cb9842c65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2b436538_9f66e32c","updated":"2025-08-30 09:02:33.000000000","message":"run-DellEMC PowerMax CI","commit_id":"7926029d07f7de68f68c7468a85c48aedc238b1f"}],"cinder/volume/drivers/dell_emc/powermax/masking.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4cbaa9dafb0ae0189d169bc4496ccbc0406e0f11","unresolved":true,"context_lines":[{"line_number":1077,"context_line":"                LOG.error(msg)"},{"line_number":1078,"context_line":"                raise exception.VolumeBackendAPIException(message\u003dmsg)"},{"line_number":1079,"context_line":"        elif self.protocol.lower() \u003d\u003d cinder_constants.NVMEOF_TCP.lower():"},{"line_number":1080,"context_line":"            if \u0027nqn\u0027 in connector and connector[\u0027nqn\u0027]:"},{"line_number":1081,"context_line":"                host_id \u003d connector.get(\u0027nvme_hostid\u0027)"},{"line_number":1082,"context_line":"                if host_id:"},{"line_number":1083,"context_line":"                    host_id \u003d str(host_id).replace(\"-\", \"\")"},{"line_number":1084,"context_line":"                    initiator_name \u003d connector[\u0027nqn\u0027] + \":\" + host_id"},{"line_number":1085,"context_line":"                    foundinitiatornames.append(initiator_name)"},{"line_number":1086,"context_line":"                else:"},{"line_number":1087,"context_line":"                    msg \u003d (_(\"Failed to determine NVMe HostId \""},{"line_number":1088,"context_line":"                             \"for connector NQN \u0027%s\u0027. \""},{"line_number":1089,"context_line":"                             \"Ensure the host is properly \""},{"line_number":1090,"context_line":"                             \"registered and HostId is available.\")"},{"line_number":1091,"context_line":"                           % connector.get(\u0027nqn\u0027))"},{"line_number":1092,"context_line":"                    LOG.error(msg)"},{"line_number":1093,"context_line":"                    raise exception.VolumeBackendAPIException(message\u003dmsg)"},{"line_number":1094,"context_line":"            else:"},{"line_number":1095,"context_line":"                msg \u003d (_(\"NVMe/TCP is the protocol but nqn is \""},{"line_number":1096,"context_line":"                         \"not supplied by OpenStack.\"))"},{"line_number":1097,"context_line":"                LOG.error(msg)"},{"line_number":1098,"context_line":"                raise exception.VolumeBackendAPIException(message\u003dmsg)"},{"line_number":1099,"context_line":""},{"line_number":1100,"context_line":"        if not foundinitiatornames:"},{"line_number":1101,"context_line":"            msg \u003d (_(\"Error finding %(name)s.\") % {\u0027name\u0027: name})"}],"source_content_type":"text/x-python","patch_set":2,"id":"24df4fa4_1610ba4e","line":1098,"range":{"start_line":1080,"start_character":12,"end_line":1098,"end_character":70},"updated":"2025-09-01 08:47:57.000000000","message":"nit: a better way to write this section would be,\n\n    # Fetch nqn and host_id details\n    nqn \u003d connector.get(\u0027nqn\u0027)\n    host_id \u003d connector.get(\u0027nvme_hostid\u0027)\n    if nqn is None:\n        msg \u003d (_(\"NVMe/TCP is the protocol but nqn is \"\n                 \"not supplied by OpenStack.\"))\n    if host_id is None:\n        msg \u003d (_(\"Failed to determine NVMe HostId \"\n                 \"for connector NQN \u0027%s\u0027. \"\n                 \"Ensure the host is properly \"\n                 \"registered and HostId is available.\")\n               % connector.get(\u0027nqn\u0027))\n    # If any of nqn or host_id is None\n    if not (nqn and host_id):    \n        LOG.error(msg)\n        raise exception.VolumeBackendAPIException(message\u003dmsg)\n\n    host_id \u003d str(host_id).replace(\"-\", \"\")\n    initiator_name \u003d connector[\u0027nqn\u0027] + \":\" + host_id\n    foundinitiatornames.append(initiator_name)","commit_id":"7926029d07f7de68f68c7468a85c48aedc238b1f"}]}