)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"b2327e553015ab0b1e4c0a52b3ab0bf5e4198d07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"52d0150f_311f58a5","updated":"2026-04-14 04:54:38.000000000","message":"LGTM only minor issue","commit_id":"bc7854418aa4848b894bbe01f9766d974dc384fd"}],"cinder/tests/unit/volume/drivers/ibm/test_storwize_svc.py":[{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"b2327e553015ab0b1e4c0a52b3ab0bf5e4198d07","unresolved":true,"context_lines":[{"line_number":5064,"context_line":"        self.assertIn(\u0027initiator_target_map\u0027, conn_info[\u0027data\u0027])"},{"line_number":5065,"context_line":""},{"line_number":5066,"context_line":"        # Scenario 2 : user defined host location"},{"line_number":5067,"context_line":"        host_site \u003d {\u0027site1\u0027: \u0027ff00000000000000\u0027, \u0027site2\u0027: \u0027ff00000000000001\u0027}"},{"line_number":5068,"context_line":"        self.fc_driver.configuration.set_override("},{"line_number":5069,"context_line":"            \u0027storwize_preferred_host_site\u0027, host_site)"},{"line_number":5070,"context_line":"        conn_info2 \u003d self.fc_driver.initialize_connection(volume_fc, connector)"}],"source_content_type":"text/x-python","patch_set":24,"id":"d6ac7fc0_65fb69c9","line":5067,"updated":"2026-04-14 04:54:38.000000000","message":"The connector has ffff prefix for WWPNs, but storwize_preferred_host_site values are ff prefixed ffff000000000000 does NOT match ff00000000000000","commit_id":"bc7854418aa4848b894bbe01f9766d974dc384fd"},{"author":{"_account_id":37888,"name":"Akshay Ranade","display_name":"Akshay Ranade","email":"akshay.ranade@ibm.com","username":"rakshay"},"change_message_id":"b2a908b625b15943e473de92b5ed9465d72d15a6","unresolved":true,"context_lines":[{"line_number":5064,"context_line":"        self.assertIn(\u0027initiator_target_map\u0027, conn_info[\u0027data\u0027])"},{"line_number":5065,"context_line":""},{"line_number":5066,"context_line":"        # Scenario 2 : user defined host location"},{"line_number":5067,"context_line":"        host_site \u003d {\u0027site1\u0027: \u0027ff00000000000000\u0027, \u0027site2\u0027: \u0027ff00000000000001\u0027}"},{"line_number":5068,"context_line":"        self.fc_driver.configuration.set_override("},{"line_number":5069,"context_line":"            \u0027storwize_preferred_host_site\u0027, host_site)"},{"line_number":5070,"context_line":"        conn_info2 \u003d self.fc_driver.initialize_connection(volume_fc, connector)"}],"source_content_type":"text/x-python","patch_set":24,"id":"e139adc1_827d7dfb","line":5067,"in_reply_to":"d6ac7fc0_65fb69c9","updated":"2026-04-14 10:20:45.000000000","message":"Thanks @jayaanand.borra@netapp.com for reveiwing the patch.\nThe UT passed even with no matching wwpn in this case is a result of failback mechanism in src code. It went ahead with the case of no host site info provided.\nI could have added site specific asserts here to catch such mismatches.\nI will rather go ahead and sycn the wwps from connector so that the UT intentions are met.","commit_id":"bc7854418aa4848b894bbe01f9766d974dc384fd"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"df43e97fa360b7930f438570a7c436a62310401a","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    else:"},{"line_number":68,"context_line":"        return SVC_POOLS[0]"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"def _callhome_loop_cleanup(driver):"},{"line_number":71,"context_line":"    if not driver:"},{"line_number":72,"context_line":"        return"},{"line_number":73,"context_line":"    loop \u003d getattr(driver, \u0027_check_callhome_loop\u0027, None)"}],"source_content_type":"text/x-python","patch_set":29,"id":"2143c951_8e43d012","line":70,"updated":"2026-06-08 12:36:18.000000000","message":"pep8: E302 expected 2 blank lines, found 1","commit_id":"ad41933383a1547237997445004f89e68fcb5f82"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"df43e97fa360b7930f438570a7c436a62310401a","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    if loop:"},{"line_number":75,"context_line":"        loop.stop()"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"def _patch_pbha_helpers(driver, fc_wwpns\u003dNone, iscsi_iqn\u003dNone):"},{"line_number":78,"context_line":"    \"\"\"Mocks PBHA backend helpers to return fixed test values."},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    Args:"}],"source_content_type":"text/x-python","patch_set":29,"id":"c357016b_a118f56b","line":77,"updated":"2026-06-08 12:36:18.000000000","message":"pep8: E302 expected 2 blank lines, found 1","commit_id":"ad41933383a1547237997445004f89e68fcb5f82"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"df43e97fa360b7930f438570a7c436a62310401a","unresolved":false,"context_lines":[{"line_number":3451,"context_line":""},{"line_number":3452,"context_line":"        return site_volume_info"},{"line_number":3453,"context_line":""},{"line_number":3454,"context_line":"    def _cmd_mkvolume(self, **kwargs):"},{"line_number":3455,"context_line":"        if \u0027volumegroup\u0027 in kwargs:"},{"line_number":3456,"context_line":"            volume_info \u003d {}"},{"line_number":3457,"context_line":"            volume_info[\u0027id\u0027] \u003d self._find_unused_id(self._volumes_list)"}],"source_content_type":"text/x-python","patch_set":29,"id":"69d1c662_ad8e6406","line":3454,"updated":"2026-06-08 12:36:18.000000000","message":"pep8: C901 \u0027StorwizeSVCManagementSimulator._cmd_mkvolume\u0027 is too complex (36)","commit_id":"ad41933383a1547237997445004f89e68fcb5f82"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"df43e97fa360b7930f438570a7c436a62310401a","unresolved":false,"context_lines":[{"line_number":6688,"context_line":"        self.assertIn(src_vol[\u0027name\u0027], clone_params)"},{"line_number":6689,"context_line":"        self.assertEqual(vol_name, tgt_vol[\u0027name\u0027])"},{"line_number":6690,"context_line":""},{"line_number":6691,"context_line":"    @mock.patch.object(storwize_svc_common.StorwizeHelpers, \u0027create_partition_volume\u0027)"},{"line_number":6692,"context_line":"    @mock.patch.object(storwize_svc_common.StorwizeSSH, \u0027addsnapshot\u0027)"},{"line_number":6693,"context_line":"    def test_storwize_svc_create_cloned_volume_from_addsnapshot_partition("},{"line_number":6694,"context_line":"            self, addsnapshot, create_partition_volume):"}],"source_content_type":"text/x-python","patch_set":29,"id":"9e26246d_76629eb6","line":6691,"updated":"2026-06-08 12:36:18.000000000","message":"pep8: E501 line too long (86 \u003e 79 characters)","commit_id":"ad41933383a1547237997445004f89e68fcb5f82"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"df43e97fa360b7930f438570a7c436a62310401a","unresolved":false,"context_lines":[{"line_number":6729,"context_line":""},{"line_number":6730,"context_line":"        create_partition_volume.assert_called()"},{"line_number":6731,"context_line":"        args, kwargs \u003d create_partition_volume.call_args"},{"line_number":6732,"context_line":"        self.assertNotEqual(kwargs.get(\u0027clone_params\u0027), None)"},{"line_number":6733,"context_line":""},{"line_number":6734,"context_line":"    def test_storwize_svc_create_cloned_volume(self):"},{"line_number":6735,"context_line":"        self._set_flag(\u0027migrate_from_flashcopy\u0027, False)"}],"source_content_type":"text/x-python","patch_set":29,"id":"138dd5da_3a34cf41","line":6732,"updated":"2026-06-08 12:36:18.000000000","message":"pep8: H203: Use assertIs(Not)None to check for None","commit_id":"ad41933383a1547237997445004f89e68fcb5f82"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"df43e97fa360b7930f438570a7c436a62310401a","unresolved":false,"context_lines":[{"line_number":17948,"context_line":"        create_partition_volume.assert_called()"},{"line_number":17949,"context_line":""},{"line_number":17950,"context_line":"        # Cleanup: Delete clone groups"},{"line_number":17951,"context_line":"        model_delete_update_vg \u003d self.driver.delete_group(self.ctxt,"},{"line_number":17952,"context_line":"                                                          clone_group_vg,"},{"line_number":17953,"context_line":"                                                          clone_volumes_vg)"},{"line_number":17954,"context_line":"        # Cleanup: Delete source groups"}],"source_content_type":"text/x-python","patch_set":29,"id":"bb4890a9_deae9c91","line":17951,"updated":"2026-06-08 12:36:18.000000000","message":"pep8: F841 local variable \u0027model_delete_update_vg\u0027 is assigned to but never used","commit_id":"ad41933383a1547237997445004f89e68fcb5f82"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"df43e97fa360b7930f438570a7c436a62310401a","unresolved":false,"context_lines":[{"line_number":17952,"context_line":"                                                          clone_group_vg,"},{"line_number":17953,"context_line":"                                                          clone_volumes_vg)"},{"line_number":17954,"context_line":"        # Cleanup: Delete source groups"},{"line_number":17955,"context_line":"        model_delete_update_src_vg \u003d self.driver.delete_group(self.ctxt,"},{"line_number":17956,"context_line":"                                                              src_group_vg,"},{"line_number":17957,"context_line":"                                                              src_volumes_vg)"},{"line_number":17958,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"affc2342_104581d0","line":17955,"updated":"2026-06-08 12:36:18.000000000","message":"pep8: F841 local variable \u0027model_delete_update_src_vg\u0027 is assigned to but never used","commit_id":"ad41933383a1547237997445004f89e68fcb5f82"}]}
