)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"a657ab6a97e24232a94d364ac7abd3b781eed09d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2d1f5bde_2d1553bc","updated":"2025-10-21 14:01:42.000000000","message":"Brian raises an excellent point, which led to an offline discussion of taking a different approach. Hold this patch for now, and I\u0027ll work on an alternative.","commit_id":"11e3c2e467da121b28a20ecf557387919b28bfbf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"09e5ac6078409086bdb7698ce9171039ab57ca1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8abea53f_bfd86506","updated":"2025-10-20 15:12:49.000000000","message":"I have a conceptual concern.","commit_id":"11e3c2e467da121b28a20ecf557387919b28bfbf"},{"author":{"_account_id":35759,"name":"Yian Zong","display_name":"Yian Zong","email":"yian.zong@dell.com","username":"yianzong"},"change_message_id":"8c0ec8b29ab41684695e0d0318fa3c25b7d942bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fee1db6d_cab3ecd1","updated":"2025-10-16 04:37:12.000000000","message":"LGTM","commit_id":"11e3c2e467da121b28a20ecf557387919b28bfbf"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8b816c1657453da6c6bcae2ec2be94031114a166","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"55fd6bdf_1c65a4f9","updated":"2025-10-16 13:31:49.000000000","message":"LGTM, thanks Alan!","commit_id":"11e3c2e467da121b28a20ecf557387919b28bfbf"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"da0e382b928fec74fd2eb66d344fb2e9044bf7c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9dccd79a_83c46598","updated":"2025-10-21 19:02:18.000000000","message":"See https://review.opendev.org/c/openstack/cinder/+/964492","commit_id":"11e3c2e467da121b28a20ecf557387919b28bfbf"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"5b6a6098638f717c7a1b13f8ffbd73118d75bcd3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8120a54d_1ff15ee4","updated":"2025-10-15 20:21:02.000000000","message":"recheck\n\ntempest-integrated-storage TIMED_OUT","commit_id":"11e3c2e467da121b28a20ecf557387919b28bfbf"}],"cinder/common/constants.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"09e5ac6078409086bdb7698ce9171039ab57ca1e","unresolved":true,"context_lines":[{"line_number":67,"context_line":"    NVMEOF_FC,"},{"line_number":68,"context_line":"    NVMEOF_TCP"},{"line_number":69,"context_line":"]"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"CACHEABLE_PROTOCOLS \u003d FC_VARIANTS + ISCSI_VARIANTS + NVMEOF_VARIANTS"}],"source_content_type":"text/x-python","patch_set":1,"id":"a548d7d0_02f7da48","line":70,"updated":"2025-10-20 15:12:49.000000000","message":"I\u0027m a little worried that the new variants at line 66-68 are different from the other variants at lines 63-65 and lines 59-61.  The current variants are all have the same referent, but the \"new\" variants actually have different referents but belong to the same family.  It may not matter in the code right now, but it\u0027s the kind of conceptual distinction the non-observation of which introduces a code smell.\n\nMy suggestion would be to add a different list, named NVMEOF_FAMILY (or something like that) that would consist of [NVMEOF_VARIANTS, NVMEOF_ROCE, NVMEOF_FC, NVME0F_TCP]","commit_id":"11e3c2e467da121b28a20ecf557387919b28bfbf"}]}