)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a9b30d26def105daf59425b0f0a84cfe219871ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e4e64484_ce57cecd","updated":"2025-11-13 08:56:50.000000000","message":"I\u0027m really not in favor of this approach due to the reasons mentioned inline.\nAlso we should discuss if we really want to store it as a volume property or just as admin metadata key/val.","commit_id":"b2a806414562fa3d15d158830eed970c8530643e"}],"cinder/volume/api.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a9b30d26def105daf59425b0f0a84cfe219871ff","unresolved":true,"context_lines":[{"line_number":230,"context_line":"        :return: True if this is an Image-Volume creation request"},{"line_number":231,"context_line":"        \"\"\""},{"line_number":232,"context_line":"        # Check if service tenant is configured"},{"line_number":233,"context_line":"        service_project_id \u003d CONF.cinder_internal_tenant_project_id"},{"line_number":234,"context_line":"        if not service_project_id:"},{"line_number":235,"context_line":"            LOG.debug(\u0027cinder_internal_tenant_project_id not configured, \u0027"},{"line_number":236,"context_line":"                      \u0027cannot detect Image-Volume\u0027)"},{"line_number":237,"context_line":"            return False"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        # Check if request is from service tenant"},{"line_number":240,"context_line":"        if context.project_id !\u003d service_project_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"8b7328a8_ed0088e4","line":237,"range":{"start_line":233,"start_character":0,"end_line":237,"end_character":24},"updated":"2025-11-13 08:56:50.000000000","message":"not a hard requirement for our effort","commit_id":"b2a806414562fa3d15d158830eed970c8530643e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a9b30d26def105daf59425b0f0a84cfe219871ff","unresolved":true,"context_lines":[{"line_number":237,"context_line":"            return False"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        # Check if request is from service tenant"},{"line_number":240,"context_line":"        if context.project_id !\u003d service_project_id:"},{"line_number":241,"context_line":"            return False"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        # Check if user has service role"},{"line_number":244,"context_line":"        if \u0027service\u0027 not in context.roles:"}],"source_content_type":"text/x-python","patch_set":1,"id":"8961cb56_7706cd24","line":241,"range":{"start_line":240,"start_character":0,"end_line":241,"end_character":24},"updated":"2025-11-13 08:56:50.000000000","message":"I don\u0027t think we should rely heavily on the cinder_internal_tenant_project_id for validating this.","commit_id":"b2a806414562fa3d15d158830eed970c8530643e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a9b30d26def105daf59425b0f0a84cfe219871ff","unresolved":true,"context_lines":[{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        # Query Keystone for Glance user and compare"},{"line_number":248,"context_line":"        try:"},{"line_number":249,"context_line":"            glance_user \u003d api_utils.get_user_by_name(context, \u0027glance\u0027)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"            if not glance_user:"},{"line_number":252,"context_line":"                LOG.warning(\u0027Could not find user named \"glance\" in \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"54617dbd_183d8547","line":249,"range":{"start_line":249,"start_character":36,"end_line":249,"end_character":52},"updated":"2025-11-13 08:56:50.000000000","message":"why create this method when we can easily fetch the username from the context itself?","commit_id":"b2a806414562fa3d15d158830eed970c8530643e"}]}