)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"61cbd564b490e1d3de81d47731a5e078bea68fe7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3168f476_a644b7d7","updated":"2026-03-10 23:32:43.000000000","message":"LGTM as a simple fix.","commit_id":"5144f85253312d70bb2cb824cfdfbe001b34e3b7"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"09f93a342e390403110a8363cd65c658e1e4a700","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6b988bac_cda50905","updated":"2026-08-31 18:13:30.000000000","message":"Patch looks okay, matches bug description, ci passes, lgtm.","commit_id":"5144f85253312d70bb2cb824cfdfbe001b34e3b7"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"c4ae554ca3bc54f09a3ca7af12892260296adb22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a8d7d57b_fcef3755","updated":"2026-02-06 05:57:43.000000000","message":"Zuul has passed. LGTM","commit_id":"5144f85253312d70bb2cb824cfdfbe001b34e3b7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e530ff6de22c9731ae290f1ca4c44adb816b5384","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0f5dea7e_3354f199","updated":"2025-12-14 12:10:48.000000000","message":"recheck","commit_id":"5144f85253312d70bb2cb824cfdfbe001b34e3b7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9db91a465b6d6beac46f40d9c0f52532a7ab705d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1b7223f7_c11d93d1","updated":"2025-12-14 04:52:56.000000000","message":"recheck","commit_id":"5144f85253312d70bb2cb824cfdfbe001b34e3b7"}],"cinder/context.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"519427f5b30059b8506488e00fd3ffaef55d2182","unresolved":true,"context_lines":[{"line_number":180,"context_line":"        result[\u0027message_resource_id\u0027] \u003d self.message_resource_id"},{"line_number":181,"context_line":"        result[\u0027message_resource_type\u0027] \u003d self.message_resource_type"},{"line_number":182,"context_line":"        result[\u0027message_action\u0027] \u003d self.message_action"},{"line_number":183,"context_line":"        return result"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    @classmethod"},{"line_number":186,"context_line":"    def from_dict(cls, values: dict) -\u003e \u0027RequestContext\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"4799f189_91bb669f","line":183,"updated":"2026-02-11 17:01:32.000000000","message":"Do we not need to cover the user_domain/project_domain fields in here in to_dict?","commit_id":"5144f85253312d70bb2cb824cfdfbe001b34e3b7"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"6adc22fb56bf6b79a0a39a1662a4454053c35d0f","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        result[\u0027message_resource_id\u0027] \u003d self.message_resource_id"},{"line_number":181,"context_line":"        result[\u0027message_resource_type\u0027] \u003d self.message_resource_type"},{"line_number":182,"context_line":"        result[\u0027message_action\u0027] \u003d self.message_action"},{"line_number":183,"context_line":"        return result"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    @classmethod"},{"line_number":186,"context_line":"    def from_dict(cls, values: dict) -\u003e \u0027RequestContext\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"d588ba72_ed0c94d3","line":183,"in_reply_to":"34cbf555_f876984e","updated":"2026-09-02 12:34:33.000000000","message":"So, if I understood correctly, 970967 supersedes this change, and even better, it reuses the parent class values, right? So this change should not be needed.","commit_id":"5144f85253312d70bb2cb824cfdfbe001b34e3b7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"49dc80337eb2c9b4efb1b1e79e2650c78bb5a6c2","unresolved":true,"context_lines":[{"line_number":180,"context_line":"        result[\u0027message_resource_id\u0027] \u003d self.message_resource_id"},{"line_number":181,"context_line":"        result[\u0027message_resource_type\u0027] \u003d self.message_resource_type"},{"line_number":182,"context_line":"        result[\u0027message_action\u0027] \u003d self.message_action"},{"line_number":183,"context_line":"        return result"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    @classmethod"},{"line_number":186,"context_line":"    def from_dict(cls, values: dict) -\u003e \u0027RequestContext\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"8f4c6e2f_bf9ac68b","line":183,"in_reply_to":"4799f189_91bb669f","updated":"2026-02-11 17:06:45.000000000","message":"No. These are already set by `super(RequestContext, self).to_dict()` and we don\u0027t have to add these again explicitly here.\n\nSide note:\nI think the main cause of this problem is the fact that to_dict inherits the parent class implementation while from_dict is implemented from scratch. I\u0027ll fix that by https://review.opendev.org/c/openstack/cinder/+/970967 .","commit_id":"5144f85253312d70bb2cb824cfdfbe001b34e3b7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"21d8dc6f0159d83aeeb91f51878af608d14fc616","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        result[\u0027message_resource_id\u0027] \u003d self.message_resource_id"},{"line_number":181,"context_line":"        result[\u0027message_resource_type\u0027] \u003d self.message_resource_type"},{"line_number":182,"context_line":"        result[\u0027message_action\u0027] \u003d self.message_action"},{"line_number":183,"context_line":"        return result"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    @classmethod"},{"line_number":186,"context_line":"    def from_dict(cls, values: dict) -\u003e \u0027RequestContext\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"34cbf555_f876984e","line":183,"in_reply_to":"8f4c6e2f_bf9ac68b","updated":"2026-06-22 08:44:03.000000000","message":"Done","commit_id":"5144f85253312d70bb2cb824cfdfbe001b34e3b7"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"7e0c7292ddf35e4e1d4595654fe793f096b0f033","unresolved":true,"context_lines":[{"line_number":180,"context_line":"        result[\u0027message_resource_id\u0027] \u003d self.message_resource_id"},{"line_number":181,"context_line":"        result[\u0027message_resource_type\u0027] \u003d self.message_resource_type"},{"line_number":182,"context_line":"        result[\u0027message_action\u0027] \u003d self.message_action"},{"line_number":183,"context_line":"        return result"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    @classmethod"},{"line_number":186,"context_line":"    def from_dict(cls, values: dict) -\u003e \u0027RequestContext\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"6f76641c_cf56e2ad","line":183,"in_reply_to":"9c533fd3_3f45beeb","updated":"2026-09-02 19:55:53.000000000","message":"ok, sounds good.","commit_id":"5144f85253312d70bb2cb824cfdfbe001b34e3b7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8a72bddc7929d8a740378f691ea72730cab42262","unresolved":true,"context_lines":[{"line_number":180,"context_line":"        result[\u0027message_resource_id\u0027] \u003d self.message_resource_id"},{"line_number":181,"context_line":"        result[\u0027message_resource_type\u0027] \u003d self.message_resource_type"},{"line_number":182,"context_line":"        result[\u0027message_action\u0027] \u003d self.message_action"},{"line_number":183,"context_line":"        return result"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    @classmethod"},{"line_number":186,"context_line":"    def from_dict(cls, values: dict) -\u003e \u0027RequestContext\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9c533fd3_3f45beeb","line":183,"in_reply_to":"d588ba72_ed0c94d3","updated":"2026-09-02 13:56:53.000000000","message":"No. 970967 depends on this one. I prefer merging this to fix the issue first, and then merge 970967 as a refactoring. Limiting the scope of this change to just bug fix may help us bakport this if we want.","commit_id":"5144f85253312d70bb2cb824cfdfbe001b34e3b7"}]}
