)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38702,"name":"Ranjith","display_name":"Ranjith","email":"goldranjith@gmail.com","username":"goldranjith"},"change_message_id":"6983b52411f824a49bd44507b9fc4275a99e99bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"19177e7f_10e7115b","updated":"2025-12-30 18:03:06.000000000","message":"It was done","commit_id":"427d75e1bb9c27967b714defd6db3e3b6fd55ed0"},{"author":{"_account_id":38702,"name":"Ranjith","display_name":"Ranjith","email":"goldranjith@gmail.com","username":"goldranjith"},"change_message_id":"060b63554d1bb97fffaea56c022ee8af0df54be7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e2c5885a_f71b312a","updated":"2025-12-30 17:13:19.000000000","message":"recheck","commit_id":"427d75e1bb9c27967b714defd6db3e3b6fd55ed0"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"63de30051492ea33eda60034e6a3b9f0e49512b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"001b74ff_deefef02","updated":"2025-12-30 22:45:24.000000000","message":"run-vmstore-ci","commit_id":"427d75e1bb9c27967b714defd6db3e3b6fd55ed0"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"60f8f0fbf98353014486575b5f4d46ba43c1937e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"148dd5ad_4c3c05a8","updated":"2025-12-30 23:12:21.000000000","message":"run-vmstore-ci","commit_id":"427d75e1bb9c27967b714defd6db3e3b6fd55ed0"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"9c0ea58fdebb7afcb66e163f16e9dbdb78efd0ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5ea5a322_bc684b5a","updated":"2025-12-30 22:39:20.000000000","message":"run-vmstore-ci","commit_id":"427d75e1bb9c27967b714defd6db3e3b6fd55ed0"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"89dd429c82da80222837673d3531e15df5d0b463","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"94a1867f_4f927b9a","updated":"2025-12-30 23:17:09.000000000","message":"run-vmstore-ci","commit_id":"427d75e1bb9c27967b714defd6db3e3b6fd55ed0"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"dd43579c5ea860bccc293738483db7e80c0a4e89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"97f6ff28_c1f03f97","updated":"2025-12-30 23:13:58.000000000","message":"run-vmstore-ci","commit_id":"427d75e1bb9c27967b714defd6db3e3b6fd55ed0"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"7478b80ae7230120e36b8939025877a904ebf8b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9ce004b7_7a2ffef9","updated":"2025-12-30 18:18:32.000000000","message":"run-vmstore-ci","commit_id":"427d75e1bb9c27967b714defd6db3e3b6fd55ed0"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"a6ddba414a91bddde3fabebed2ec9f7ba2e78d39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ac436480_2b37f630","updated":"2025-12-30 18:41:26.000000000","message":"run-vmstore-ci","commit_id":"427d75e1bb9c27967b714defd6db3e3b6fd55ed0"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"e61261c924990e1f3d55c33364f93753de9945b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"be855c11_71ead952","updated":"2025-12-30 20:11:01.000000000","message":"run-vmstore-ci","commit_id":"427d75e1bb9c27967b714defd6db3e3b6fd55ed0"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"5517025d66a98a8ccf9cfb58cac703be30140b87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e3eb9599_0d87f413","updated":"2025-12-30 23:03:55.000000000","message":"run-vmstore-ci","commit_id":"427d75e1bb9c27967b714defd6db3e3b6fd55ed0"},{"author":{"_account_id":38702,"name":"Ranjith","display_name":"Ranjith","email":"goldranjith@gmail.com","username":"goldranjith"},"change_message_id":"6983b52411f824a49bd44507b9fc4275a99e99bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"183e6e95_a197b47c","in_reply_to":"e2c5885a_f71b312a","updated":"2025-12-30 18:03:06.000000000","message":"Done","commit_id":"427d75e1bb9c27967b714defd6db3e3b6fd55ed0"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"08c3237e75a080c119368433b09e218e6b834b42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0e709684_6a188dc6","updated":"2026-01-02 17:55:04.000000000","message":"run-vmstore-ci","commit_id":"d58dc5b8b5d2fde5703f3275db438b4f3422f974"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"b44d4fb0cfc9b0271b46ca44882311effb3f1a72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"53d08647_8980ddae","updated":"2026-01-02 19:36:13.000000000","message":"run-vmstore-ci","commit_id":"d58dc5b8b5d2fde5703f3275db438b4f3422f974"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"f34d01da923455c9df7d540485957ce9afe0f5c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"64007e9b_1baf34a2","updated":"2026-01-02 06:00:53.000000000","message":"run-vmstore-ci","commit_id":"d58dc5b8b5d2fde5703f3275db438b4f3422f974"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"6102a1c183c70b5774914031a12daa518561637b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"bbd4799d_1aaa4b01","updated":"2026-01-07 12:15:45.000000000","message":"1] The support matrix file can be updated\ndoc/source/reference/support-matrix.ini\n\n2] Please find inline comment about README file / .rst file\n\n3] It may help to add entry of this patch in below etherpad:\nhttps://etherpad.opendev.org/p/cinder-gazpacho-reviews","commit_id":"1acbc5adc0f0a8d1a8713dd33895cd1bc40f1ad0"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f6ab9088766dc24744cbebd507bc209d572fdb41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"99ae07be_9cb4904f","updated":"2026-01-05 19:04:18.000000000","message":"Please don\u0027t +1 your own patch. It is assumed since you are submitting it that you are good with the code.","commit_id":"1acbc5adc0f0a8d1a8713dd33895cd1bc40f1ad0"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"261ea8888c5507b17a60714f95c69574d6558d34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a93de4d2_4767dede","updated":"2026-01-05 19:12:05.000000000","message":"removed the +1 as per Sean\u0027s comment. \nrun-VMstore CI","commit_id":"1acbc5adc0f0a8d1a8713dd33895cd1bc40f1ad0"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3f1005f1556914101994a69d9e1ae47aabc74c87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9fead03a_03cbc9e4","updated":"2026-01-05 19:04:47.000000000","message":"run-VMstore CI","commit_id":"1acbc5adc0f0a8d1a8713dd33895cd1bc40f1ad0"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"125384b481c8a7d878ad4c437afb5a9fc9513d08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"af245b24_b64e38cb","updated":"2026-01-06 01:02:26.000000000","message":"run-VMstore CI","commit_id":"1acbc5adc0f0a8d1a8713dd33895cd1bc40f1ad0"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"f5fb4ce68a391efb09ec69c1d3d9d92bfceed80a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"c7045a81_136947fc","updated":"2026-01-05 19:25:26.000000000","message":"run-VMstore CI","commit_id":"1acbc5adc0f0a8d1a8713dd33895cd1bc40f1ad0"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"c81662b90f012b185dfb9de4140adfb26a04ba3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4119a374_3c9f56eb","in_reply_to":"45d4ea20_fbfdc3a9","updated":"2026-01-09 10:43:52.000000000","message":"Regarding point #3, i saw that entry of this patch was added at top of etherpad.\nThere are patches submitted by other people earlier \u0026 waiting for review since long time.\nThus, in etherpad i moved entry of this patch towards end of \"Features\" section (third from last).","commit_id":"1acbc5adc0f0a8d1a8713dd33895cd1bc40f1ad0"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"fa6bbf9786c2f05171fcf0ac60310837261ed641","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"45d4ea20_fbfdc3a9","in_reply_to":"87eb635e_00e51379","updated":"2026-01-08 18:11:54.000000000","message":"Added a note to the etherpad","commit_id":"1acbc5adc0f0a8d1a8713dd33895cd1bc40f1ad0"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"f3d95ba2d8432a11696bb5bb7f3db821519520b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"87eb635e_00e51379","in_reply_to":"bbd4799d_1aaa4b01","updated":"2026-01-08 17:35:48.000000000","message":"thanks for your review. About point #3 - do I just modify this doc with a link to this review?","commit_id":"1acbc5adc0f0a8d1a8713dd33895cd1bc40f1ad0"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"646de941ae04103db5cb4f3cc43e57fd24d92480","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"fa009b31_2cd24365","updated":"2026-01-08 17:25:49.000000000","message":"Sorry, also missing `cinder/opts.py` updates and a release note.\n\nHere is a good example https://review.opendev.org/c/openstack/cinder/+/939005","commit_id":"72dd8fd3fb97557acc132072a4f990d1aa6b8d73"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"f3d95ba2d8432a11696bb5bb7f3db821519520b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a3d79eeb_3c207f51","in_reply_to":"fa009b31_2cd24365","updated":"2026-01-08 17:35:48.000000000","message":"should I make changes to opts.py manually? I ran tox -e genopts and it does not generate anything.","commit_id":"72dd8fd3fb97557acc132072a4f990d1aa6b8d73"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"ea742d50afe2026f3cf94bbf4a5de78d6efd1c5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"65ac75c0_7f17d12b","updated":"2026-01-08 18:48:26.000000000","message":"I\u0027ve updated the options.py to register opts and made changes to reflect them in cinder/opts.py","commit_id":"bf0426bc9e4042519f8bf1235b8e2e9c0fac54fd"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"16dd31700d638e790baa85778928d5bc8d4f015e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ea17dae9_455fd5f3","updated":"2026-01-08 19:11:20.000000000","message":"One more. Still need a release note added so the next release\u0027s release notes include a blurb that this new driver is available.\n\nhttps://docs.openstack.org/cinder/latest/contributor/releasenotes.html\n\nOther than that, I think this is looking pretty good.","commit_id":"bf0426bc9e4042519f8bf1235b8e2e9c0fac54fd"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"70e2a6060ba41c373b41860fe3aeca091c55f820","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"fcbd8f08_a89a5e7c","in_reply_to":"ea17dae9_455fd5f3","updated":"2026-01-08 19:25:55.000000000","message":"added the release note in PS 11","commit_id":"bf0426bc9e4042519f8bf1235b8e2e9c0fac54fd"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b9f90410a2c0fe71abc912b78eefaebbce9c3ce5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3924b46d_0d704c51","updated":"2026-01-09 15:48:04.000000000","message":"Assuming CI will be happy at some point...","commit_id":"ed74253e8f8adeea556be45eddfcc09a5ab950ce"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"57cf470862e59c0868adc00e3939709f1691835b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"63ad13ca_e6583fe1","updated":"2026-01-14 15:04:03.000000000","message":"How much testing have you done with encrypted volumes with this driver?","commit_id":"ed74253e8f8adeea556be45eddfcc09a5ab950ce"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"695066eba644f29c5a6947c38f744b945daae8e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"159d9375_37fbca5d","updated":"2026-01-09 00:12:52.000000000","message":"addressed all the reviews, PR is reporting success and looks like zuul passed all the voting tests","commit_id":"ed74253e8f8adeea556be45eddfcc09a5ab950ce"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"c81662b90f012b185dfb9de4140adfb26a04ba3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"1a46eeba_cc925e7a","updated":"2026-01-09 10:43:52.000000000","message":"my comments have been addressed. So +1.\nzuul is failing on other patches also, with same reason RETRY_LIMIT","commit_id":"ed74253e8f8adeea556be45eddfcc09a5ab950ce"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"403d0d415fe926f11feabd2fae4ea11de9f2c3d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3f1e0283_328ec9dd","updated":"2026-01-09 04:29:15.000000000","message":"recheck","commit_id":"ed74253e8f8adeea556be45eddfcc09a5ab950ce"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"50be7daa9d381bd56348a3250274a74d0eebf9e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"704c54c1_c608acc5","updated":"2026-01-09 03:33:24.000000000","message":"recheck","commit_id":"ed74253e8f8adeea556be45eddfcc09a5ab950ce"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"fbbc9b1e8236fbb2ab43193c3d127219a7dd7e9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"5032f3b7_473da193","updated":"2026-01-09 12:55:04.000000000","message":"recheck some tests failed with RETRY_LIMIT","commit_id":"ed74253e8f8adeea556be45eddfcc09a5ab950ce"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"bb6dbeb109893f65c59413429891f16581d3c376","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"a56e0509_351487f4","in_reply_to":"38ba913c_b9f411cf","updated":"2026-01-14 18:27:28.000000000","message":"I tested the basic functionality (create/attach) for encrypted volumes and it works fine. Are there any known issues with this?","commit_id":"ed74253e8f8adeea556be45eddfcc09a5ab950ce"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"772484de09ce7d11eb03a7a800196b40ee5b65c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"d8cecb04_a9a65ed1","in_reply_to":"3924b46d_0d704c51","updated":"2026-01-12 18:35:48.000000000","message":"Hi Sean, is there a way to bring this review to the attention of other core reviewers? Maybe we could tag someone? Both our CI and zuul look happy now.","commit_id":"ed74253e8f8adeea556be45eddfcc09a5ab950ce"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"95b4f7ceb0694e21c7c0a904eb1c1135ad252a87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"c1297e4c_be230c5f","in_reply_to":"43d1bace_65578e75","updated":"2026-01-14 19:52:59.000000000","message":"I have just tested this in devstack with \nqemu-img version 8.2.2 (Debian 1:8.2.2+ds-0ubuntu1.11)\n\nDidn\u0027t hit this issue and the volume got created and attached to an instance. The cmd format looks a little different in our logs than in the ticket, but I don\u0027t see any crucial difference:\nqemu-img create -f qcow2 -o encrypt.format\u003dluks,encrypt.key-secret\u003d*** --object secret,id\u003dsec1,format\u003draw,file\u003d/opt/stack/data/cinder/conversion/tmp65527fh9 /opt/stack/data/cinder/mnt/46b002fe1a027d0b78d34b7f17535e2e/volume-e7ff86fb-9db6-4d2d-9fce-58a18331e69b 1073741824\n\nOne thing to note is that we always mount with nolock which might be relevant for qemu-img commands.\n\nI have also verified that snapshots and clones work for encrypted volumes.","commit_id":"ed74253e8f8adeea556be45eddfcc09a5ab950ce"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"820d5f0bf65c33415ad581ee1a8ee60892ce8bef","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"38ba913c_b9f411cf","in_reply_to":"63ad13ca_e6583fe1","updated":"2026-01-14 15:05:11.000000000","message":"Marking ^ unresolved","commit_id":"ed74253e8f8adeea556be45eddfcc09a5ab950ce"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a36f4a1bff709d57530c8d8a82c01130b7ca7596","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"43d1bace_65578e75","in_reply_to":"a56e0509_351487f4","updated":"2026-01-14 19:39:10.000000000","message":"I have been looking this week at encryption w/ the generic NFS driver and I think there are one or two -- https://bugs.launchpad.net/cinder/+bug/2138330 and a failure creating volumes from images exposed in https://review.opendev.org/c/openstack/devstack-plugin-nfs/+/597145 (no bug filed yet).","commit_id":"ed74253e8f8adeea556be45eddfcc09a5ab950ce"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"4b940531b35c30e06850c3417a7f8c3a54855c4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"ff364cbd_88f5e7e1","in_reply_to":"d8cecb04_a9a65ed1","updated":"2026-01-12 20:03:41.000000000","message":"Someone will review it soon. The best recommendation I can give is to attend the weekly meeting and bring it up there to raise awareness.","commit_id":"ed74253e8f8adeea556be45eddfcc09a5ab950ce"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"25245739b1c4840e64a418a526cc07f934330fb6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"7dd5535a_4aa04ed7","updated":"2026-01-20 23:18:25.000000000","message":"@eharney@redhat.com,  @sean.mcginnis@gmail.com - latest patch set addresses all the comments, please review","commit_id":"a0ae22d78039ca7f3ba179bb1454db905193ff4e"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"9b7c75f42fa71b0e0e8bec70366d31ea029a2bb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"1cdbbaeb_3385ddbd","updated":"2026-02-18 13:27:46.000000000","message":"+2s from Sean and Eric, tests, CI, code looks okay.","commit_id":"3641da69f51a70736a1cc3e15a1820c443b91fd4"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"b47046e9e1e4debf5959b2568eba6efee1f88b7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"3b91ccc4_caddf190","updated":"2026-02-17 17:34:59.000000000","message":"Hi Eric @eharney@redhat.com, I\u0027ve addressed all the comments and zuul is happy. Please take a look.","commit_id":"3641da69f51a70736a1cc3e15a1820c443b91fd4"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"ecdf77d525ebbf1b7a9e2bac30b58c1672a63522","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"165d1fd1_61b694e2","updated":"2026-02-12 03:39:58.000000000","message":"recheck","commit_id":"3641da69f51a70736a1cc3e15a1820c443b91fd4"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"2e5ebf1f0d93d62eb070c8437277a1d03664ff67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"30e2e63f_bd6edc31","updated":"2026-02-16 23:59:24.000000000","message":"recheck","commit_id":"3641da69f51a70736a1cc3e15a1820c443b91fd4"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"681cb41856800877eaab8a63e9f2e29e474e31ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"94612d49_742facc6","updated":"2026-02-16 21:54:27.000000000","message":"recheck","commit_id":"3641da69f51a70736a1cc3e15a1820c443b91fd4"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"1ff856865019ff2165223f07a9706fd1e655ae3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"c173f070_e2470749","updated":"2026-02-17 01:41:49.000000000","message":"recheck","commit_id":"3641da69f51a70736a1cc3e15a1820c443b91fd4"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"093572e0682a4f4c7c8797732fef0e01c2e8fe44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"6fa558b6_654a2868","updated":"2026-02-12 02:49:53.000000000","message":"run-vmstore-ci","commit_id":"3641da69f51a70736a1cc3e15a1820c443b91fd4"}],"cinder/volume/drivers/vmstore/README.md":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"6102a1c183c70b5774914031a12daa518561637b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# VMstore Openstack cinder driver (NFS)."},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"## Compatibility matrix"},{"line_number":4,"context_line":"|Vmstore version|CSI driver version|"}],"source_content_type":"text/x-gfm","patch_set":7,"id":"98a28d6d_4fb58cd0","line":1,"updated":"2026-01-07 12:15:45.000000000","message":"Instead of this README file, a documentation .rst file can be created;\nunder doc/source/configuration/block-storage/drivers\n\nReference:\nhttps://github.com/openstack/cinder/tree/master/doc/source/configuration/block-storage/drivers","commit_id":"1acbc5adc0f0a8d1a8713dd33895cd1bc40f1ad0"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"f3d95ba2d8432a11696bb5bb7f3db821519520b3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# VMstore Openstack cinder driver (NFS)."},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"## Compatibility matrix"},{"line_number":4,"context_line":"|Vmstore version|CSI driver version|"}],"source_content_type":"text/x-gfm","patch_set":7,"id":"d2986a3e_6ca1c0a1","line":1,"in_reply_to":"98a28d6d_4fb58cd0","updated":"2026-01-08 17:35:48.000000000","message":"Done","commit_id":"1acbc5adc0f0a8d1a8713dd33895cd1bc40f1ad0"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"59d9519946a3395085020e07bb76a6275aa78e1d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# VMstore Openstack cinder driver (NFS)."},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"## Compatibility matrix"},{"line_number":4,"context_line":"|Vmstore version|CSI driver version|"}],"source_content_type":"text/x-gfm","patch_set":7,"id":"bc04164a_4c13ef8b","line":1,"in_reply_to":"98a28d6d_4fb58cd0","updated":"2026-01-08 17:19:55.000000000","message":"Still need to drop this file.","commit_id":"1acbc5adc0f0a8d1a8713dd33895cd1bc40f1ad0"}],"cinder/volume/drivers/vmstore/api.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"36132bc2d345bff1b15686acb33640630d56c2d9","unresolved":true,"context_lines":[{"line_number":487,"context_line":"    def url(self, path\u003dNone):"},{"line_number":488,"context_line":"        if not path:"},{"line_number":489,"context_line":"            path \u003d \u0027\u0027"},{"line_number":490,"context_line":"        netloc \u003d \u0027%s:%d/api/v310\u0027 % (self.host, self.port)"},{"line_number":491,"context_line":"        components \u003d (self.scheme, netloc, path, None, None)"},{"line_number":492,"context_line":"        url \u003d urlparse.urlunsplit(components)"},{"line_number":493,"context_line":"        return url"}],"source_content_type":"text/x-python","patch_set":14,"id":"d45daab2_f6adbb14","line":490,"range":{"start_line":490,"start_character":37,"end_line":490,"end_character":46},"updated":"2026-02-11 16:25:52.000000000","message":"This won\u0027t work if self.host is an IPv6 address. May want to note this if it could be a problem.","commit_id":"a0ae22d78039ca7f3ba179bb1454db905193ff4e"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"ebf0b9bd903dad10ebb551331fdb6ccacfe9f11c","unresolved":false,"context_lines":[{"line_number":487,"context_line":"    def url(self, path\u003dNone):"},{"line_number":488,"context_line":"        if not path:"},{"line_number":489,"context_line":"            path \u003d \u0027\u0027"},{"line_number":490,"context_line":"        netloc \u003d \u0027%s:%d/api/v310\u0027 % (self.host, self.port)"},{"line_number":491,"context_line":"        components \u003d (self.scheme, netloc, path, None, None)"},{"line_number":492,"context_line":"        url \u003d urlparse.urlunsplit(components)"},{"line_number":493,"context_line":"        return url"}],"source_content_type":"text/x-python","patch_set":14,"id":"cd354ac7_86d466e3","line":490,"range":{"start_line":490,"start_character":37,"end_line":490,"end_character":46},"in_reply_to":"d45daab2_f6adbb14","updated":"2026-02-12 00:22:32.000000000","message":"Done","commit_id":"a0ae22d78039ca7f3ba179bb1454db905193ff4e"}],"cinder/volume/drivers/vmstore/nfs.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d0d64032bcdc2aa06b54b0c300b5ca2bcb37414a","unresolved":true,"context_lines":[{"line_number":156,"context_line":"        return True"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def check_for_setup_error(self) -\u003e None:"},{"line_number":159,"context_line":"        secure_options \u003d {"},{"line_number":160,"context_line":"            \u0027nas_secure_file_operations\u0027: self.nas_secure_file_operations,"},{"line_number":161,"context_line":"            \u0027nas_secure_file_permissions\u0027: self.nas_secure_file_permissions"},{"line_number":162,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":12,"id":"8d421294_d225e633","line":159,"updated":"2026-01-14 15:00:37.000000000","message":"I don\u0027t think you want to duplicate support for these nas_secure options into a new driver. They don\u0027t work very well, would be better to just avoid these.","commit_id":"ed74253e8f8adeea556be45eddfcc09a5ab950ce"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a36f4a1bff709d57530c8d8a82c01130b7ca7596","unresolved":true,"context_lines":[{"line_number":156,"context_line":"        return True"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def check_for_setup_error(self) -\u003e None:"},{"line_number":159,"context_line":"        secure_options \u003d {"},{"line_number":160,"context_line":"            \u0027nas_secure_file_operations\u0027: self.nas_secure_file_operations,"},{"line_number":161,"context_line":"            \u0027nas_secure_file_permissions\u0027: self.nas_secure_file_permissions"},{"line_number":162,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":12,"id":"ac331741_76d941a7","line":159,"in_reply_to":"52bb025d_a0dcae09","updated":"2026-01-14 19:39:10.000000000","message":"Yes - they cause weird bugs and therefore everyone sets them to off. Better to just not support them on a new driver if there isn\u0027t a particular requirement for them.","commit_id":"ed74253e8f8adeea556be45eddfcc09a5ab950ce"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"733d66e48727ac325c66756dcab4d4e706afad6d","unresolved":true,"context_lines":[{"line_number":156,"context_line":"        return True"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def check_for_setup_error(self) -\u003e None:"},{"line_number":159,"context_line":"        secure_options \u003d {"},{"line_number":160,"context_line":"            \u0027nas_secure_file_operations\u0027: self.nas_secure_file_operations,"},{"line_number":161,"context_line":"            \u0027nas_secure_file_permissions\u0027: self.nas_secure_file_permissions"},{"line_number":162,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":12,"id":"f4b6084c_1761122a","line":159,"in_reply_to":"8d421294_d225e633","updated":"2026-01-14 16:46:31.000000000","message":"are these deprecated or not recommended?","commit_id":"ed74253e8f8adeea556be45eddfcc09a5ab950ce"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"95b4f7ceb0694e21c7c0a904eb1c1135ad252a87","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        return True"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def check_for_setup_error(self) -\u003e None:"},{"line_number":159,"context_line":"        secure_options \u003d {"},{"line_number":160,"context_line":"            \u0027nas_secure_file_operations\u0027: self.nas_secure_file_operations,"},{"line_number":161,"context_line":"            \u0027nas_secure_file_permissions\u0027: self.nas_secure_file_permissions"},{"line_number":162,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f833b6e_b8693930","line":159,"in_reply_to":"ac331741_76d941a7","updated":"2026-01-14 19:52:59.000000000","message":"There is no specific requirement for these in our driver, so I will just remove this then.","commit_id":"ed74253e8f8adeea556be45eddfcc09a5ab950ce"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"c54574dc38f0f23e35a9ecd1acc8007b995b8153","unresolved":true,"context_lines":[{"line_number":156,"context_line":"        return True"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def check_for_setup_error(self) -\u003e None:"},{"line_number":159,"context_line":"        secure_options \u003d {"},{"line_number":160,"context_line":"            \u0027nas_secure_file_operations\u0027: self.nas_secure_file_operations,"},{"line_number":161,"context_line":"            \u0027nas_secure_file_permissions\u0027: self.nas_secure_file_permissions"},{"line_number":162,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":12,"id":"52bb025d_a0dcae09","line":159,"in_reply_to":"f4b6084c_1761122a","updated":"2026-01-14 18:30:26.000000000","message":"The reason I am asking is because this was taken from the generic NFS driver. I assumed that this should be the standard for NFS based drivers.","commit_id":"ed74253e8f8adeea556be45eddfcc09a5ab950ce"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d0d64032bcdc2aa06b54b0c300b5ca2bcb37414a","unresolved":true,"context_lines":[{"line_number":230,"context_line":"            self.shares[share_address] \u003d self.mount_options"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        else:"},{"line_number":233,"context_line":"            LOG.error(\u0027nas_host or nas_share_path not configured.\u0027)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        LOG.debug(\u0027shares loaded: %s\u0027, self.shares)"},{"line_number":236,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"ace74298_49d55e01","line":233,"updated":"2026-01-14 15:00:37.000000000","message":"Doesn\u0027t this driver require these to be configured?  (I think it should.)","commit_id":"ed74253e8f8adeea556be45eddfcc09a5ab950ce"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"733d66e48727ac325c66756dcab4d4e706afad6d","unresolved":true,"context_lines":[{"line_number":230,"context_line":"            self.shares[share_address] \u003d self.mount_options"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        else:"},{"line_number":233,"context_line":"            LOG.error(\u0027nas_host or nas_share_path not configured.\u0027)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        LOG.debug(\u0027shares loaded: %s\u0027, self.shares)"},{"line_number":236,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"b0af2ec1_ed0ef41b","line":233,"in_reply_to":"ace74298_49d55e01","updated":"2026-01-14 16:46:31.000000000","message":"It will fail later on in self._find_share(volume) if the self._mounted_shares is empty. Do you think we should raise an error here?","commit_id":"ed74253e8f8adeea556be45eddfcc09a5ab950ce"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"e32ed7958f980fd8d4d8c44c4d709520d2282648","unresolved":false,"context_lines":[{"line_number":230,"context_line":"            self.shares[share_address] \u003d self.mount_options"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        else:"},{"line_number":233,"context_line":"            LOG.error(\u0027nas_host or nas_share_path not configured.\u0027)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        LOG.debug(\u0027shares loaded: %s\u0027, self.shares)"},{"line_number":236,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"cc50ad81_9ba031e5","line":233,"in_reply_to":"b0af2ec1_ed0ef41b","updated":"2026-01-15 00:37:05.000000000","message":"Done","commit_id":"ed74253e8f8adeea556be45eddfcc09a5ab950ce"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"36132bc2d345bff1b15686acb33640630d56c2d9","unresolved":true,"context_lines":[{"line_number":296,"context_line":"            current \u003d 1"},{"line_number":297,"context_line":"            while len(vd) \u003c 1:"},{"line_number":298,"context_line":"                if current \u003c timeout:"},{"line_number":299,"context_line":"                    LOG.info(\u0027VirtualDisk for %s not found, sleeping %d\u0027,"},{"line_number":300,"context_line":"                             volume.name_id, current)"},{"line_number":301,"context_line":"                    time.sleep(current)"},{"line_number":302,"context_line":"                    self.vmstore.cinder_refresh.create(payload)"}],"source_content_type":"text/x-python","patch_set":14,"id":"bea7019d_0f0d5989","line":299,"range":{"start_line":299,"start_character":24,"end_line":299,"end_character":28},"updated":"2026-02-11 16:25:52.000000000","message":"debug level log message","commit_id":"a0ae22d78039ca7f3ba179bb1454db905193ff4e"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"ebf0b9bd903dad10ebb551331fdb6ccacfe9f11c","unresolved":false,"context_lines":[{"line_number":296,"context_line":"            current \u003d 1"},{"line_number":297,"context_line":"            while len(vd) \u003c 1:"},{"line_number":298,"context_line":"                if current \u003c timeout:"},{"line_number":299,"context_line":"                    LOG.info(\u0027VirtualDisk for %s not found, sleeping %d\u0027,"},{"line_number":300,"context_line":"                             volume.name_id, current)"},{"line_number":301,"context_line":"                    time.sleep(current)"},{"line_number":302,"context_line":"                    self.vmstore.cinder_refresh.create(payload)"}],"source_content_type":"text/x-python","patch_set":14,"id":"c7d1c7f0_de65e0df","line":299,"range":{"start_line":299,"start_character":24,"end_line":299,"end_character":28},"in_reply_to":"bea7019d_0f0d5989","updated":"2026-02-12 00:22:32.000000000","message":"Done","commit_id":"a0ae22d78039ca7f3ba179bb1454db905193ff4e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"36132bc2d345bff1b15686acb33640630d56c2d9","unresolved":true,"context_lines":[{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        volume.provider_location \u003d self._find_share(volume)"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        LOG.info(\u0027casted to %s\u0027, volume.provider_location)"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        self._do_create_volume(volume)"},{"line_number":332,"context_line":"        self.refresh_hypervisor(volume)"}],"source_content_type":"text/x-python","patch_set":14,"id":"adbc4f3c_6c7225d6","line":329,"range":{"start_line":329,"start_character":12,"end_line":329,"end_character":16},"updated":"2026-02-11 16:25:52.000000000","message":"This looks like it should a debug-level message.","commit_id":"a0ae22d78039ca7f3ba179bb1454db905193ff4e"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"ebf0b9bd903dad10ebb551331fdb6ccacfe9f11c","unresolved":false,"context_lines":[{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        volume.provider_location \u003d self._find_share(volume)"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        LOG.info(\u0027casted to %s\u0027, volume.provider_location)"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"        self._do_create_volume(volume)"},{"line_number":332,"context_line":"        self.refresh_hypervisor(volume)"}],"source_content_type":"text/x-python","patch_set":14,"id":"16bac960_120e8949","line":329,"range":{"start_line":329,"start_character":12,"end_line":329,"end_character":16},"in_reply_to":"adbc4f3c_6c7225d6","updated":"2026-02-12 00:22:32.000000000","message":"Done","commit_id":"a0ae22d78039ca7f3ba179bb1454db905193ff4e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"36132bc2d345bff1b15686acb33640630d56c2d9","unresolved":true,"context_lines":[{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        return \u0027%s:%s\u0027 % (nas_host, nas_share_path)"},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"    @coordination.synchronized(\u0027{self.vmstore.lock}\u0027)"},{"line_number":466,"context_line":"    def initialize_connection(self, volume, connector):"},{"line_number":467,"context_line":"        \"\"\"Allow connection to connector and return connection info."},{"line_number":468,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"0a73e8a9_30c895a6","line":465,"range":{"start_line":465,"start_character":32,"end_line":465,"end_character":51},"updated":"2026-02-11 16:25:52.000000000","message":"This works but you will probably want to make it specific to the volume id to allow concurrent operations if possible.\n\nSame with other locks on methods below. This can be addressed in a follow-up patchset if you\u0027d prefer.","commit_id":"a0ae22d78039ca7f3ba179bb1454db905193ff4e"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"ebf0b9bd903dad10ebb551331fdb6ccacfe9f11c","unresolved":false,"context_lines":[{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        return \u0027%s:%s\u0027 % (nas_host, nas_share_path)"},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"    @coordination.synchronized(\u0027{self.vmstore.lock}\u0027)"},{"line_number":466,"context_line":"    def initialize_connection(self, volume, connector):"},{"line_number":467,"context_line":"        \"\"\"Allow connection to connector and return connection info."},{"line_number":468,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"0314f9c8_1aceb6a3","line":465,"range":{"start_line":465,"start_character":32,"end_line":465,"end_character":51},"in_reply_to":"0a73e8a9_30c895a6","updated":"2026-02-12 00:22:32.000000000","message":"We will look into this in a later patchset","commit_id":"a0ae22d78039ca7f3ba179bb1454db905193ff4e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"36132bc2d345bff1b15686acb33640630d56c2d9","unresolved":true,"context_lines":[{"line_number":687,"context_line":"        current \u003d 1"},{"line_number":688,"context_line":"        while len(vd) \u003c 1:"},{"line_number":689,"context_line":"            if current \u003c timeout:"},{"line_number":690,"context_line":"                LOG.info(\u0027VirtualDisk for %s not found, sleeping %d\u0027,"},{"line_number":691,"context_line":"                         src_id, current)"},{"line_number":692,"context_line":"                time.sleep(current)"},{"line_number":693,"context_line":"                current +\u003d 2"}],"source_content_type":"text/x-python","patch_set":14,"id":"41a9a862_e5a0e7ff","line":690,"range":{"start_line":690,"start_character":20,"end_line":690,"end_character":24},"updated":"2026-02-11 16:25:52.000000000","message":"debug-level log message","commit_id":"a0ae22d78039ca7f3ba179bb1454db905193ff4e"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"ebf0b9bd903dad10ebb551331fdb6ccacfe9f11c","unresolved":false,"context_lines":[{"line_number":687,"context_line":"        current \u003d 1"},{"line_number":688,"context_line":"        while len(vd) \u003c 1:"},{"line_number":689,"context_line":"            if current \u003c timeout:"},{"line_number":690,"context_line":"                LOG.info(\u0027VirtualDisk for %s not found, sleeping %d\u0027,"},{"line_number":691,"context_line":"                         src_id, current)"},{"line_number":692,"context_line":"                time.sleep(current)"},{"line_number":693,"context_line":"                current +\u003d 2"}],"source_content_type":"text/x-python","patch_set":14,"id":"3fa65089_131b662b","line":690,"range":{"start_line":690,"start_character":20,"end_line":690,"end_character":24},"in_reply_to":"41a9a862_e5a0e7ff","updated":"2026-02-12 00:22:32.000000000","message":"Done","commit_id":"a0ae22d78039ca7f3ba179bb1454db905193ff4e"}],"cinder/volume/drivers/vmstore/options.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"36132bc2d345bff1b15686acb33640630d56c2d9","unresolved":true,"context_lines":[{"line_number":59,"context_line":"                    \u0027or Vmstore appliance retriable errors.\u0027),"},{"line_number":60,"context_line":"    cfg.StrOpt(\u0027vmstore_refresh_openstack_region\u0027,"},{"line_number":61,"context_line":"               default\u003d\u0027RegionOne\u0027,"},{"line_number":62,"context_line":"               help\u003d\u0027Openstack region for Vmstore hypervisor refresh call.\u0027),"},{"line_number":63,"context_line":"    cfg.StrOpt(\u0027vmstore_openstack_hostname\u0027,"},{"line_number":64,"context_line":"               help\u003d\u0027OpenStack controller hostname or IP address. \u0027"},{"line_number":65,"context_line":"                    \u0027Used for VMstore hypervisor refresh operations. \u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"28770592_90792b82","line":62,"range":{"start_line":62,"start_character":21,"end_line":62,"end_character":30},"updated":"2026-02-11 16:25:52.000000000","message":"```suggestion\n               help\u003d\u0027OpenStack region for Vmstore hypervisor refresh call.\u0027),\n```","commit_id":"a0ae22d78039ca7f3ba179bb1454db905193ff4e"},{"author":{"_account_id":15439,"name":"Alexey Khodos","email":"akhodos@tintri.com","username":"Alexey"},"change_message_id":"ebf0b9bd903dad10ebb551331fdb6ccacfe9f11c","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                    \u0027or Vmstore appliance retriable errors.\u0027),"},{"line_number":60,"context_line":"    cfg.StrOpt(\u0027vmstore_refresh_openstack_region\u0027,"},{"line_number":61,"context_line":"               default\u003d\u0027RegionOne\u0027,"},{"line_number":62,"context_line":"               help\u003d\u0027Openstack region for Vmstore hypervisor refresh call.\u0027),"},{"line_number":63,"context_line":"    cfg.StrOpt(\u0027vmstore_openstack_hostname\u0027,"},{"line_number":64,"context_line":"               help\u003d\u0027OpenStack controller hostname or IP address. \u0027"},{"line_number":65,"context_line":"                    \u0027Used for VMstore hypervisor refresh operations. \u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"485b29b8_219d2792","line":62,"range":{"start_line":62,"start_character":21,"end_line":62,"end_character":30},"in_reply_to":"28770592_90792b82","updated":"2026-02-12 00:22:32.000000000","message":"Done","commit_id":"a0ae22d78039ca7f3ba179bb1454db905193ff4e"}]}