)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"050d949b3d80dd9186cb6b6951a1f743b330e229","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6ddf214f_d5079248","updated":"2026-01-09 05:03:50.000000000","message":"Adding NetApp engineers.","commit_id":"64f06b9ffa17def8d31dd46a47a99ac5c649be26"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"7b10c5882e5a49a90a55d29d8fc945b08b724324","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"47580444_18394240","updated":"2026-04-08 14:03:57.000000000","message":"Also can you add UTs to cover additional scenarios... Flexgroup,FlexVol, upload and snapshot scenarios.","commit_id":"64f06b9ffa17def8d31dd46a47a99ac5c649be26"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"7c0f88da068a7724af1a8a8f453f7ac8537727fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"24ac356f_f7ae2376","updated":"2026-01-08 18:56:04.000000000","message":"I don\u0027t think we should merge this as-is - it makes the NetApp driver behave differently from every other volume driver and I don\u0027t think we should set this expectation. This should be approached with a more general solution (i.e. using clones/snapshots where appropriate from the manager).","commit_id":"64f06b9ffa17def8d31dd46a47a99ac5c649be26"},{"author":{"_account_id":37175,"name":"Alexander Hild","display_name":"hildale","email":"alexander.hild@stackit.cloud","username":"hildale"},"change_message_id":"b68b7c4ffa4062c07105afe12ccb08ee0ad359ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d2c69ef4_c72c5389","updated":"2026-01-07 08:25:30.000000000","message":"recheck \n-unrelated ci failures","commit_id":"64f06b9ffa17def8d31dd46a47a99ac5c649be26"},{"author":{"_account_id":37175,"name":"Alexander Hild","display_name":"hildale","email":"alexander.hild@stackit.cloud","username":"hildale"},"change_message_id":"dc3595d5f3a285a40e33e2258125334c4cbb1c38","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"07464170_d73ad32d","in_reply_to":"24ac356f_f7ae2376","updated":"2026-01-09 07:23:43.000000000","message":"that is not true. microsoft iscsi driver does the same btw.\nsee https://github.com/openstack/cinder/blob/9555cc8b6fcddf73b9eef705b4797c3374982d4d/cinder/volume/drivers/windows/iscsi.py#L291","commit_id":"64f06b9ffa17def8d31dd46a47a99ac5c649be26"}],"cinder/volume/drivers/netapp/dataontap/nfs_base.py":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"0c1df281e1216e939429500de4f12b5680144dee","unresolved":true,"context_lines":[{"line_number":1285,"context_line":"            \u0027size\u0027: volume[\u0027size\u0027],"},{"line_number":1286,"context_line":"        }"},{"line_number":1287,"context_line":""},{"line_number":1288,"context_line":"        snapshot_path \u003d self._get_volume_path(snapshot[\u0027provider_location\u0027],"},{"line_number":1289,"context_line":"                                              snapshot[\u0027name\u0027])"},{"line_number":1290,"context_line":""},{"line_number":1291,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"6eb79260_f8e40638","line":1288,"updated":"2026-04-08 14:07:21.000000000","message":"The snapshot_path depends on the visibility of .snapshot folder. That may be disabled. The assumption that this folder will be available for is not correct.\n\nThis can be toggled by command: volume modify -vserver \u003csvm_name\u003e -volume \u003cvol_name\u003e -snapdir-access true|false","commit_id":"64f06b9ffa17def8d31dd46a47a99ac5c649be26"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"0c1df281e1216e939429500de4f12b5680144dee","unresolved":true,"context_lines":[{"line_number":1301,"context_line":"            LOG.info(\u0027Uploading snapshot %(snap)s to image %(img)s.\u0027,"},{"line_number":1302,"context_line":"                     {\u0027snap\u0027: snapshot_name, \u0027img\u0027: image_meta[\u0027id\u0027]})"},{"line_number":1303,"context_line":""},{"line_number":1304,"context_line":"            snapshotsize \u003d os.stat(snapshot_path).st_size / units.Mi"},{"line_number":1305,"context_line":""},{"line_number":1306,"context_line":"            start_time \u003d timeutils.utcnow()"},{"line_number":1307,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"99b1b7a8_3e885a9a","line":1304,"updated":"2026-04-08 14:07:21.000000000","message":"st_size reports the logical file size, not physical usage. This may get bloated up in a thin volume with minimum data written.","commit_id":"64f06b9ffa17def8d31dd46a47a99ac5c649be26"},{"author":{"_account_id":38902,"name":"Daniel Schulz","display_name":"Daniel Schulz","email":"daniel.schulz@digits.schwarz","username":"schulzda"},"change_message_id":"ec6907f58d5414edff5545c9c788e52d2127d6e1","unresolved":true,"context_lines":[{"line_number":1304,"context_line":"            snapshotsize \u003d os.stat(snapshot_path).st_size / units.Mi"},{"line_number":1305,"context_line":""},{"line_number":1306,"context_line":"            start_time \u003d timeutils.utcnow()"},{"line_number":1307,"context_line":""},{"line_number":1308,"context_line":"            volume_utils.upload_volume(context, image_service, image_meta,"},{"line_number":1309,"context_line":"                                       snapshot_path, volume)"},{"line_number":1310,"context_line":""},{"line_number":1311,"context_line":"            duration \u003d timeutils.delta_seconds(start_time, timeutils.utcnow())"},{"line_number":1312,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"458df2c2_dc5ca500","line":1309,"range":{"start_line":1307,"start_character":0,"end_line":1309,"end_character":61},"updated":"2026-03-13 12:51:26.000000000","message":"```suggestion\n\n            volume_utils.upload_volume(\n               context,\n               image_service,\n               image_meta,\n               snapshot_path,\n               volume,\n               run_as_root\u003dself._execute_as_root,\n            )\n\n```\n\nThe run_as_root setting should be passed here. \nWithout it and when configuration.nas_secure_file_operations is set to true we observed that the image creation fails for qcow2 images.\nThis is caused by qemu-img running with the wrong privileges in that case.\n\nSee https://gitlab.com/yaook/images/cinder/-/merge_requests/222 for reference","commit_id":"64f06b9ffa17def8d31dd46a47a99ac5c649be26"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"7b10c5882e5a49a90a55d29d8fc945b08b724324","unresolved":true,"context_lines":[{"line_number":1339,"context_line":"                     {\u0027snap\u0027: snapshot_name})"},{"line_number":1340,"context_line":"            try:"},{"line_number":1341,"context_line":"                if os.path.exists(snapshot_path):"},{"line_number":1342,"context_line":"                    self.delete_snapshot(snapshot)"},{"line_number":1343,"context_line":""},{"line_number":1344,"context_line":"            except Exception as e:"},{"line_number":1345,"context_line":"                LOG.warning(\u0027Failed to delete temp snapshot %(snap)s: \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"5256f288_ef743fda","line":1342,"updated":"2026-04-08 14:03:57.000000000","message":"delete_snapshot is expecting Oslo versioned object and code is passing plain object is it fine? I am suspecting attribute error will be thrown for temporary object and snapshot never deleted. Can you pls confirm.","commit_id":"64f06b9ffa17def8d31dd46a47a99ac5c649be26"}]}