)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"8364e398325c43a269a27d5855f0b90063097b77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4f6ddf30_f686f81d","updated":"2026-01-13 19:55:37.000000000","message":"@rosmaita.fossdev@gmail.com and @rajatdhasmana@gmail.com this is customer escalated issue, please do a review when you get a time.","commit_id":"6bde0a6972ecace92ff67d47cb5f2715ae5f54d8"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1841c3930f7de5eb53cb5913d4744b2d1e7394a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1bcdcb45_8142bc33","updated":"2026-01-14 13:48:57.000000000","message":"What\u0027s the Dell third party CI status?  Don\u0027t see any responses on this patch.","commit_id":"6bde0a6972ecace92ff67d47cb5f2715ae5f54d8"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"d522de66fb1229b5d7deab1a6187a9df71192e9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ed51820b_36dd3830","updated":"2026-01-15 18:28:02.000000000","message":"@rosmaita.fossdev@gmail.com and @rajatdhasmana@gmail.com thanks for the update,\n\nhere is the etherpad link[1] which explain the different scenario workflow.\n1. https://etherpad.opendev.org/p/powerflex-detach-issue","commit_id":"a3b8201763dbf8bad7807ca39f49d6e4a833da10"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"75965f6bf4efa03a0028806eb06a14ed0463bee6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5e9da7c9_a1ebe1a1","updated":"2026-01-15 14:15:06.000000000","message":"I have some of the same concerns as Rajat.  Let me state it this way:\n\nThe original change required changes in both cinder and os-brick.  This fix is only in cinder.  Can you provide a description of the workflow in an etherpad or something to help us understand how this works, and that it\u0027s hitting all the correct code paths?  It would be helpful to walk us through both how this is supposed to work for the new volume case, and how it will work for the pre-fix-attachment case.\n\nThanks!","commit_id":"a3b8201763dbf8bad7807ca39f49d6e4a833da10"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"02e82dd23a4f1daf7c448022280ee0499591797d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f098f16f_03c0c02c","updated":"2026-01-14 14:45:16.000000000","message":"Thanks for the review. I’ve updated the release notes.\nThe PowerFlex CI is currently down, and the team is actively working on restoring it. In the meantime, we have tested the code manually by running tempest locally. If required, I can attach the test results to the Launchpad ID.","commit_id":"a3b8201763dbf8bad7807ca39f49d6e4a833da10"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"af1515f969269c74deb027e81884b9e624ba4001","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"140f8645_d525d380","updated":"2026-01-14 19:34:13.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"a3b8201763dbf8bad7807ca39f49d6e4a833da10"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"af1515f969269c74deb027e81884b9e624ba4001","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"59831bdc_5446d0b8","updated":"2026-01-14 19:34:13.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"a3b8201763dbf8bad7807ca39f49d6e4a833da10"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"4bf40fd3734b460f68e77b32779a7ac129d4d4d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5b5a5729_36e22e8d","updated":"2026-01-14 17:33:25.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"a3b8201763dbf8bad7807ca39f49d6e4a833da10"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"6d3fc217075e7e224cddb502dcd7d24c2c96d9fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9623e9f0_66a11d37","updated":"2026-01-14 17:11:36.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"a3b8201763dbf8bad7807ca39f49d6e4a833da10"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"0a28979871927cf383e300d89ad7d241cae791ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fd8650eb_c9a5787c","updated":"2026-01-14 16:36:15.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"a3b8201763dbf8bad7807ca39f49d6e4a833da10"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"d522de66fb1229b5d7deab1a6187a9df71192e9d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f079db3c_7ef494b1","in_reply_to":"5e9da7c9_a1ebe1a1","updated":"2026-01-15 18:28:02.000000000","message":"Please find etherpad link[1] which explain the diff scenario workflow.\n\n1. https://etherpad.opendev.org/p/powerflex-detach-issue","commit_id":"a3b8201763dbf8bad7807ca39f49d6e4a833da10"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"d522de66fb1229b5d7deab1a6187a9df71192e9d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e897951d_3a111e55","in_reply_to":"6e9ee037_4d301a81","updated":"2026-01-15 18:28:02.000000000","message":"Will attach test result and conf file into launchpad id.","commit_id":"a3b8201763dbf8bad7807ca39f49d6e4a833da10"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"322559455e8081dfe646437d9c9f3c4cf8291c37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"32dadace_b1143037","in_reply_to":"e897951d_3a111e55","updated":"2026-01-27 08:54:22.000000000","message":"As discussed, changed the code.","commit_id":"a3b8201763dbf8bad7807ca39f49d6e4a833da10"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"322559455e8081dfe646437d9c9f3c4cf8291c37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"564213e0_a47fcbbf","in_reply_to":"f079db3c_7ef494b1","updated":"2026-01-27 08:54:22.000000000","message":"As discussed, changed the code.","commit_id":"a3b8201763dbf8bad7807ca39f49d6e4a833da10"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ab2d3f92a5316ea44a347bab4dcd951ef431fe3d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6e9ee037_4d301a81","in_reply_to":"f098f16f_03c0c02c","updated":"2026-01-15 14:17:35.000000000","message":"It would be good to have tempest results to indicate no regression.\nAlso, since I don\u0027t think there are tempest tests that would catch this error, it would be good to see manual testing results that show the fix is working.","commit_id":"a3b8201763dbf8bad7807ca39f49d6e4a833da10"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"5fe7a13e6258eb5cf109c473d34d6d5e998e5530","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b5e1d3f7_47040451","updated":"2026-01-16 06:53:54.000000000","message":"@rosmaita.fossdev@gmail.com and @rajatdhasmana@gmail.com,\n\nHave attached tempest result to the launchpad id https://bugs.launchpad.net/cinder/+bug/2138280","commit_id":"41db934a9cc6270c530a149875ac6074fa319712"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"72014045445477035b0b86fe1710ebdf910c198f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"293bbbe5_06ac5760","updated":"2026-01-17 06:25:04.000000000","message":"recheck","commit_id":"f550d7855c1ad9f4ca17388250b7de1a7cd4d117"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"8e4264cb60869886095f75fbbd674ca6668ceeaf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1c6a9b50_ed167b3f","updated":"2026-01-16 20:10:34.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"f550d7855c1ad9f4ca17388250b7de1a7cd4d117"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"543997dc6fa4c435b5c84af7a5268613eebe5ea4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"503f7630_375b53a5","updated":"2026-01-17 11:33:25.000000000","message":"recheck","commit_id":"860cf5801e71abfbac6b3ee1a0c5b8c73d68b241"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"6efa9cd1666ce7c5f756c192ca7534885f8f1ccd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"60fe34e6_78a589d9","updated":"2026-01-17 16:58:50.000000000","message":"recheck\nopenstack-tox-py313 getting retry_limits.","commit_id":"860cf5801e71abfbac6b3ee1a0c5b8c73d68b241"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8db80bd13c96580932cf4ba0b61a8689c9b12a03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"fec9bc8f_123b63f1","updated":"2026-01-19 11:20:36.000000000","message":"Few questions inline and a suggestion for an alternative approach that I feel is more safer.","commit_id":"5941afed5729287fddd8b458ebbb37908609d929"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"322559455e8081dfe646437d9c9f3c4cf8291c37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ddb8fb12_1bab4a2f","updated":"2026-01-27 08:54:22.000000000","message":"@rajatdhasmana@gmail.com and @rosmaita.fossdev@gmail.com thanks for the review,\n\nAs we discussed, updated the code.","commit_id":"0efbfbde4d232f34a855cf30ab19d39f07eb16f3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6df8ba8a07a6288f224e47ce9b91cb40226a6b3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"8967a634_c3894fad","updated":"2026-01-27 20:10:30.000000000","message":"found an issue in UT otherwise looks good.","commit_id":"8bf7fc894cf719b901176704961141969189ed99"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"6090bbff30491601d09ef7e7fa951ef5b2171e6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"569763b4_d63307c9","updated":"2026-01-27 10:23:29.000000000","message":"recheck","commit_id":"8bf7fc894cf719b901176704961141969189ed99"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"8268556cbed97be64911b6e813ce0e7f8cb1c373","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"bbd7cadd_1f63fc8c","updated":"2026-01-27 09:18:25.000000000","message":"recheck","commit_id":"8bf7fc894cf719b901176704961141969189ed99"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"d48bc5647b2acd3c482797b6b1a530963546c4b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"2305a874_43821d84","updated":"2026-01-27 10:23:43.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"8bf7fc894cf719b901176704961141969189ed99"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"3b03adc11928536d89939452234157a612d5f6b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7ab6d06f_11e0debb","updated":"2026-01-27 10:18:07.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"8bf7fc894cf719b901176704961141969189ed99"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e0037b8517a3b4e39a2ace81acf5c795e7218adf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"c5dfd38c_c3eba575","updated":"2026-01-29 18:15:16.000000000","message":"@rajatdhasmana@gmail.com\n\nPowerFlex-v4 got passed and NVMe/TCP patch not merged that is getting failed.","commit_id":"c7e119be85b2557993205f7afdfb18ec59f4b976"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"17dd38d44d8fefc51f2a4fd70d06b23b47ec6a13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"b86c7ae1_eedaecd0","updated":"2026-01-28 05:14:58.000000000","message":"Thanks for the review @rajatdhasmana@gmail.com.\n\nUpdate the UT.","commit_id":"c7e119be85b2557993205f7afdfb18ec59f4b976"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"9c823926a8272627522baf8b953229aedde7e720","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"b310d46b_7c5641c9","updated":"2026-01-29 14:35:47.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"c7e119be85b2557993205f7afdfb18ec59f4b976"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"779acbe7c2622a2583324f6ab08a2b40cdc44cab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"fee77a70_78d80ca5","updated":"2026-01-29 14:14:00.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"c7e119be85b2557993205f7afdfb18ec59f4b976"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"74ce583abe5be789dce781284ddbc67e4b95e0fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"ff6b2ad6_862896a7","updated":"2026-01-30 23:31:17.000000000","message":"Revisions LGTM.  Thanks for outlining the workflow in the etherpad, that was helpful for reviewing.","commit_id":"1fd0b7fc3b529aba3b9d5fc523fedb6089cbc3df"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"a01c8aa6047c18c837cb171447ea5d3f6862c5b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"b2d23018_bbc4c772","updated":"2026-01-31 06:48:23.000000000","message":"Thanks for the review @rajatdhasmana@gmail.com and @rosmaita.fossdev@gmail.com\n\nBrian, it seems we needs to merge os-brick first then this, getting gate error because of os-brick patch is not merged.","commit_id":"1fd0b7fc3b529aba3b9d5fc523fedb6089cbc3df"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5d7af5e564b9a359d2d5d099cb7598e470c3e8c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"56b9d3fe_1762824f","updated":"2026-01-30 11:14:37.000000000","message":"powerflex-v4-cinder-tempest CI passed.\nCode and tests looks good along with the releasenote. LGTM.","commit_id":"1fd0b7fc3b529aba3b9d5fc523fedb6089cbc3df"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"d75fa3872512a600e86e664bcee146bb62a1889b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"0d8320d5_e770b96a","updated":"2026-01-31 17:46:12.000000000","message":"recheck","commit_id":"1fd0b7fc3b529aba3b9d5fc523fedb6089cbc3df"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"32601de9760ff19bb51e6a1bc3dcbac207621b09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"293ba3cd_40146188","updated":"2026-01-30 04:28:29.000000000","message":"recheck","commit_id":"1fd0b7fc3b529aba3b9d5fc523fedb6089cbc3df"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"86aed43aa4aa351df5b7f7ebd654d1cab530866d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"a9eb6790_62c60d13","updated":"2026-01-31 14:34:07.000000000","message":"recheck","commit_id":"1fd0b7fc3b529aba3b9d5fc523fedb6089cbc3df"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"78de40ed50050e358827bccd92e8ef9686feb43a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"ae331cd6_a6484492","updated":"2026-01-29 22:30:28.000000000","message":"recheck","commit_id":"1fd0b7fc3b529aba3b9d5fc523fedb6089cbc3df"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"b8aaae7f0f40f2f64a4940c576b51c550c066fcd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"60592e80_d1eae028","updated":"2026-01-29 19:26:27.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"1fd0b7fc3b529aba3b9d5fc523fedb6089cbc3df"}],"cinder/tests/unit/volume/drivers/dell_emc/powerflex/test_sdc.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a1629f82f5017cefb3c58e8cffde9682e4bb4fd8","unresolved":true,"context_lines":[{"line_number":170,"context_line":"        self.driver._detach_volume_from_host.assert_called_once_with("},{"line_number":171,"context_line":"            self.volume, self.host_id)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def test__terminate_connection_no_connector(self):"},{"line_number":174,"context_line":"        self.assertRaises(exception.InvalidHost,"},{"line_number":175,"context_line":"                          self.driver._terminate_connection,"},{"line_number":176,"context_line":"                          self.volume,"},{"line_number":177,"context_line":"                          {})"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def test__terminate_connection_multiattached(self):"},{"line_number":180,"context_line":"        self.driver._is_multiattached_to_host \u003d mock.MagicMock("}],"source_content_type":"text/x-python","patch_set":2,"id":"2c5a2758_629f4b4c","side":"PARENT","line":177,"range":{"start_line":173,"start_character":0,"end_line":177,"end_character":29},"updated":"2026-01-15 07:48:15.000000000","message":"rather than removing this test, we should assert that terminate connection returns successfully when sdc_guid is not supplied","commit_id":"00505d25879992b268402a71125ccc65b3c4088d"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e04783d4ac57848f5f2b1a4a3cdbc33d0a2efbc1","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        self.driver._detach_volume_from_host.assert_called_once_with("},{"line_number":171,"context_line":"            self.volume, self.host_id)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def test__terminate_connection_no_connector(self):"},{"line_number":174,"context_line":"        self.assertRaises(exception.InvalidHost,"},{"line_number":175,"context_line":"                          self.driver._terminate_connection,"},{"line_number":176,"context_line":"                          self.volume,"},{"line_number":177,"context_line":"                          {})"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def test__terminate_connection_multiattached(self):"},{"line_number":180,"context_line":"        self.driver._is_multiattached_to_host \u003d mock.MagicMock("}],"source_content_type":"text/x-python","patch_set":2,"id":"7451c115_46cb4f0c","side":"PARENT","line":177,"range":{"start_line":173,"start_character":0,"end_line":177,"end_character":29},"in_reply_to":"2c5a2758_629f4b4c","updated":"2026-01-16 06:33:32.000000000","message":"Done","commit_id":"00505d25879992b268402a71125ccc65b3c4088d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6df8ba8a07a6288f224e47ce9b91cb40226a6b3a","unresolved":true,"context_lines":[{"line_number":171,"context_line":"            self.volume, self.host_id)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def test__terminate_connection_with_no_sdc_guid(self):"},{"line_number":174,"context_line":"        self.driver._terminate_connection \u003d mock.MagicMock()"},{"line_number":175,"context_line":"        self.driver._detach_volume_from_host \u003d mock.MagicMock()"},{"line_number":176,"context_line":"        self.driver.terminate_connection(self.volume, self.connector)"},{"line_number":177,"context_line":"        self.driver._detach_volume_from_host.assert_not_called()"}],"source_content_type":"text/x-python","patch_set":10,"id":"a1bc812d_d5061812","line":174,"range":{"start_line":174,"start_character":0,"end_line":174,"end_character":60},"updated":"2026-01-27 20:10:30.000000000","message":"this doesn\u0027t look correct. If we\u0027re mocking the whole _terminate_connection then no method inside it will be called so self.driver._detach_volume_from_host.assert_not_called() is not a valid assert.\nWe should only mock _detach_volume_from_host (or other methods inside _terminate_connection and not the whole _terminate_connection method)","commit_id":"8bf7fc894cf719b901176704961141969189ed99"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"17dd38d44d8fefc51f2a4fd70d06b23b47ec6a13","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            self.volume, self.host_id)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def test__terminate_connection_with_no_sdc_guid(self):"},{"line_number":174,"context_line":"        self.driver._terminate_connection \u003d mock.MagicMock()"},{"line_number":175,"context_line":"        self.driver._detach_volume_from_host \u003d mock.MagicMock()"},{"line_number":176,"context_line":"        self.driver.terminate_connection(self.volume, self.connector)"},{"line_number":177,"context_line":"        self.driver._detach_volume_from_host.assert_not_called()"}],"source_content_type":"text/x-python","patch_set":10,"id":"e9057b92_c54bc587","line":174,"range":{"start_line":174,"start_character":0,"end_line":174,"end_character":60},"in_reply_to":"a1bc812d_d5061812","updated":"2026-01-28 05:14:58.000000000","message":"Yes correcrt, updated the test case.","commit_id":"8bf7fc894cf719b901176704961141969189ed99"}],"cinder/volume/drivers/dell_emc/powerflex/driver.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fcc0b2988ea47e5f0442d3acbfcac558c104fa33","unresolved":true,"context_lines":[{"line_number":1062,"context_line":"            self._detach_volume_from_host(volume_or_snap)"},{"line_number":1063,"context_line":"            return"},{"line_number":1064,"context_line":""},{"line_number":1065,"context_line":"        if \"sdc_guid\" in connector:"},{"line_number":1066,"context_line":"            sdc_guid \u003d connector[\"sdc_guid\"]"},{"line_number":1067,"context_line":"            LOG.info(\"Terminate connection for %(vol_id)s to SDC %(sdc)s.\","},{"line_number":1068,"context_line":"                     {\"vol_id\": volume_or_snap.id, \"sdc\": sdc_guid})"}],"source_content_type":"text/x-python","patch_set":2,"id":"6b0e1ca2_0febcf43","line":1065,"range":{"start_line":1065,"start_character":0,"end_line":1065,"end_character":35},"updated":"2026-01-15 07:47:02.000000000","message":"I\u0027m not really sure how the fix works.\nIf we are skipping the detachment in case the sdc_guid doesn\u0027t exist, does it mean os-brick will do the unmapping?\nIf the sdc_guid exists, does it mean that we try to do the unmapping 2 times, once in os-brick (disconnect_volume) and then in cinder (terminate_connection)?","commit_id":"a3b8201763dbf8bad7807ca39f49d6e4a833da10"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"322559455e8081dfe646437d9c9f3c4cf8291c37","unresolved":false,"context_lines":[{"line_number":1062,"context_line":"            self._detach_volume_from_host(volume_or_snap)"},{"line_number":1063,"context_line":"            return"},{"line_number":1064,"context_line":""},{"line_number":1065,"context_line":"        if \"sdc_guid\" in connector:"},{"line_number":1066,"context_line":"            sdc_guid \u003d connector[\"sdc_guid\"]"},{"line_number":1067,"context_line":"            LOG.info(\"Terminate connection for %(vol_id)s to SDC %(sdc)s.\","},{"line_number":1068,"context_line":"                     {\"vol_id\": volume_or_snap.id, \"sdc\": sdc_guid})"}],"source_content_type":"text/x-python","patch_set":2,"id":"2258a5ef_5d4c0007","line":1065,"range":{"start_line":1065,"start_character":0,"end_line":1065,"end_character":35},"in_reply_to":"5b20eb34_959cf7b3","updated":"2026-01-27 08:54:22.000000000","message":"As discussed, changed the code.","commit_id":"a3b8201763dbf8bad7807ca39f49d6e4a833da10"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"d522de66fb1229b5d7deab1a6187a9df71192e9d","unresolved":true,"context_lines":[{"line_number":1062,"context_line":"            self._detach_volume_from_host(volume_or_snap)"},{"line_number":1063,"context_line":"            return"},{"line_number":1064,"context_line":""},{"line_number":1065,"context_line":"        if \"sdc_guid\" in connector:"},{"line_number":1066,"context_line":"            sdc_guid \u003d connector[\"sdc_guid\"]"},{"line_number":1067,"context_line":"            LOG.info(\"Terminate connection for %(vol_id)s to SDC %(sdc)s.\","},{"line_number":1068,"context_line":"                     {\"vol_id\": volume_or_snap.id, \"sdc\": sdc_guid})"}],"source_content_type":"text/x-python","patch_set":2,"id":"b0997e4c_2d1bd7a2","line":1065,"range":{"start_line":1065,"start_character":0,"end_line":1065,"end_character":35},"in_reply_to":"6b0e1ca2_0febcf43","updated":"2026-01-15 18:28:02.000000000","message":"Please find etherpad link[1] which explain the diff scenario workflow.\n\n1. https://etherpad.opendev.org/p/powerflex-detach-issue","commit_id":"a3b8201763dbf8bad7807ca39f49d6e4a833da10"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"00bdb5eca233e608ff5a8fe7db0447d1ede7ad70","unresolved":true,"context_lines":[{"line_number":1062,"context_line":"            self._detach_volume_from_host(volume_or_snap)"},{"line_number":1063,"context_line":"            return"},{"line_number":1064,"context_line":""},{"line_number":1065,"context_line":"        if \"sdc_guid\" in connector:"},{"line_number":1066,"context_line":"            sdc_guid \u003d connector[\"sdc_guid\"]"},{"line_number":1067,"context_line":"            LOG.info(\"Terminate connection for %(vol_id)s to SDC %(sdc)s.\","},{"line_number":1068,"context_line":"                     {\"vol_id\": volume_or_snap.id, \"sdc\": sdc_guid})"}],"source_content_type":"text/x-python","patch_set":2,"id":"bc4dd614_3a55003d","line":1065,"range":{"start_line":1065,"start_character":0,"end_line":1065,"end_character":35},"in_reply_to":"b0997e4c_2d1bd7a2","updated":"2026-01-16 11:04:39.000000000","message":"Left some comments on the etherpad. The assumption of case 3 doesn\u0027t look correct given the recommendation is to remove the connector.conf file after upgrading powerflex driver and os-brick so os-brick won\u0027t be able to handle the unmapping.","commit_id":"a3b8201763dbf8bad7807ca39f49d6e4a833da10"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"e27aaa9d3b227d4e1c783b12c3947e72f9446308","unresolved":true,"context_lines":[{"line_number":1062,"context_line":"            self._detach_volume_from_host(volume_or_snap)"},{"line_number":1063,"context_line":"            return"},{"line_number":1064,"context_line":""},{"line_number":1065,"context_line":"        if \"sdc_guid\" in connector:"},{"line_number":1066,"context_line":"            sdc_guid \u003d connector[\"sdc_guid\"]"},{"line_number":1067,"context_line":"            LOG.info(\"Terminate connection for %(vol_id)s to SDC %(sdc)s.\","},{"line_number":1068,"context_line":"                     {\"vol_id\": volume_or_snap.id, \"sdc\": sdc_guid})"}],"source_content_type":"text/x-python","patch_set":2,"id":"5b20eb34_959cf7b3","line":1065,"range":{"start_line":1065,"start_character":0,"end_line":1065,"end_character":35},"in_reply_to":"bc4dd614_3a55003d","updated":"2026-01-16 19:58:32.000000000","message":"Update comments on the etherpad\n\nYes correct after removing connector.conf file unmap/detach operation handle by the driver and which is giving error of sdc_guid for legacy volume, now new patch will handle that as well.","commit_id":"a3b8201763dbf8bad7807ca39f49d6e4a833da10"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8db80bd13c96580932cf4ba0b61a8689c9b12a03","unresolved":true,"context_lines":[{"line_number":1081,"context_line":"        if \"sdc_guid\" not in connector:"},{"line_number":1082,"context_line":"            LOG.info(\"Terminate legacy volume connection for %(vol_id)s.\","},{"line_number":1083,"context_line":"                     {\"vol_id\": volume_or_snap.id})"},{"line_number":1084,"context_line":"            self._unmap_legacy_volume(volume_or_snap)"},{"line_number":1085,"context_line":"        else:"},{"line_number":1086,"context_line":"            sdc_guid \u003d connector[\"sdc_guid\"]"},{"line_number":1087,"context_line":"            LOG.info(\"Terminate connection for %(vol_id)s to SDC %(sdc)s.\","},{"line_number":1088,"context_line":"                     {\"vol_id\": volume_or_snap.id, \"sdc\": sdc_guid})"}],"source_content_type":"text/x-python","patch_set":8,"id":"89f9815f_e47c8380","line":1085,"range":{"start_line":1084,"start_character":0,"end_line":1085,"end_character":13},"updated":"2026-01-19 11:20:36.000000000","message":"nit: a better way to write this would be\n\n        if \"sdc_guid\" not in connector:\n            LOG.info(\"Terminate legacy volume connection for %(vol_id)s.\",\n                     {\"vol_id\": volume_or_snap.id})\n            return self._unmap_legacy_volume(volume_or_snap)\n        sdc_guid \u003d connector[\"sdc_guid\"]\n        LOG.info(\"Terminate connection for %(vol_id)s to SDC %(sdc)s.\",\n                 {\"vol_id\": volume_or_snap.id, \"sdc\": sdc_guid})\n        host_id \u003d self._get_client().query_sdc_id_by_guid(sdc_guid)\n        self._detach_volume_from_host(volume_or_snap, host_id)\n        self._check_volume_unmapped(host_id, volume_or_snap.provider_id)\n        LOG.info(\"Terminated connection for %(vol_id)s to SDC %(sdc)s.\",\n                 {\"vol_id\": volume_or_snap.id, \"sdc\": sdc_guid})","commit_id":"5941afed5729287fddd8b458ebbb37908609d929"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"322559455e8081dfe646437d9c9f3c4cf8291c37","unresolved":false,"context_lines":[{"line_number":1081,"context_line":"        if \"sdc_guid\" not in connector:"},{"line_number":1082,"context_line":"            LOG.info(\"Terminate legacy volume connection for %(vol_id)s.\","},{"line_number":1083,"context_line":"                     {\"vol_id\": volume_or_snap.id})"},{"line_number":1084,"context_line":"            self._unmap_legacy_volume(volume_or_snap)"},{"line_number":1085,"context_line":"        else:"},{"line_number":1086,"context_line":"            sdc_guid \u003d connector[\"sdc_guid\"]"},{"line_number":1087,"context_line":"            LOG.info(\"Terminate connection for %(vol_id)s to SDC %(sdc)s.\","},{"line_number":1088,"context_line":"                     {\"vol_id\": volume_or_snap.id, \"sdc\": sdc_guid})"}],"source_content_type":"text/x-python","patch_set":8,"id":"91a93276_1c1f30fc","line":1085,"range":{"start_line":1084,"start_character":0,"end_line":1085,"end_character":13},"in_reply_to":"89f9815f_e47c8380","updated":"2026-01-27 08:54:22.000000000","message":"As discussed, changed the code.","commit_id":"5941afed5729287fddd8b458ebbb37908609d929"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8db80bd13c96580932cf4ba0b61a8689c9b12a03","unresolved":true,"context_lines":[{"line_number":1116,"context_line":"        ]"},{"line_number":1117,"context_line":"        return len(attachments) \u003e 1"},{"line_number":1118,"context_line":""},{"line_number":1119,"context_line":"    def _unmap_legacy_volume(self, volume):"},{"line_number":1120,"context_line":"        provider_id \u003d volume.provider_id"},{"line_number":1121,"context_line":"        vol \u003d self._get_client().query_volume(provider_id)"},{"line_number":1122,"context_line":"        if not vol[\"mappedSdcInfo\"]:"}],"source_content_type":"text/x-python","patch_set":8,"id":"42140673_506f72ac","line":1119,"range":{"start_line":1119,"start_character":0,"end_line":1119,"end_character":43},"updated":"2026-01-19 11:20:36.000000000","message":"from what i can read in the _detach_volume_from_host method, it handles a case when sdc_guid is missing from connector L#1205.\nWhat I feel should work is,\n1. don\u0027t raise if sdc_guid is not present\n2. Call _detach_volume_from_host without sdc_id for legacy volumes\n\nIIUC, this should make the unmapping based on the provider_id of the volume L#1214\n\n    self._get_client().unmap_volume(provider_id)","commit_id":"5941afed5729287fddd8b458ebbb37908609d929"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"322559455e8081dfe646437d9c9f3c4cf8291c37","unresolved":false,"context_lines":[{"line_number":1116,"context_line":"        ]"},{"line_number":1117,"context_line":"        return len(attachments) \u003e 1"},{"line_number":1118,"context_line":""},{"line_number":1119,"context_line":"    def _unmap_legacy_volume(self, volume):"},{"line_number":1120,"context_line":"        provider_id \u003d volume.provider_id"},{"line_number":1121,"context_line":"        vol \u003d self._get_client().query_volume(provider_id)"},{"line_number":1122,"context_line":"        if not vol[\"mappedSdcInfo\"]:"}],"source_content_type":"text/x-python","patch_set":8,"id":"df85dc41_eb6c8c82","line":1119,"range":{"start_line":1119,"start_character":0,"end_line":1119,"end_character":43},"in_reply_to":"42140673_506f72ac","updated":"2026-01-27 08:54:22.000000000","message":"As discussed, changed the code.","commit_id":"5941afed5729287fddd8b458ebbb37908609d929"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8db80bd13c96580932cf4ba0b61a8689c9b12a03","unresolved":true,"context_lines":[{"line_number":1131,"context_line":"                      })"},{"line_number":1132,"context_line":"            return"},{"line_number":1133,"context_line":"        else:"},{"line_number":1134,"context_line":"            sdc_id \u003d vol[\"mappedSdcInfo\"][0][\"sdcId\"]"},{"line_number":1135,"context_line":"            self._get_client().unmap_volume(provider_id, sdc_id)"},{"line_number":1136,"context_line":"            self._check_volume_unmapped(sdc_id, provider_id)"},{"line_number":1137,"context_line":"            LOG.info(\"Terminated legacy volume connection \""}],"source_content_type":"text/x-python","patch_set":8,"id":"87eacecb_3a21d522","line":1134,"range":{"start_line":1134,"start_character":41,"end_line":1134,"end_character":53},"updated":"2026-01-19 11:20:36.000000000","message":"what happens if the LUN is mapped to multiple hosts (multiattach volumes)? IIUC, we are detaching it from the first host at 0th index right? I\u0027m not sure if it\u0027s a great idea to unmap it from the first host without any check.","commit_id":"5941afed5729287fddd8b458ebbb37908609d929"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"322559455e8081dfe646437d9c9f3c4cf8291c37","unresolved":false,"context_lines":[{"line_number":1131,"context_line":"                      })"},{"line_number":1132,"context_line":"            return"},{"line_number":1133,"context_line":"        else:"},{"line_number":1134,"context_line":"            sdc_id \u003d vol[\"mappedSdcInfo\"][0][\"sdcId\"]"},{"line_number":1135,"context_line":"            self._get_client().unmap_volume(provider_id, sdc_id)"},{"line_number":1136,"context_line":"            self._check_volume_unmapped(sdc_id, provider_id)"},{"line_number":1137,"context_line":"            LOG.info(\"Terminated legacy volume connection \""}],"source_content_type":"text/x-python","patch_set":8,"id":"5b9f0251_331883cf","line":1134,"range":{"start_line":1134,"start_character":41,"end_line":1134,"end_character":53},"in_reply_to":"87eacecb_3a21d522","updated":"2026-01-27 08:54:22.000000000","message":"Yes correct, multi attach volume request goes to drivers side and driver does not have info of any compute nodes sdc_guid and there is currently no way to find out mapping for it. Now it will handle on os-brick side as discussed.","commit_id":"5941afed5729287fddd8b458ebbb37908609d929"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6df8ba8a07a6288f224e47ce9b91cb40226a6b3a","unresolved":true,"context_lines":[{"line_number":911,"context_line":"        volume_name \u003d flex_utils.id_to_base64(vol_or_snap.id)"},{"line_number":912,"context_line":"        connection_properties[\"scaleIO_volname\"] \u003d volume_name"},{"line_number":913,"context_line":"        connection_properties[\"scaleIO_volume_id\"] \u003d vol_or_snap.provider_id"},{"line_number":914,"context_line":"        # This will require when initialize connection call from cinder"},{"line_number":915,"context_line":"        # side for operation like image volume, added this"},{"line_number":916,"context_line":"        # to handle detach on driver side not on os-brick side."},{"line_number":917,"context_line":"        connection_properties[\"sdc_guid\"] \u003d sdc_guid"},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"        # map volume"}],"source_content_type":"text/x-python","patch_set":10,"id":"c4d93c4c_ac9066d6","line":916,"range":{"start_line":914,"start_character":8,"end_line":916,"end_character":63},"updated":"2026-01-27 20:10:30.000000000","message":"nit: rephrase this to\n\n    # This will be required when calling initialize connection on cinder\n    # side for operation like creating bootable volume from image.\n    # This indicates that handling for detach is done on the driver\n    # side and not on os-brick side.","commit_id":"8bf7fc894cf719b901176704961141969189ed99"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"17dd38d44d8fefc51f2a4fd70d06b23b47ec6a13","unresolved":false,"context_lines":[{"line_number":911,"context_line":"        volume_name \u003d flex_utils.id_to_base64(vol_or_snap.id)"},{"line_number":912,"context_line":"        connection_properties[\"scaleIO_volname\"] \u003d volume_name"},{"line_number":913,"context_line":"        connection_properties[\"scaleIO_volume_id\"] \u003d vol_or_snap.provider_id"},{"line_number":914,"context_line":"        # This will require when initialize connection call from cinder"},{"line_number":915,"context_line":"        # side for operation like image volume, added this"},{"line_number":916,"context_line":"        # to handle detach on driver side not on os-brick side."},{"line_number":917,"context_line":"        connection_properties[\"sdc_guid\"] \u003d sdc_guid"},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"        # map volume"}],"source_content_type":"text/x-python","patch_set":10,"id":"eb1bccc7_87fcf2ac","line":916,"range":{"start_line":914,"start_character":8,"end_line":916,"end_character":63},"in_reply_to":"c4d93c4c_ac9066d6","updated":"2026-01-28 05:14:58.000000000","message":"Done","commit_id":"8bf7fc894cf719b901176704961141969189ed99"}],"releasenotes/notes/bug-2138280-dell-powerflex-detach-issue-2b031ac216d04d19.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"dc7434c2896343c0b752af69edaaebe375000263","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    that do not include sdc_guid. The driver now falls back to"},{"line_number":8,"context_line":"    the legacy detach path when sdc_guid is missing, restoring"},{"line_number":9,"context_line":"    backward compatibility and preventing errors for legacy"},{"line_number":10,"context_line":"    attachments.ā"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"90fd9b84_7aaf37a5","line":10,"range":{"start_line":10,"start_character":16,"end_line":10,"end_character":17},"updated":"2026-01-14 13:58:49.000000000","message":"please remove extraneous character\n\nAlso, usually when mentioning some kind of response field, we tend to put them in double-backticks so that they render in monospace font (but that\u0027s up to you).","commit_id":"6bde0a6972ecace92ff67d47cb5f2715ae5f54d8"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"02e82dd23a4f1daf7c448022280ee0499591797d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    that do not include sdc_guid. The driver now falls back to"},{"line_number":8,"context_line":"    the legacy detach path when sdc_guid is missing, restoring"},{"line_number":9,"context_line":"    backward compatibility and preventing errors for legacy"},{"line_number":10,"context_line":"    attachments.ā"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5da82b29_5205362b","line":10,"range":{"start_line":10,"start_character":16,"end_line":10,"end_character":17},"in_reply_to":"90fd9b84_7aaf37a5","updated":"2026-01-14 14:45:16.000000000","message":"Done","commit_id":"6bde0a6972ecace92ff67d47cb5f2715ae5f54d8"}]}