)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6771f6d2f0e236c0d0c496e48fd51782027d8ae3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sanketh Shetty \u003csanketh.shetty@netapp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-01-22 01:22:43 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"NetApp ONTAP MirrorAllSnapshots snapmirror replication failing issue fix"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: #2138640"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a5dc50c_b8008a8b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":72},"updated":"2026-02-24 06:50:01.000000000","message":"I won\u0027t block for this reason but please try to be as verbose as possible in the commit message.\nAt least we have provided some details in releasenote so that is good.","commit_id":"6a4fcb4b7770e63cd68a5a41845bf22c7f81a9a8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"b48a2410375f6c50e81292634907dfccbff1d72a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"810a1f88_8024cf35","updated":"2026-01-20 08:15:54.000000000","message":"Please look at the below comment.","commit_id":"54d953805338b7e6079f64a1291b7af6b0a0458e"},{"author":{"_account_id":38623,"name":"Sanketh Shetty","display_name":"Sanketh Shetty","email":"sanketh.shetty@netapp.com","username":"sanketh-netapp","status":"NetApp"},"change_message_id":"d94e041c09b63146cd8c7789c4d1765a77de6461","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"05996c8d_62c69268","updated":"2026-01-20 05:27:52.000000000","message":"Requesting review","commit_id":"54d953805338b7e6079f64a1291b7af6b0a0458e"},{"author":{"_account_id":38623,"name":"Sanketh Shetty","display_name":"Sanketh Shetty","email":"sanketh.shetty@netapp.com","username":"sanketh-netapp","status":"NetApp"},"change_message_id":"925ff0285fbe2675dbeab201b32a3136b90fbad8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ab68913b_42a75be3","updated":"2026-01-21 14:02:41.000000000","message":"Hi Cinder core reviewers. Requesting your review for this bug fix. Currently netapp-ci is having issues and not running. Since its a small fix, wanted your feedback on whether we can get an excpetion for this.","commit_id":"13dcedccaa148ba562624f62630753302fb94355"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"ca986d8b0d06d9aabb7f6e138b2a00a61eb6a644","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d1534799_de460630","updated":"2026-02-20 18:49:37.000000000","message":"+1 as I\u0027m satisfied with the answer that Sanketh gave me. The \"/cg/None\" path won\u0027t actually get used if the src is None.","commit_id":"6a4fcb4b7770e63cd68a5a41845bf22c7f81a9a8"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"6f39dcc1909d272faae449660fe1dacdf8e26f5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c9de19df_eff82a4a","updated":"2026-02-20 15:03:23.000000000","message":"-1 as while I think it would solve the problem, I\u0027m not sure the way it\u0027s solved makes sense and would like to hear back on the logic.  It might be that I misunderstand what\u0027s going on.","commit_id":"6a4fcb4b7770e63cd68a5a41845bf22c7f81a9a8"},{"author":{"_account_id":38623,"name":"Sanketh Shetty","display_name":"Sanketh Shetty","email":"sanketh.shetty@netapp.com","username":"sanketh-netapp","status":"NetApp"},"change_message_id":"16d339dfa5f6777ed8648b962184e61992edf465","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"36730f9f_dd0544e5","updated":"2026-03-02 07:18:10.000000000","message":"@rosmaita.fossdev@gmail.com @jobernar@redhat.com - Requesting a +2 on this to merge the patch.","commit_id":"6a4fcb4b7770e63cd68a5a41845bf22c7f81a9a8"},{"author":{"_account_id":38623,"name":"Sanketh Shetty","display_name":"Sanketh Shetty","email":"sanketh.shetty@netapp.com","username":"sanketh-netapp","status":"NetApp"},"change_message_id":"0d9f1e71fdb41c92f1359ceaf4ca2e3e1bb76f26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"52137087_2ee81518","updated":"2026-01-23 06:12:41.000000000","message":"Core reviewers. Requesting your review on this bug. Have updated Brian\u0027s comment on release notes.","commit_id":"6a4fcb4b7770e63cd68a5a41845bf22c7f81a9a8"},{"author":{"_account_id":38623,"name":"Sanketh Shetty","display_name":"Sanketh Shetty","email":"sanketh.shetty@netapp.com","username":"sanketh-netapp","status":"NetApp"},"change_message_id":"4a0d90210ee6dc70bfe3aa9196691d7e26111bba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a0ab0121_16a13988","updated":"2026-02-20 16:12:03.000000000","message":"Hi @anthony.galica@hitachivantara.com, responded to your query. Can you pleae take a look. thanks.","commit_id":"6a4fcb4b7770e63cd68a5a41845bf22c7f81a9a8"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"bb4c9e19b15d1db0b103b33f66b8aaa12f708313","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"718b5418_c36ca1a0","updated":"2026-03-09 16:33:54.000000000","message":"I agree with Rajat about not blocking this for CI, although we do need to get this working - other reviewers are unlikely to take the time to understand each vendor\u0027s CI nuances.  Thank you Rajat and Sean for the reviews.","commit_id":"6a4fcb4b7770e63cd68a5a41845bf22c7f81a9a8"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"48ad26cfdb0ac5734e11e86d0336477df4072feb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b34641f9_1e2c7e20","updated":"2026-01-28 08:54:45.000000000","message":"LGTM","commit_id":"6a4fcb4b7770e63cd68a5a41845bf22c7f81a9a8"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"5f3924e2bf2f9d502a373965c0115919ce1d4f6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d4c9c47f_b9038ac8","updated":"2026-03-09 13:19:09.000000000","message":"Looks fine to me, but will leave it to someone more in the loop about the third party CI concern to actually approve.","commit_id":"6a4fcb4b7770e63cd68a5a41845bf22c7f81a9a8"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"9cb297fc07f546dfa2d45ec30648b777f65a32dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"786cad77_ab86e2c8","updated":"2026-02-20 14:45:47.000000000","message":"Looks good to me - thank you!","commit_id":"6a4fcb4b7770e63cd68a5a41845bf22c7f81a9a8"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"7fc8b89304a46a4fb45540b6d64d7004cfc8a29e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a7f2f150_a94924d0","updated":"2026-02-20 14:10:52.000000000","message":"Looks simple enough and appropriate","commit_id":"6a4fcb4b7770e63cd68a5a41845bf22c7f81a9a8"},{"author":{"_account_id":38623,"name":"Sanketh Shetty","display_name":"Sanketh Shetty","email":"sanketh.shetty@netapp.com","username":"sanketh-netapp","status":"NetApp"},"change_message_id":"bb3e7bfba261b6d9288069208216cd2e993ed143","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ac853921_fc68c8d8","updated":"2026-02-05 07:26:00.000000000","message":"Requesting core reviewers for urgent feedback on the review.","commit_id":"6a4fcb4b7770e63cd68a5a41845bf22c7f81a9a8"},{"author":{"_account_id":37328,"name":"Nimesh Desai","display_name":"Nimesh Desai","email":"nimesh.desai@ibm.com","username":"nimeshdesai"},"change_message_id":"3311b85de98527acabfca54266a303aa1600e07f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c25375ca_84ca72ee","updated":"2026-02-20 14:13:30.000000000","message":"The change to None looks good.","commit_id":"6a4fcb4b7770e63cd68a5a41845bf22c7f81a9a8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6771f6d2f0e236c0d0c496e48fd51782027d8ae3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0a9c3158_0d1a7b88","updated":"2026-02-24 06:50:01.000000000","message":"code and tests LGTM. The author clearly stated that NetApp CI is not working but I think this should have a wider discussion since we have recurring cases and might allow more exceptions than CI validated patches.","commit_id":"6a4fcb4b7770e63cd68a5a41845bf22c7f81a9a8"}],"cinder/volume/drivers/netapp/dataontap/utils/data_motion.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6771f6d2f0e236c0d0c496e48fd51782027d8ae3","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        sync_mirror_policy \u003d self.is_sync_mirror_policy(replication_policy)"},{"line_number":191,"context_line":"        active_sync_asymmetric_policy \u003d self.is_active_sync_asymmetric_policy("},{"line_number":192,"context_line":"            replication_policy)"},{"line_number":193,"context_line":"        src_cg \u003d \"cg_\" + src_flexvol_name if active_sync_asymmetric_policy \\"},{"line_number":194,"context_line":"            else None"},{"line_number":195,"context_line":"        dest_cg \u003d \"cg_\" + dest_flexvol_name if active_sync_asymmetric_policy \\"},{"line_number":196,"context_line":"            else None"}],"source_content_type":"text/x-python","patch_set":5,"id":"78480d33_d4517e8a","line":193,"range":{"start_line":193,"start_character":8,"end_line":193,"end_character":14},"updated":"2026-02-24 06:50:01.000000000","message":"I see the problem with old logic but it would be good to check src_cg as well as dest_cg in the condition\n\nhttps://opendev.org/openstack/cinder/src/branch/master/cinder/volume/drivers/netapp/dataontap/client/client_cmode_rest.py#L2107\n\n    \u003e\u003e\u003e src_cg \u003d \u0027\u0027\n    \u003e\u003e\u003e if src_cg is not None:\n    ...     print(\"src cg is empty but not None\")\n    ...     \n    src cg is empty but not None\n\n\n    \u003e\u003e\u003e src_cg \u003d None\n    \u003e\u003e\u003e if src_cg is not None:\n    ...     print(\"src cg is empty but not None\")\n    \u003cnothing printed\u003e","commit_id":"6a4fcb4b7770e63cd68a5a41845bf22c7f81a9a8"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"6f39dcc1909d272faae449660fe1dacdf8e26f5c","unresolved":true,"context_lines":[{"line_number":194,"context_line":"            else None"},{"line_number":195,"context_line":"        dest_cg \u003d \"cg_\" + dest_flexvol_name if active_sync_asymmetric_policy \\"},{"line_number":196,"context_line":"            else None"},{"line_number":197,"context_line":"        src_cg_path \u003d \"/cg/\" + str(src_cg)"},{"line_number":198,"context_line":"        dest_cg_path \u003d \"/cg/\" + str(dest_cg)"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        # 2. Check if SnapMirror relationship exists"}],"source_content_type":"text/x-python","patch_set":5,"id":"b980a6cd_75ca8f64","line":197,"updated":"2026-02-20 15:03:23.000000000","message":"Maybe I\u0027m reading this wrong, but it looks like it\u0027s only going to work because instead of the path \"/cg/\", which will surely break, you\u0027d have the path \"/cg/None\". I can\u0027t imagine this would work for src (which probably always has a value?), but it would work for dest.\n\nIs this really want you want?","commit_id":"6a4fcb4b7770e63cd68a5a41845bf22c7f81a9a8"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"ca986d8b0d06d9aabb7f6e138b2a00a61eb6a644","unresolved":false,"context_lines":[{"line_number":194,"context_line":"            else None"},{"line_number":195,"context_line":"        dest_cg \u003d \"cg_\" + dest_flexvol_name if active_sync_asymmetric_policy \\"},{"line_number":196,"context_line":"            else None"},{"line_number":197,"context_line":"        src_cg_path \u003d \"/cg/\" + str(src_cg)"},{"line_number":198,"context_line":"        dest_cg_path \u003d \"/cg/\" + str(dest_cg)"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        # 2. Check if SnapMirror relationship exists"}],"source_content_type":"text/x-python","patch_set":5,"id":"a2f925ce_92ffa03f","line":197,"in_reply_to":"b59c8844_055e3cda","updated":"2026-02-20 18:49:37.000000000","message":"Gotcha, understood.  If the value isn\u0027t going to be used in that case, the destination path is ignored so it doesn\u0027t matter if it is \"/cg/None\".  I will resolve this thread and issue a +1.","commit_id":"6a4fcb4b7770e63cd68a5a41845bf22c7f81a9a8"},{"author":{"_account_id":38623,"name":"Sanketh Shetty","display_name":"Sanketh Shetty","email":"sanketh.shetty@netapp.com","username":"sanketh-netapp","status":"NetApp"},"change_message_id":"4a0d90210ee6dc70bfe3aa9196691d7e26111bba","unresolved":true,"context_lines":[{"line_number":194,"context_line":"            else None"},{"line_number":195,"context_line":"        dest_cg \u003d \"cg_\" + dest_flexvol_name if active_sync_asymmetric_policy \\"},{"line_number":196,"context_line":"            else None"},{"line_number":197,"context_line":"        src_cg_path \u003d \"/cg/\" + str(src_cg)"},{"line_number":198,"context_line":"        dest_cg_path \u003d \"/cg/\" + str(dest_cg)"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        # 2. Check if SnapMirror relationship exists"}],"source_content_type":"text/x-python","patch_set":5,"id":"b59c8844_055e3cda","line":197,"in_reply_to":"b980a6cd_75ca8f64","updated":"2026-02-20 16:12:03.000000000","message":"This problem occurs when active_sync_asymmetric_policy if False. the src_cg_path would not be used when this flag is set to False. in line 201. But when dest_client.create_snapmirror() is used in line 228, the function has a logic to check if src_cg and dest_cg are Not None --\u003e \"if source_cg is not None:\" (client_cmode_rest.py). So instead of passing None we are passing empty string.","commit_id":"6a4fcb4b7770e63cd68a5a41845bf22c7f81a9a8"}],"releasenotes/notes/bug-2138640-fix-for-async-snapmirror-regression-1d1250e1a1a545ef.yaml":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"b48a2410375f6c50e81292634907dfccbff1d72a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #2138640 \u003chttps://bugs.launchpad.net/cinder/+bug/2138640\u003e`_: Fixed the issue where MirrorAllSnapshots snapmirror creation is failing. This bug is introduced duoe to a regression while adding support for AutomatedFailOver policy."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b62b6e1c_990dc0c1","line":4,"updated":"2026-01-20 08:15:54.000000000","message":"\"due\" to a regresssion - typo","commit_id":"54d953805338b7e6079f64a1291b7af6b0a0458e"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"b48a2410375f6c50e81292634907dfccbff1d72a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #2138640 \u003chttps://bugs.launchpad.net/cinder/+bug/2138640\u003e`_: Fixed the issue where MirrorAllSnapshots snapmirror creation is failing. This bug is introduced duoe to a regression while adding support for AutomatedFailOver policy."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f9d06f25_84edffdb","line":4,"updated":"2026-01-20 08:15:54.000000000","message":"Fixed the issue where replication using the default MirrorAllSnapshot policy is failing for Cinder Volumes. This issue was introduced due to a regression while adding support for AutomatedFailover policy.","commit_id":"54d953805338b7e6079f64a1291b7af6b0a0458e"},{"author":{"_account_id":38623,"name":"Sanketh Shetty","display_name":"Sanketh Shetty","email":"sanketh.shetty@netapp.com","username":"sanketh-netapp","status":"NetApp"},"change_message_id":"925ff0285fbe2675dbeab201b32a3136b90fbad8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #2138640 \u003chttps://bugs.launchpad.net/cinder/+bug/2138640\u003e`_: Fixed the issue where MirrorAllSnapshots snapmirror creation is failing. This bug is introduced duoe to a regression while adding support for AutomatedFailOver policy."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"439f221d_a0a3c664","line":4,"in_reply_to":"b62b6e1c_990dc0c1","updated":"2026-01-21 14:02:41.000000000","message":"Done","commit_id":"54d953805338b7e6079f64a1291b7af6b0a0458e"},{"author":{"_account_id":38623,"name":"Sanketh Shetty","display_name":"Sanketh Shetty","email":"sanketh.shetty@netapp.com","username":"sanketh-netapp","status":"NetApp"},"change_message_id":"925ff0285fbe2675dbeab201b32a3136b90fbad8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #2138640 \u003chttps://bugs.launchpad.net/cinder/+bug/2138640\u003e`_: Fixed the issue where MirrorAllSnapshots snapmirror creation is failing. This bug is introduced duoe to a regression while adding support for AutomatedFailOver policy."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"50bdfccc_f81a7744","line":4,"in_reply_to":"f9d06f25_84edffdb","updated":"2026-01-21 14:02:41.000000000","message":"@anoop.shukla@netapp.com - updated comment","commit_id":"54d953805338b7e6079f64a1291b7af6b0a0458e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"5f3924e2bf2f9d502a373965c0115919ce1d4f6b","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #2138640 \u003chttps://bugs.launchpad.net/cinder/+bug/2138640\u003e`_:"},{"line_number":5,"context_line":"      Fixed the issue where replication using the default MirrorAllSnapshot"},{"line_number":6,"context_line":"      policy is failing for Cinder Volumes. This issue was introduced due to"},{"line_number":7,"context_line":"      a regression while adding support for AutomatedFailover policy."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"cc347755_2be18340","line":5,"updated":"2026-03-09 13:19:09.000000000","message":"I think this will render fine, but if you do need to do another update, all lines but the first are over indented.","commit_id":"6a4fcb4b7770e63cd68a5a41845bf22c7f81a9a8"}]}