)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"300bfcd9a34cd3ceb3c626f2b6b7631d3f109845","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Manideep \u003cmanideep.openstack@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-03-05 14:11:14 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added additional capabilities to ASAr2 driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added multiple improvements to the existing driver capabilities"},{"line_number":10,"context_line":"and SVM as pool instead of Cluster."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"57acbfec_ead14f2f","line":7,"updated":"2026-03-06 16:10:51.000000000","message":"Should we mention what capabilities were added so reviewers know what to look out for?","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"1f81345ffae220a8b558c52f0b12bdcdea3802d6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Manideep \u003cmanideep.openstack@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-03-05 14:11:14 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added additional capabilities to ASAr2 driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added multiple improvements to the existing driver capabilities"},{"line_number":10,"context_line":"and SVM as pool instead of Cluster."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3182a602_e8321e79","line":7,"in_reply_to":"34bb7b3b_af830249","updated":"2026-03-10 23:00:02.000000000","message":"I think it\u0027s probably ok in my view - I noted the release notes also.  Other reviewers might ask you to change it, though, which was my motivation here as I\u0027ve had people ask me for more information in the commit message than was provided (despite having release notes), and it feels pretty vague here).","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"e77047783e0078b5b91aed7efbb604661991b782","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Manideep \u003cmanideep.openstack@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-03-05 14:11:14 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added additional capabilities to ASAr2 driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added multiple improvements to the existing driver capabilities"},{"line_number":10,"context_line":"and SVM as pool instead of Cluster."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ae886e1b_24fe4590","line":7,"in_reply_to":"57acbfec_ead14f2f","updated":"2026-03-09 18:49:30.000000000","message":"There is a detailed release notes attached to the patch that explains all the changes made with this change request. I wanted to keep the commit message short as release note is detailed. Please let me know if still I need to add more details here.","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"b617d0d0f2be9d7259abab098a3cec2834290413","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Manideep \u003cmanideep.openstack@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-03-05 14:11:14 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added additional capabilities to ASAr2 driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added multiple improvements to the existing driver capabilities"},{"line_number":10,"context_line":"and SVM as pool instead of Cluster."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"34bb7b3b_af830249","line":7,"in_reply_to":"ae886e1b_24fe4590","updated":"2026-03-10 05:34:15.000000000","message":"Done","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"300bfcd9a34cd3ceb3c626f2b6b7631d3f109845","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added additional capabilities to ASAr2 driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added multiple improvements to the existing driver capabilities"},{"line_number":10,"context_line":"and SVM as pool instead of Cluster."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: https://review.opendev.org/c/openstack/neutron/+/979005"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"d6526712_0848c9a9","line":9,"updated":"2026-03-06 16:10:51.000000000","message":"What kind of improvements?  Perf?  etc? (I do see it in the release notes, so maybe that\u0027s enough)\n\nI also wonder if this should be broken down into multiple feature patches so there\u0027s only 1 feature per patch.  I know that\u0027s treated somewhat loosely, but this patch looks like it has a lot and the commit message is vague as to everything that\u0027s in here.","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"e77047783e0078b5b91aed7efbb604661991b782","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added additional capabilities to ASAr2 driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added multiple improvements to the existing driver capabilities"},{"line_number":10,"context_line":"and SVM as pool instead of Cluster."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: https://review.opendev.org/c/openstack/neutron/+/979005"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ee8990fa_0a2bfa0e","line":9,"in_reply_to":"d6526712_0848c9a9","updated":"2026-03-09 18:49:30.000000000","message":"The way we have split the ASAr2 work is, capabilities (driver side work), Volume workflows which has couple of additional patches. This patch addresses driver capabilities. Splitting the patch for each capability will be a hard to do thing as the changes are limited to the base files and some zapi and rest files.\n\nThe release note covers all the improvements that were done.","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"1f81345ffae220a8b558c52f0b12bdcdea3802d6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added additional capabilities to ASAr2 driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added multiple improvements to the existing driver capabilities"},{"line_number":10,"context_line":"and SVM as pool instead of Cluster."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: https://review.opendev.org/c/openstack/neutron/+/979005"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"658fc207_7f485aec","line":9,"in_reply_to":"eb9c774f_5d55445d","updated":"2026-03-10 23:00:02.000000000","message":"Understood.  I agree btw in regards to features that all meld together, I just don\u0027t know if you will get called out for it later.","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"b617d0d0f2be9d7259abab098a3cec2834290413","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added additional capabilities to ASAr2 driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added multiple improvements to the existing driver capabilities"},{"line_number":10,"context_line":"and SVM as pool instead of Cluster."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Depends-On: https://review.opendev.org/c/openstack/neutron/+/979005"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"eb9c774f_5d55445d","line":9,"in_reply_to":"ee8990fa_0a2bfa0e","updated":"2026-03-10 05:34:15.000000000","message":"Done","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"c16a9401118ce8bb6c121d0f7a39992e7706a6b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"153059dd_d69d0ed9","updated":"2026-02-25 14:40:51.000000000","message":"recheck","commit_id":"c9c881035f18ba21b8ee69c535f8926c92f00f24"},{"author":{"_account_id":38623,"name":"Sanketh Shetty","display_name":"Sanketh Shetty","email":"sanketh.shetty@netapp.com","username":"sanketh-netapp","status":"NetApp"},"change_message_id":"7d1c4fd8587095d9bf2ddf10454486ab572d9a71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4b006624_c93b3c09","updated":"2026-02-27 09:39:28.000000000","message":"LGTM","commit_id":"7989fd2431b786019a0da90097966148d619ea5d"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"da9d2b9e26eeda08b58203fdd5e3229a798b4224","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"be9bb245_c008acf5","updated":"2026-02-27 10:00:03.000000000","message":"LGTM ..!","commit_id":"7989fd2431b786019a0da90097966148d619ea5d"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"6a73667520ad063c7d6041c161ae89f63362ca8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2f92c30a_4c6cb22c","updated":"2026-03-05 03:13:59.000000000","message":"Run-NetApp CI","commit_id":"7989fd2431b786019a0da90097966148d619ea5d"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"6b81258a93e9c0a822e7816d81119f37a227fd32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5836bb7c_24050858","updated":"2026-03-05 03:47:14.000000000","message":"Run-NetApp CI","commit_id":"7989fd2431b786019a0da90097966148d619ea5d"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"885ff46668e140579764ea1736733b152857420e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"712b15d8_9a3125a8","updated":"2026-03-05 02:48:50.000000000","message":"Run-NetApp CI","commit_id":"7989fd2431b786019a0da90097966148d619ea5d"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"bc17f86303b2efcc5a3d59a1f9d1925d1ba041bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"802d28b5_67fb8b51","updated":"2026-02-26 11:44:07.000000000","message":"recheck","commit_id":"7989fd2431b786019a0da90097966148d619ea5d"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"43ac6a74ca313fe9eb020ee633790f6f52b36c56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"199cb869_bf6cd794","updated":"2026-02-26 17:37:28.000000000","message":"run-NetApp CI","commit_id":"7989fd2431b786019a0da90097966148d619ea5d"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"b61d1e693b97637febd372348be2af78dbdf6bf8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6c7af47b_f288d211","updated":"2026-02-27 09:25:00.000000000","message":"run-NetApp CI","commit_id":"7989fd2431b786019a0da90097966148d619ea5d"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"165ad438d48f9074a1c6cf1a003260723179c887","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"96d7492e_9b1d8699","updated":"2026-03-03 12:56:53.000000000","message":"run-NetApp CI","commit_id":"7989fd2431b786019a0da90097966148d619ea5d"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"9fd3c5eec485fcef627e3490fb19f767fa0579b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"aaf6f37e_19a7b1be","updated":"2026-03-04 13:45:35.000000000","message":"run-NetApp CI","commit_id":"7989fd2431b786019a0da90097966148d619ea5d"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"723d366ea46d7ec94a10775a5e964b104093f922","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ad1d1a42_188aa8f0","updated":"2026-03-05 05:20:24.000000000","message":"Run-NetApp CI","commit_id":"dafcc76e362226909aee014f554e7c0f61b1e9e4"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"300bfcd9a34cd3ceb3c626f2b6b7631d3f109845","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"02c56ea2_2b197597","updated":"2026-03-06 16:10:51.000000000","message":"I have a bunch of minor questions and (potential) nitpicks here that would lead to a neutral review unless explained (I am not sure I actually think you need to change anything), but the code itself does not look bad.  I do wonder if inheritance could play a bigger role in the new decision tree, but maybe it would be overkill / hard to work in.\n\nThe -1 comes from this:\ncinder/tests/unit/volume/drivers/netapp/dataontap/client/test_client_cmode_rest_asar2.py 1141\nIt may be that there\u0027s nothing wrong with it, but the nature of it made me want it to at least be explained.","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"5f0498a37dcc8f7fae59af30e93665293b6de55b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5e1e1619_0efd7308","updated":"2026-03-05 14:11:44.000000000","message":"Run-NetApp CI","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"1f81345ffae220a8b558c52f0b12bdcdea3802d6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"57583221_d5472474","updated":"2026-03-10 23:00:02.000000000","message":"Hi Anoop!  It looks like you\u0027ve made some good changes to encourage consistency and whatnot.  I am leaving the -1 as it appears you may have accidentally deleted a test.  Please verify \u0026 let me know.  I will issue +1 once the test is back or you\u0027ve verified that it\u0027s not necessary. I marked the comment related to this back as \"unresolved\" so you can find it easily.","commit_id":"e0add1c6bfaa21766eaca6f4f8b12d3b85fce3c9"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"f72a093fc73fc8be3d489c6147d601085c694411","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a28a4668_25e52302","updated":"2026-03-09 18:51:44.000000000","message":"Reslved comments.","commit_id":"e0add1c6bfaa21766eaca6f4f8b12d3b85fce3c9"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"e77047783e0078b5b91aed7efbb604661991b782","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1b60910e_db2f3b44","updated":"2026-03-09 18:49:30.000000000","message":"Thank you @anthony.galica@hitachivantara.com for the review comments. I have addressed all the comments. Please take a look at them.","commit_id":"e0add1c6bfaa21766eaca6f4f8b12d3b85fce3c9"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"565960208d9102f3287acd2630558bbb4b7e17f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3496c7e1_4b19491a","updated":"2026-03-10 05:33:43.000000000","message":"recheck","commit_id":"e0add1c6bfaa21766eaca6f4f8b12d3b85fce3c9"},{"author":{"_account_id":38479,"name":"Medha Choudhary","display_name":"Medha Choudhary","email":"medhaj06@gmail.com","username":"medhac1403","status":"NetApp"},"change_message_id":"714261eac731ff266bc2f6f307b04be8eae8607a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"14a62e4e_52aca6f7","updated":"2026-03-11 03:05:22.000000000","message":"run-NetApp CI","commit_id":"e0add1c6bfaa21766eaca6f4f8b12d3b85fce3c9"},{"author":{"_account_id":38614,"name":"Sailaja Mada","display_name":"Sailaja Mada","email":"sailajam@netapp.com","username":"sailajam"},"change_message_id":"6e9f92902c84b6039f345c8e5f5022a454cfc316","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"94d5a4ee_af63c45a","updated":"2026-03-10 17:23:49.000000000","message":"run-NetApp CI","commit_id":"e0add1c6bfaa21766eaca6f4f8b12d3b85fce3c9"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"75b5689639f212417b14519abb30967d930afaa1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6fd58da3_8e8e0621","in_reply_to":"57583221_d5472474","updated":"2026-03-11 09:37:58.000000000","message":"Acknowledged","commit_id":"e0add1c6bfaa21766eaca6f4f8b12d3b85fce3c9"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"845e51b06d9a214abe3325f05736f757694d5031","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c1a71b94_84ce54ab","updated":"2026-03-13 05:51:53.000000000","message":"@rajatdhasmana@gmail.com, @rosmaita.fossdev@gmail.com, @jobernar@redhat.com - This patch has CI runs and ZUUL as well. Can you folks please take a look at this?","commit_id":"2351eb951d89ab4879efc3d8ed6d4d6e9680f630"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"24abcb66cd6b2485000eb2bdf755df51ab36a931","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f0b15e94_05ec1f2c","updated":"2026-03-11 16:16:46.000000000","message":"It looks like your test is passing even though the test itself still uses float.  +1 since the zuul failures seem to be due to traffic and the bad 3par test.","commit_id":"2351eb951d89ab4879efc3d8ed6d4d6e9680f630"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"34bbc389b96851786fbb7b181d99bd6ffd9f05ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fab7281a_55441a42","updated":"2026-03-12 05:36:24.000000000","message":"LGTM ..!","commit_id":"2351eb951d89ab4879efc3d8ed6d4d6e9680f630"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"65173067d1b9a67fdc64071e0e9bb1ddc7757c0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4e2d444c_89e6bc86","updated":"2026-03-13 05:37:35.000000000","message":"Run-NetApp-ASAr2 CI","commit_id":"2351eb951d89ab4879efc3d8ed6d4d6e9680f630"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"cbf788271bbca917831efe060cbf7e30c836c46d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e2613cb7_9d2e65f6","updated":"2026-03-11 10:55:24.000000000","message":"recheck","commit_id":"2351eb951d89ab4879efc3d8ed6d4d6e9680f630"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"c4587196605590e6cf19d94a916c98e8603d4ef0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e437d023_90462bc4","updated":"2026-03-11 13:50:52.000000000","message":"recheck","commit_id":"2351eb951d89ab4879efc3d8ed6d4d6e9680f630"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"75b5689639f212417b14519abb30967d930afaa1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"65a97822_b6696754","updated":"2026-03-11 09:37:58.000000000","message":"run-NetApp CI","commit_id":"2351eb951d89ab4879efc3d8ed6d4d6e9680f630"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"fa43a80d48b0269ce046d153351616464b45959b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c137793e_2475d43f","updated":"2026-03-12 09:18:29.000000000","message":"run-NetApp CI","commit_id":"2351eb951d89ab4879efc3d8ed6d4d6e9680f630"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"bd9b366fa3ee2daac441631bb10a35a9d77a8cf7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"16f27a0e_c74e1917","updated":"2026-03-12 12:36:10.000000000","message":"upstream-check-cinder-ASAr2","commit_id":"2351eb951d89ab4879efc3d8ed6d4d6e9680f630"},{"author":{"_account_id":38479,"name":"Medha Choudhary","display_name":"Medha Choudhary","email":"medhaj06@gmail.com","username":"medhac1403","status":"NetApp"},"change_message_id":"d18b59f728b78b001430cd08fba0a513f016e88a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"829563e8_b221df95","updated":"2026-03-18 11:47:06.000000000","message":"Run Netapp-CI","commit_id":"e12e416e433e77c2bf866318cd69d3dd1a164d09"},{"author":{"_account_id":38479,"name":"Medha Choudhary","display_name":"Medha Choudhary","email":"medhaj06@gmail.com","username":"medhac1403","status":"NetApp"},"change_message_id":"875b8969bb333f76b98645118ae06f07d0ae5bac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b008d17e_8bfcf1da","updated":"2026-03-18 07:50:32.000000000","message":"Run Netapp-CI","commit_id":"e12e416e433e77c2bf866318cd69d3dd1a164d09"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"9d531c95bec24b7ad4576fb0ce1c5d5460415483","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"00e4720e_d5df40ac","updated":"2026-03-20 07:20:27.000000000","message":"Run-NetApp CI","commit_id":"e12e416e433e77c2bf866318cd69d3dd1a164d09"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"d3eaad37d052c20b4336087176f7acb84a0ecde6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"02e10a91_816b1018","updated":"2026-03-20 07:16:58.000000000","message":"Run-NetApp CI","commit_id":"e12e416e433e77c2bf866318cd69d3dd1a164d09"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"7223acff84bbba261a1694acb979ad5c26e92051","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0aed4965_c5f1dd31","updated":"2026-03-20 09:57:38.000000000","message":"Run-NetApp CI","commit_id":"e12e416e433e77c2bf866318cd69d3dd1a164d09"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"948d9b068aeb239da79d9f3884d3a39deb7f64ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5c24ea7e_14b0c0af","updated":"2026-03-20 10:04:43.000000000","message":"Run-NetApp CI","commit_id":"e12e416e433e77c2bf866318cd69d3dd1a164d09"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"e56a36cf22136da9be292884ad5f9beb3c6c1f87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4527fdaa_9602cc68","updated":"2026-03-17 10:50:22.000000000","message":"Run-NetApp-ASAr2 CI","commit_id":"e12e416e433e77c2bf866318cd69d3dd1a164d09"},{"author":{"_account_id":38479,"name":"Medha Choudhary","display_name":"Medha Choudhary","email":"medhaj06@gmail.com","username":"medhac1403","status":"NetApp"},"change_message_id":"21c313ff366c223a6acf9123f3329c4070be1eac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"929575d0_a97310c5","updated":"2026-03-18 07:34:16.000000000","message":"recheck","commit_id":"e12e416e433e77c2bf866318cd69d3dd1a164d09"},{"author":{"_account_id":38479,"name":"Medha Choudhary","display_name":"Medha Choudhary","email":"medhaj06@gmail.com","username":"medhac1403","status":"NetApp"},"change_message_id":"573b16402de163d67c07f933aa9eefd0a2ccab97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"db15d76c_dc91e59e","updated":"2026-03-18 11:28:56.000000000","message":"recheck","commit_id":"e12e416e433e77c2bf866318cd69d3dd1a164d09"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"1adb78a359e304cf158f86f42f345720f33b27f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7e60a524_988d1a6d","updated":"2026-03-17 14:08:45.000000000","message":"run-NetApp CI","commit_id":"e12e416e433e77c2bf866318cd69d3dd1a164d09"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"6d406ac34a622e9ab19312495c1c693db3f9e2ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f78b3162_6696df8e","updated":"2026-03-20 07:13:49.000000000","message":"run-NetApp CI","commit_id":"e12e416e433e77c2bf866318cd69d3dd1a164d09"},{"author":{"_account_id":38373,"name":"Manideep","display_name":"Manideep","email":"manideep.openstack@gmail.com","username":"manideepn","status":"NetApp"},"change_message_id":"1fe4dd26361b00a59099e16d48cc43a39d3a4de5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f8daa8e9_cb6dd210","updated":"2026-03-18 12:05:39.000000000","message":"run-NetApp CI","commit_id":"e12e416e433e77c2bf866318cd69d3dd1a164d09"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"360a712b32597f2e092daaaf416f8d0b8271bfed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"673146b2_2c266fd6","updated":"2026-04-28 21:35:56.000000000","message":"Please resolve the merge conflict","commit_id":"185c3fdcd8257eef9e4bcc117dfbba62bbebcf29"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"b2397b6b49f09770c3622128ec85764fda3729e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6f25edf1_18934540","updated":"2026-04-17 15:41:09.000000000","message":"Quite a few changes all in one here, all documented in the release note.  It would be nice to list them in the commit message (if another change comes) but that\u0027s minor.  Code looks okay, tests pass.","commit_id":"185c3fdcd8257eef9e4bcc117dfbba62bbebcf29"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"36fa859aa54ee0a5cf8c793c8f6b65a1fcb01811","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2872fa40_67bde03e","updated":"2026-04-17 14:31:34.000000000","message":"Restoring +1","commit_id":"185c3fdcd8257eef9e4bcc117dfbba62bbebcf29"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"e578e3655900dfbad50392ba97c1820ca2ea9114","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"21169026_6544945a","updated":"2026-04-13 05:29:45.000000000","message":"Run-NetApp CI","commit_id":"185c3fdcd8257eef9e4bcc117dfbba62bbebcf29"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"9f8225f11a7b5dfd9518516a5fcb05fa55d2d56a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"475d4e93_385ab243","updated":"2026-04-27 10:29:00.000000000","message":"Run-NetApp CI","commit_id":"185c3fdcd8257eef9e4bcc117dfbba62bbebcf29"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"162f8f71def7f167fe34b792ab0198d106b6c446","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b15a65bc_937e902a","updated":"2026-04-10 08:24:58.000000000","message":"recheck","commit_id":"185c3fdcd8257eef9e4bcc117dfbba62bbebcf29"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"1ae1b4ec8e9b3809996e1bef6b40ecff4af72eac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"fcb1d812_c4646a74","updated":"2026-04-10 05:12:44.000000000","message":"run-NetApp CI","commit_id":"185c3fdcd8257eef9e4bcc117dfbba62bbebcf29"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"3d51b16af917d1bf8b73ec82cfd54891d0f5a299","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"68871f5a_8559ad32","in_reply_to":"673146b2_2c266fd6","updated":"2026-05-04 17:39:13.000000000","message":"Hi @eharney@redhat.com, @rosmaita.fossdev@gmail.com - I have resolved the merge conflicts on this PR. Will be waiting for Zuul build success.","commit_id":"185c3fdcd8257eef9e4bcc117dfbba62bbebcf29"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"938e633560da82553f9327a6ae29e61057028246","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"fb72aec6_2e5c3320","updated":"2026-05-06 06:05:10.000000000","message":"LGTM ..!","commit_id":"19c40f9de9bd96687b18d339ae15bf4a76c5c484"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"1a7c04059caeac59aa8928c298e8fe05278db9f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b90884ec_c4702345","updated":"2026-05-06 14:56:26.000000000","message":"Restoring +1","commit_id":"19c40f9de9bd96687b18d339ae15bf4a76c5c484"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"41d568682219db3e0d51390a821aa2ecc6254605","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1d1ed423_73c81ff5","updated":"2026-05-06 14:58:22.000000000","message":"merge conflict resolved, restoring +2","commit_id":"19c40f9de9bd96687b18d339ae15bf4a76c5c484"}],"cinder/tests/unit/volume/drivers/netapp/dataontap/client/test_client_cmode_rest_asar2.py":[{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"300bfcd9a34cd3ceb3c626f2b6b7631d3f109845","unresolved":true,"context_lines":[{"line_number":946,"context_line":"                    \u0027aggregates\u0027: ["},{"line_number":947,"context_line":"                        {\u0027name\u0027: \u0027aggr1\u0027},"},{"line_number":948,"context_line":"                        {\u0027name\u0027: \u0027aggr2\u0027},"},{"line_number":949,"context_line":"                        {\u0027name\u0027: None},"},{"line_number":950,"context_line":"                    ],"},{"line_number":951,"context_line":"                },"},{"line_number":952,"context_line":"                {"}],"source_content_type":"text/x-python","patch_set":4,"id":"b27e8287_5eb16a49","line":949,"updated":"2026-03-06 16:10:51.000000000","message":"Should this maybe be broken down into two tests?\n i.e.:\n First test: make sure names are properly returned\n Second test: make sure that a name of None is ignored and other names are returned\n \nMaybe it\u0027s taking things too far to do that, but this test wouldn\u0027t catch a bug where the last entry in the aggregates list is skipped.","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"b617d0d0f2be9d7259abab098a3cec2834290413","unresolved":false,"context_lines":[{"line_number":946,"context_line":"                    \u0027aggregates\u0027: ["},{"line_number":947,"context_line":"                        {\u0027name\u0027: \u0027aggr1\u0027},"},{"line_number":948,"context_line":"                        {\u0027name\u0027: \u0027aggr2\u0027},"},{"line_number":949,"context_line":"                        {\u0027name\u0027: None},"},{"line_number":950,"context_line":"                    ],"},{"line_number":951,"context_line":"                },"},{"line_number":952,"context_line":"                {"}],"source_content_type":"text/x-python","patch_set":4,"id":"b3cc5afc_a196f792","line":949,"in_reply_to":"545b9720_c45529fa","updated":"2026-03-10 05:34:15.000000000","message":"Done","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"e77047783e0078b5b91aed7efbb604661991b782","unresolved":true,"context_lines":[{"line_number":946,"context_line":"                    \u0027aggregates\u0027: ["},{"line_number":947,"context_line":"                        {\u0027name\u0027: \u0027aggr1\u0027},"},{"line_number":948,"context_line":"                        {\u0027name\u0027: \u0027aggr2\u0027},"},{"line_number":949,"context_line":"                        {\u0027name\u0027: None},"},{"line_number":950,"context_line":"                    ],"},{"line_number":951,"context_line":"                },"},{"line_number":952,"context_line":"                {"}],"source_content_type":"text/x-python","patch_set":4,"id":"545b9720_c45529fa","line":949,"in_reply_to":"b27e8287_5eb16a49","updated":"2026-03-09 18:49:30.000000000","message":"In case the aggregate returns none (although we do not expect it to be returned). We will have some additional work on ASAr2 and we can club the UT changes in those patches? Let me know if that works.","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"1f81345ffae220a8b558c52f0b12bdcdea3802d6","unresolved":false,"context_lines":[{"line_number":946,"context_line":"                    \u0027aggregates\u0027: ["},{"line_number":947,"context_line":"                        {\u0027name\u0027: \u0027aggr1\u0027},"},{"line_number":948,"context_line":"                        {\u0027name\u0027: \u0027aggr2\u0027},"},{"line_number":949,"context_line":"                        {\u0027name\u0027: None},"},{"line_number":950,"context_line":"                    ],"},{"line_number":951,"context_line":"                },"},{"line_number":952,"context_line":"                {"}],"source_content_type":"text/x-python","patch_set":4,"id":"15412034_af96f858","line":949,"in_reply_to":"b3cc5afc_a196f792","updated":"2026-03-10 23:00:02.000000000","message":"I think that\u0027s probably ok, personally.","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"1f81345ffae220a8b558c52f0b12bdcdea3802d6","unresolved":false,"context_lines":[{"line_number":946,"context_line":"                    \u0027aggregates\u0027: ["},{"line_number":947,"context_line":"                        {\u0027name\u0027: \u0027aggr1\u0027},"},{"line_number":948,"context_line":"                        {\u0027name\u0027: \u0027aggr2\u0027},"},{"line_number":949,"context_line":"                        {\u0027name\u0027: None},"},{"line_number":950,"context_line":"                    ],"},{"line_number":951,"context_line":"                },"},{"line_number":952,"context_line":"                {"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f14dca6_a9fe0622","line":949,"in_reply_to":"b3cc5afc_a196f792","updated":"2026-03-10 23:00:02.000000000","message":"Yeah, that\u0027ll probably work.","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"300bfcd9a34cd3ceb3c626f2b6b7631d3f109845","unresolved":true,"context_lines":[{"line_number":984,"context_line":""},{"line_number":985,"context_line":"        result \u003d self.client.get_vserver_aggregates()"},{"line_number":986,"context_line":""},{"line_number":987,"context_line":"        self.assertEqual([\u0027aggrX\u0027], result)"},{"line_number":988,"context_line":"        mock_send_request.assert_called_once_with("},{"line_number":989,"context_line":"            \u0027/svm/svms\u0027,"},{"line_number":990,"context_line":"            \u0027get\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7c5e9782_e6628683","line":987,"updated":"2026-03-06 16:10:51.000000000","message":"Shouldn\u0027t this be returning empty according to the test name \u0026 v-server name above vs. the records?","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"e77047783e0078b5b91aed7efbb604661991b782","unresolved":true,"context_lines":[{"line_number":984,"context_line":""},{"line_number":985,"context_line":"        result \u003d self.client.get_vserver_aggregates()"},{"line_number":986,"context_line":""},{"line_number":987,"context_line":"        self.assertEqual([\u0027aggrX\u0027], result)"},{"line_number":988,"context_line":"        mock_send_request.assert_called_once_with("},{"line_number":989,"context_line":"            \u0027/svm/svms\u0027,"},{"line_number":990,"context_line":"            \u0027get\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba65efc1_315c05f2","line":987,"in_reply_to":"7c5e9782_e6628683","updated":"2026-03-09 18:49:30.000000000","message":"Have renamed the test to better represent what it is testing.","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"b617d0d0f2be9d7259abab098a3cec2834290413","unresolved":false,"context_lines":[{"line_number":984,"context_line":""},{"line_number":985,"context_line":"        result \u003d self.client.get_vserver_aggregates()"},{"line_number":986,"context_line":""},{"line_number":987,"context_line":"        self.assertEqual([\u0027aggrX\u0027], result)"},{"line_number":988,"context_line":"        mock_send_request.assert_called_once_with("},{"line_number":989,"context_line":"            \u0027/svm/svms\u0027,"},{"line_number":990,"context_line":"            \u0027get\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9b3087d2_3489ff1d","line":987,"in_reply_to":"ba65efc1_315c05f2","updated":"2026-03-10 05:34:15.000000000","message":"Done","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"300bfcd9a34cd3ceb3c626f2b6b7631d3f109845","unresolved":true,"context_lines":[{"line_number":1083,"context_line":"        self.assertRaises("},{"line_number":1084,"context_line":"            netapp_utils.NetAppDriverException,"},{"line_number":1085,"context_line":"            self.client.get_storage_availability_zones,"},{"line_number":1086,"context_line":"        )"},{"line_number":1087,"context_line":""},{"line_number":1088,"context_line":"    @mock.patch.object(client_cmode_rest_asar2.RestClientASAr2,"},{"line_number":1089,"context_line":"                       \u0027send_request\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f3dd3f7_8e970ad0","line":1086,"updated":"2026-03-06 16:10:51.000000000","message":"Should you have ```assert_called_once_with``` here to be consistent?","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"e77047783e0078b5b91aed7efbb604661991b782","unresolved":false,"context_lines":[{"line_number":1083,"context_line":"        self.assertRaises("},{"line_number":1084,"context_line":"            netapp_utils.NetAppDriverException,"},{"line_number":1085,"context_line":"            self.client.get_storage_availability_zones,"},{"line_number":1086,"context_line":"        )"},{"line_number":1087,"context_line":""},{"line_number":1088,"context_line":"    @mock.patch.object(client_cmode_rest_asar2.RestClientASAr2,"},{"line_number":1089,"context_line":"                       \u0027send_request\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"60212d80_c00e290b","line":1086,"in_reply_to":"3f3dd3f7_8e970ad0","updated":"2026-03-09 18:49:30.000000000","message":"Acknowledged","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"300bfcd9a34cd3ceb3c626f2b6b7631d3f109845","unresolved":true,"context_lines":[{"line_number":1094,"context_line":"        self.assertRaises("},{"line_number":1095,"context_line":"            netapp_utils.NetAppDriverException,"},{"line_number":1096,"context_line":"            self.client.get_storage_availability_zones,"},{"line_number":1097,"context_line":"        )"},{"line_number":1098,"context_line":""},{"line_number":1099,"context_line":"    @mock.patch.object(client_cmode_rest_asar2.RestClientASAr2,"},{"line_number":1100,"context_line":"                       \u0027send_request\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"6e5b2ebc_9ee95377","line":1097,"updated":"2026-03-06 16:10:51.000000000","message":"Should you have ```assert_called_once_with``` here to be consistent?","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"e77047783e0078b5b91aed7efbb604661991b782","unresolved":false,"context_lines":[{"line_number":1094,"context_line":"        self.assertRaises("},{"line_number":1095,"context_line":"            netapp_utils.NetAppDriverException,"},{"line_number":1096,"context_line":"            self.client.get_storage_availability_zones,"},{"line_number":1097,"context_line":"        )"},{"line_number":1098,"context_line":""},{"line_number":1099,"context_line":"    @mock.patch.object(client_cmode_rest_asar2.RestClientASAr2,"},{"line_number":1100,"context_line":"                       \u0027send_request\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da223f6b_5d7ad3c0","line":1097,"in_reply_to":"6e5b2ebc_9ee95377","updated":"2026-03-09 18:49:30.000000000","message":"Acknowledged","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"300bfcd9a34cd3ceb3c626f2b6b7631d3f109845","unresolved":true,"context_lines":[{"line_number":1138,"context_line":"        result \u003d self.client.get_namespace_sizes_by_svm()"},{"line_number":1139,"context_line":""},{"line_number":1140,"context_line":"        expected \u003d ["},{"line_number":1141,"context_line":"            {\u0027path\u0027: \u0027ns1\u0027, \u0027size\u0027: 1234.0},"},{"line_number":1142,"context_line":"            {\u0027path\u0027: \u0027ns2\u0027, \u0027size\u0027: 5678.0},"},{"line_number":1143,"context_line":"        ]"},{"line_number":1144,"context_line":"        self.assertEqual(expected, result)"}],"source_content_type":"text/x-python","patch_set":4,"id":"4c595bfe_86df46f3","line":1141,"updated":"2026-03-06 16:10:51.000000000","message":"This is a potential red flag to me - why is the ```space``` changing from int to float as a ```size```?\n\nParticularly when another test below shows that ```provisioned-size``` is an int.","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"1f81345ffae220a8b558c52f0b12bdcdea3802d6","unresolved":true,"context_lines":[{"line_number":1138,"context_line":"        result \u003d self.client.get_namespace_sizes_by_svm()"},{"line_number":1139,"context_line":""},{"line_number":1140,"context_line":"        expected \u003d ["},{"line_number":1141,"context_line":"            {\u0027path\u0027: \u0027ns1\u0027, \u0027size\u0027: 1234.0},"},{"line_number":1142,"context_line":"            {\u0027path\u0027: \u0027ns2\u0027, \u0027size\u0027: 5678.0},"},{"line_number":1143,"context_line":"        ]"},{"line_number":1144,"context_line":"        self.assertEqual(expected, result)"}],"source_content_type":"text/x-python","patch_set":4,"id":"f2e5fa87_edf80f63","line":1141,"in_reply_to":"4c0048a2_5c399e60","updated":"2026-03-10 23:00:02.000000000","message":"I see the code change (definitely a good thing), but it looks like the test was removed and replaced with a different test.\n\nThe test was named ```test_get_namespace_sizes_by_svm_with_records``` and now there\u0027s a different new test that does something else named ```test_get_namespace_sizes_by_svm_invalid_size``` in its place.\n\nI\u0027m unresolving this as I don\u0027t know if it was intentional to remove the test altogether.","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"e77047783e0078b5b91aed7efbb604661991b782","unresolved":true,"context_lines":[{"line_number":1138,"context_line":"        result \u003d self.client.get_namespace_sizes_by_svm()"},{"line_number":1139,"context_line":""},{"line_number":1140,"context_line":"        expected \u003d ["},{"line_number":1141,"context_line":"            {\u0027path\u0027: \u0027ns1\u0027, \u0027size\u0027: 1234.0},"},{"line_number":1142,"context_line":"            {\u0027path\u0027: \u0027ns2\u0027, \u0027size\u0027: 5678.0},"},{"line_number":1143,"context_line":"        ]"},{"line_number":1144,"context_line":"        self.assertEqual(expected, result)"}],"source_content_type":"text/x-python","patch_set":4,"id":"e53ff032_d343ecc6","line":1141,"in_reply_to":"4c595bfe_86df46f3","updated":"2026-03-09 18:49:30.000000000","message":"Fixed in the code and in the test.","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"b617d0d0f2be9d7259abab098a3cec2834290413","unresolved":false,"context_lines":[{"line_number":1138,"context_line":"        result \u003d self.client.get_namespace_sizes_by_svm()"},{"line_number":1139,"context_line":""},{"line_number":1140,"context_line":"        expected \u003d ["},{"line_number":1141,"context_line":"            {\u0027path\u0027: \u0027ns1\u0027, \u0027size\u0027: 1234.0},"},{"line_number":1142,"context_line":"            {\u0027path\u0027: \u0027ns2\u0027, \u0027size\u0027: 5678.0},"},{"line_number":1143,"context_line":"        ]"},{"line_number":1144,"context_line":"        self.assertEqual(expected, result)"}],"source_content_type":"text/x-python","patch_set":4,"id":"4c0048a2_5c399e60","line":1141,"in_reply_to":"e53ff032_d343ecc6","updated":"2026-03-10 05:34:15.000000000","message":"Done","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"98131ce53e916c9405b04d2b7b53db1c6d6e74c7","unresolved":false,"context_lines":[{"line_number":1138,"context_line":"        result \u003d self.client.get_namespace_sizes_by_svm()"},{"line_number":1139,"context_line":""},{"line_number":1140,"context_line":"        expected \u003d ["},{"line_number":1141,"context_line":"            {\u0027path\u0027: \u0027ns1\u0027, \u0027size\u0027: 1234.0},"},{"line_number":1142,"context_line":"            {\u0027path\u0027: \u0027ns2\u0027, \u0027size\u0027: 5678.0},"},{"line_number":1143,"context_line":"        ]"},{"line_number":1144,"context_line":"        self.assertEqual(expected, result)"}],"source_content_type":"text/x-python","patch_set":4,"id":"2be79a51_70762748","line":1141,"in_reply_to":"f2e5fa87_edf80f63","updated":"2026-03-11 06:37:31.000000000","message":"Thanks @anthony.galica@hitachivantara.com for pointing out. I have now added both the test cases.","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"300bfcd9a34cd3ceb3c626f2b6b7631d3f109845","unresolved":true,"context_lines":[{"line_number":1166,"context_line":"                {"},{"line_number":1167,"context_line":"                    \u0027name\u0027: \u0027su2\u0027,"},{"line_number":1168,"context_line":"                    \u0027uuid\u0027: \u0027uuid-2\u0027,"},{"line_number":1169,"context_line":"                    \u0027space\u0027: {\u0027size\u0027: \u00275678\u0027},"},{"line_number":1170,"context_line":"                },"},{"line_number":1171,"context_line":"            ],"},{"line_number":1172,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":4,"id":"088319b4_6f6dbfb3","line":1169,"updated":"2026-03-06 16:10:51.000000000","message":"I guess the backend API might return a string or an int?  Should this be called out as its own test?","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"e77047783e0078b5b91aed7efbb604661991b782","unresolved":true,"context_lines":[{"line_number":1166,"context_line":"                {"},{"line_number":1167,"context_line":"                    \u0027name\u0027: \u0027su2\u0027,"},{"line_number":1168,"context_line":"                    \u0027uuid\u0027: \u0027uuid-2\u0027,"},{"line_number":1169,"context_line":"                    \u0027space\u0027: {\u0027size\u0027: \u00275678\u0027},"},{"line_number":1170,"context_line":"                },"},{"line_number":1171,"context_line":"            ],"},{"line_number":1172,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":4,"id":"406890d1_85ef4f87","line":1169,"in_reply_to":"088319b4_6f6dbfb3","updated":"2026-03-09 18:49:30.000000000","message":"Fixed it to represent int.","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"b617d0d0f2be9d7259abab098a3cec2834290413","unresolved":false,"context_lines":[{"line_number":1166,"context_line":"                {"},{"line_number":1167,"context_line":"                    \u0027name\u0027: \u0027su2\u0027,"},{"line_number":1168,"context_line":"                    \u0027uuid\u0027: \u0027uuid-2\u0027,"},{"line_number":1169,"context_line":"                    \u0027space\u0027: {\u0027size\u0027: \u00275678\u0027},"},{"line_number":1170,"context_line":"                },"},{"line_number":1171,"context_line":"            ],"},{"line_number":1172,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":4,"id":"b01c8048_e0fb5260","line":1169,"in_reply_to":"406890d1_85ef4f87","updated":"2026-03-10 05:34:15.000000000","message":"Done","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"24abcb66cd6b2485000eb2bdf755df51ab36a931","unresolved":true,"context_lines":[{"line_number":1182,"context_line":"        result \u003d self.client.get_namespace_sizes_by_svm()"},{"line_number":1183,"context_line":""},{"line_number":1184,"context_line":"        expected \u003d ["},{"line_number":1185,"context_line":"            {\u0027path\u0027: \u0027ns1\u0027, \u0027size\u0027: 1234.0},"},{"line_number":1186,"context_line":"            {\u0027path\u0027: \u0027ns2\u0027, \u0027size\u0027: 5678.0},"},{"line_number":1187,"context_line":"        ]"},{"line_number":1188,"context_line":"        self.assertEqual(expected, result)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fbed8872_be80f4d0","line":1185,"updated":"2026-03-11 16:16:46.000000000","message":"Still has the floating point here, but I know it was solved in the actual code base so I won\u0027t ding you for it as the test passes. I\u0027d change these to int personally, but I\u0027ll give you a +1 since the code is using int appropriately.","commit_id":"2351eb951d89ab4879efc3d8ed6d4d6e9680f630"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"5d02363991c7a8b5c08246725efd53c8786111da","unresolved":false,"context_lines":[{"line_number":1182,"context_line":"        result \u003d self.client.get_namespace_sizes_by_svm()"},{"line_number":1183,"context_line":""},{"line_number":1184,"context_line":"        expected \u003d ["},{"line_number":1185,"context_line":"            {\u0027path\u0027: \u0027ns1\u0027, \u0027size\u0027: 1234.0},"},{"line_number":1186,"context_line":"            {\u0027path\u0027: \u0027ns2\u0027, \u0027size\u0027: 5678.0},"},{"line_number":1187,"context_line":"        ]"},{"line_number":1188,"context_line":"        self.assertEqual(expected, result)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5d8677e5_dc612933","line":1185,"in_reply_to":"fbed8872_be80f4d0","updated":"2026-03-12 09:18:08.000000000","message":"Thanks agalica. I wanted to keep the floating values to test the code with both types. Hence keeping the float value in test after making code changes was intentional.","commit_id":"2351eb951d89ab4879efc3d8ed6d4d6e9680f630"}],"cinder/tests/unit/volume/drivers/netapp/dataontap/test_block_cmode.py":[{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"300bfcd9a34cd3ceb3c626f2b6b7631d3f109845","unresolved":true,"context_lines":[{"line_number":2008,"context_line":"        \"\"\"Gracefully handle capacity dicts missing size fields.\"\"\""},{"line_number":2009,"context_line":"        aggregates \u003d [\u0027aggr1\u0027, \u0027aggr2\u0027]"},{"line_number":2010,"context_line":"        aggr_capacities \u003d {"},{"line_number":2011,"context_line":"            \u0027aggr1\u0027: {\u0027size-total\u0027: 5 * units.Gi},  # missing size-available"},{"line_number":2012,"context_line":"            \u0027aggr2\u0027: {\u0027size-available\u0027: 3 * units.Gi},  # missing size-total"},{"line_number":2013,"context_line":"        }"},{"line_number":2014,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"e77576e7_2e113cbc","line":2011,"updated":"2026-03-06 16:10:51.000000000","message":"Should there be a test with all keys missing (maybe that isn\u0027t possible for the API to return, and these half-responses are?)","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"b617d0d0f2be9d7259abab098a3cec2834290413","unresolved":false,"context_lines":[{"line_number":2008,"context_line":"        \"\"\"Gracefully handle capacity dicts missing size fields.\"\"\""},{"line_number":2009,"context_line":"        aggregates \u003d [\u0027aggr1\u0027, \u0027aggr2\u0027]"},{"line_number":2010,"context_line":"        aggr_capacities \u003d {"},{"line_number":2011,"context_line":"            \u0027aggr1\u0027: {\u0027size-total\u0027: 5 * units.Gi},  # missing size-available"},{"line_number":2012,"context_line":"            \u0027aggr2\u0027: {\u0027size-available\u0027: 3 * units.Gi},  # missing size-total"},{"line_number":2013,"context_line":"        }"},{"line_number":2014,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"cc5eb299_7de48508","line":2011,"in_reply_to":"56886827_d8cfd354","updated":"2026-03-10 05:34:15.000000000","message":"Done","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"e77047783e0078b5b91aed7efbb604661991b782","unresolved":true,"context_lines":[{"line_number":2008,"context_line":"        \"\"\"Gracefully handle capacity dicts missing size fields.\"\"\""},{"line_number":2009,"context_line":"        aggregates \u003d [\u0027aggr1\u0027, \u0027aggr2\u0027]"},{"line_number":2010,"context_line":"        aggr_capacities \u003d {"},{"line_number":2011,"context_line":"            \u0027aggr1\u0027: {\u0027size-total\u0027: 5 * units.Gi},  # missing size-available"},{"line_number":2012,"context_line":"            \u0027aggr2\u0027: {\u0027size-available\u0027: 3 * units.Gi},  # missing size-total"},{"line_number":2013,"context_line":"        }"},{"line_number":2014,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"56886827_d8cfd354","line":2011,"in_reply_to":"e77576e7_2e113cbc","updated":"2026-03-09 18:49:30.000000000","message":"I\u0027d say that missing all the keys in ONTAP API is not going to happen. With space values, we have seen in some cases some space attributes have been missing from past experience. This test ensures that such a scenario is handled gracefully.","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"}],"cinder/tests/unit/volume/drivers/netapp/dataontap/test_nvme_library.py":[{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"300bfcd9a34cd3ceb3c626f2b6b7631d3f109845","unresolved":true,"context_lines":[{"line_number":1264,"context_line":""},{"line_number":1265,"context_line":"        result \u003d self.library._get_disaggregated_capacity()"},{"line_number":1266,"context_line":""},{"line_number":1267,"context_line":"        self.assertEqual(0, result[\u0027size-total\u0027])"},{"line_number":1268,"context_line":"        self.assertEqual(0, result[\u0027size-available\u0027])"},{"line_number":1269,"context_line":""},{"line_number":1270,"context_line":"    def test_get_disaggregated_provisioned_capacity_sums_sizes(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7774cbea_85dced4a","line":1267,"updated":"2026-03-06 16:10:51.000000000","message":"IS there a reason why the behavior here seems to differ from some of the other disaggregated capacities?  i.e. in several other tests it expects that bad data is more or less ignored, so I\u0027d think that we\u0027d see 5GB/3GB as the results for total/available if it behaved similarly.","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"e77047783e0078b5b91aed7efbb604661991b782","unresolved":true,"context_lines":[{"line_number":1264,"context_line":""},{"line_number":1265,"context_line":"        result \u003d self.library._get_disaggregated_capacity()"},{"line_number":1266,"context_line":""},{"line_number":1267,"context_line":"        self.assertEqual(0, result[\u0027size-total\u0027])"},{"line_number":1268,"context_line":"        self.assertEqual(0, result[\u0027size-available\u0027])"},{"line_number":1269,"context_line":""},{"line_number":1270,"context_line":"    def test_get_disaggregated_provisioned_capacity_sums_sizes(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"e3ff6935_45c7f5b9","line":1267,"in_reply_to":"7774cbea_85dced4a","updated":"2026-03-09 18:49:30.000000000","message":"The tests where bad data is ignored are modeling per‑record invalidity: skip the broken record, aggregate the good ones.\nget_disaggregated_capacity_with_invalid_aggregate_data is modeling a structurally invalid aggregate: in that case, the driver intentionally does not try to salvage partial numbers and instead returns a safe default which in this case is 0 to avoid misrepresenting capacity. We can remove this test if required, but this is just a safety check UT.","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"b617d0d0f2be9d7259abab098a3cec2834290413","unresolved":false,"context_lines":[{"line_number":1264,"context_line":""},{"line_number":1265,"context_line":"        result \u003d self.library._get_disaggregated_capacity()"},{"line_number":1266,"context_line":""},{"line_number":1267,"context_line":"        self.assertEqual(0, result[\u0027size-total\u0027])"},{"line_number":1268,"context_line":"        self.assertEqual(0, result[\u0027size-available\u0027])"},{"line_number":1269,"context_line":""},{"line_number":1270,"context_line":"    def test_get_disaggregated_provisioned_capacity_sums_sizes(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"e80a9546_39a774bf","line":1267,"in_reply_to":"e3ff6935_45c7f5b9","updated":"2026-03-10 05:34:15.000000000","message":"Done","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"1f81345ffae220a8b558c52f0b12bdcdea3802d6","unresolved":false,"context_lines":[{"line_number":1264,"context_line":""},{"line_number":1265,"context_line":"        result \u003d self.library._get_disaggregated_capacity()"},{"line_number":1266,"context_line":""},{"line_number":1267,"context_line":"        self.assertEqual(0, result[\u0027size-total\u0027])"},{"line_number":1268,"context_line":"        self.assertEqual(0, result[\u0027size-available\u0027])"},{"line_number":1269,"context_line":""},{"line_number":1270,"context_line":"    def test_get_disaggregated_provisioned_capacity_sums_sizes(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"6ffae592_75b5e9e9","line":1267,"in_reply_to":"e80a9546_39a774bf","updated":"2026-03-10 23:00:02.000000000","message":"Understood, thanks for explanation.","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"}],"cinder/volume/drivers/netapp/dataontap/block_cmode.py":[{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"300bfcd9a34cd3ceb3c626f2b6b7631d3f109845","unresolved":true,"context_lines":[{"line_number":581,"context_line":"        size_total \u003d 0"},{"line_number":582,"context_line":"        size_available \u003d 0"},{"line_number":583,"context_line":"        for caps in aggr_capacities.values():"},{"line_number":584,"context_line":"            size_total +\u003d int(caps.get(\u0027size-total\u0027, 0))"},{"line_number":585,"context_line":"            size_available +\u003d int(caps.get(\u0027size-available\u0027, 0))"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"        return {\u0027size-total\u0027: size_total, \u0027size-available\u0027: size_available}"}],"source_content_type":"text/x-python","patch_set":4,"id":"f4f9df69_ec840c05","line":584,"updated":"2026-03-06 16:10:51.000000000","message":"Is it possible for these to have a ```TypeError``` or ```ValueError``` like in ```_get_disaggregated_provisioned_capacity```?","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"e77047783e0078b5b91aed7efbb604661991b782","unresolved":false,"context_lines":[{"line_number":581,"context_line":"        size_total \u003d 0"},{"line_number":582,"context_line":"        size_available \u003d 0"},{"line_number":583,"context_line":"        for caps in aggr_capacities.values():"},{"line_number":584,"context_line":"            size_total +\u003d int(caps.get(\u0027size-total\u0027, 0))"},{"line_number":585,"context_line":"            size_available +\u003d int(caps.get(\u0027size-available\u0027, 0))"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"        return {\u0027size-total\u0027: size_total, \u0027size-available\u0027: size_available}"}],"source_content_type":"text/x-python","patch_set":4,"id":"3d06d981_afb33412","line":584,"in_reply_to":"f4f9df69_ec840c05","updated":"2026-03-09 18:49:30.000000000","message":"Done","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"}],"cinder/volume/drivers/netapp/dataontap/client/client_cmode_rest_asar2.py":[{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"300bfcd9a34cd3ceb3c626f2b6b7631d3f109845","unresolved":true,"context_lines":[{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        response \u003d self.send_request(\u0027/storage/luns/\u0027, \u0027get\u0027, query\u003dquery)"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        if response[\u0027num_records\u0027] \u003d\u003d \u00270\u0027:"},{"line_number":293,"context_line":"            return []"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        luns \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"d767ba34_4fd24cdf","line":292,"updated":"2026-03-06 16:10:51.000000000","message":"Are we sure this will be \u00270\u0027 and not 0?  Don\u0027t recall seeing a UT, but might have missed it.","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"b617d0d0f2be9d7259abab098a3cec2834290413","unresolved":false,"context_lines":[{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        response \u003d self.send_request(\u0027/storage/luns/\u0027, \u0027get\u0027, query\u003dquery)"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        if response[\u0027num_records\u0027] \u003d\u003d \u00270\u0027:"},{"line_number":293,"context_line":"            return []"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        luns \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"4c563713_28ca0c66","line":292,"in_reply_to":"3e72f897_e92f3496","updated":"2026-03-10 05:34:15.000000000","message":"Done","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"e77047783e0078b5b91aed7efbb604661991b782","unresolved":true,"context_lines":[{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        response \u003d self.send_request(\u0027/storage/luns/\u0027, \u0027get\u0027, query\u003dquery)"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        if response[\u0027num_records\u0027] \u003d\u003d \u00270\u0027:"},{"line_number":293,"context_line":"            return []"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"        luns \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"3e72f897_e92f3496","line":292,"in_reply_to":"d767ba34_4fd24cdf","updated":"2026-03-09 18:49:30.000000000","message":"Have made it consistent now. API generally responds with int 0 but the \u00270\u0027 handling is additionally to ensure i case it returns a string value.","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"300bfcd9a34cd3ceb3c626f2b6b7631d3f109845","unresolved":true,"context_lines":[{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        response \u003d self.send_request(\u0027/storage/luns/\u0027, \u0027get\u0027, query\u003dquery)"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        if response[\u0027num_records\u0027] \u003d\u003d \u00270\u0027:"},{"line_number":426,"context_line":"            return []"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        luns \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"43c4773b_a0f8cd70","line":425,"updated":"2026-03-06 16:10:51.000000000","message":"num_records really a string?","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"e77047783e0078b5b91aed7efbb604661991b782","unresolved":true,"context_lines":[{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        response \u003d self.send_request(\u0027/storage/luns/\u0027, \u0027get\u0027, query\u003dquery)"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        if response[\u0027num_records\u0027] \u003d\u003d \u00270\u0027:"},{"line_number":426,"context_line":"            return []"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        luns \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"56a4b98d_39a11578","line":425,"in_reply_to":"43c4773b_a0f8cd70","updated":"2026-03-09 18:49:30.000000000","message":"Have made it consistent now. API generally responds with int 0 but the \u00270\u0027 handling is additionally to ensure i case it returns a string value.","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"b617d0d0f2be9d7259abab098a3cec2834290413","unresolved":false,"context_lines":[{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        response \u003d self.send_request(\u0027/storage/luns/\u0027, \u0027get\u0027, query\u003dquery)"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        if response[\u0027num_records\u0027] \u003d\u003d \u00270\u0027:"},{"line_number":426,"context_line":"            return []"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        luns \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"8af160ba_68293711","line":425,"in_reply_to":"56a4b98d_39a11578","updated":"2026-03-10 05:34:15.000000000","message":"Done","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"300bfcd9a34cd3ceb3c626f2b6b7631d3f109845","unresolved":true,"context_lines":[{"line_number":445,"context_line":""},{"line_number":446,"context_line":"        # Some REST calls return num_records as string; handle both gracefully."},{"line_number":447,"context_line":"        num_records \u003d response.get(\u0027num_records\u0027)"},{"line_number":448,"context_line":"        if not num_records or str(num_records) \u003d\u003d \u00270\u0027:"},{"line_number":449,"context_line":"            return []"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"        namespaces \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"b55fb550_d6f486e0","line":448,"updated":"2026-03-06 16:10:51.000000000","message":"Ahh, I see - so it can be either.  Can it be either for the other cases I mentioned above as well?","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"e77047783e0078b5b91aed7efbb604661991b782","unresolved":true,"context_lines":[{"line_number":445,"context_line":""},{"line_number":446,"context_line":"        # Some REST calls return num_records as string; handle both gracefully."},{"line_number":447,"context_line":"        num_records \u003d response.get(\u0027num_records\u0027)"},{"line_number":448,"context_line":"        if not num_records or str(num_records) \u003d\u003d \u00270\u0027:"},{"line_number":449,"context_line":"            return []"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"        namespaces \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"fe08f9d9_7d874673","line":448,"in_reply_to":"b55fb550_d6f486e0","updated":"2026-03-09 18:49:30.000000000","message":"Have made it consistent now. API generally responds with int 0 but the \u00270\u0027 handling is additionally to ensure i case it returns a string value.","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"b617d0d0f2be9d7259abab098a3cec2834290413","unresolved":false,"context_lines":[{"line_number":445,"context_line":""},{"line_number":446,"context_line":"        # Some REST calls return num_records as string; handle both gracefully."},{"line_number":447,"context_line":"        num_records \u003d response.get(\u0027num_records\u0027)"},{"line_number":448,"context_line":"        if not num_records or str(num_records) \u003d\u003d \u00270\u0027:"},{"line_number":449,"context_line":"            return []"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"        namespaces \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"d62ecf8b_16d20ff1","line":448,"in_reply_to":"fe08f9d9_7d874673","updated":"2026-03-10 05:34:15.000000000","message":"Done","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"}],"cinder/volume/drivers/netapp/dataontap/utils/utils.py":[{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"300bfcd9a34cd3ceb3c626f2b6b7631d3f109845","unresolved":true,"context_lines":[{"line_number":221,"context_line":"                    value\u003dsvm_name,"},{"line_number":222,"context_line":"                )"},{"line_number":223,"context_line":"        except Exception as exc:"},{"line_number":224,"context_line":"            msg \u003d ("},{"line_number":225,"context_line":"                \"Error while looking up SVM \u0027%(svm)s\u0027 on cluster \""},{"line_number":226,"context_line":"                \"\u0027%(cluster)s\u0027: %(err)s; failing ASA r2 pool initialization.\""},{"line_number":227,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":4,"id":"124ae158_701eefc5","line":224,"updated":"2026-03-06 16:10:51.000000000","message":"I wonder if you should handle InvalidConfigurationValue separately and just re-raise it so you don\u0027t get duplicate logs.","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"b617d0d0f2be9d7259abab098a3cec2834290413","unresolved":false,"context_lines":[{"line_number":221,"context_line":"                    value\u003dsvm_name,"},{"line_number":222,"context_line":"                )"},{"line_number":223,"context_line":"        except Exception as exc:"},{"line_number":224,"context_line":"            msg \u003d ("},{"line_number":225,"context_line":"                \"Error while looking up SVM \u0027%(svm)s\u0027 on cluster \""},{"line_number":226,"context_line":"                \"\u0027%(cluster)s\u0027: %(err)s; failing ASA r2 pool initialization.\""},{"line_number":227,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":4,"id":"1bd83498_fa20663f","line":224,"in_reply_to":"092eef47_b2995ae2","updated":"2026-03-10 05:34:15.000000000","message":"Done","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"e77047783e0078b5b91aed7efbb604661991b782","unresolved":true,"context_lines":[{"line_number":221,"context_line":"                    value\u003dsvm_name,"},{"line_number":222,"context_line":"                )"},{"line_number":223,"context_line":"        except Exception as exc:"},{"line_number":224,"context_line":"            msg \u003d ("},{"line_number":225,"context_line":"                \"Error while looking up SVM \u0027%(svm)s\u0027 on cluster \""},{"line_number":226,"context_line":"                \"\u0027%(cluster)s\u0027: %(err)s; failing ASA r2 pool initialization.\""},{"line_number":227,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":4,"id":"092eef47_b2995ae2","line":224,"in_reply_to":"124ae158_701eefc5","updated":"2026-03-09 18:49:30.000000000","message":"Have updated the code to handle the InvalidConfigurationValue error.","commit_id":"522524efd5c52e2b8bc99d3affda3d1d1e1a24a6"}]}