)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e51987aa91b4a5830aacbc3b51ccc57fb482a23c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2c8518a4_60829531","updated":"2026-02-26 13:35:01.000000000","message":"I saw this failure happen in a downstream CI run but haven\u0027t figured out how one arrives at this code w/ volume.status \u003d None.","commit_id":"df67a77331e7fb91d99156586a310410465c471a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"63a14b72079eaebccf0293fd4d24899118af77eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f55696b1_bc8dc051","updated":"2026-02-26 14:14:29.000000000","message":"Suggestion inline.","commit_id":"df67a77331e7fb91d99156586a310410465c471a"}],"cinder/volume/api.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"63a14b72079eaebccf0293fd4d24899118af77eb","unresolved":true,"context_lines":[{"line_number":1126,"context_line":"                    \"in error status.\")"},{"line_number":1127,"context_line":"            LOG.error(msg)"},{"line_number":1128,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":1129,"context_line":"        if (volume[\u0027status\u0027] is not None and"},{"line_number":1130,"context_line":"                volume[\u0027status\u0027].startswith(\u0027replica_\u0027)):"},{"line_number":1131,"context_line":"            # Can\u0027t snapshot secondary replica"},{"line_number":1132,"context_line":"            msg \u003d _(\"Snapshot of secondary replica is not allowed.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"5af536a2_b21c5979","line":1129,"updated":"2026-02-26 14:14:29.000000000","message":"So with volume[\u0027status\u0027] None, this function won\u0027t fail, which means we\u0027ll go ahead and create a reservation, etc.  I think we should make the None check the first one in this series at line 1110 and raise InvalidVolume if the volume status is unset.","commit_id":"df67a77331e7fb91d99156586a310410465c471a"}]}
