)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"a20fa18855a0427d670aa63f0ce853f8015f0a09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"28514b68_79182548","updated":"2026-03-04 11:00:03.000000000","message":"recheck   pip network issues showed in multiple jobs (same on our own ci) but that has been fixed now (no longer turns up in our ci), so i expect recheck to be fine now.","commit_id":"3367eea2cdcc545da1859a94d398baaeae1e8134"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"854af86157b3f4f5538af408aa05da755c678ff4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4c40940f_eaecd00a","updated":"2026-03-04 08:42:04.000000000","message":"run-Quobyte CI","commit_id":"3367eea2cdcc545da1859a94d398baaeae1e8134"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"a602399a3565ead6c52dbecb41adb0363244cbc3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3f740502_72d30e87","updated":"2026-03-03 13:39:01.000000000","message":"run-Quobyte CI\n\nCI failed it\u0027s last run due to network issues pulling dependencies during devstack being set up.","commit_id":"3367eea2cdcc545da1859a94d398baaeae1e8134"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"f742216b33166b40a45b4c8f19f4535f7ceabcd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"08d2b68c_8f1b8c2f","updated":"2026-03-04 09:12:44.000000000","message":"run-Quobyte CI\nVery clever me launched the ci re-run and the proceeded to run updates on the CI itself, interrupting the job, *sigh*.","commit_id":"3367eea2cdcc545da1859a94d398baaeae1e8134"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"909d1b31c7a295d87172a5a55588eba0915ea9ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9868cd20_73b9e111","updated":"2026-03-31 11:35:49.000000000","message":"Please look at the comment.","commit_id":"80cb175533d3278625fbcba65a1eb29bd676059e"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"906bcdd26f86056c59ef4489514f072ee5534aeb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"295bda21_b8085747","updated":"2026-05-04 18:15:38.000000000","message":"LGTM.","commit_id":"d497fec93b841e15635467f41322b8e6f3d3c3db"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"ebe9bc9fbf995cca124775c4b0ee1919e2659489","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"dd927297_d34151dc","updated":"2026-07-17 15:34:09.000000000","message":"Small, clear patch, release notes provided, CI passing:  LGTM","commit_id":"7884bcd49ec2efa1b939f732e015227d16b3668f"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"e6ffa5728dbf91c8b691640739085180d2569606","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c7130cab_45f16679","updated":"2026-07-29 12:39:14.000000000","message":"lgtm","commit_id":"7884bcd49ec2efa1b939f732e015227d16b3668f"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"959576a947bcc24e952e9df32d6bf8b1ddf28fe6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2f2ceea2_ba09f00e","updated":"2026-06-30 12:26:34.000000000","message":"run-Quobyte CI","commit_id":"7884bcd49ec2efa1b939f732e015227d16b3668f"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"e80d7576db7bdb8094a3da5719597488cb367e9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"52e71bb9_ba9851a6","updated":"2026-07-21 03:50:53.000000000","message":"set-vol-format-metadata seems clean and the _do_create_volume tests cover the metadata values\n\nso not really blocking , but can you add metadata value assert in test_create_volume_from_snapshot.","commit_id":"7884bcd49ec2efa1b939f732e015227d16b3668f"}],"cinder/tests/unit/volume/drivers/test_quobyte.py":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"e80d7576db7bdb8094a3da5719597488cb367e9a","unresolved":true,"context_lines":[{"line_number":1578,"context_line":"            drv._find_share.assert_called_once_with(new_volume)"},{"line_number":1579,"context_line":"            (drv._copy_volume_from_snapshot."},{"line_number":1580,"context_line":"             assert_called_once_with(snap_ref, new_volume, new_volume[\u0027size\u0027]))"},{"line_number":1581,"context_line":"            mock_volume_save.assert_called_once()"},{"line_number":1582,"context_line":"        else:"},{"line_number":1583,"context_line":"            self.assertRaises(exception.InvalidSnapshot,"},{"line_number":1584,"context_line":"                              drv.create_volume_from_snapshot,"}],"source_content_type":"text/x-python","patch_set":9,"id":"80d9f3c6_c8834dd8","line":1581,"updated":"2026-07-21 03:50:53.000000000","message":"can you please add an assert of actual data too here","commit_id":"7884bcd49ec2efa1b939f732e015227d16b3668f"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"ee6a2b2b8b9c93566b6859e417ce3b78ab157665","unresolved":false,"context_lines":[{"line_number":1578,"context_line":"            drv._find_share.assert_called_once_with(new_volume)"},{"line_number":1579,"context_line":"            (drv._copy_volume_from_snapshot."},{"line_number":1580,"context_line":"             assert_called_once_with(snap_ref, new_volume, new_volume[\u0027size\u0027]))"},{"line_number":1581,"context_line":"            mock_volume_save.assert_called_once()"},{"line_number":1582,"context_line":"        else:"},{"line_number":1583,"context_line":"            self.assertRaises(exception.InvalidSnapshot,"},{"line_number":1584,"context_line":"                              drv.create_volume_from_snapshot,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3af39fca_24ceba88","line":1581,"in_reply_to":"29b33d44_65f1ab9e","updated":"2026-07-29 14:03:56.000000000","message":"Took a look. I\u0027ll probably add this but not in this version (as it is ready to merge). I noted this down and will update in a future context, if that is acceptable.","commit_id":"7884bcd49ec2efa1b939f732e015227d16b3668f"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"945747959a2561f38471566447fe44617d5b7c7e","unresolved":true,"context_lines":[{"line_number":1578,"context_line":"            drv._find_share.assert_called_once_with(new_volume)"},{"line_number":1579,"context_line":"            (drv._copy_volume_from_snapshot."},{"line_number":1580,"context_line":"             assert_called_once_with(snap_ref, new_volume, new_volume[\u0027size\u0027]))"},{"line_number":1581,"context_line":"            mock_volume_save.assert_called_once()"},{"line_number":1582,"context_line":"        else:"},{"line_number":1583,"context_line":"            self.assertRaises(exception.InvalidSnapshot,"},{"line_number":1584,"context_line":"                              drv.create_volume_from_snapshot,"}],"source_content_type":"text/x-python","patch_set":9,"id":"29b33d44_65f1ab9e","line":1581,"in_reply_to":"80d9f3c6_c8834dd8","updated":"2026-07-28 09:35:41.000000000","message":"Thnx for reviewing, I\u0027ll take a look and follow up.\nSry for the delayed answer, I was ooo for a while","commit_id":"7884bcd49ec2efa1b939f732e015227d16b3668f"}],"cinder/volume/drivers/quobyte.py":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"909d1b31c7a295d87172a5a55588eba0915ea9ac","unresolved":true,"context_lines":[{"line_number":617,"context_line":"            self.get_active_image_from_info(volume))"},{"line_number":618,"context_line":"        image_utils.resize_image(active_path, size_gb)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"    def _set_volume_format_metadata(self, volume):"},{"line_number":621,"context_line":"        if self.configuration.quobyte_qcow2_volumes:"},{"line_number":622,"context_line":"            volume_format \u003d \u0027qcow2\u0027"},{"line_number":623,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"b1e887fa_cf175793","line":620,"updated":"2026-03-31 11:35:49.000000000","message":"I can see that we are setting the metadata. But where are we using this set value in code while creating the volume from snapshot?","commit_id":"80cb175533d3278625fbcba65a1eb29bd676059e"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"de7da219936d5ed3b917f879a69176339d5ccd6c","unresolved":false,"context_lines":[{"line_number":617,"context_line":"            self.get_active_image_from_info(volume))"},{"line_number":618,"context_line":"        image_utils.resize_image(active_path, size_gb)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"    def _set_volume_format_metadata(self, volume):"},{"line_number":621,"context_line":"        if self.configuration.quobyte_qcow2_volumes:"},{"line_number":622,"context_line":"            volume_format \u003d \u0027qcow2\u0027"},{"line_number":623,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"cedde1d6_84429d34","line":620,"in_reply_to":"21ba7308_25905a60","updated":"2026-04-07 05:00:19.000000000","message":"That line also sets the volume format metadata. I was wondering where were we getting it to use it for volume from snapshot creation.","commit_id":"80cb175533d3278625fbcba65a1eb29bd676059e"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"45faceac2baffaab1ba5f2eeb8872f7130fe2b6c","unresolved":false,"context_lines":[{"line_number":617,"context_line":"            self.get_active_image_from_info(volume))"},{"line_number":618,"context_line":"        image_utils.resize_image(active_path, size_gb)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"    def _set_volume_format_metadata(self, volume):"},{"line_number":621,"context_line":"        if self.configuration.quobyte_qcow2_volumes:"},{"line_number":622,"context_line":"            volume_format \u003d \u0027qcow2\u0027"},{"line_number":623,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"21ba7308_25905a60","line":620,"in_reply_to":"b1e887fa_cf175793","updated":"2026-04-01 12:32:04.000000000","message":"line 375 above, is that what you seek?","commit_id":"80cb175533d3278625fbcba65a1eb29bd676059e"},{"author":{"_account_id":13915,"name":"Silvan Kaiser","email":"silvan@quobyte.com","username":"kaisers"},"change_message_id":"787a20abdc6d137309acf9f29d0ed3ff56459b41","unresolved":false,"context_lines":[{"line_number":617,"context_line":"            self.get_active_image_from_info(volume))"},{"line_number":618,"context_line":"        image_utils.resize_image(active_path, size_gb)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"    def _set_volume_format_metadata(self, volume):"},{"line_number":621,"context_line":"        if self.configuration.quobyte_qcow2_volumes:"},{"line_number":622,"context_line":"            volume_format \u003d \u0027qcow2\u0027"},{"line_number":623,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"eaf1cf3d_d365645f","line":620,"in_reply_to":"cedde1d6_84429d34","updated":"2026-04-15 08:18:05.000000000","message":"remotefs.py _create_snapshot_offline is using it, such a snapshot is later then used in volume from snapshot.","commit_id":"80cb175533d3278625fbcba65a1eb29bd676059e"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"906bcdd26f86056c59ef4489514f072ee5534aeb","unresolved":false,"context_lines":[{"line_number":617,"context_line":"            self.get_active_image_from_info(volume))"},{"line_number":618,"context_line":"        image_utils.resize_image(active_path, size_gb)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"    def _set_volume_format_metadata(self, volume):"},{"line_number":621,"context_line":"        if self.configuration.quobyte_qcow2_volumes:"},{"line_number":622,"context_line":"            volume_format \u003d \u0027qcow2\u0027"},{"line_number":623,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fcc17448_53d727cf","line":620,"in_reply_to":"eaf1cf3d_d365645f","updated":"2026-05-04 18:15:38.000000000","message":"ack","commit_id":"80cb175533d3278625fbcba65a1eb29bd676059e"}]}