)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"046a1caa635d029b5c78f7ff3bb411256b99ca20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5c835093_fd8e7019","updated":"2026-08-24 13:35:04.000000000","message":"This needs a Partial-Bug: tag in the commit message.\nThis is the patch that needs the release notes, as it is the one adding the new config option.","commit_id":"4557f90a5f6f5c161d6f606795bb415425525d4f"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"f461726a5e46009421a72bacd044e5d0f11b6426","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b09ab006_eddf303a","updated":"2026-08-24 16:54:34.000000000","message":"Only as few tiny things now and then we should be good","commit_id":"fe576d96c0bf957e6791c1b7e5dd3b5d9e9d1808"},{"author":{"_account_id":36680,"name":"Josselin Mouette","display_name":"Josselin Mouette","email":"josselin.mouette@exaion.com","username":"jmouette"},"change_message_id":"43be378492ee3c885b7ab18222abeea31009f95e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9b1a50ee_18c9df83","updated":"2026-08-24 17:59:27.000000000","message":"Thanks for the review!","commit_id":"fe576d96c0bf957e6791c1b7e5dd3b5d9e9d1808"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"2bd33a8255f63cb48cc85f1fd017dfb384ad7359","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3fe0bef4_d710b02c","updated":"2026-08-24 20:15:00.000000000","message":"Thanks for bearing with me on this. We are good now.","commit_id":"73fa7d4b8ae6660ee545ef37b94094ec92a01da1"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"bd39c30126a612b0660e8d2ac8c7b54abacff616","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f8fbdf4f_a678aab2","updated":"2026-09-01 14:00:40.000000000","message":"Readding +1 s last PS was a tiny comment typo fix only","commit_id":"1b7fa2d0f2793de07926d89a0129f71e47c40cdd"}],"cinder/volume/driver.py":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"f461726a5e46009421a72bacd044e5d0f11b6426","unresolved":true,"context_lines":[{"line_number":331,"context_line":"                default\u003d{},"},{"line_number":332,"context_line":"                help\u003d\u0027List of options to pass to nvme-connect and their \u0027"},{"line_number":333,"context_line":"                     \u0027values, such as nr_io_queues, queue_size, \u0027"},{"line_number":334,"context_line":"                     \u0027reconnect_delay…\u0027)"},{"line_number":335,"context_line":"]"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"scst_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"2d953328_0a828f30","line":334,"range":{"start_line":334,"start_character":37,"end_line":334,"end_character":38},"updated":"2026-08-24 16:54:34.000000000","message":"change this (the three dots) to `,etc` as they are being seen as unicode ellipsis which will mess up the config reference generation.\nAlso might be worth saying the recognised names are enforced by os-brick and anything else is silenty ignored","commit_id":"fe576d96c0bf957e6791c1b7e5dd3b5d9e9d1808"},{"author":{"_account_id":36680,"name":"Josselin Mouette","display_name":"Josselin Mouette","email":"josselin.mouette@exaion.com","username":"jmouette"},"change_message_id":"43be378492ee3c885b7ab18222abeea31009f95e","unresolved":false,"context_lines":[{"line_number":331,"context_line":"                default\u003d{},"},{"line_number":332,"context_line":"                help\u003d\u0027List of options to pass to nvme-connect and their \u0027"},{"line_number":333,"context_line":"                     \u0027values, such as nr_io_queues, queue_size, \u0027"},{"line_number":334,"context_line":"                     \u0027reconnect_delay…\u0027)"},{"line_number":335,"context_line":"]"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"scst_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":4,"id":"d0ac84e2_e469457a","line":334,"range":{"start_line":334,"start_character":37,"end_line":334,"end_character":38},"in_reply_to":"2d953328_0a828f30","updated":"2026-08-24 17:59:27.000000000","message":"Done","commit_id":"fe576d96c0bf957e6791c1b7e5dd3b5d9e9d1808"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"6dfc8fa3570be5d86ce51bba359143cf35543910","unresolved":true,"context_lines":[{"line_number":329,"context_line":"                    \u0027Maximum supported value in Linux is 8192\u0027),"},{"line_number":330,"context_line":"    cfg.DictOpt(\u0027nvmet_connect_opts\u0027,"},{"line_number":331,"context_line":"                default\u003d{},"},{"line_number":332,"context_line":"                help\u003d\u0027List of options to pass to nvme-connect and their \u0027"},{"line_number":333,"context_line":"                     \u0027values, such as nr_io_queues, queue_size, \u0027"},{"line_number":334,"context_line":"                     \u0027reconnect_delay, etc.  Options are filtered by \u0027"},{"line_number":335,"context_line":"                     \u0027os_brick and unknown options will be silently \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"5651cb15_f2801564","line":332,"updated":"2026-08-31 15:17:02.000000000","message":"List or Dictionary?","commit_id":"73fa7d4b8ae6660ee545ef37b94094ec92a01da1"},{"author":{"_account_id":36680,"name":"Josselin Mouette","display_name":"Josselin Mouette","email":"josselin.mouette@exaion.com","username":"jmouette"},"change_message_id":"ef0df1c009bc15b3180177157515ef761b4c0b3e","unresolved":false,"context_lines":[{"line_number":329,"context_line":"                    \u0027Maximum supported value in Linux is 8192\u0027),"},{"line_number":330,"context_line":"    cfg.DictOpt(\u0027nvmet_connect_opts\u0027,"},{"line_number":331,"context_line":"                default\u003d{},"},{"line_number":332,"context_line":"                help\u003d\u0027List of options to pass to nvme-connect and their \u0027"},{"line_number":333,"context_line":"                     \u0027values, such as nr_io_queues, queue_size, \u0027"},{"line_number":334,"context_line":"                     \u0027reconnect_delay, etc.  Options are filtered by \u0027"},{"line_number":335,"context_line":"                     \u0027os_brick and unknown options will be silently \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"baf20fcf_d1475607","line":332,"in_reply_to":"5651cb15_f2801564","updated":"2026-09-01 07:15:13.000000000","message":"Done","commit_id":"73fa7d4b8ae6660ee545ef37b94094ec92a01da1"}],"cinder/volume/targets/nvmeof.py":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"f461726a5e46009421a72bacd044e5d0f11b6426","unresolved":true,"context_lines":[{"line_number":132,"context_line":"         \u0027transport_type\u0027: Network fabric being used for an NVMe-oF network"},{"line_number":133,"context_line":"                           One of: tcp, rdma"},{"line_number":134,"context_line":"         \u0027ns_id\u0027: namespace id associated with the subsystem"},{"line_number":135,"context_line":"         \u0027nvmet_connect_opts\u0027: options to pass to \"nvme connect\""},{"line_number":136,"context_line":"        }"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7fea97f5_b59978d9","line":135,"range":{"start_line":135,"start_character":10,"end_line":135,"end_character":28},"updated":"2026-08-24 16:54:34.000000000","message":"per line 175 you are sending back `connect_opts`, not `nvmet_connect_opts`","commit_id":"fe576d96c0bf957e6791c1b7e5dd3b5d9e9d1808"},{"author":{"_account_id":36680,"name":"Josselin Mouette","display_name":"Josselin Mouette","email":"josselin.mouette@exaion.com","username":"jmouette"},"change_message_id":"43be378492ee3c885b7ab18222abeea31009f95e","unresolved":false,"context_lines":[{"line_number":132,"context_line":"         \u0027transport_type\u0027: Network fabric being used for an NVMe-oF network"},{"line_number":133,"context_line":"                           One of: tcp, rdma"},{"line_number":134,"context_line":"         \u0027ns_id\u0027: namespace id associated with the subsystem"},{"line_number":135,"context_line":"         \u0027nvmet_connect_opts\u0027: options to pass to \"nvme connect\""},{"line_number":136,"context_line":"        }"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"69fef97b_146fde7d","line":135,"range":{"start_line":135,"start_character":10,"end_line":135,"end_character":28},"in_reply_to":"7fea97f5_b59978d9","updated":"2026-08-24 17:59:27.000000000","message":"Done","commit_id":"fe576d96c0bf957e6791c1b7e5dd3b5d9e9d1808"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"f461726a5e46009421a72bacd044e5d0f11b6426","unresolved":true,"context_lines":[{"line_number":144,"context_line":"          \u0027portals\u0027: [(target_address, target_port, transport_type) ... ]"},{"line_number":145,"context_line":"          \u0027ns_id\u0027: namespace id associated with the subsystem, in case target"},{"line_number":146,"context_line":"                   doesn\u0027t provide the volume_uuid."},{"line_number":147,"context_line":"          \u0027nvmet_connect_opts\u0027: options to pass to \"nvme connect\""},{"line_number":148,"context_line":"        }"},{"line_number":149,"context_line":"        Unlike the old format the transport_type can be one of RoCEv2 and tcp"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"2bf44383_377891fd","line":147,"range":{"start_line":147,"start_character":11,"end_line":147,"end_character":29},"updated":"2026-08-24 16:54:34.000000000","message":"same comment as line 135","commit_id":"fe576d96c0bf957e6791c1b7e5dd3b5d9e9d1808"},{"author":{"_account_id":36680,"name":"Josselin Mouette","display_name":"Josselin Mouette","email":"josselin.mouette@exaion.com","username":"jmouette"},"change_message_id":"43be378492ee3c885b7ab18222abeea31009f95e","unresolved":false,"context_lines":[{"line_number":144,"context_line":"          \u0027portals\u0027: [(target_address, target_port, transport_type) ... ]"},{"line_number":145,"context_line":"          \u0027ns_id\u0027: namespace id associated with the subsystem, in case target"},{"line_number":146,"context_line":"                   doesn\u0027t provide the volume_uuid."},{"line_number":147,"context_line":"          \u0027nvmet_connect_opts\u0027: options to pass to \"nvme connect\""},{"line_number":148,"context_line":"        }"},{"line_number":149,"context_line":"        Unlike the old format the transport_type can be one of RoCEv2 and tcp"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"78676fbb_d3bb7b77","line":147,"range":{"start_line":147,"start_character":11,"end_line":147,"end_character":29},"in_reply_to":"2bf44383_377891fd","updated":"2026-08-24 17:59:27.000000000","message":"Done","commit_id":"fe576d96c0bf957e6791c1b7e5dd3b5d9e9d1808"}],"releasenotes/notes/add-nvme-connect-opts-105a42123a6f5474.yaml":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"f461726a5e46009421a72bacd044e5d0f11b6426","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    nvmet target driver: Added support for associating client options to"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7c461632_be7408dc","line":1,"updated":"2026-08-24 16:54:34.000000000","message":"- State that this only applies to targets derived from the NVMeOF target\n  class (nvmet, spdk-nvmf). Third-party NVMe-oF drivers that build their\n  own connection_info will not honour it, and operators will otherwise\n  reasonably assume \"NVMe-oF backend\" means all of them.\n\n- State that it requires a matching os-brick. As the Depends-On is\n  currently wired, this change merges first and the note advertises a\n  feature that does nothing until 979346 lands and os-brick releases.\n  Older os-brick ignores the key harmlessly, so there is no breakage -\n  just nothing happening, which the note should not promise.","commit_id":"fe576d96c0bf957e6791c1b7e5dd3b5d9e9d1808"},{"author":{"_account_id":36680,"name":"Josselin Mouette","display_name":"Josselin Mouette","email":"josselin.mouette@exaion.com","username":"jmouette"},"change_message_id":"43be378492ee3c885b7ab18222abeea31009f95e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    nvmet target driver: Added support for associating client options to"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1b24204b_0aeca736","line":1,"in_reply_to":"7c461632_be7408dc","updated":"2026-08-24 17:59:27.000000000","message":"Done","commit_id":"fe576d96c0bf957e6791c1b7e5dd3b5d9e9d1808"}]}