)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"db9fec01d2cfe874d3f08f247e1ada386b1be8c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f3d0fcb2_d3744371","updated":"2026-04-17 15:19:06.000000000","message":"LGTM. The test looks a little confusing in the first pass, but overall I think it should work.","commit_id":"e3a6f3c45167427402ee5c8bc203611f5cb60f95"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"d4bba2996fbfe7c1cf1484dcef25ff4d1b696831","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e4e311b7_98ab0fd6","updated":"2026-04-17 15:18:06.000000000","message":"This looks okay to me. It took me a bit to understand that both notifications were present in the test code, but that the test itself was off.","commit_id":"e3a6f3c45167427402ee5c8bc203611f5cb60f95"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"7ec4d6d34dfa1bf904163e96198c9dbb2a56ac31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"26051177_1573f47b","updated":"2026-04-09 04:10:03.000000000","message":"thank you! hongp for clear explanation. I understood now. LGTM","commit_id":"e3a6f3c45167427402ee5c8bc203611f5cb60f95"}],"cinder/tests/unit/group/test_groups_manager.py":[{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"7faf5b380fc0e8eea2e4b2752a074a8baf951cf6","unresolved":true,"context_lines":[{"line_number":504,"context_line":"                         self.notifier.notifications)"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        self.volume.delete_group(self.context, group2)"},{"line_number":507,"context_line":"        if len(self.notifier.notifications) \u003e 10:"},{"line_number":508,"context_line":"            self.assertFalse(self.notifier.notifications[11],"},{"line_number":509,"context_line":"                             self.notifier.notifications)"},{"line_number":510,"context_line":"        self.assertEqual(10, len(self.notifier.notifications),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ad65ad8_bd4afbb9","line":507,"updated":"2026-03-17 11:17:56.000000000","message":"length check is increase by one(i.e. 9 to 10). Two assert statements are added?","commit_id":"e3a6f3c45167427402ee5c8bc203611f5cb60f95"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"4a0cc39c9687aed2b7238569b273a997dc287575","unresolved":false,"context_lines":[{"line_number":504,"context_line":"                         self.notifier.notifications)"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        self.volume.delete_group(self.context, group2)"},{"line_number":507,"context_line":"        if len(self.notifier.notifications) \u003e 10:"},{"line_number":508,"context_line":"            self.assertFalse(self.notifier.notifications[11],"},{"line_number":509,"context_line":"                             self.notifier.notifications)"},{"line_number":510,"context_line":"        self.assertEqual(10, len(self.notifier.notifications),"}],"source_content_type":"text/x-python","patch_set":3,"id":"7b81c08c_e13cb135","line":507,"in_reply_to":"0f003e9c_9d88a5a1","updated":"2026-04-09 04:11:31.000000000","message":"Done","commit_id":"e3a6f3c45167427402ee5c8bc203611f5cb60f95"},{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"5e66bdbfab36539926870e075bf39825b2399f03","unresolved":true,"context_lines":[{"line_number":504,"context_line":"                         self.notifier.notifications)"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        self.volume.delete_group(self.context, group2)"},{"line_number":507,"context_line":"        if len(self.notifier.notifications) \u003e 10:"},{"line_number":508,"context_line":"            self.assertFalse(self.notifier.notifications[11],"},{"line_number":509,"context_line":"                             self.notifier.notifications)"},{"line_number":510,"context_line":"        self.assertEqual(10, len(self.notifier.notifications),"}],"source_content_type":"text/x-python","patch_set":3,"id":"92f87597_ad1704ba","line":507,"in_reply_to":"5ad65ad8_bd4afbb9","updated":"2026-03-17 12:06:54.000000000","message":"Thanks for the review! That’s right. While the volume.delete.start notification (index 7) was already being generated, I’ve now added a check for the volume.delete.end notification at index 9. This is why the total length increased from 9 to 10. I added two assert statements to verify both the \u0027start\u0027 and \u0027end\u0027 events to ensure the entire deletion process is correctly tracked.","commit_id":"e3a6f3c45167427402ee5c8bc203611f5cb60f95"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"d4bba2996fbfe7c1cf1484dcef25ff4d1b696831","unresolved":false,"context_lines":[{"line_number":504,"context_line":"                         self.notifier.notifications)"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        self.volume.delete_group(self.context, group2)"},{"line_number":507,"context_line":"        if len(self.notifier.notifications) \u003e 10:"},{"line_number":508,"context_line":"            self.assertFalse(self.notifier.notifications[11],"},{"line_number":509,"context_line":"                             self.notifier.notifications)"},{"line_number":510,"context_line":"        self.assertEqual(10, len(self.notifier.notifications),"}],"source_content_type":"text/x-python","patch_set":3,"id":"afc40fde_9fdea488","line":507,"in_reply_to":"7b81c08c_e13cb135","updated":"2026-04-17 15:18:06.000000000","message":"The changes in manager.py are the same for both notifications (start and end), why is start present already, but end is not?  I still don\u0027t understand why only increasing by 1.","commit_id":"e3a6f3c45167427402ee5c8bc203611f5cb60f95"},{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"3c78b95f49ef503d4713b8e0c7b2ba9083b0bd0a","unresolved":true,"context_lines":[{"line_number":504,"context_line":"                         self.notifier.notifications)"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        self.volume.delete_group(self.context, group2)"},{"line_number":507,"context_line":"        if len(self.notifier.notifications) \u003e 10:"},{"line_number":508,"context_line":"            self.assertFalse(self.notifier.notifications[11],"},{"line_number":509,"context_line":"                             self.notifier.notifications)"},{"line_number":510,"context_line":"        self.assertEqual(10, len(self.notifier.notifications),"}],"source_content_type":"text/x-python","patch_set":3,"id":"0f003e9c_9d88a5a1","line":507,"in_reply_to":"92f87597_ad1704ba","updated":"2026-04-08 14:57:43.000000000","message":"@jayaanand.borra@netapp.com Hi, I\u0027ve explained why the notification count increased to 10 in the comments above. Could you please check it again and let me know if it resolves your concern? Thanks!","commit_id":"e3a6f3c45167427402ee5c8bc203611f5cb60f95"}]}