)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"7581062a239330ea965124e9b9dc7c25fcc78f7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"4eff82f0_872a5958","updated":"2026-04-24 13:13:30.000000000","message":"recheck\n\nopenstack-tox-docs POST_FAILURE due to rsync failure","commit_id":"2b824b872f3a95966e7acfa25be9759f71257df3"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"1403341bbf379ade926d7d36b94fafd3b72f5e0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"b81167f7_73cd14c7","updated":"2026-06-09 13:01:51.000000000","message":"The setUp() method here is missing the shutil.copyfile() mechanism that Manila uses. If we are only using sqlite, do we need that at all?","commit_id":"eb6f969c833e62a8ccfdad27ec6791ff4ebd302e"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"ad776a6b1446a64498d9be0394e012870949c8cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"8a36d752_a5656f4f","updated":"2026-06-10 19:09:20.000000000","message":"-2 so that other reviewers don\u0027t spend time - the sqlalchemy errors that this patch attempted to fix are not or no longer present, making these changes likely unnecessary.","commit_id":"d078feefe59ede0148838f2d64eb21db878420fe"}],"cinder/tests/unit/test.py":[{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"60bfbe090a2caeb368e1e6a8d36cca18974a2635","unresolved":true,"context_lines":[{"line_number":101,"context_line":"        db_logger.setLevel(logging.WARNING)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        self.setup_sqlite(db_migrate)"},{"line_number":104,"context_line":"        conn \u003d self.engine.connect()"},{"line_number":105,"context_line":"        self._DB \u003d \"\".join(line for line in conn.connection.iterdump())"},{"line_number":106,"context_line":"        self.engine.dispose()"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"a56adbe7_cd92d59d","line":104,"updated":"2026-04-14 05:16:05.000000000","message":"connecting empty db after setup","commit_id":"df23b40974c894cc5e04fdbf6fdfa73ca6b597ce"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"2527ba99c926da2763b9a16420c00c68869b9214","unresolved":true,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def setUp(self):"},{"line_number":109,"context_line":"        super().setUp()"},{"line_number":110,"context_line":"        conn \u003d self.engine.connect()"},{"line_number":111,"context_line":"        conn.connection.executescript(self._DB)"},{"line_number":112,"context_line":"        self.addCleanup(self.engine.dispose)"},{"line_number":113,"context_line":"        migration.db_sync(engine\u003dself.engine)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ee329ea4_7efec1f7","line":110,"updated":"2026-04-14 05:24:24.000000000","message":"init is connecting to db. may be conditional connect based on context may optimize","commit_id":"df23b40974c894cc5e04fdbf6fdfa73ca6b597ce"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"60bfbe090a2caeb368e1e6a8d36cca18974a2635","unresolved":true,"context_lines":[{"line_number":110,"context_line":"        conn \u003d self.engine.connect()"},{"line_number":111,"context_line":"        conn.connection.executescript(self._DB)"},{"line_number":112,"context_line":"        self.addCleanup(self.engine.dispose)"},{"line_number":113,"context_line":"        migration.db_sync(engine\u003dself.engine)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def setup_sqlite(self, db_migrate):"},{"line_number":116,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":7,"id":"76857df9_63b5088a","line":113,"updated":"2026-04-14 05:16:05.000000000","message":"db_sync is run for every test. Is it required? init may be correct location.","commit_id":"df23b40974c894cc5e04fdbf6fdfa73ca6b597ce"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"52de6602cd27c68f106676443b3f558f76202d86","unresolved":true,"context_lines":[{"line_number":110,"context_line":"        conn \u003d self.engine.connect()"},{"line_number":111,"context_line":"        conn.connection.executescript(self._DB)"},{"line_number":112,"context_line":"        self.addCleanup(self.engine.dispose)"},{"line_number":113,"context_line":"        migration.db_sync(engine\u003dself.engine)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def setup_sqlite(self, db_migrate):"},{"line_number":116,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":7,"id":"917f0873_aa79ce0c","line":113,"in_reply_to":"48fae207_347383fc","updated":"2026-05-21 09:39:41.000000000","message":"yes Eric, you are correct. Practically same. My concern is regarding full Alembic run for every test. DB is same for all tests and sync can happen at global level once.","commit_id":"df23b40974c894cc5e04fdbf6fdfa73ca6b597ce"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"31728b81ea73b9c8a80c0b8fd299feaf3216cd8a","unresolved":true,"context_lines":[{"line_number":110,"context_line":"        conn \u003d self.engine.connect()"},{"line_number":111,"context_line":"        conn.connection.executescript(self._DB)"},{"line_number":112,"context_line":"        self.addCleanup(self.engine.dispose)"},{"line_number":113,"context_line":"        migration.db_sync(engine\u003dself.engine)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def setup_sqlite(self, db_migrate):"},{"line_number":116,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":7,"id":"48fae207_347383fc","line":113,"in_reply_to":"76857df9_63b5088a","updated":"2026-04-14 12:31:26.000000000","message":"This is just mirroring what our unit tests have always done - before it was done by the\n\n  conn.connection.executescript(DB_SCHEMA)\n\ncall.","commit_id":"df23b40974c894cc5e04fdbf6fdfa73ca6b597ce"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f936e2a42809b541f6ab8109e92a6cac3c2151b1","unresolved":true,"context_lines":[{"line_number":105,"context_line":"        self._DB \u003d \"\".join(line for line in conn.connection.iterdump())"},{"line_number":106,"context_line":"        self.engine.dispose()"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def setUp(self):"},{"line_number":109,"context_line":"        super().setUp()"},{"line_number":110,"context_line":"        conn \u003d self.engine.connect()"},{"line_number":111,"context_line":"        conn.connection.executescript(self._DB)"}],"source_content_type":"text/x-python","patch_set":14,"id":"124448af_00cc316a","line":108,"updated":"2026-06-03 13:31:45.000000000","message":"The setUp() method here is missing the shutil.copyfile() mechanism that Manila uses.  If we are only using sqlite, do we need that at all?","commit_id":"6c266262124fb16ed7c566b1e0674f8d38d3e706"}]}