)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"592f6d7e2ed4fbbcc9a7d61e24c1d631a4ca6670","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1d665522_8f51fa3b","updated":"2026-04-30 13:14:06.000000000","message":"It\u0027s been backported to all the other stable branches, so makes sense to hit Dalmatian too.","commit_id":"135a521f891abe4ad9b53b9987cfc8c07c3f3cb1"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"1829a337e446e0615f57075e5e0e0af3f9816bb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"883fb34e_5903a0d6","updated":"2026-04-30 13:10:47.000000000","message":"looks good to me.","commit_id":"135a521f891abe4ad9b53b9987cfc8c07c3f3cb1"}],"cinder/volume/drivers/hitachi/hbsd_rest.py":[{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"fe8564b5e1694f47b3c0090ffd4361e38970920e","unresolved":true,"context_lines":[{"line_number":622,"context_line":"                msg \u003d self.output_log("},{"line_number":623,"context_line":"                    MSG.GET_SNAPSHOT_FROM_SVOL_FAILURE, svol\u003drepr(svol))"},{"line_number":624,"context_line":"                LOG.error(msg)"},{"line_number":625,"context_line":"                self._delete_pair_from_storage(pvol, svol)"},{"line_number":626,"context_line":"                self.raise_error(msg)"},{"line_number":627,"context_line":"        try:"},{"line_number":628,"context_line":"            ss_id \u003d ss_result[\u0027data\u0027][0][\u0027snapshotId\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"8c29e414_6071c5f9","line":625,"updated":"2026-04-01 05:54:11.000000000","message":"try/catch missing? i see it in other places","commit_id":"135a521f891abe4ad9b53b9987cfc8c07c3f3cb1"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"f6b3c720501888f4de9819b5601702aadeb4b539","unresolved":false,"context_lines":[{"line_number":622,"context_line":"                msg \u003d self.output_log("},{"line_number":623,"context_line":"                    MSG.GET_SNAPSHOT_FROM_SVOL_FAILURE, svol\u003drepr(svol))"},{"line_number":624,"context_line":"                LOG.error(msg)"},{"line_number":625,"context_line":"                self._delete_pair_from_storage(pvol, svol)"},{"line_number":626,"context_line":"                self.raise_error(msg)"},{"line_number":627,"context_line":"        try:"},{"line_number":628,"context_line":"            ss_id \u003d ss_result[\u0027data\u0027][0][\u0027snapshotId\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"01e9eda8_203cbedf","line":625,"in_reply_to":"8c29e414_6071c5f9","updated":"2026-04-01 22:58:44.000000000","message":"Hi jayaanand borra,\n\nThanks for your review again :)\n\nOut of curiosity I took a look, and try/catch is used interchangeably for this. This/the pattern was probably copied from somewhere that didn\u0027t use it, and I didn\u0027t write this or the original code so I can\u0027t really comment fully.  It would be a pretty big corner case if it\u0027s wrong is about the most I can say (network goes down, or storage array gets locked for a long period of time by another user in between the pair creation and deletion).\n\nHowever, this is a cherry-pick backport, so I can\u0027t change it (or anything else) for this patch, anyway.","commit_id":"135a521f891abe4ad9b53b9987cfc8c07c3f3cb1"}]}