)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"733b6218f25c52a6666e8c42d7870822fb4e0847","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"25e2af94_a911eee2","updated":"2026-07-01 09:04:09.000000000","message":"LGTM","commit_id":"839f28c074f4adf440fc1dc7937e8a9addabb098"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"5bc702b492d025fc9aa2b183af4d0e8b55fa3422","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c5a50320_3c54d655","updated":"2026-07-17 15:15:26.000000000","message":"LGTM, with one minor suggestion to mention time unit in description of new config option.","commit_id":"839f28c074f4adf440fc1dc7937e8a9addabb098"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"805c11024a448f9ad816b4a291e40b98ed3cc0ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"65c9882c_411c8f6b","updated":"2026-07-17 16:30:37.000000000","message":"See inline for comments, questions, and a possible followup.","commit_id":"839f28c074f4adf440fc1dc7937e8a9addabb098"},{"author":{"_account_id":36538,"name":"Harsh Ailani","display_name":"Harsh Ailani","email":"harsh.ailani@ibm.com","username":"harshailani"},"change_message_id":"43695d44e93fba648ec44f42ea08f91bc75a66a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1cd00172_37ef14c4","updated":"2026-06-17 07:01:10.000000000","message":"recheck","commit_id":"839f28c074f4adf440fc1dc7937e8a9addabb098"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"25b95d19b8fcf819e276a85016ca85cc3f319366","unresolved":true,"context_lines":[{"line_number":3262,"context_line":"                             force_unmap\u003dFalse,"},{"line_number":3263,"context_line":"                             force_delete\u003dFalse)"},{"line_number":3264,"context_line":"        except exception.VolumeBackendAPIException as ex:"},{"line_number":3265,"context_line":"            if \"CMMVC5840E\" in str(ex.msg):"},{"line_number":3266,"context_line":"                msg \u003d (\u0027The vdisk to be deleted has a FlashCopy mapping/\u0027"},{"line_number":3267,"context_line":"                       \u0027 is in a RC relationship/ restore is in-progress.\u0027"},{"line_number":3268,"context_line":"                       \u0027 Waiting for mapping/ restore to complete.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"8d37c355_5844d8aa","line":3265,"updated":"2026-04-15 08:51:55.000000000","message":"no attribute guard\nex#593 if hasattr(ex, \u0027msg\u0027) and \u0027CMMVC8749E\u0027 in ex.msg:","commit_id":"340265fb6d1dd7eeb9b7fca75ff8659b58681f6c"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"25b95d19b8fcf819e276a85016ca85cc3f319366","unresolved":true,"context_lines":[{"line_number":3262,"context_line":"                             force_unmap\u003dFalse,"},{"line_number":3263,"context_line":"                             force_delete\u003dFalse)"},{"line_number":3264,"context_line":"        except exception.VolumeBackendAPIException as ex:"},{"line_number":3265,"context_line":"            if \"CMMVC5840E\" in str(ex.msg):"},{"line_number":3266,"context_line":"                msg \u003d (\u0027The vdisk to be deleted has a FlashCopy mapping/\u0027"},{"line_number":3267,"context_line":"                       \u0027 is in a RC relationship/ restore is in-progress.\u0027"},{"line_number":3268,"context_line":"                       \u0027 Waiting for mapping/ restore to complete.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d3f5a1f4_3151a429","line":3265,"updated":"2026-04-15 08:51:55.000000000","message":"server returns any error code other than CMMVC5840E (e.g., CMMVC5753E \u003d volume not found during a race etc...) the exception is silently dropped and delete_vdisk returns None as if the operation succeeded","commit_id":"340265fb6d1dd7eeb9b7fca75ff8659b58681f6c"},{"author":{"_account_id":36800,"name":"Vrinda Dhakad","display_name":"vdhakad","email":"vrinda.dhakad@ibm.com","username":"vdhakad"},"change_message_id":"57192a3903a5d681cf14d712018dae73fb9a9f85","unresolved":false,"context_lines":[{"line_number":3262,"context_line":"                             force_unmap\u003dFalse,"},{"line_number":3263,"context_line":"                             force_delete\u003dFalse)"},{"line_number":3264,"context_line":"        except exception.VolumeBackendAPIException as ex:"},{"line_number":3265,"context_line":"            if \"CMMVC5840E\" in str(ex.msg):"},{"line_number":3266,"context_line":"                msg \u003d (\u0027The vdisk to be deleted has a FlashCopy mapping/\u0027"},{"line_number":3267,"context_line":"                       \u0027 is in a RC relationship/ restore is in-progress.\u0027"},{"line_number":3268,"context_line":"                       \u0027 Waiting for mapping/ restore to complete.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"954b9203_d8ff7083","line":3265,"in_reply_to":"8d37c355_5844d8aa","updated":"2026-05-20 07:04:40.000000000","message":"Done","commit_id":"340265fb6d1dd7eeb9b7fca75ff8659b58681f6c"},{"author":{"_account_id":36800,"name":"Vrinda Dhakad","display_name":"vdhakad","email":"vrinda.dhakad@ibm.com","username":"vdhakad"},"change_message_id":"57192a3903a5d681cf14d712018dae73fb9a9f85","unresolved":false,"context_lines":[{"line_number":3262,"context_line":"                             force_unmap\u003dFalse,"},{"line_number":3263,"context_line":"                             force_delete\u003dFalse)"},{"line_number":3264,"context_line":"        except exception.VolumeBackendAPIException as ex:"},{"line_number":3265,"context_line":"            if \"CMMVC5840E\" in str(ex.msg):"},{"line_number":3266,"context_line":"                msg \u003d (\u0027The vdisk to be deleted has a FlashCopy mapping/\u0027"},{"line_number":3267,"context_line":"                       \u0027 is in a RC relationship/ restore is in-progress.\u0027"},{"line_number":3268,"context_line":"                       \u0027 Waiting for mapping/ restore to complete.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"82fcece6_dcea6008","line":3265,"in_reply_to":"d3f5a1f4_3151a429","updated":"2026-05-20 07:04:40.000000000","message":"Done","commit_id":"340265fb6d1dd7eeb9b7fca75ff8659b58681f6c"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"238de14125a509eee92949bdca4df82b55e62e89","unresolved":true,"context_lines":[{"line_number":4556,"context_line":"        tgt_vol, rel_info \u003d self._helpers.get_target_volume_information("},{"line_number":4557,"context_line":"            volume)"},{"line_number":4558,"context_line":""},{"line_number":4559,"context_line":"        ret \u003d self._helpers.ensure_vdisk_no_fc_mappings(volume_name,"},{"line_number":4560,"context_line":"                                                        allow_snaps\u003dFalse,"},{"line_number":4561,"context_line":"                                                        rel_info\u003drel_info)"},{"line_number":4562,"context_line":"        if not ret:"}],"source_content_type":"text/x-python","patch_set":1,"id":"b14f722e_cabb1848","line":4559,"updated":"2026-04-14 11:01:34.000000000","message":"Do we really need to check for vdisk fcmapping during resize.","commit_id":"340265fb6d1dd7eeb9b7fca75ff8659b58681f6c"},{"author":{"_account_id":36800,"name":"Vrinda Dhakad","display_name":"vdhakad","email":"vrinda.dhakad@ibm.com","username":"vdhakad"},"change_message_id":"57192a3903a5d681cf14d712018dae73fb9a9f85","unresolved":false,"context_lines":[{"line_number":4556,"context_line":"        tgt_vol, rel_info \u003d self._helpers.get_target_volume_information("},{"line_number":4557,"context_line":"            volume)"},{"line_number":4558,"context_line":""},{"line_number":4559,"context_line":"        ret \u003d self._helpers.ensure_vdisk_no_fc_mappings(volume_name,"},{"line_number":4560,"context_line":"                                                        allow_snaps\u003dFalse,"},{"line_number":4561,"context_line":"                                                        rel_info\u003drel_info)"},{"line_number":4562,"context_line":"        if not ret:"}],"source_content_type":"text/x-python","patch_set":1,"id":"2e4ae6bd_76307138","line":4559,"in_reply_to":"b14f722e_cabb1848","updated":"2026-05-20 07:04:40.000000000","message":"This should be handled in patch: https://review.opendev.org/c/openstack/cinder/+/912053","commit_id":"340265fb6d1dd7eeb9b7fca75ff8659b58681f6c"},{"author":{"_account_id":38081,"name":"Anthony Galica","display_name":"agalica","email":"anthony.galica@hitachivantara.com","username":"agalica","status":"Hitachi Vantara"},"change_message_id":"5bc702b492d025fc9aa2b183af4d0e8b55fa3422","unresolved":true,"context_lines":[{"line_number":185,"context_line":"                help\u003d\u0027Parameter to allow or prevent volumes with legacy \u0027"},{"line_number":186,"context_line":"                     \u0027FlashCopy mappings to be part of volume_group_enabled \u0027"},{"line_number":187,"context_line":"                     \u0027and temporary_volume_group_enabled groups.\u0027),"},{"line_number":188,"context_line":"    cfg.IntOpt(\u0027check_fcmapping_interval\u0027,"},{"line_number":189,"context_line":"               default\u003d11,"},{"line_number":190,"context_line":"               help\u003d\u0027The interval at which driver will check for fcmappings \u0027"},{"line_number":191,"context_line":"                    \u0027to ensure no mappings exists before operations that are \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f461197_224530da","line":188,"updated":"2026-07-17 15:15:26.000000000","message":"Nitpick: Perhaps mention the time unit.  I assume seconds, but can\u0027t hurt to mention it.","commit_id":"839f28c074f4adf440fc1dc7937e8a9addabb098"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"805c11024a448f9ad816b4a291e40b98ed3cc0ab","unresolved":true,"context_lines":[{"line_number":185,"context_line":"                help\u003d\u0027Parameter to allow or prevent volumes with legacy \u0027"},{"line_number":186,"context_line":"                     \u0027FlashCopy mappings to be part of volume_group_enabled \u0027"},{"line_number":187,"context_line":"                     \u0027and temporary_volume_group_enabled groups.\u0027),"},{"line_number":188,"context_line":"    cfg.IntOpt(\u0027check_fcmapping_interval\u0027,"},{"line_number":189,"context_line":"               default\u003d11,"},{"line_number":190,"context_line":"               help\u003d\u0027The interval at which driver will check for fcmappings \u0027"},{"line_number":191,"context_line":"                    \u0027to ensure no mappings exists before operations that are \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"42ef81cc_1f40dd73","line":188,"in_reply_to":"7f461197_224530da","updated":"2026-07-17 16:30:37.000000000","message":"Agree with agalica that you should mention the time unit.","commit_id":"839f28c074f4adf440fc1dc7937e8a9addabb098"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"805c11024a448f9ad816b4a291e40b98ed3cc0ab","unresolved":true,"context_lines":[{"line_number":190,"context_line":"               help\u003d\u0027The interval at which driver will check for fcmappings \u0027"},{"line_number":191,"context_line":"                    \u0027to ensure no mappings exists before operations that are \u0027"},{"line_number":192,"context_line":"                    \u0027affected due to ongoing fcmaps. Set the value longer \u0027"},{"line_number":193,"context_line":"                    \u0027than the volume service hearbeat.\u0027),"},{"line_number":194,"context_line":"]"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":2,"id":"6c60486f_d07ad4d0","line":193,"range":{"start_line":193,"start_character":45,"end_line":193,"end_character":53},"updated":"2026-07-17 16:30:37.000000000","message":"heartbeat\n\nAlso, are you referring to the \u0027report_interval\u0027 option (which is seconds), or something else?","commit_id":"839f28c074f4adf440fc1dc7937e8a9addabb098"}],"doc/source/configuration/tables/cinder-storwize.inc":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"805c11024a448f9ad816b4a291e40b98ed3cc0ab","unresolved":true,"context_lines":[{"line_number":76,"context_line":"     - (Boolean) Specifies whether volumegroup snapshots can be created on volumes having legacy FlashCopy mappings or not."},{"line_number":77,"context_line":"   * - ``check_fcmapping_interval`` \u003d ``11``"},{"line_number":78,"context_line":"     - (Integer) The interval at which driver will check for fcmappings to ensure no mappings exists before operations that are affected due to ongoing fcmaps. Set the value longer than the volume service hearbeat."},{"line_number":79,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"eac74c5a_bef84657","line":79,"updated":"2026-07-17 16:30:37.000000000","message":"For a followup: I don\u0027t think you need to maintain this table manually any more; we have a sphinx extension in doc/ext/driver_opts.py that should generate the table directly from the config option definition.  See for example,\nhttps://opendev.org/openstack/cinder/blame/commit/de0ba0a17cd37f80021ac8f34c72cba51c021218/doc/source/configuration/block-storage/drivers/huawei-storage-driver.rst#L519-L525","commit_id":"839f28c074f4adf440fc1dc7937e8a9addabb098"}]}