)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"f2b9add201514d7a038d18f7b71ae8c1c54daa4f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bcc516e7_15ab41d9","updated":"2026-04-30 16:53:40.000000000","message":"do we need to add min mypy version to tox.ini?","commit_id":"26b4c115cb31d912aaf1a231a01a03a98f12159e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d14a75fdcd98e968b45075f2ece6de13227815fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ba5d9d3a_c87e5306","updated":"2026-04-17 16:04:44.000000000","message":"recheck timeout","commit_id":"26b4c115cb31d912aaf1a231a01a03a98f12159e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"63c5f822e8aa337433a0d9da54dd07beeb304ed7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"82fc76b8_a149d806","updated":"2026-05-07 21:34:52.000000000","message":"Forgot to vote.","commit_id":"7b016f85e5db9f0c1767a0835f32c3e760038acc"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7901e954234b817ee244248aeaf0c1e798896aba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bece5758_9fe3df78","updated":"2026-05-07 21:34:36.000000000","message":"Thanks for posting this, Stephen.  Comment inline.","commit_id":"7b016f85e5db9f0c1767a0835f32c3e760038acc"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"bc794026fee2a35c580332e89e26de1db4424a44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"420eb569_885a38e4","updated":"2026-05-08 13:37:36.000000000","message":"LGTM; zuul is going to -1 on this round due to unrelated issues, but the mypy job is passing, and the tox mypy testenv works for me locally, so I\u0027m good with this change.","commit_id":"93d102ab3ae26ea3b739f3de616c262e7f063132"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4d0445db38d031963d6cb5eabfb3d7fd112202f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4636c948_dfd248f9","updated":"2026-05-12 11:22:31.000000000","message":"recheck","commit_id":"93d102ab3ae26ea3b739f3de616c262e7f063132"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6425ab0ed1761d31b64bd6470e841e341d98a952","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"10de5a80_bdd0b34c","updated":"2026-05-27 12:30:57.000000000","message":"I think the mypy job will fail upon recheck; we\u0027ll need to rebase this on https://review.opendev.org/c/openstack/cinder/+/990130","commit_id":"dd765d7196bac4cd5851947d142272db21baba98"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"dfcb4cfdcd5dcd7b97faa5a8b5cd3da7e91b8ed7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d884b10d_760c9801","updated":"2026-05-28 09:53:15.000000000","message":"oh mypy also failed.\n\nbut why, this patch do not update volume/manger.py !!!  we should not need rebase!!!!\n\n```\n2026-05-28 06:41:33.676716 | ubuntu-noble | cinder/volume/manager.py: note: In member \"__init__\" of class \"VolumeManager\":\n2026-05-28 06:41:33.676777 | ubuntu-noble | cinder/volume/manager.py:307:19: error: Module has no attribute \"urllib3\"\n2026-05-28 06:41:33.676790 | ubuntu-noble | [attr-defined]\n2026-05-28 06:41:33.676801 | ubuntu-noble |                 rpu \u003d requests.packages.urllib3\n2026-05-28 06:41:33.676811 | ubuntu-noble |                       ^~~~~~~~~~~~~~~~~~~~~~~~~\n2026-05-28 06:41:34.219722 | ubuntu-noble | Generated HTML report (via XSLT): /home/zuul/src/opendev.org/openstack/cinder/mypy-report/index.html\n2026-05-28 06:41:34.219796 | ubuntu-noble | Found 1 error in 1 file (checked 56 source files)\n2026-05-28 06:41:34.233578 | ubuntu-noble | mypy: 15603 C exit 1 (9.26 seconds) /home/zuul/src/opendev.org/openstack/cinder\u003e mypy --cache-dir\u003d/home/zuul/src/opendev.org/openstack/cinder/.tox/mypy/mypy_cache pid\u003d6803 [tox/execute/api.py:308]\n2026-05-28 06:41:34.235274 | ubuntu-noble | .pkg: 15604 W _exit\u003e python /home/zuul/.local/tox/lib/python3.12/site-packages/pyproject_api/_backend.py True pbr.build [tox/tox_env/api.py:485]\n2026-05-28 06:41:34.236524 | ubuntu-noble | Backend: run command _exit with args {}\n2026-05-28 06:41:34.236547 | ubuntu-noble | Backend: Wrote response {\u0027return\u0027: 0} to /tmp/pep517__exit-osvueuko.json\n2026-05-28 06:41:34.238040 | ubuntu-noble | .pkg: 15607 I exit None (0.00 seconds) /home/zuul/src/opendev.org/openstack/cinder\u003e python /home/zuul/.local/tox/lib/python3.12/site-packages/pyproject_api/_backend.py True pbr.build pid\u003d6523 [tox/execute/api.py:308]\n2026-05-28 06:41:34.302799 | ubuntu-noble | .pkg: 15672 D delete package /home/zuul/src/opendev.org/openstack/cinder/.tox/.tmp/package/2/cinder-28.1.0.dev100-0.editable-py3-none-any.whl [tox/tox_env/python/virtual_env/package/pyproject.py:245]\n2026-05-28 06:41:34.304722 | ubuntu-noble |   mypy: FAIL code 1 (14.91\u003dsetup[5.66]+cmd[9.26] seconds)\n```","commit_id":"1fa19f0e42749ff3e95bf9a9e452b415fc25cab1"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"5191d67196287c5bee16ddfb85a2083779830baf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"22680d16_57d2e9a7","updated":"2026-05-28 06:31:12.000000000","message":"recheck\ncinder-mypy job is fixed and we need this","commit_id":"1fa19f0e42749ff3e95bf9a9e452b415fc25cab1"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"2abed5671a5f25c79cdac4208ccb54a54fabaabd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e021b0ce_dcf08c5b","updated":"2026-05-28 09:50:56.000000000","message":"recheck\nin hope this is not another CI blocker ☹️\n\nunrelated test failed in openstacksdk-functional-devstack job\nhttps://c29ca3abb67549251b43-47f48df00c64fad5ac52c18b2c99603a.ssl.cf5.rackcdn.com/openstack/fd212996c1424777bb60fc0ec675792c/testr_results.html","commit_id":"1fa19f0e42749ff3e95bf9a9e452b415fc25cab1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fc9d1f97cc5af69e083215420a9433d1cee30f79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f88600b8_91c07d20","in_reply_to":"684ad299_0bd32378","updated":"2026-05-28 12:31:14.000000000","message":"Ah, wait: I had not seen your fix. Apologies.","commit_id":"1fa19f0e42749ff3e95bf9a9e452b415fc25cab1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b5773ce0a667ff1f62903b8cbf34f26dc11b6fa6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"684ad299_0bd32378","in_reply_to":"bd67c620_a2277632","updated":"2026-05-28 12:30:26.000000000","message":"\u003e but why, this patch do not update volume/manger.py !!! we should not need rebase!!!!\n\nWhy are we shouting!!!! 😉 This is a legitimate issue, though I\u0027m not sure why it\u0027s popped up here and not elsewhere. I\u0027ve proposed a fix below this.","commit_id":"1fa19f0e42749ff3e95bf9a9e452b415fc25cab1"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"56e8516559fa7be6ae8d336d0f22551b90edd2b7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bd67c620_a2277632","in_reply_to":"d884b10d_760c9801","updated":"2026-05-28 10:13:25.000000000","message":"this is specific for this patch and not failing for other patches.","commit_id":"1fa19f0e42749ff3e95bf9a9e452b415fc25cab1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8a46e14e5e3ca727387994f25e7f402f60427219","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"afdeea7c_716ee30d","updated":"2026-06-02 13:00:28.000000000","message":"Still LGTM.","commit_id":"eb16b7936a296f22894b260849d4a110e07cf27d"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"9c123727a602b0917a696a62953d9ce14a10a4d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"28ff566d_cdcb3f7d","updated":"2026-05-28 13:06:12.000000000","message":"lgtm","commit_id":"eb16b7936a296f22894b260849d4a110e07cf27d"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"cbc98f439a13f56fc35673e6edfb1964a1fbcf83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"59546d1c_486ada9e","updated":"2026-05-28 13:03:32.000000000","message":"oh nice, I thought rebasing might run CI again on [1] but it did not, it\u0027s only re running here. not sure how relation chain in between 3 commits working here.\n\n[1] https://review.opendev.org/c/openstack/cinder/+/990441/1","commit_id":"eb16b7936a296f22894b260849d4a110e07cf27d"}],"pyproject.toml":[{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"f2b9add201514d7a038d18f7b71ae8c1c54daa4f","unresolved":true,"context_lines":[{"line_number":182,"context_line":"# disallow_untyped_defs \u003d true"},{"line_number":183,"context_line":"extra_checks \u003d true"},{"line_number":184,"context_line":"no_implicit_reexport \u003d true"},{"line_number":185,"context_line":"strict_bytes \u003d true"},{"line_number":186,"context_line":"strict_equality \u003d true"},{"line_number":187,"context_line":"# warn_redundant_casts \u003d true"},{"line_number":188,"context_line":"# warn_return_any \u003d true"}],"source_content_type":"text/x-toml","patch_set":1,"id":"70d67d0a_3aaf640c","line":185,"updated":"2026-04-30 16:53:40.000000000","message":"do we need to add min version to tox.ini? check version from https://github.com/python/mypy/pull/19002","commit_id":"26b4c115cb31d912aaf1a231a01a03a98f12159e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8e2173f7393a1c59635f0e7f3f890ce8c8aa984a","unresolved":false,"context_lines":[{"line_number":182,"context_line":"# disallow_untyped_defs \u003d true"},{"line_number":183,"context_line":"extra_checks \u003d true"},{"line_number":184,"context_line":"no_implicit_reexport \u003d true"},{"line_number":185,"context_line":"strict_bytes \u003d true"},{"line_number":186,"context_line":"strict_equality \u003d true"},{"line_number":187,"context_line":"# warn_redundant_casts \u003d true"},{"line_number":188,"context_line":"# warn_return_any \u003d true"}],"source_content_type":"text/x-toml","patch_set":1,"id":"535661e7_1c24f479","line":185,"in_reply_to":"70d67d0a_3aaf640c","updated":"2026-04-30 17:01:07.000000000","message":"I don\u0027t think so. Firstly, this is not a runtime dependency. Secondly, this is not included in `upper-constraints.txt` (by design) and, absent a constraint, `pip install` defaults to the latest version of a package available in PyPI (or your mirror) that suits the environment (i.e. `python_version` and `platform`). There\u0027s no realistic scenario where we will end up pulling an ancient version of mypy here. I don\u0027t see the point in adding a lower bound unless we want to take advantage of particularly new dependencies.","commit_id":"26b4c115cb31d912aaf1a231a01a03a98f12159e"}],"tox.ini":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7901e954234b817ee244248aeaf0c1e798896aba","unresolved":true,"context_lines":[{"line_number":190,"context_line":"  types-decorator"},{"line_number":191,"context_line":"  types-requests"},{"line_number":192,"context_line":"  types-tabulate"},{"line_number":193,"context_line":"  mypy"},{"line_number":194,"context_line":"commands \u003d"},{"line_number":195,"context_line":"  mypy --cache-dir\u003d\"{envdir}/mypy_cache\" {posargs}"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"22bcff0f_37bcf552","line":193,"updated":"2026-05-07 21:34:36.000000000","message":"I understand your point about test-requirements.txt, but the mypy job is voting in the gate and it\u0027s not included in upper-constraints.  We have had it happen that a new release came out and broke the gate at an inconvenient time, which is why we had a cap on it in test-requirements.txt  So I think we should make this\n\n```\nmypy\u003e\u003d1.7.0,\u003c1.21.0\n\nThe current mypy release is 1.20.2, so the way Eric had it capped, we\u0027ll catch bugfix releases automatically, but will require manual intervention to move to the next minor release.\n\nI pretty much buy the explanation you gave jayaanand on a previous PS, but if we\u0027re going to specify a max, might as well set a min.  Though I won\u0027t insist on that.\n\nI\u0027m not sure how fast moving the other deps listed here are, but we might want to cap those too.","commit_id":"7b016f85e5db9f0c1767a0835f32c3e760038acc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c31e9eb57a376d1a94016c01775213f83612a32d","unresolved":false,"context_lines":[{"line_number":190,"context_line":"  types-decorator"},{"line_number":191,"context_line":"  types-requests"},{"line_number":192,"context_line":"  types-tabulate"},{"line_number":193,"context_line":"  mypy"},{"line_number":194,"context_line":"commands \u003d"},{"line_number":195,"context_line":"  mypy --cache-dir\u003d\"{envdir}/mypy_cache\" {posargs}"},{"line_number":196,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"197b56d3_d7df413c","line":193,"in_reply_to":"22bcff0f_37bcf552","updated":"2026-05-08 11:33:43.000000000","message":"Fair. I\u0027ve added the same range to `mypy`. The `types-` packages are released with varying frequency, but new releases only include coverage for new APIs (which would require a corresponding bump in the actual package to use, of course) and bugfixes (which we want), so I don\u0027t think there\u0027s a good reason to cap _those_.","commit_id":"7b016f85e5db9f0c1767a0835f32c3e760038acc"}]}