)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"d2e7c481da49e9c7e2f2e46894c72b0b4157098e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"37067354_a2a7f9f7","updated":"2026-07-12 09:34:24.000000000","message":"@jayaanand.borra@netapp.com thanks your feedback. please check the reply. Also, as I understand it, this is a backport and must remain identical to the merged master commit per the stable branch policy, so I\u0027d prefer not to modify it here.","commit_id":"09599f4dee134728de3ed0be33e83e2208ead6ef"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"a030c6215a467f5ae434463fa24f1b4420dedcb0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"18b8a708_a357c0c3","updated":"2026-06-09 06:12:41.000000000","message":"This is a backport request. LGTM.","commit_id":"09599f4dee134728de3ed0be33e83e2208ead6ef"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"4598a0279590766785f800027bb3598e450eaca1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0fbb65fe_16ebd7a9","updated":"2026-07-09 08:08:04.000000000","message":"can you confirm if manage and volume from snapshot and other workflows dosn\u0027t need this change?","commit_id":"09599f4dee134728de3ed0be33e83e2208ead6ef"},{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"b764ea309d57eb6ccd9d17000d882cfd9a505de2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5cb23fbc_cbd34bec","updated":"2026-06-08 10:11:13.000000000","message":"recheck","commit_id":"09599f4dee134728de3ed0be33e83e2208ead6ef"},{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"84103e196d4c63662eaf5ab8b1631d88d6b86f63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b1b255ea_49fe5036","updated":"2026-07-03 01:15:35.000000000","message":"recheck","commit_id":"09599f4dee134728de3ed0be33e83e2208ead6ef"},{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"450e0932c21664b1b541210ef1177cd56fd0d795","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e0d6f873_7430f3d4","updated":"2026-05-14 11:44:32.000000000","message":"recheck","commit_id":"09599f4dee134728de3ed0be33e83e2208ead6ef"},{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"ed915bc94edb9a64a9ec2907dc5dd27e64eddbf5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f8fe6e2c_c8169936","updated":"2026-05-25 08:12:47.000000000","message":"recheck","commit_id":"09599f4dee134728de3ed0be33e83e2208ead6ef"},{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"d2e7c481da49e9c7e2f2e46894c72b0b4157098e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f05aa141_361c8229","in_reply_to":"0fbb65fe_16ebd7a9","updated":"2026-07-12 09:34:24.000000000","message":"Yes, this is intentional. The driver only sets space-allocation at LUN creation time in the blank create_volume() path — the clone-based paths have never set it, since the feature was introduced in https://review.opendev.org/c/openstack/cinder/+/893106 (neither ZAPI clone-create nor the REST clone request passes it; cloned LUNs inherit it from the source LUN). \n\nFor manage_existing, the driver adopts an existing LUN as-is, so its current space-allocation setting is preserved, which I believe is the expected behavior there. So this patch does not change behavior for any of those workflows.","commit_id":"09599f4dee134728de3ed0be33e83e2208ead6ef"}],"cinder/tests/unit/volume/drivers/netapp/dataontap/test_block_base.py":[{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"4598a0279590766785f800027bb3598e450eaca1","unresolved":true,"context_lines":[{"line_number":222,"context_line":"        self.mock_object(self.library, \u0027_add_lun_to_table\u0027)"},{"line_number":223,"context_line":"        self.mock_object(self.library, \u0027_mark_qos_policy_group_for_deletion\u0027)"},{"line_number":224,"context_line":"        self.mock_object(self.library, \u0027_get_volume_model_update\u0027)"},{"line_number":225,"context_line":"        self.zapi_client.get_ontap_version.return_value \u003d (9, 14, 0)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        self.library.create_volume(fake.VOLUME)"},{"line_number":228,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7656eab2_eee1aff8","line":225,"updated":"2026-07-09 08:08:04.000000000","message":"ontap version is harcoded multiple times. can you move to global and club tests if applicable","commit_id":"09599f4dee134728de3ed0be33e83e2208ead6ef"},{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"d2e7c481da49e9c7e2f2e46894c72b0b4157098e","unresolved":true,"context_lines":[{"line_number":222,"context_line":"        self.mock_object(self.library, \u0027_add_lun_to_table\u0027)"},{"line_number":223,"context_line":"        self.mock_object(self.library, \u0027_mark_qos_policy_group_for_deletion\u0027)"},{"line_number":224,"context_line":"        self.mock_object(self.library, \u0027_get_volume_model_update\u0027)"},{"line_number":225,"context_line":"        self.zapi_client.get_ontap_version.return_value \u003d (9, 14, 0)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        self.library.create_volume(fake.VOLUME)"},{"line_number":228,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"b13c37bd_f6d5acd9","line":225,"in_reply_to":"7656eab2_eee1aff8","updated":"2026-07-12 09:34:24.000000000","message":"Same comment was raised on the 2025.2 backport — please see my reply there: https://review.opendev.org/c/openstack/cinder/+/988574/comment/5e44b340_924846a0/","commit_id":"09599f4dee134728de3ed0be33e83e2208ead6ef"}],"cinder/volume/drivers/netapp/dataontap/block_base.py":[{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"4598a0279590766785f800027bb3598e450eaca1","unresolved":true,"context_lines":[{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        extra_specs \u003d na_utils.get_volume_extra_specs(volume)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        ontap_version \u003d self.zapi_client.get_ontap_version(cached\u003dTrue)"},{"line_number":238,"context_line":"        space_allocation_spec \u003d extra_specs.get(\u0027netapp:space_allocation\u0027)"},{"line_number":239,"context_line":"        if space_allocation_spec is not None:"},{"line_number":240,"context_line":"            space_allocation \u003d volume_utils.is_boolean_str("}],"source_content_type":"text/x-python","patch_set":2,"id":"60ea0f37_bb026f52","line":237,"updated":"2026-07-09 08:08:04.000000000","message":"ontap version is fetched for netapp:space_allocation set scenarios as well. Can be optimized.","commit_id":"09599f4dee134728de3ed0be33e83e2208ead6ef"},{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"d2e7c481da49e9c7e2f2e46894c72b0b4157098e","unresolved":true,"context_lines":[{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        extra_specs \u003d na_utils.get_volume_extra_specs(volume)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        ontap_version \u003d self.zapi_client.get_ontap_version(cached\u003dTrue)"},{"line_number":238,"context_line":"        space_allocation_spec \u003d extra_specs.get(\u0027netapp:space_allocation\u0027)"},{"line_number":239,"context_line":"        if space_allocation_spec is not None:"},{"line_number":240,"context_line":"            space_allocation \u003d volume_utils.is_boolean_str("}],"source_content_type":"text/x-python","patch_set":2,"id":"b60e58ac_6b41f8f3","line":237,"in_reply_to":"60ea0f37_bb026f52","updated":"2026-07-12 09:34:24.000000000","message":"Same comment was raised on the 2025.2 backport — please see my reply there: https://review.opendev.org/c/openstack/cinder/+/988574/comment/40718170_905573a8/","commit_id":"09599f4dee134728de3ed0be33e83e2208ead6ef"}]}
