)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"421a90445836c900496dfb9dcda26f253b61ff2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fc07d591_e2e3c144","updated":"2026-07-12 09:25:35.000000000","message":"@jayaanand.borra@netapp.com thank you for your comment. please check the reply.","commit_id":"6fa71f7ef2791e229cb52e1652fe37aad2cba00e"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"14d315ef69d9233bd23f3dd0d64df6cb0304151c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e4d5e5d2_0768376d","updated":"2026-06-17 12:23:38.000000000","message":"Backport request. +1 since already reviewed upstream.","commit_id":"6fa71f7ef2791e229cb52e1652fe37aad2cba00e"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"1f28646452c0f75802dc81b50f43ef1682416904","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"268b06b4_6be5e7a1","updated":"2026-07-12 15:14:03.000000000","message":"bad cheery-pick\nthis should have come from deeed8f3ff97c5a9ba37f2c46056c97e75d7fc1c","commit_id":"6fa71f7ef2791e229cb52e1652fe37aad2cba00e"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"3cf08c72f9da3952a5e089c09b616fd923e90ffe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c738d77f_f3e7fb85","updated":"2026-07-09 08:01:14.000000000","message":"can you please confirm behavior for these scenarios...This patch updates only the blank create_volume() path.Manage and Clone-based creation paths such as create_volume_from_snapshot() and create_cloned_volume() go through _clone_source_to_destination() / _clone_lun() and do not apply this version-based default logic. Are these scenarios automatically taken care?","commit_id":"6fa71f7ef2791e229cb52e1652fe37aad2cba00e"},{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"51fb07efbdc3cd035e7238cec3aa0cd5901ac8c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"76024edb_5205eb15","updated":"2026-07-02 14:42:32.000000000","message":"recheck","commit_id":"6fa71f7ef2791e229cb52e1652fe37aad2cba00e"},{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"3478753679f548557234982ceb69c8d634fbd057","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"edfe1816_291b0da7","updated":"2026-05-25 08:01:36.000000000","message":"recheck","commit_id":"6fa71f7ef2791e229cb52e1652fe37aad2cba00e"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"63ecce9073abd989f0ad650ff0261e5f99320588","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"44215468_8447601f","updated":"2026-05-14 11:16:58.000000000","message":"recheck\n\nunrealted fail\n```\n2026-05-14 08:39:17.877494 | controller | ERROR: Cannot install sphinx!\u003d2.1.0 and \u003e\u003d2.0.0 because these package versions have conflicting dependencies.\n2026-05-14 08:39:17.877562 | controller |\n2026-05-14 08:39:17.877586 | controller | The conflict is caused by:\n2026-05-14 08:39:17.877603 | controller |     The user requested sphinx!\u003d2.1.0 and \u003e\u003d2.0.0\n2026-05-14 08:39:17.877640 | controller |     The user requested (constraint) sphinx\u003d\u003d\u003d9.0.4\n2026-05-14 08:39:17.877660 | controller |\n2026-05-14 08:39:17.877698 | controller | To fix this you could try to:\n2026-05-14 08:39:17.877739 | controller | 1. loosen the range of package versions you\u0027ve specified\n2026-05-14 08:39:17.877775 | controller | 2. remove package versions to allow pip to attempt to solve the dependency conflict\n2026-05-14 08:39:17.877801 | controller |\n2026-05-14 08:39:17.877832 | controller | ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts\n2026-05-14 08:39:17.877860 | controller |\n2026-05-14 08:39:17.877878 | controller | [notice] A new release of pip is available: 24.1 -\u003e 26.1.1\n2026-05-14 08:39:17.877891 | controller | [notice] To update, run: pip install --upgrade pip\n2026-05-14 08:39:17.877906 | controller |\n2026-05-14 08:39:17.877947 | controller | \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d log end \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n2026-05-14 08:39:17.877998 | controller | ERROR: could not install deps [-chttps://releases.openstack.org/constraints/upper/master, -r/opt/stack/old/tempest/requirements.txt, -r/opt/stack/old/tempest/doc/requirements.txt]; v \u003d InvocationError(\u0027/opt/stack/old/tempest/.tox/venv/bin/python -m pip install -chttps://releases.openstack.org/constraints/upper/master -r/opt/stack/old/tempest/requirements.txt -r/opt/stack/old/tempest/doc/requirements.txt\u0027, 1)\n```\n\n\nthough I do not agree with cherry-pick too, its directly from master, if we merge this, this might create issues in stable branch.","commit_id":"6fa71f7ef2791e229cb52e1652fe37aad2cba00e"},{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"2fcdacda839fceb0b287d025162ec336e50d7ea4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5e4539fc_508a789a","in_reply_to":"268b06b4_6be5e7a1","updated":"2026-07-17 05:57:16.000000000","message":"Thanks for your comment. I didn\u0027t know that, I will reopen this backport after merged at stable/2026.1\nI just checked this guide[1] at this time thanks.\n[1] https://docs.openstack.org/cinder/latest/contributor/backporting.html","commit_id":"6fa71f7ef2791e229cb52e1652fe37aad2cba00e"},{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"421a90445836c900496dfb9dcda26f253b61ff2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6445d932_6ca45dcd","in_reply_to":"c738d77f_f3e7fb85","updated":"2026-07-12 09:25:35.000000000","message":"Yes, this is intentional. The driver only sets space-allocation at LUN creation time in the blank create_volume() path — the clone-based paths have never set it, since the feature was introduced in https://review.opendev.org/c/openstack/cinder/+/893106 (neither ZAPI clone-create nor the REST clone request passes it; cloned LUNs inherit it from the source LUN). So this patch does not change clone/snapshot behavior.\n\nThat said, I agree it would be good to cover those paths as well — they were simply missed when the original feature was added. I think that\u0027s best done as a separate patch on master, since this backport must stay identical to the merged master commit.","commit_id":"6fa71f7ef2791e229cb52e1652fe37aad2cba00e"}],"cinder/tests/unit/volume/drivers/netapp/dataontap/test_block_base.py":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"1f28646452c0f75802dc81b50f43ef1682416904","unresolved":true,"context_lines":[{"line_number":162,"context_line":"        self.mock_object(self.library, \u0027_add_lun_to_table\u0027)"},{"line_number":163,"context_line":"        self.mock_object(self.library, \u0027_mark_qos_policy_group_for_deletion\u0027)"},{"line_number":164,"context_line":"        self.mock_object(self.library, \u0027_get_volume_model_update\u0027)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        self.library.create_volume(fake.VOLUME)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        self.library._create_lun.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":2,"id":"80259304_70496933","line":165,"updated":"2026-07-12 15:14:03.000000000","message":"missing `self.zapi_client.get_ontap_version.return_value \u003d (9, 14, 0)`","commit_id":"6fa71f7ef2791e229cb52e1652fe37aad2cba00e"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"3cf08c72f9da3952a5e089c09b616fd923e90ffe","unresolved":true,"context_lines":[{"line_number":222,"context_line":"        self.mock_object(self.library, \u0027_add_lun_to_table\u0027)"},{"line_number":223,"context_line":"        self.mock_object(self.library, \u0027_mark_qos_policy_group_for_deletion\u0027)"},{"line_number":224,"context_line":"        self.mock_object(self.library, \u0027_get_volume_model_update\u0027)"},{"line_number":225,"context_line":"        self.zapi_client.get_ontap_version.return_value \u003d (9, 14, 0)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        self.library.create_volume(fake.VOLUME)"},{"line_number":228,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5e44b340_924846a0","line":225,"updated":"2026-07-09 08:01:14.000000000","message":"ontap version information is hardcode and repeated for multiple steps. can you create at global level and re-use.","commit_id":"6fa71f7ef2791e229cb52e1652fe37aad2cba00e"},{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"421a90445836c900496dfb9dcda26f253b61ff2d","unresolved":true,"context_lines":[{"line_number":222,"context_line":"        self.mock_object(self.library, \u0027_add_lun_to_table\u0027)"},{"line_number":223,"context_line":"        self.mock_object(self.library, \u0027_mark_qos_policy_group_for_deletion\u0027)"},{"line_number":224,"context_line":"        self.mock_object(self.library, \u0027_get_volume_model_update\u0027)"},{"line_number":225,"context_line":"        self.zapi_client.get_ontap_version.return_value \u003d (9, 14, 0)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        self.library.create_volume(fake.VOLUME)"},{"line_number":228,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"0cb55e60_eacf2ed1","line":225,"in_reply_to":"5e44b340_924846a0","updated":"2026-07-12 09:25:35.000000000","message":"I think that’s a good suggestion, but as you know, this patch is a backport. How about updating the master branch first?","commit_id":"6fa71f7ef2791e229cb52e1652fe37aad2cba00e"}],"cinder/volume/drivers/netapp/dataontap/block_base.py":[{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"3cf08c72f9da3952a5e089c09b616fd923e90ffe","unresolved":true,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        extra_specs \u003d na_utils.get_volume_extra_specs(volume)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        ontap_version \u003d self.zapi_client.get_ontap_version(cached\u003dTrue)"},{"line_number":240,"context_line":"        space_allocation_spec \u003d extra_specs.get(\u0027netapp:space_allocation\u0027)"},{"line_number":241,"context_line":"        if space_allocation_spec is not None:"},{"line_number":242,"context_line":"            space_allocation \u003d volume_utils.is_boolean_str("}],"source_content_type":"text/x-python","patch_set":2,"id":"40718170_905573a8","line":239,"updated":"2026-07-09 08:01:14.000000000","message":"avoid fetching/comparing the ONTAP version when netapp:space_allocation is explicitly set","commit_id":"6fa71f7ef2791e229cb52e1652fe37aad2cba00e"},{"author":{"_account_id":36686,"name":"Inyong Hong","display_name":"hongp","email":"inyong.hong@samsung.com","username":"hong-p"},"change_message_id":"421a90445836c900496dfb9dcda26f253b61ff2d","unresolved":true,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"        extra_specs \u003d na_utils.get_volume_extra_specs(volume)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        ontap_version \u003d self.zapi_client.get_ontap_version(cached\u003dTrue)"},{"line_number":240,"context_line":"        space_allocation_spec \u003d extra_specs.get(\u0027netapp:space_allocation\u0027)"},{"line_number":241,"context_line":"        if space_allocation_spec is not None:"},{"line_number":242,"context_line":"            space_allocation \u003d volume_utils.is_boolean_str("}],"source_content_type":"text/x-python","patch_set":2,"id":"9da8b6dc_fa8c21fb","line":239,"in_reply_to":"40718170_905573a8","updated":"2026-07-12 09:25:35.000000000","message":"Good point. but you know, get_ontap_version(cached\u003dTrue) does not issue an API call — it returns the version tuple stored in memory on the connection object during driver setup, so there is no fetch cost here.","commit_id":"6fa71f7ef2791e229cb52e1652fe37aad2cba00e"}]}
