)]}'
{"cinder/brick/local_dev/lvm.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"dfba652a1fa671c53d2719a8c01f212f199bc3b2","unresolved":true,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        \"\"\""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        if LVM.get_lvm_version(root_helper) \u003c (2, 2, 95):"},{"line_number":252,"context_line":"            LOG.debug(f\"LVM version {LVM.get_lvm_version(root_helper)} \""},{"line_number":253,"context_line":"                      f\"does not support thin provisioning.\")"},{"line_number":254,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"498c10ca_e9f4630c","line":251,"updated":"2026-05-19 16:40:50.000000000","message":"See https://review.opendev.org/c/openstack/cinder/+/899074","commit_id":"05f8ecbbbb046b1e3f4b77ddf96ed45403eaa62b"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"3843c2e4d59c5215ac4db6ebbd5fd55bd0824ae9","unresolved":true,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        \"\"\""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        if LVM.get_lvm_version(root_helper) \u003c (2, 2, 95):"},{"line_number":252,"context_line":"            LOG.debug(f\"LVM version {LVM.get_lvm_version(root_helper)} \""},{"line_number":253,"context_line":"                      f\"does not support thin provisioning.\")"},{"line_number":254,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"5dddb202_3edeedd2","line":251,"in_reply_to":"498c10ca_e9f4630c","updated":"2026-05-20 10:40:49.000000000","message":"Acknowledged","commit_id":"05f8ecbbbb046b1e3f4b77ddf96ed45403eaa62b"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"dfba652a1fa671c53d2719a8c01f212f199bc3b2","unresolved":true,"context_lines":[{"line_number":261,"context_line":"        try:"},{"line_number":262,"context_line":"            # Try to load dm-thin-pool module (succeeds if already loaded,"},{"line_number":263,"context_line":"            # built-in, or successfully loaded as a module)"},{"line_number":264,"context_line":"            cmd \u003d LVM.LVM_CMD_PREFIX + [\"modprobe\", \"dm-thin-pool\"]"},{"line_number":265,"context_line":"            putils.execute(*cmd, root_helper\u003droot_helper, run_as_root\u003dTrue)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"            # Verify thin targets are available via dmsetup"}],"source_content_type":"text/x-python","patch_set":1,"id":"09fe6d90_36f5d343","line":264,"updated":"2026-05-19 16:40:50.000000000","message":"IMO this should be setup outside of Cinder - does this problem occur on any platform other than ubuntu-minimal image?\n\nI don\u0027t think we really want to get into the business of loading kernel modules from Cinder code, we don\u0027t do this for dm-crypt, iscsi_target_mod, etc. either.","commit_id":"05f8ecbbbb046b1e3f4b77ddf96ed45403eaa62b"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"3843c2e4d59c5215ac4db6ebbd5fd55bd0824ae9","unresolved":true,"context_lines":[{"line_number":261,"context_line":"        try:"},{"line_number":262,"context_line":"            # Try to load dm-thin-pool module (succeeds if already loaded,"},{"line_number":263,"context_line":"            # built-in, or successfully loaded as a module)"},{"line_number":264,"context_line":"            cmd \u003d LVM.LVM_CMD_PREFIX + [\"modprobe\", \"dm-thin-pool\"]"},{"line_number":265,"context_line":"            putils.execute(*cmd, root_helper\u003droot_helper, run_as_root\u003dTrue)"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"            # Verify thin targets are available via dmsetup"}],"source_content_type":"text/x-python","patch_set":1,"id":"ae89313b_07b4bc33","line":264,"in_reply_to":"09fe6d90_36f5d343","updated":"2026-05-20 10:40:49.000000000","message":"\u003e does this problem occur on any platform other than ubuntu-minimal image?\n\nI found this on ubuntu cloud img, and (without devstack) fedora and other systems (beaker) where dm-thin-pool is a loadable module that isn\u0027t pre-loaded.\n\n\u003e I don\u0027t think we really want to get into the business of loading kernel modules from Cinder code, we don\u0027t do this for dm-crypt, iscsi_target_mod, etc. either.\n\nmake sense, though I am not sure if dm-crypt and iSCSI are explicitly fail in same way if unavailable. thin provisioning with lvm_type\u003dauto is (seems to me) designed for graceful fallback, use thin if available else fallback to thick.\n\nI looked for other way on how to verify this, dir `/sys/module/dm_thin_pool/` suppose to exists if loaded - but this still misses unloaded-but-available, like same as dmsetup, thats why I have to call modprobe first.\n\n---\nmy overall need from this bugfix is cinder-volume doesn\u0027t fail to start when thin isn\u0027t available - it should gracefully fall back to thick.\n\n--- \nI see your patch #899074 removes the check entirely, - I\u0027ll ask there about the approach without any runtime detection.","commit_id":"05f8ecbbbb046b1e3f4b77ddf96ed45403eaa62b"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"dfba652a1fa671c53d2719a8c01f212f199bc3b2","unresolved":true,"context_lines":[{"line_number":568,"context_line":"        if not self.supports_thin_provisioning(self._root_helper):"},{"line_number":569,"context_line":"            LOG.error(\"Requested to setup thin provisioning, \""},{"line_number":570,"context_line":"                      \"however thin provisioning is not supported \""},{"line_number":571,"context_line":"                      \"(LVM version too old or kernel lacks dm-thin-pool).\")"},{"line_number":572,"context_line":"            return None"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"        if name is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ab7c4f54_9208e232","line":571,"range":{"start_line":571,"start_character":36,"end_line":571,"end_character":43},"updated":"2026-05-19 16:40:50.000000000","message":"See above - I don\u0027t think we state that anything too old for this is supported anyway.","commit_id":"05f8ecbbbb046b1e3f4b77ddf96ed45403eaa62b"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"3843c2e4d59c5215ac4db6ebbd5fd55bd0824ae9","unresolved":true,"context_lines":[{"line_number":568,"context_line":"        if not self.supports_thin_provisioning(self._root_helper):"},{"line_number":569,"context_line":"            LOG.error(\"Requested to setup thin provisioning, \""},{"line_number":570,"context_line":"                      \"however thin provisioning is not supported \""},{"line_number":571,"context_line":"                      \"(LVM version too old or kernel lacks dm-thin-pool).\")"},{"line_number":572,"context_line":"            return None"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"        if name is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3c689056_9a95708c","line":571,"range":{"start_line":571,"start_character":36,"end_line":571,"end_character":43},"in_reply_to":"ab7c4f54_9208e232","updated":"2026-05-20 10:40:49.000000000","message":"Acknowledged","commit_id":"05f8ecbbbb046b1e3f4b77ddf96ed45403eaa62b"}]}