)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"403e8f858209da80768d646e7c3599c75eba86eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"daa31e67_31c3c978","updated":"2026-05-27 13:16:37.000000000","message":"This must have changed between 1.20 and 1.20.1 or 1.20.2, since https://review.opendev.org/c/openstack/cinder/+/983639 passed the checks?","commit_id":"212e7e15b15f626b50489e1595cc5fc1d6d51d1f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0a77ce00d39e120f26f4e6272701868fc23ab7e2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"55b33303_c87b6a30","updated":"2026-05-27 12:29:38.000000000","message":"We need to merge https://review.opendev.org/c/openstack/cinder/+/985038 right after this patch so that we get some constraints on the mypy version.","commit_id":"212e7e15b15f626b50489e1595cc5fc1d6d51d1f"}],"cinder/volume/manager.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"ed5c3cf04daa2e6d78791695343c6c6cc68c3d68","unresolved":true,"context_lines":[{"line_number":304,"context_line":""},{"line_number":305,"context_line":"        if self.configuration.suppress_requests_ssl_warnings:"},{"line_number":306,"context_line":"            LOG.warning(\"Suppressing requests library SSL Warnings\")"},{"line_number":307,"context_line":"            rpu \u003d requests.packages.urllib3"},{"line_number":308,"context_line":"            rpu.disable_warnings(rpu.exceptions.InsecureRequestWarning)"},{"line_number":309,"context_line":"            rpu.disable_warnings(rpu.exceptions.InsecurePlatformWarning)"},{"line_number":310,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"92a1cad8_17ef1281","line":307,"updated":"2026-05-26 15:55:34.000000000","message":"This code is probably due to be reworked since the requests lib no longer vendors a copy of urllib3?","commit_id":"212e7e15b15f626b50489e1595cc5fc1d6d51d1f"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a876992422623f16f7d5eebb3346055d14ebf315","unresolved":true,"context_lines":[{"line_number":304,"context_line":""},{"line_number":305,"context_line":"        if self.configuration.suppress_requests_ssl_warnings:"},{"line_number":306,"context_line":"            LOG.warning(\"Suppressing requests library SSL Warnings\")"},{"line_number":307,"context_line":"            rpu \u003d requests.packages.urllib3"},{"line_number":308,"context_line":"            rpu.disable_warnings(rpu.exceptions.InsecureRequestWarning)"},{"line_number":309,"context_line":"            rpu.disable_warnings(rpu.exceptions.InsecurePlatformWarning)"},{"line_number":310,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"cd145083_c19b8f7d","line":307,"in_reply_to":"7bc8d47e_ae5ae752","updated":"2026-05-27 13:09:30.000000000","message":"See https://github.com/psf/requests/blob/main/src/requests/packages.py","commit_id":"212e7e15b15f626b50489e1595cc5fc1d6d51d1f"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"a0a135dd81b2f7ffaa1f3eba90b3434ebc4d52fd","unresolved":true,"context_lines":[{"line_number":304,"context_line":""},{"line_number":305,"context_line":"        if self.configuration.suppress_requests_ssl_warnings:"},{"line_number":306,"context_line":"            LOG.warning(\"Suppressing requests library SSL Warnings\")"},{"line_number":307,"context_line":"            rpu \u003d requests.packages.urllib3"},{"line_number":308,"context_line":"            rpu.disable_warnings(rpu.exceptions.InsecureRequestWarning)"},{"line_number":309,"context_line":"            rpu.disable_warnings(rpu.exceptions.InsecurePlatformWarning)"},{"line_number":310,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dd84eaf0_795b0ef0","line":307,"in_reply_to":"92a1cad8_17ef1281","updated":"2026-05-27 07:59:24.000000000","message":"I did not quite get that.\n\ndo you mean urllib3 is no longer part in the requests library, or wont be supported in future, so we should import it directly instead of using requests.packages.urllib3?\n\nI can still access it in  py3.14:\n```\n\u003e\u003e\u003e import requests\n\u003e\u003e\u003e requests.packages.urllib3\n\u003cmodule \u0027urllib3\u0027 from \u0027/usr/lib/python3.14/site-packages/urllib3/__init__.py\u0027\u003e\n\u003e\u003e\u003e\n```","commit_id":"212e7e15b15f626b50489e1595cc5fc1d6d51d1f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0a77ce00d39e120f26f4e6272701868fc23ab7e2","unresolved":true,"context_lines":[{"line_number":304,"context_line":""},{"line_number":305,"context_line":"        if self.configuration.suppress_requests_ssl_warnings:"},{"line_number":306,"context_line":"            LOG.warning(\"Suppressing requests library SSL Warnings\")"},{"line_number":307,"context_line":"            rpu \u003d requests.packages.urllib3"},{"line_number":308,"context_line":"            rpu.disable_warnings(rpu.exceptions.InsecureRequestWarning)"},{"line_number":309,"context_line":"            rpu.disable_warnings(rpu.exceptions.InsecurePlatformWarning)"},{"line_number":310,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7bc8d47e_ae5ae752","line":307,"in_reply_to":"dd84eaf0_795b0ef0","updated":"2026-05-27 12:29:38.000000000","message":"Let\u0027s address Eric\u0027s point later, we need to get the CI job fixed now.","commit_id":"212e7e15b15f626b50489e1595cc5fc1d6d51d1f"}]}