)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"ce137828788d7589355678d0d453cecbdd0cab71","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve Dell PowerStore driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Improve driver function in Dell Powerster driver."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ic5304ac0949f97f529fcc6249b01b790514a1952"},{"line_number":12,"context_line":"Signed-off-by: JaeSeong \u003crornfl916@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"db860a05_ff8c6a90","line":9,"updated":"2026-06-18 17:12:58.000000000","message":"Hi JaeSeong-Shin, would you mind describing what improvement this patch aims to achieve?","commit_id":"0cc8a8cc964b97beab7e1029e53e112f23e218e7"},{"author":{"_account_id":35057,"name":"JaeSeong-Shin","email":"rornfl916@gmail.com","username":"JaeSeong"},"change_message_id":"81c1fcde236eb81867eb5ecf94e242512ed920f5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve Dell PowerStore driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Improve driver function in Dell Powerster driver."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ic5304ac0949f97f529fcc6249b01b790514a1952"},{"line_number":12,"context_line":"Signed-off-by: JaeSeong \u003crornfl916@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"f374ede1_7c888f8b","line":9,"in_reply_to":"9e52f6c9_36aab60d","updated":"2026-07-16 04:16:49.000000000","message":"Done","commit_id":"0cc8a8cc964b97beab7e1029e53e112f23e218e7"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"42f2fd9412035d4b6eeefaf01dc660b08c047a60","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improve Dell PowerStore driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Improve driver function in Dell Powerster driver."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ic5304ac0949f97f529fcc6249b01b790514a1952"},{"line_number":12,"context_line":"Signed-off-by: JaeSeong \u003crornfl916@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9e52f6c9_36aab60d","line":9,"in_reply_to":"db860a05_ff8c6a90","updated":"2026-06-18 17:16:15.000000000","message":"I mean describing in more detail in the commit message.","commit_id":"0cc8a8cc964b97beab7e1029e53e112f23e218e7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":35057,"name":"JaeSeong-Shin","email":"rornfl916@gmail.com","username":"JaeSeong"},"change_message_id":"2dc0ecb625fe7911078be88e8ee3c23cdab5749b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3be555cb_fe7f90c3","updated":"2026-05-27 04:41:49.000000000","message":"recheck","commit_id":"12d2d1ecec2d96c6f2ad5d18db57c2102bb2cd45"},{"author":{"_account_id":35057,"name":"JaeSeong-Shin","email":"rornfl916@gmail.com","username":"JaeSeong"},"change_message_id":"81c1fcde236eb81867eb5ecf94e242512ed920f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4881d22c_cf1c4f63","updated":"2026-07-16 04:16:49.000000000","message":"recheck","commit_id":"0554a4c8394a96f912de69179d78f2c73cf943f0"},{"author":{"_account_id":35057,"name":"JaeSeong-Shin","email":"rornfl916@gmail.com","username":"JaeSeong"},"change_message_id":"3f0324b8a584b798dab39cb32a214645c8cddf4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ca99edaf_09e487fa","updated":"2026-08-13 01:39:05.000000000","message":"recheck","commit_id":"0554a4c8394a96f912de69179d78f2c73cf943f0"},{"author":{"_account_id":35057,"name":"JaeSeong-Shin","email":"rornfl916@gmail.com","username":"JaeSeong"},"change_message_id":"fbeac842248fc168a3838eaac1b88357b532c4ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6f9ef801_19f6a031","updated":"2026-08-13 05:42:57.000000000","message":"recheck","commit_id":"3ab47e8100c8f0d796a11ea8eaee94a86e007e7f"},{"author":{"_account_id":35057,"name":"JaeSeong-Shin","email":"rornfl916@gmail.com","username":"JaeSeong"},"change_message_id":"834f3bb3e030b6ef4c0f50bd7881fe11ac13cdc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8fed4313_20ba78d0","updated":"2026-08-13 04:37:22.000000000","message":"recheck","commit_id":"3ab47e8100c8f0d796a11ea8eaee94a86e007e7f"},{"author":{"_account_id":35057,"name":"JaeSeong-Shin","email":"rornfl916@gmail.com","username":"JaeSeong"},"change_message_id":"408fa402ae082a69dbbd26e817e5db4e3b49e1b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a246a5d3_871b2314","updated":"2026-08-13 05:57:30.000000000","message":"recheck","commit_id":"3ab47e8100c8f0d796a11ea8eaee94a86e007e7f"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"bde826edee3c6af0624806f106378815de5b41a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d2f639ad_43671abc","updated":"2026-09-08 13:57:30.000000000","message":"run-DellEMC PowerStore CI","commit_id":"3ab47e8100c8f0d796a11ea8eaee94a86e007e7f"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"8e3a6f1b4f7784da697667da18ab6dbcaa560d4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6b3c432a_4ff0d119","updated":"2026-09-23 07:23:45.000000000","message":"Thanks for contributing. LGTM","commit_id":"dc68306eebe73e6b5193d4c8dbf2945bf27713cb"}],"cinder/volume/drivers/dell_emc/powerstore/adapter.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f20ea12343873bc22ffee147c0ac8865ff3af26a","unresolved":false,"context_lines":[{"line_number":798,"context_line":"                                                          \"Fractured\"]:"},{"line_number":799,"context_line":"                msg \u003d _(\"Error reverting PowerStore metro \""},{"line_number":800,"context_line":"                        \"volume %(volume_id)s. The replication \""},{"line_number":801,"context_line":"                        \"session %(id)s must be paused or fractured in order to \""},{"line_number":802,"context_line":"                        \"revert metro volumes.\" % {"},{"line_number":803,"context_line":"                            \"volume_id\": volume.id,"},{"line_number":804,"context_line":"                            \"id\": metro_replication_session_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"17631aa3_0d09c5d1","line":801,"updated":"2026-07-14 08:36:48.000000000","message":"pep8: E501 line too long (81 \u003e 79 characters)","commit_id":"2c9040fbe375c141845dc857a834dfdb7c285a64"}],"cinder/volume/drivers/dell_emc/powerstore/driver.py":[{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"a7dc0e17d71db9fc3a832139ae757198f8f801f1","unresolved":true,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def create_volume(self, volume):"},{"line_number":141,"context_line":"        remote_system_name \u003d None"},{"line_number":142,"context_line":"        if utils.is_metro_volume(volume) and self.failover_choices:"},{"line_number":143,"context_line":"            remote_system_name \u003d self.adapters.get("},{"line_number":144,"context_line":"                list(self.failover_choices)[0]).get_cluster_name()"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"61fa1049_99dbacb8","line":142,"updated":"2026-09-17 18:32:32.000000000","message":"This avoids the IndexError, but the metro volume is still passed to CommonAdapter.create_volume() with remote_system_name\u003dNone. The adapter then calls configure_metro(), producing \"remote_system_id\": \"name:None\" after the local volume has already been created. Could we reject the request before creating the volume when no replication backend is configured? The test currently hides this behavior by mocking CommonAdapter.create_volume() entirely.","commit_id":"3ab47e8100c8f0d796a11ea8eaee94a86e007e7f"},{"author":{"_account_id":35057,"name":"JaeSeong-Shin","email":"rornfl916@gmail.com","username":"JaeSeong"},"change_message_id":"4e68ae97d30581eca20ab502e43b7edeccdcdcee","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def create_volume(self, volume):"},{"line_number":141,"context_line":"        remote_system_name \u003d None"},{"line_number":142,"context_line":"        if utils.is_metro_volume(volume) and self.failover_choices:"},{"line_number":143,"context_line":"            remote_system_name \u003d self.adapters.get("},{"line_number":144,"context_line":"                list(self.failover_choices)[0]).get_cluster_name()"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"17641178_aa4a0c7b","line":142,"in_reply_to":"61fa1049_99dbacb8","updated":"2026-09-22 13:17:12.000000000","message":"Thanks for catching that. You\u0027re right that the previous guard only avoided\nthe IndexError and still let the local volume be created before\nconfigure_metro() failed with \"name:None\".\n\nIn the new patchset, create_volume() now raises InvalidVolumeType\nbefore calling the adapter when a metro volume is requested but no\nreplication_device is configured. This can\u0027t be validated in\ncheck_for_setup_error() because metro is determined per volume type.\n\nThe unit test now mocks at the client level and asserts that neither\ncreate_volume() nor configure_metro() is called on the backend.","commit_id":"3ab47e8100c8f0d796a11ea8eaee94a86e007e7f"}]}
