)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0e762d22108fe749fdf001df59d0d827e2afa241","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use urllib3 directly in remaining driver code"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Replace requests.packages.urllib3 with direct urllib3 imports following"},{"line_number":10,"context_line":"the fix in volume/manager.py"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The urllib3 package is a dependency of the requests library and can be"},{"line_number":13,"context_line":"imported directly without issues, this works in all python versions"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"0125a70c_bfd767bc","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":28},"updated":"2026-06-16 13:39:53.000000000","message":"nit: should include reference to the fix and also a Related-Bug: #number tag for the bug that was fixed with the change","commit_id":"738353c242da2c9586e721f3bd6e298343e66d33"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"209b3c863455df902a092bf7d1224361aa823aae","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use urllib3 directly in remaining driver code"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Replace requests.packages.urllib3 with direct urllib3 imports following"},{"line_number":10,"context_line":"the fix in volume/manager.py"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The urllib3 package is a dependency of the requests library and can be"},{"line_number":13,"context_line":"imported directly without issues, this works in all python versions"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"4e919eda_455f1a72","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":28},"in_reply_to":"0125a70c_bfd767bc","updated":"2026-06-16 15:07:40.000000000","message":"we don\u0027t have bug for this unfortunately, this was gate issue which we just fixed [1], and then continue to refactor the code.\n\nhttps://review.opendev.org/c/openstack/cinder/+/990130","commit_id":"738353c242da2c9586e721f3bd6e298343e66d33"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"d0ba7ee7339f6259afd8a2f335756f008749d6ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2372c7dd_a844bbb2","updated":"2026-05-29 17:32:21.000000000","message":"I\u0027ll push another patch with divison of s3 driver.\n\nwaiting for https://review.opendev.org/c/openstack/cinder/+/990441/ to merge as I do not want to lose +2\u0027s there, its been hours since workflow started, normally it completes unders 2.5 hour.\nalso there is no gate job running in patch in zuul, will check mornig.","commit_id":"f88c9b6a3b2d58c329cdea57151003b7d23866ee"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1b28cb886c4dcc36fd297e21cd3fe73577bd161b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"795e14f2_c715a6cf","updated":"2026-06-16 13:35:46.000000000","message":"@Jayaanand thanks for catching this.  Since it also applies to the parent patch, that has already merged, I think we should make the requirements change its own patch instead of smuggling it into this one.  But you are correct, we do need to add urllib3 to requirements.txt.","commit_id":"738353c242da2c9586e721f3bd6e298343e66d33"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"a0140137ac6ed4f336c20f26ea964155e5e08f78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"81961fa7_d6ecf5df","updated":"2026-06-15 10:27:37.000000000","message":"Hi Amit, without adding urllib3 to Cinder requirements.txt. New runtime may result in module not found error? Any indirect way this is resolved? Please remove my -1 if you feel otherwise. Thank you!","commit_id":"738353c242da2c9586e721f3bd6e298343e66d33"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"8bdfb7d6a6c0a45d408dbe3164f735b52d093e4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ba6a309d_dc7c400a","updated":"2026-07-10 15:05:24.000000000","message":"I agree with Brian, looks good, jay\u0027s comment was addressed.","commit_id":"738353c242da2c9586e721f3bd6e298343e66d33"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"6d5b5d674fba54f983908932ec1cedbfc8fde04b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"23c1ad56_63cefe54","updated":"2026-06-02 14:32:47.000000000","message":"Since NetApp CI has passed, I hope this change does not affect driver. Thanks for the code changes.","commit_id":"738353c242da2c9586e721f3bd6e298343e66d33"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"933f0251deee22fe554363f750ac4747e9a1ee0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"18cb8eda_6f52147e","updated":"2026-06-12 15:02:14.000000000","message":"This looks fine to me; the s3 driver is handled by a different patch.\n\nHere\u0027s what we can tell from the third-party CI for these drivers:\n\nYADRO TATLIN and NetApp ontap are both green.\n\nfor the other drivers:\n- DellEMC PowerMAX CI last seen [0]: 2024-09-04 02:45:24 (646 days, 10:20:25 old)\n- DellEMC SC CI last seen: 2023-03-26 19:21:14 (1173 days, 17:45:06 old)\n- Huawei FusionStorage CI last seen: 2020-07-23 09:23:28 (2150 days, 3:44:22 old)\n- Huawei Volume CI last seen: 2018-06-12 10:12:22 (2922 days, 2:55:35 old)\n- IBM Storage CI is active, but does not obviously test ds8k\n- Nexenta CI is active but has not responded on this patch yet: https://review.opendev.org/q/project:openstack/cinder+commentby:openstackci@nexenta.com\n- NetApp SolidFire went EOA 2023-10-02 and support ends Oct 2028; doesn\u0027t look like it has CI any more\n- VMware doesn\u0027t have CI any more.\n\nLooks to me like our options are to wait for the requests change to break these drivers and then maybe someone will notice and fix them, or we use YADRO and NetApp as proxies and figure that this change won\u0027t break the other drivers.  My opinion is that at some point we will get a breakage, so we might as well cause it ourselves and then the commit log for the drivers will show that this change was made and the driver maintainers can address it.\n\n[0] \"last seen\" dates from http://cinderstats.ivehearditbothways.com/cireport.txt","commit_id":"738353c242da2c9586e721f3bd6e298343e66d33"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"2a0fc32ffa7d0eefe4bcf436c8cbe5ed607d93e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3f8ee8ae_b91e0455","updated":"2026-06-02 08:12:46.000000000","message":"run-NetApp CI","commit_id":"738353c242da2c9586e721f3bd6e298343e66d33"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0088fc1f12883124a8cfc9f11633ba97626b1e6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"45224ca6_b7119205","updated":"2026-06-12 14:10:16.000000000","message":"run-nexentaci","commit_id":"738353c242da2c9586e721f3bd6e298343e66d33"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"83975e7e885bcd90cc2f2cf28da6447e21ab5867","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b843ba86_7ee6ee2b","in_reply_to":"4dd23526_27d4d914","updated":"2026-07-06 06:46:33.000000000","message":"urllib3 is drectly added in requirement.txt, so resolving this patch.\n\n@jayaanand.borra@netapp.com can you please update your vote","commit_id":"738353c242da2c9586e721f3bd6e298343e66d33"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"209b3c863455df902a092bf7d1224361aa823aae","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4dd23526_27d4d914","in_reply_to":"7b4724ee_2644f70b","updated":"2026-06-16 15:07:40.000000000","message":"added patch here \nhttps://review.opendev.org/c/openstack/cinder/+/993615","commit_id":"738353c242da2c9586e721f3bd6e298343e66d33"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"5c90d78973ccc97c185710ee19f078b3673097b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ee2095f4_cf92dec8","in_reply_to":"81961fa7_d6ecf5df","updated":"2026-06-16 06:35:34.000000000","message":"hey, yeah thanks for noticing and raising, that\u0027s a valid concern. though urllib does not need to be added explicitely  because its an indirect dependency of requests lib, which is alread added, so urllib is always guaranteed to be installed on every deployment.\n\nhttps://github.com/openstack/cinder/blob/f59cf1c9b974d6ef24e51c4f87b8dff076a7222b/requirements.txt#L43\n\n\nI cant update/remove your  vote 🙂","commit_id":"738353c242da2c9586e721f3bd6e298343e66d33"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"7a4a94081aff4cbd7dff154fb82cf2872f8145ba","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7b4724ee_2644f70b","in_reply_to":"ee2095f4_cf92dec8","updated":"2026-06-16 13:34:54.000000000","message":"\u003e urllib3 is different from requests, though they are closely related. urllib3 is a low-level HTTP networking library, while requests is a higher-level \"wrapper\" library built on top of urllib3\n\nyes, it need to be added as separate lib, will add it in requirements.txt in another patch.\nthanks","commit_id":"738353c242da2c9586e721f3bd6e298343e66d33"}],"cinder/backup/drivers/s3.py":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"89e385b2960ecfd31f7ac1612ebb6a596c0f4305","unresolved":true,"context_lines":[{"line_number":74,"context_line":"from botocore.config import Config"},{"line_number":75,"context_line":"from botocore import exceptions as boto_exc"},{"line_number":76,"context_line":"from botocore.vendored.requests.packages.urllib3 import exceptions as \\"},{"line_number":77,"context_line":"    urrlib_exc"},{"line_number":78,"context_line":"from oslo_config import cfg"},{"line_number":79,"context_line":"from oslo_log import log as logging"},{"line_number":80,"context_line":"from oslo_utils import timeutils"}],"source_content_type":"text/x-python","patch_set":2,"id":"26d00f71_9dd94038","side":"PARENT","line":77,"updated":"2026-05-28 11:54:32.000000000","message":"reviewers please be aware, I am not certain on botocore.vendored.\n\nthis seemed like same requests.packages.urllib3 lib to me, and on checking it seems AWS has deprecated it in Oct 2019 [1], on update, existing tests passed for me locally and nothing flagged out, so I went ahead with this change.\n\nhttps://aws.amazon.com/blogs/developer/removing-the-vendored-version-of-requests-from-botocore/","commit_id":"850a4ad429d7531ab0d0f5099dd60c34a20a8793"}]}