)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36630,"name":"Winicius Allan Bezerra da Silva","display_name":"Winicius Allan","email":"winiciusab12@gmail.com","username":"winiciusallan"},"change_message_id":"704e8891c36622e50dfa8abe9562f06359b6aa23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"666aaf61_a904eeb2","updated":"2026-05-29 22:44:00.000000000","message":"Thanks! Looks good to me, just small nit comments inline.","commit_id":"45453a0a23df8cab9846bc165cc86939da4562a4"}],"cinder/scheduler/filters/capacity_filter.py":[{"author":{"_account_id":36630,"name":"Winicius Allan Bezerra da Silva","display_name":"Winicius Allan","email":"winiciusab12@gmail.com","username":"winiciusallan"},"change_message_id":"704e8891c36622e50dfa8abe9562f06359b6aa23","unresolved":true,"context_lines":[{"line_number":54,"context_line":"                       \u0027size\u0027: requested_size})"},{"line_number":55,"context_line":"        else:"},{"line_number":56,"context_line":"            requested_size \u003d filter_properties.get(\"size\")"},{"line_number":57,"context_line":"            if requested_size:"},{"line_number":58,"context_line":"                LOG.debug("},{"line_number":59,"context_line":"                    \"Checking if %(grouping)s %(grouping_name)s can create \""},{"line_number":60,"context_line":"                    \"a %(size)s GB volume (%(id)s)\","}],"source_content_type":"text/x-python","patch_set":1,"id":"6d4cbb01_8866f9b1","line":57,"updated":"2026-05-29 22:44:00.000000000","message":"nit: I wouldn\u0027t add this check because if no size is passed, we will lose some useful log message that could help us to debug later on.","commit_id":"45453a0a23df8cab9846bc165cc86939da4562a4"},{"author":{"_account_id":36824,"name":"Isaac Silva","display_name":"Isaac Vicente","email":"isaacvicentsocial@gmail.com","username":"isaacvicente","status":"Cloud Engineer working with Openstack on Laboratory of Distributed System at LSD, Brazil"},"change_message_id":"8eb065ed749323b691cda5808634140efcadfaa7","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                       \u0027size\u0027: requested_size})"},{"line_number":55,"context_line":"        else:"},{"line_number":56,"context_line":"            requested_size \u003d filter_properties.get(\"size\")"},{"line_number":57,"context_line":"            if requested_size:"},{"line_number":58,"context_line":"                LOG.debug("},{"line_number":59,"context_line":"                    \"Checking if %(grouping)s %(grouping_name)s can create \""},{"line_number":60,"context_line":"                    \"a %(size)s GB volume (%(id)s)\","}],"source_content_type":"text/x-python","patch_set":1,"id":"79d6307a_1d402c30","line":57,"in_reply_to":"6d4cbb01_8866f9b1","updated":"2026-05-29 22:55:22.000000000","message":"That\u0027s fair, this log message indeed helped us. I will remove this check.\nThank you!","commit_id":"45453a0a23df8cab9846bc165cc86939da4562a4"},{"author":{"_account_id":36630,"name":"Winicius Allan Bezerra da Silva","display_name":"Winicius Allan","email":"winiciusab12@gmail.com","username":"winiciusallan"},"change_message_id":"704e8891c36622e50dfa8abe9562f06359b6aa23","unresolved":true,"context_lines":[{"line_number":69,"context_line":"        # requested_size is 0 means that it\u0027s a manage request."},{"line_number":70,"context_line":"        # NOTE(isaacvicente): if requested_size is None, no size was passed"},{"line_number":71,"context_line":"        # when filtering, so it should pass"},{"line_number":72,"context_line":"        if requested_size is None or requested_size \u003d\u003d 0:"},{"line_number":73,"context_line":"            return True"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        if backend_state.free_capacity_gb is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"af80c6a4_72e7c9f5","line":72,"updated":"2026-05-29 22:44:00.000000000","message":"just a small nit, not sure if there is a project\u0027s preference.\n\n```suggestion\n        if not requested_size:\n```","commit_id":"45453a0a23df8cab9846bc165cc86939da4562a4"},{"author":{"_account_id":36824,"name":"Isaac Silva","display_name":"Isaac Vicente","email":"isaacvicentsocial@gmail.com","username":"isaacvicente","status":"Cloud Engineer working with Openstack on Laboratory of Distributed System at LSD, Brazil"},"change_message_id":"8eb065ed749323b691cda5808634140efcadfaa7","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        # requested_size is 0 means that it\u0027s a manage request."},{"line_number":70,"context_line":"        # NOTE(isaacvicente): if requested_size is None, no size was passed"},{"line_number":71,"context_line":"        # when filtering, so it should pass"},{"line_number":72,"context_line":"        if requested_size is None or requested_size \u003d\u003d 0:"},{"line_number":73,"context_line":"            return True"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        if backend_state.free_capacity_gb is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"83849aa9_844e4d3c","line":72,"in_reply_to":"af80c6a4_72e7c9f5","updated":"2026-05-29 22:55:22.000000000","message":"Ack. This is more clean, thanks.","commit_id":"45453a0a23df8cab9846bc165cc86939da4562a4"}]}