)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"bc994de8694f29c709538ee2ae4687ad0c996fe9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3258036f_7a24f9a8","updated":"2026-10-19 06:57:20.000000000","message":"Hey Takashi, because you worked on this Ie9846b1d18e2afca9752a5ba9ccc697f528ab8d7\ncan you please have a look","commit_id":"afcdee9091e9a43fab4d5faea071272064af7290"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f0a1267d26a2422dba79832b03b3c520576fb5af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"34870538_4c1b101c","updated":"2026-10-23 13:24:37.000000000","message":"Thanks, Amit.  Patch looks good, and you have done due diligence with your ML post 6 months ago to which there have been no negative responses.","commit_id":"afcdee9091e9a43fab4d5faea071272064af7290"}],"cinder/backup/drivers/s3.py":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"a04c36c9588f681650eaf5d729c5634707cebb98","unresolved":true,"context_lines":[{"line_number":75,"context_line":"from botocore import exceptions as boto_exc"},{"line_number":76,"context_line":"from botocore.vendored.requests.packages.urllib3 import exceptions as \\"},{"line_number":77,"context_line":"    urrlib_exc"},{"line_number":78,"context_line":"from oslo_config import cfg"},{"line_number":79,"context_line":"from oslo_log import log as logging"},{"line_number":80,"context_line":"from oslo_utils import timeutils"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"78036c53_7ec20438","side":"PARENT","line":78,"updated":"2026-05-30 05:24:40.000000000","message":"note: https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/HEEWHRVRYFWQNYEYBZ5SCRAF5ODSL3S6/","commit_id":"738353c242da2c9586e721f3bd6e298343e66d33"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"45f0bcb62273761b6a0ee0668759020d0ed5e2bc","unresolved":true,"context_lines":[{"line_number":75,"context_line":"from botocore import exceptions as boto_exc"},{"line_number":76,"context_line":"from botocore.vendored.requests.packages.urllib3 import exceptions as \\"},{"line_number":77,"context_line":"    urrlib_exc"},{"line_number":78,"context_line":"from oslo_config import cfg"},{"line_number":79,"context_line":"from oslo_log import log as logging"},{"line_number":80,"context_line":"from oslo_utils import timeutils"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"0738b597_dd33ec66","side":"PARENT","line":78,"in_reply_to":"78036c53_7ec20438","updated":"2026-08-18 07:31:29.000000000","message":"added in commit msg.","commit_id":"738353c242da2c9586e721f3bd6e298343e66d33"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"9d2540b254bab8851095a07b3bb86ce4448fc5a9","unresolved":true,"context_lines":[{"line_number":76,"context_line":"from oslo_config import cfg"},{"line_number":77,"context_line":"from oslo_log import log as logging"},{"line_number":78,"context_line":"from oslo_utils import timeutils"},{"line_number":79,"context_line":"from urllib3 import exceptions as urrlib_exc"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"from cinder.backup import chunkeddriver"},{"line_number":82,"context_line":"from cinder import exception"}],"source_content_type":"text/x-python","patch_set":2,"id":"648fc809_c40ca59a","line":79,"range":{"start_line":79,"start_character":34,"end_line":79,"end_character":44},"updated":"2026-08-14 14:56:18.000000000","message":"```suggestion\nfrom urllib3 import exceptions as urllib_exc\n```","commit_id":"2868f12f833cddd064667c9a9afefb7c2f721677"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"45f0bcb62273761b6a0ee0668759020d0ed5e2bc","unresolved":true,"context_lines":[{"line_number":76,"context_line":"from oslo_config import cfg"},{"line_number":77,"context_line":"from oslo_log import log as logging"},{"line_number":78,"context_line":"from oslo_utils import timeutils"},{"line_number":79,"context_line":"from urllib3 import exceptions as urrlib_exc"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"from cinder.backup import chunkeddriver"},{"line_number":82,"context_line":"from cinder import exception"}],"source_content_type":"text/x-python","patch_set":2,"id":"ab2468fe_62615b1b","line":79,"range":{"start_line":79,"start_character":34,"end_line":79,"end_character":44},"in_reply_to":"648fc809_c40ca59a","updated":"2026-08-18 07:31:29.000000000","message":"fixed thanks","commit_id":"2868f12f833cddd064667c9a9afefb7c2f721677"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"bc994de8694f29c709538ee2ae4687ad0c996fe9","unresolved":false,"context_lines":[{"line_number":76,"context_line":"from oslo_config import cfg"},{"line_number":77,"context_line":"from oslo_log import log as logging"},{"line_number":78,"context_line":"from oslo_utils import timeutils"},{"line_number":79,"context_line":"from urllib3 import exceptions as urrlib_exc"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"from cinder.backup import chunkeddriver"},{"line_number":82,"context_line":"from cinder import exception"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfb470af_a49ffe9d","line":79,"range":{"start_line":79,"start_character":34,"end_line":79,"end_character":44},"in_reply_to":"ab2468fe_62615b1b","updated":"2026-10-19 06:57:20.000000000","message":"Done","commit_id":"2868f12f833cddd064667c9a9afefb7c2f721677"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"9d2540b254bab8851095a07b3bb86ce4448fc5a9","unresolved":true,"context_lines":[{"line_number":379,"context_line":"                resp \u003d self.conn.get_object(**get_args)"},{"line_number":380,"context_line":"                return resp.get(\u0027Body\u0027).read()"},{"line_number":381,"context_line":"            except (socket.timeout, socket.error,"},{"line_number":382,"context_line":"                    urrlib_exc.ReadTimeoutError,"},{"line_number":383,"context_line":"                    boto_exc.IncompleteReadError) as e:"},{"line_number":384,"context_line":"                last_exception \u003d e"},{"line_number":385,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":2,"id":"9640e964_f91b73ea","line":382,"updated":"2026-08-14 14:56:18.000000000","message":"```suggestion\n                    urllib_exc.ReadTimeoutError,\n```","commit_id":"2868f12f833cddd064667c9a9afefb7c2f721677"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"45f0bcb62273761b6a0ee0668759020d0ed5e2bc","unresolved":false,"context_lines":[{"line_number":379,"context_line":"                resp \u003d self.conn.get_object(**get_args)"},{"line_number":380,"context_line":"                return resp.get(\u0027Body\u0027).read()"},{"line_number":381,"context_line":"            except (socket.timeout, socket.error,"},{"line_number":382,"context_line":"                    urrlib_exc.ReadTimeoutError,"},{"line_number":383,"context_line":"                    boto_exc.IncompleteReadError) as e:"},{"line_number":384,"context_line":"                last_exception \u003d e"},{"line_number":385,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":2,"id":"df7a4dd4_284d1b40","line":382,"in_reply_to":"9640e964_f91b73ea","updated":"2026-08-18 07:31:29.000000000","message":"Done","commit_id":"2868f12f833cddd064667c9a9afefb7c2f721677"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"949b9af720c498e7142240c1b2b255cafee8e122","unresolved":false,"context_lines":[{"line_number":388,"context_line":"                resp \u003d self.conn.get_object(**get_args)"},{"line_number":389,"context_line":"                return resp.get(\u0027Body\u0027).read()"},{"line_number":390,"context_line":"            except (socket.timeout, socket.error,"},{"line_number":391,"context_line":"                    urrlib_exc.ReadTimeoutError,"},{"line_number":392,"context_line":"                    boto_exc.IncompleteReadError) as e:"},{"line_number":393,"context_line":"                last_exception \u003d e"},{"line_number":394,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":5,"id":"aca40659_c25b0809","side":"PARENT","line":391,"range":{"start_line":391,"start_character":31,"end_line":391,"end_character":47},"updated":"2026-10-19 15:33:34.000000000","message":"botocore.vendored.requests.packages.urllib3.exceptions.ReadTimeoutError has been a subclass of urllib3.exceptions.ReadTimeoutError since botocore 1.11.0, so this looks correct.\n\nhttps://github.com/boto/botocore/commit/1cb7bf663cacd2e9bc9bdc3e2a666cff53679dcd\n\nThis subclassing was introduced when they removed vendored urllib by https://github.com/boto/botocore/pull/1495 .","commit_id":"270ba9ea896827272485526127c2cbcb3a16a3ee"}]}