)]}'
{"id":"openstack%2Fcinder~9908","triplet_id":"openstack%2Fcinder~master~I0370293807f0282e1dbdd59246f70be031e888a9","project":"openstack/cinder","branch":"master","topic":"bp/common-rpc","hashtags":[],"change_id":"I0370293807f0282e1dbdd59246f70be031e888a9","subject":"Add missing ack to impl_qpid.","status":"MERGED","created":"2012-07-17 12:19:22.000000000","updated":"2012-07-19 14:57:40.000000000","submitted":"2012-07-19 14:57:39.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e50beb25ce46ee5994475b85eaee3166f0a1278c","_number":9908,"virtual_id_number":9908,"owner":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":2,"date":"2012-07-19 14:57:39.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"all":[{"value":0,"date":"2012-07-19 14:57:39.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2012-07-19 14:57:39.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"date":"2012-07-19 14:57:39.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"all":[{"value":0,"date":"2012-07-19 14:57:39.000000000","_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2012-07-19 14:57:39.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":1,"date":"2012-07-19 14:57:39.000000000","_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-07-17 12:19:22.000000000","updated_by":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"reviewer":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"state":"REVIEWER"},{"updated":"2012-07-18 15:19:49.000000000","updated_by":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"reviewer":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"state":"REVIEWER"},{"updated":"2012-07-18 15:38:46.000000000","updated_by":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"reviewer":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"state":"REVIEWER"},{"updated":"2012-07-18 16:42:22.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"9530ed307c0be2c8995a6e707015b400d4439651","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-07-17 12:35:35.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- https://jenkins.openstack.org/job/gate-cinder-merge/100/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-cinder-docs/61/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-cinder-pep8/103/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-cinder-python26/103/testReport : SUCCESS\n- https://jenkins.openstack.org/job/gate-cinder-python27/104/testReport : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"2a859e755447fc31e0ce3c7b58dbb2728f0305e5","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2012-07-17 12:46:49.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ee2c5ef5f074dbcc28236dbb08c8feff151bd8e3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-07-17 12:53:20.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed\n\n- https://jenkins.openstack.org/job/gate-cinder-merge/104/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-cinder-docs/65/consoleFull : FAILURE\n- https://jenkins.openstack.org/job/gate-cinder-pep8/106/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-cinder-python26/107/testReport : SUCCESS\n- https://jenkins.openstack.org/job/gate-cinder-python27/106/testReport : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"c4b5cfd4f329268ab747b4dfaafbc0da4b074f79","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2012-07-17 13:03:37.000000000","message":"Patch Set 2:\n\nSeems spurious:\n\n  py.error.ENOENT: [No such file or directory]: open(\u0027/home/jenkins/workspace/gate-cinder-docs/.tox/venv/log/venv-1.log\u0027, \u0027r\u0027)","accounts_in_message":[],"_revision_number":2},{"id":"4073994f82162b75ac344173395e427a937c61d6","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2012-07-18 15:19:49.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"da437df04c4f13e41667e2b6f40351152037ecbf","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2012-07-18 15:33:14.000000000","message":"Patch Set 2:\n\nreverify","accounts_in_message":[],"_revision_number":2},{"id":"88fdff58ba74e0ea4265058885dc83a622983542","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-07-18 15:33:17.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"559f39c07c764a75a77ea213ca991fc29e72dfa3","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2012-07-18 15:38:46.000000000","message":"Patch Set 2: Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"0a6a6a68df9b485aad0a2e253d7fa9f59aefdfd9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-07-18 16:42:22.000000000","message":"Patch Set 2: Verified\n\nBuild successful\n\n- https://jenkins.openstack.org/job/gate-cinder-merge/229/consoleFull : This change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.\n- https://jenkins.openstack.org/job/gate-cinder-docs/171/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-cinder-pep8/213/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-cinder-python26/212/testReport : SUCCESS\n- https://jenkins.openstack.org/job/gate-cinder-python27/214/testReport : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"b31ac1d0cb4f1e4077a1741a29b247d112f3a196","date":"2012-07-18 17:04:06.000000000","message":"Change could not be merged because of a missing dependency.\n\nThe following changes must also be submitted:\n\n* Id128126e0bc064a2a1c710c6bd32fb3d137dc7f6\n* If92675beecff5471b416a929c161b810e3c71939\n* Ibd0292936f9afc77aeb5d040660bfa857861eed1\n* I07bd82e9ff60c356123950e466caaffdfce79eba\n* I4b16577f774194a628bf84d5352e63ec1f868698\n* If213a4a5da1faf96aac82f34b18d1e0b061495c0\n* Ie17fe855a75b5021b031902aa86031d8ddc06dfd\n* Id5a0ffabf7c6eab0bbda1b130a39a6581b26e350\n* I1a11e8fd6a56b2336457f7df178c2b3c187246c3\n","accounts_in_message":[],"_revision_number":2},{"id":"38620b3f55864c3ac7d78db26dd4e3918ec8f256","date":"2012-07-18 17:27:49.000000000","message":"Change could not be merged because of a missing dependency.","accounts_in_message":[],"_revision_number":2},{"id":"80455cc6fa8781afff1b4264af5af9d85baeb3fb","date":"2012-07-18 18:40:00.000000000","message":"Change could not be merged because of a missing dependency.","accounts_in_message":[],"_revision_number":2},{"id":"dfc8cb239b8ecff7ef685adfa7f65d9f0ee559d6","date":"2012-07-19 08:11:24.000000000","message":"Change could not be merged because of a missing dependency.","accounts_in_message":[],"_revision_number":2},{"id":"0e8e5990354ffa7d1afba0c7acdd13933ade9ce1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-07-19 14:57:40.000000000","message":"Change has been successfully cherry-picked as a5d16cfb8d6d953d2a9689ddc855cade604e1e9b","accounts_in_message":[],"_revision_number":2}],"current_revision_number":3,"current_revision":"a5d16cfb8d6d953d2a9689ddc855cade604e1e9b","revisions":{"28f89a2308a6d1ae86357e8b1e4561a894282c9f":{"kind":"REWORK","_number":1,"created":"2012-07-17 12:19:22.000000000","uploader":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"ref":"refs/changes/08/9908/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder","ref":"refs/changes/08/9908/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder refs/changes/08/9908/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder refs/changes/08/9908/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder refs/changes/08/9908/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder refs/changes/08/9908/1"}}},"commit":{"parents":[{"commit":"1fd2e7856fb34f696428464c26c7b19e40cb2725","subject":"Use openstack.common.cfg.CONF.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/1fd2e7856fb34f696428464c26c7b19e40cb2725"}]}],"author":{"name":"Russell Bryant","email":"rbryant@redhat.com","date":"2012-06-12 21:07:18.000000000","tz":-240},"committer":{"name":"Mark McLoughlin","email":"markmc@redhat.com","date":"2012-07-17 12:13:21.000000000","tz":60},"subject":"Add missing ack to impl_qpid.","message":"Add missing ack to impl_qpid.\n\nFix bug 1012374.\n\nJohannes Erdfelt pointed out that impl_qpid wasn\u0027t acking messages that\nit received.  This turned out to be a nasty oversight, resulting in\nunbounded message queue growth inside of the python-qpid library.  This\nfixes it.\n\nChange-Id: I0370293807f0282e1dbdd59246f70be031e888a9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/28f89a2308a6d1ae86357e8b1e4561a894282c9f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/28f89a2308a6d1ae86357e8b1e4561a894282c9f"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"1fd2e7856fb34f696428464c26c7b19e40cb2725","is_merged_in_target_branch":false,"change_id":"Id128126e0bc064a2a1c710c6bd32fb3d137dc7f6","change_number":9907,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"},"7859deaedbb6e029f30aeab884022063d9ef0b7a":{"kind":"NO_CHANGE","_number":2,"created":"2012-07-17 12:46:49.000000000","uploader":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"ref":"refs/changes/08/9908/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder","ref":"refs/changes/08/9908/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder refs/changes/08/9908/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder refs/changes/08/9908/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder refs/changes/08/9908/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder refs/changes/08/9908/2"}}},"commit":{"parents":[{"commit":"d454a618e4c3158bb501e868197a838e16fd2a29","subject":"Use openstack.common.cfg.CONF.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/d454a618e4c3158bb501e868197a838e16fd2a29"}]}],"author":{"name":"Russell Bryant","email":"rbryant@redhat.com","date":"2012-06-12 21:07:18.000000000","tz":-240},"committer":{"name":"Mark McLoughlin","email":"markmc@redhat.com","date":"2012-07-17 12:42:00.000000000","tz":60},"subject":"Add missing ack to impl_qpid.","message":"Add missing ack to impl_qpid.\n\nFix bug 1012374.\n\nJohannes Erdfelt pointed out that impl_qpid wasn\u0027t acking messages that\nit received.  This turned out to be a nasty oversight, resulting in\nunbounded message queue growth inside of the python-qpid library.  This\nfixes it.\n\nChange-Id: I0370293807f0282e1dbdd59246f70be031e888a9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/7859deaedbb6e029f30aeab884022063d9ef0b7a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/7859deaedbb6e029f30aeab884022063d9ef0b7a"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"d454a618e4c3158bb501e868197a838e16fd2a29","is_merged_in_target_branch":false,"change_id":"Id128126e0bc064a2a1c710c6bd32fb3d137dc7f6","change_number":9907,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"a5d16cfb8d6d953d2a9689ddc855cade604e1e9b":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":3,"created":"2012-07-19 14:57:39.000000000","uploader":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"ref":"refs/changes/08/9908/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder","ref":"refs/changes/08/9908/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder refs/changes/08/9908/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder refs/changes/08/9908/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder refs/changes/08/9908/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder refs/changes/08/9908/3"}}},"commit":{"parents":[{"commit":"22a9da3cc4b0cc17d8d3483b95dc57ed43bf0ecb","subject":"Move queue_get_for() from db to rpc.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/22a9da3cc4b0cc17d8d3483b95dc57ed43bf0ecb"}]}],"author":{"name":"Russell Bryant","email":"rbryant@redhat.com","date":"2012-06-12 21:07:18.000000000","tz":-240},"committer":{"name":"Jenkins","email":"jenkins@review.openstack.org","date":"2012-07-18 16:42:22.000000000","tz":0},"subject":"Add missing ack to impl_qpid.","message":"Add missing ack to impl_qpid.\n\nFix bug 1012374.\n\nJohannes Erdfelt pointed out that impl_qpid wasn\u0027t acking messages that\nit received.  This turned out to be a nasty oversight, resulting in\nunbounded message queue growth inside of the python-qpid library.  This\nfixes it.\n\nChange-Id: I0370293807f0282e1dbdd59246f70be031e888a9\nReviewed-on: https://review.openstack.org/9908\nReviewed-by: Vish Ishaya \u003cvishvananda@gmail.com\u003e\nApproved: John Griffith \u003cjohn.griffith@solidfire.com\u003e\nTested-by: Jenkins\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/a5d16cfb8d6d953d2a9689ddc855cade604e1e9b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/a5d16cfb8d6d953d2a9689ddc855cade604e1e9b"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"22a9da3cc4b0cc17d8d3483b95dc57ed43bf0ecb","is_merged_in_target_branch":true,"change_id":"If92675beecff5471b416a929c161b810e3c71939","change_number":9906,"patch_set_number":3,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
