)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"f5d935388998361f2d6eaf4bf681b7b28344c4f3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"23328832_baeb4a6c","updated":"2026-07-03 15:09:40.000000000","message":"overall change look fine to me, and current test appropriately cover the error path with mocking failure.\nbut it would be nice to have real concurrent request validation for this.\nthough I know we cant test that with units and functioanl fw does allow that yet.\nso I am not sure its possible.\n\nthough a tempest test can  be added with threads","commit_id":"f119f9fc11e4e74ebe434d3323aeed1aa460f210"}],"cinder/backup/api.py":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"f5d935388998361f2d6eaf4bf681b7b28344c4f3","unresolved":true,"context_lines":[{"line_number":248,"context_line":"            msg \u003d (_(\u0027Volume to be backed up must be available \u0027"},{"line_number":249,"context_line":"                     \u0027or in-use, but the current status is \"%s\".\u0027)"},{"line_number":250,"context_line":"                   % volume[\u0027status\u0027])"},{"line_number":251,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":252,"context_line":"        elif volume[\u0027status\u0027] in [\"in-use\"] and not force:"},{"line_number":253,"context_line":"            msg \u003d _(\u0027Backing up an in-use volume must use \u0027"},{"line_number":254,"context_line":"                    \u0027the force flag.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"266c64d1_2a894faf","line":251,"updated":"2026-07-03 15:09:40.000000000","message":"ok validation is happening here, so for later vol cant be in error or any state which is not correct for update.","commit_id":"f119f9fc11e4e74ebe434d3323aeed1aa460f210"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"f5d935388998361f2d6eaf4bf681b7b28344c4f3","unresolved":false,"context_lines":[{"line_number":333,"context_line":"            if not volume.conditional_update("},{"line_number":334,"context_line":"                    {\u0027status\u0027: \u0027backing-up\u0027,"},{"line_number":335,"context_line":"                     \u0027previous_status\u0027: previous_status},"},{"line_number":336,"context_line":"                    {\u0027status\u0027: previous_status}):"},{"line_number":337,"context_line":"                QUOTAS.rollback(context, reservations)"},{"line_number":338,"context_line":"                msg \u003d _(\u0027Volume is already being backed up.\u0027)"},{"line_number":339,"context_line":"                raise exception.InvalidVolume(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"57a4fecb_a11a191e","line":336,"updated":"2026-07-03 15:09:40.000000000","message":"so prevoius_status and expected can only in available and in-use.","commit_id":"f119f9fc11e4e74ebe434d3323aeed1aa460f210"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"f5d935388998361f2d6eaf4bf681b7b28344c4f3","unresolved":true,"context_lines":[{"line_number":337,"context_line":"                QUOTAS.rollback(context, reservations)"},{"line_number":338,"context_line":"                msg \u003d _(\u0027Volume is already being backed up.\u0027)"},{"line_number":339,"context_line":"                raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        kwargs \u003d {"},{"line_number":342,"context_line":"            \u0027user_id\u0027: context.user_id,"},{"line_number":343,"context_line":"            \u0027project_id\u0027: context.project_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"2181160f_a5b81e5e","line":340,"updated":"2026-07-03 15:09:40.000000000","message":"this msg assume, conditional_update failied only because of concurrent/another backing going on, \nI am not sure what other reason could be of its failing - but there could be!!\nthe func itself only returns True/False - so this is correct IMO.\n\nbut still I think we should add some negative test cases to just to be sure","commit_id":"f119f9fc11e4e74ebe434d3323aeed1aa460f210"}],"cinder/tests/unit/backup/test_backup.py":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"f5d935388998361f2d6eaf4bf681b7b28344c4f3","unresolved":true,"context_lines":[{"line_number":2454,"context_line":"        self.assertEqual(\u0027backup_az\u0027, backup.availability_zone)"},{"line_number":2455,"context_line":""},{"line_number":2456,"context_line":"    @mock.patch.object("},{"line_number":2457,"context_line":"        objects.Volume, \"conditional_update\", return_value\u003dFalse"},{"line_number":2458,"context_line":"    )"},{"line_number":2459,"context_line":"    @mock.patch.object(quota.QUOTAS, \u0027rollback\u0027)"},{"line_number":2460,"context_line":"    @mock.patch.object(quota.QUOTAS, \u0027reserve\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"c19e9096_4d0e7e77","line":2457,"updated":"2026-07-03 15:09:40.000000000","message":"this is just a genric fail, doesnt test specific scenario!","commit_id":"f119f9fc11e4e74ebe434d3323aeed1aa460f210"}]}