)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"43dea81b72024efa10cae622df497bf94ec4a8f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0d94c29b_17cf4706","updated":"2026-07-22 18:06:38.000000000","message":"Can you think of any reason why this wasn\u0027t added in the first patch? I\u0027m wondering if there\u0027s any caveat that the author was thinking at the first patch and didn\u0027t add this there.","commit_id":"9cd07d8ab5b83c9aa7957163b687d07b887db8c5"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"2fb2b31ba2eb6ad398d8c4467c655a32e35a5d3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"412c540a_f64ea9f7","updated":"2026-07-07 19:45:50.000000000","message":"I can\u0027t find anything wrong with this one, but I\u0027m still coming up to speed on db-related changes, hoping another reviewer can verify.","commit_id":"9cd07d8ab5b83c9aa7957163b687d07b887db8c5"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"3d672f610bdfac52dec0beb28e143a035ae928c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7764b86e_d4963341","updated":"2026-06-29 15:19:57.000000000","message":"Indexing will improve read performance. Do you see any impact on large deployment with older InnoDB where table locks are taken when updating index?","commit_id":"9cd07d8ab5b83c9aa7957163b687d07b887db8c5"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"f5d394c8c888a4592ae6e662ee40083931914bf7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4c83153d_e95457d6","updated":"2026-07-16 06:46:55.000000000","message":"lgtm\nregarding test using `index_exists` from oslo_db, check here is correct, which made me to notice that `_check_daa98075b90d` dont assert the result,  so those checks are not useful right now, if possible can you fix them too.","commit_id":"9cd07d8ab5b83c9aa7957163b687d07b887db8c5"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"16b4ead3ddba29e344fa87e8c5302e12dc0733ec","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1f3dfbd9_053dc10f","in_reply_to":"0d94c29b_17cf4706","updated":"2026-07-23 07:47:33.000000000","message":"yeah I had similar thoguht, why  @stephenfin@redhat.com did not added this that time itself.\n\nthey added todo, why not just fix it  in same patch https://review.opendev.org/c/openstack/cinder/+/813221\n\n\nI think, because that patch was about fixing model-migration mismatch, and not adding new migration which makes sense. and this is that todo-followup.\nso no caveats just a scope decision.","commit_id":"9cd07d8ab5b83c9aa7957163b687d07b887db8c5"}],"cinder/tests/unit/db/test_migrations.py":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"f5d394c8c888a4592ae6e662ee40083931914bf7","unresolved":true,"context_lines":[{"line_number":336,"context_line":"        \"\"\"Test resources have indexes.\"\"\""},{"line_number":337,"context_line":"        for table in (\u0027groups\u0027, \u0027group_snapshots\u0027, \u0027volumes\u0027, \u0027snapshots\u0027,"},{"line_number":338,"context_line":"                      \u0027backups\u0027):"},{"line_number":339,"context_line":"            db_utils.index_exists(connection,"},{"line_number":340,"context_line":"                                  table,"},{"line_number":341,"context_line":"                                  f\u0027{table}_deleted_project_id_idx\u0027)"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        db_utils.index_exists(connection,"},{"line_number":344,"context_line":"                              \u0027volumes\u0027, \u0027volumes_deleted_host_idx\u0027)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    def _check_89aa6f9639f9(self, connection):"},{"line_number":347,"context_line":"        # the table only existed on legacy deployments: there\u0027s no way to check"}],"source_content_type":"text/x-python","patch_set":3,"id":"c6c8c3ee_214ae5bc","line":344,"range":{"start_line":339,"start_character":12,"end_line":344,"end_character":68},"updated":"2026-07-16 06:46:55.000000000","message":"this also calls `index_exists` but don\u0027t assert it, as `_check_c95af7b5bdef`, so this test is not really useful","commit_id":"9cd07d8ab5b83c9aa7957163b687d07b887db8c5"}]}