)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"08c0dee7c6f1c85c17497b49facbdde2fd1eec92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6f59c06b_7e36f236","updated":"2026-06-12 15:35:57.000000000","message":"I agree with Eric that this looks like a oslo.service issue (so you might want to file a bug there, or just point them to this patch), but on the other hand, I don\u0027t see a problem with explicitly saying, when making the call in cinder, that we are expecting to get a specific number of workers.","commit_id":"14bdc990f04ff5f55e64aaed6bd6543bc8a90422"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"15c00fe3411bb456a5c715545b8c37b367e1c11c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4aaa0a37_d2ab2567","updated":"2026-06-11 13:21:06.000000000","message":"This might be a bug in oslo.service?","commit_id":"14bdc990f04ff5f55e64aaed6bd6543bc8a90422"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"07cbe791be7793aa868932d47d220e7296df58d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4ffb832a_a9b84ac0","updated":"2026-06-16 15:57:33.000000000","message":"Change looks good to me. Thanks for the detailed commit message.","commit_id":"97b8b58e8dfa0ccd43ddea94ca3c0a4bf3e1a34e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ba755bf7ec4cc88e60925f2c67f728c0d6b25e31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8008e5ef_61a1a367","updated":"2026-06-18 13:30:23.000000000","message":"Consensus is that this patch is fine as-is, so I think i am over-engineering this.  LGTM.","commit_id":"97b8b58e8dfa0ccd43ddea94ca3c0a4bf3e1a34e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"bc40ce13b27a5f2a5764005023a7a52b00770b35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8dc82cd0_1934e3ec","updated":"2026-06-16 15:38:40.000000000","message":"I liked the explicit use of the \u0027workers\u0027 argument in PS 1 because then a reader doesn\u0027t have to check the default behavior, but I\u0027m OK with PS2 if Eric is.","commit_id":"97b8b58e8dfa0ccd43ddea94ca3c0a4bf3e1a34e"}],"cinder/service.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"15c00fe3411bb456a5c715545b8c37b367e1c11c","unresolved":true,"context_lines":[{"line_number":621,"context_line":"    global _launcher"},{"line_number":622,"context_line":"    if _launcher:"},{"line_number":623,"context_line":"        raise RuntimeError(_(\u0027serve() can only be called once\u0027))"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"    _launcher \u003d service.launch(CONF, server, workers\u003dworkers,"},{"line_number":626,"context_line":"                               restart_method\u003d\u0027mutate\u0027)"},{"line_number":627,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"c930bd02_3de2bd0f","line":624,"updated":"2026-06-11 13:21:06.000000000","message":"Probably better to just fix this here -- if workers is None, don\u0027t pass it to the launch() call.","commit_id":"14bdc990f04ff5f55e64aaed6bd6543bc8a90422"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"da7e84a58bcdc857218d633638382b7d971a7020","unresolved":true,"context_lines":[{"line_number":621,"context_line":"    global _launcher"},{"line_number":622,"context_line":"    if _launcher:"},{"line_number":623,"context_line":"        raise RuntimeError(_(\u0027serve() can only be called once\u0027))"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"    _launcher \u003d service.launch(CONF, server, workers\u003dworkers,"},{"line_number":626,"context_line":"                               restart_method\u003d\u0027mutate\u0027)"},{"line_number":627,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"8b5e04bd_032137ea","line":624,"in_reply_to":"0098a575_e7336279","updated":"2026-06-16 06:09:34.000000000","message":"ack, will move here.\n\n\u003e then it will be mandatory to pass the number of workers, and workers\u003dNone doesn\u0027t make any sense.\n\nyeah, workers\u003dNone doesn\u0027t make sense. also oslo.service default to 1 too.\nthe issue is cinder passing explictly None, here making it default worker\u003d1 works for both eventlet and threading mode without breaking anything.","commit_id":"14bdc990f04ff5f55e64aaed6bd6543bc8a90422"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"d95f0264e9b90e18b98c444262642543d460b29d","unresolved":true,"context_lines":[{"line_number":621,"context_line":"    global _launcher"},{"line_number":622,"context_line":"    if _launcher:"},{"line_number":623,"context_line":"        raise RuntimeError(_(\u0027serve() can only be called once\u0027))"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"    _launcher \u003d service.launch(CONF, server, workers\u003dworkers,"},{"line_number":626,"context_line":"                               restart_method\u003d\u0027mutate\u0027)"},{"line_number":627,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"0098a575_e7336279","line":624,"in_reply_to":"b5f89b9a_df4eb546","updated":"2026-06-13 07:27:58.000000000","message":"agree with Brain...def serve(server, *, workers: int \u003d 1): change makes keyword-only and explicit","commit_id":"14bdc990f04ff5f55e64aaed6bd6543bc8a90422"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"08c0dee7c6f1c85c17497b49facbdde2fd1eec92","unresolved":true,"context_lines":[{"line_number":621,"context_line":"    global _launcher"},{"line_number":622,"context_line":"    if _launcher:"},{"line_number":623,"context_line":"        raise RuntimeError(_(\u0027serve() can only be called once\u0027))"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":"    _launcher \u003d service.launch(CONF, server, workers\u003dworkers,"},{"line_number":626,"context_line":"                               restart_method\u003d\u0027mutate\u0027)"},{"line_number":627,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"b5f89b9a_df4eb546","line":624,"in_reply_to":"c930bd02_3de2bd0f","updated":"2026-06-12 15:35:57.000000000","message":"I\u0027d go a different direction.  If you make the function signature\n\n    def serve(server, *, workers):\n\nthen it will be mandatory to pass the number of workers, and workers\u003dNone doesn\u0027t make any sense.","commit_id":"14bdc990f04ff5f55e64aaed6bd6543bc8a90422"}]}