)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"0b9562642d47207f6397fbf8f2f51a0f947039a5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"575afbbf_1227c550","updated":"2026-07-02 10:51:28.000000000","message":"@auniyal@redhat.com We wanted to backport PowerFlex 5.0 to stable/2026.1. We are unable to backport because of this backport has been abandoned. Any specific reason to abandon this backport ?","commit_id":"43e096dd6bd1be7ddf36a33bdf81463f1a39a9e9"},{"author":{"_account_id":37437,"name":"Amit Zauber","display_name":"Zaubea","email":"amit.zauber@dell.com","username":"amit.zauber@dell.com"},"change_message_id":"da582812af2fd367057c0146f8086e303c4cfb7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5984b2b1_f60ba4ab","updated":"2026-07-02 14:16:11.000000000","message":"Hi Amit,  as Abhishek mentioned, this was created as bug fix since there is no new functionality, this is only rest-api fixes for PowerFlex platform","commit_id":"43e096dd6bd1be7ddf36a33bdf81463f1a39a9e9"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"c09395fc42b77da6d00be314b72728037861ccfe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3d7aea59_2976e1d2","updated":"2026-07-21 10:35:59.000000000","message":"recheck","commit_id":"43e096dd6bd1be7ddf36a33bdf81463f1a39a9e9"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"0fe5f1f19d68c53bdd0cfd09bf4271dab88df6f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"50a070ae_6167eb26","updated":"2026-07-31 10:54:13.000000000","message":"recheck","commit_id":"43e096dd6bd1be7ddf36a33bdf81463f1a39a9e9"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"193dcc85473e2bbec73864dea498f1661b7d480d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"549f4302_c0cbf96b","in_reply_to":"437f5ff1_be5bee2f","updated":"2026-09-23 10:14:54.000000000","message":"Acknowledged","commit_id":"43e096dd6bd1be7ddf36a33bdf81463f1a39a9e9"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"be70e374aee00de7b711f863eb2bbf7adcbdb808","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e60347ab_bc8b6ba4","in_reply_to":"575afbbf_1227c550","updated":"2026-07-02 11:11:50.000000000","message":"hey, yeah so I didn\u0027t realize this earlier while creating, but this is kind of feature.\nand we do not backport features in stable branches.","commit_id":"43e096dd6bd1be7ddf36a33bdf81463f1a39a9e9"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"0851d68fe0972648324d917106d76b0e348c46a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3040988c_6c37576a","in_reply_to":"5984b2b1_f60ba4ab","updated":"2026-07-02 14:54:16.000000000","message":"sure, if you feel this is required. \nI don\u0027t think this should be merged in stable, but it can be surely used to test it in stable branches CI to eventually used in downstream.","commit_id":"43e096dd6bd1be7ddf36a33bdf81463f1a39a9e9"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"c58262a7bd324a8b8aee06561ce0d88151c77035","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"437f5ff1_be5bee2f","in_reply_to":"97f1a691_39bf7c38","updated":"2026-07-21 10:26:16.000000000","message":"@auniyal@redhat.com\nHi Amit,\n\nThis patch fixes Launchpad bug #2139336 — it was filed as a bug, not a feature. The PowerFlex 5.0 API changes broke existing Cinder driver workflows, so this is a bug fix.\n\nCould you please restore this backport? Fixing broken functionality in a stable branch is consistent with the OpenStack Stable Branch Policy.\nhttps://docs.openstack.org/project-team-guide/stable-branches.html","commit_id":"43e096dd6bd1be7ddf36a33bdf81463f1a39a9e9"},{"author":{"_account_id":37784,"name":"Abhishek Gupta","display_name":"Abhishek Gupta","email":"Abhishek_Gupta14@Dell.com","username":"abhishek-gupta14"},"change_message_id":"dfd8cd4f4f96c9907dd9bdc913b4d80de9328c59","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"97f1a691_39bf7c38","in_reply_to":"e60347ab_bc8b6ba4","updated":"2026-07-02 13:14:25.000000000","message":"Hi, This is a launchpad bug fix. For features, we have patches created against blueprint. Is it possible if you can restore this backport since customers are in need of this ?\nCC: @amit.zauber@dell.com @nilesh.thathagar@dell.com","commit_id":"43e096dd6bd1be7ddf36a33bdf81463f1a39a9e9"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"fa93eca893901178a0f47f67a3c81427ee58200a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"826de494_eaf1b89c","updated":"2026-09-02 12:45:16.000000000","message":"@rajatdhasmana@gmail.com @rosmaita.fossdev@gmail.com\nTeam can we have this backport request reviewed.","commit_id":"e6f2a817220f9bbfdc7779d4478ffdacde8b96d6"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"2e6a0016f9f40f1c18cb11a99ffc2bc6c598fba4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"512150c7_3a76eb97","updated":"2026-09-08 14:28:50.000000000","message":"@siddharth.kumar1@dell.com you have the link for the change that introduced powerflex 5?","commit_id":"e6f2a817220f9bbfdc7779d4478ffdacde8b96d6"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"3df7e787597c6c6db7e8251b964bb7f298d6d130","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"88d4846f_6025e9f5","updated":"2026-09-08 01:56:55.000000000","message":"earlier discussion didn\u0027t land/agreed on, so let me try to answer this better: why we dont think this should merge into upstrea stable/branches.\n\nstable branches policy:\nhttps://docs.openstack.org/project-team-guide/stable-branches.html#appropriate-fixes\nhttps://docs.openstack.org/project-team-guide/stable-branches.html#review-guidelines\n\nso bug vs blueprint doesn\u0027t decide this, the added code does. \nthis adds PowerFlex 5.0 EC support, which is new. 2026.1 is already released without it, so nothing regressed for anyone running 2026.1.\n\napart from policy, iirc from master patch discussion, 4.x to 5.0 upgrade is not supported anyway, so existing users have no path to have new behaviour.  but not all of this change is checked by `check_powerflex_ec_version()` condition, so\nsome of it lands on them regardless.\n\nIf you still want this on 2026.1, you can request exception (see the same page), you could also raise it in upstream wednesday meet.\n\nindependent of that, leaving the change up is still useful, to run stavle CI and driver CI, and gives you a tested patch to pull downstream, that why we un-abandoned tis earlier.","commit_id":"e6f2a817220f9bbfdc7779d4478ffdacde8b96d6"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"288bfcc1b809ef57081feb507664b39c9a88ec1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e86c1452_d9dceb2f","updated":"2026-08-10 12:14:51.000000000","message":"recheck","commit_id":"e6f2a817220f9bbfdc7779d4478ffdacde8b96d6"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"d0dea3d6c016f483539e1c95cded0f06ce4ef122","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"37ba7087_1c70314a","updated":"2026-08-10 10:44:20.000000000","message":"recheck devstack-plugin-nfs-tempest-full","commit_id":"e6f2a817220f9bbfdc7779d4478ffdacde8b96d6"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"33d7f317e95c42db2d8c7a50845c69d182095d88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"36a10e50_c87f6fe2","updated":"2026-08-19 05:47:13.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"e6f2a817220f9bbfdc7779d4478ffdacde8b96d6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"47e98abb2b7dcad53aa9f3d730b65a5c0085d90c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b5e18fd4_0bd6ff45","updated":"2026-08-12 07:27:55.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"e6f2a817220f9bbfdc7779d4478ffdacde8b96d6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"ca99552eb2dab531d3896c77a5b93e216d6169d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ba4fbca6_00bef9df","updated":"2026-08-12 07:25:45.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"e6f2a817220f9bbfdc7779d4478ffdacde8b96d6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"9fd194717a1723e884fe04fd865ac7fd38a4c094","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"29fba73e_216de1fe","updated":"2026-09-03 21:20:35.000000000","message":"run-DellEMC PowerFlex-v4 CI","commit_id":"e6f2a817220f9bbfdc7779d4478ffdacde8b96d6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"fe040c89d13b583403c8ec1b2dbd43fa31904a93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"32b52fc4_a89ccc9d","updated":"2026-08-17 08:54:32.000000000","message":"run-DellEMC PowerFlex-v4 CI","commit_id":"e6f2a817220f9bbfdc7779d4478ffdacde8b96d6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"92ba50cc58964ac03523d8351a07681fe1043827","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"65bab5a3_13d62e29","updated":"2026-08-12 10:00:28.000000000","message":"run-DellEMC PowerFlex-v4 CI","commit_id":"e6f2a817220f9bbfdc7779d4478ffdacde8b96d6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"4c587188f8caa05ac90b50c821a315d445edbb9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"77237e5b_cd71ad40","updated":"2026-08-19 08:11:02.000000000","message":"run-DellEMC PowerFlex-v4 CI","commit_id":"e6f2a817220f9bbfdc7779d4478ffdacde8b96d6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"55b24f16fcb0a150756047686ae543a1366441b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"89e7d5cd_55100091","updated":"2026-08-12 10:06:21.000000000","message":"run-DellEMC PowerFlex-v4 CI","commit_id":"e6f2a817220f9bbfdc7779d4478ffdacde8b96d6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"429ae51893a41f66b0f4d52079769a988d63efbb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8dfe9b28_fb75060f","updated":"2026-08-19 08:15:48.000000000","message":"run-DellEMC PowerFlex-v4 CI","commit_id":"e6f2a817220f9bbfdc7779d4478ffdacde8b96d6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"38a62c30162c7761617a137e7b00e4d88abfde73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9a045b71_e2944f54","updated":"2026-08-19 08:00:40.000000000","message":"run-DellEMC PowerFlex-v4 CI","commit_id":"e6f2a817220f9bbfdc7779d4478ffdacde8b96d6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"673e8f89aedf0b6ed681f0a28d0c95651f102ccf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bb9b1b4b_516e70cd","updated":"2026-08-17 08:56:16.000000000","message":"run-DellEMC PowerFlex-v4 CI","commit_id":"e6f2a817220f9bbfdc7779d4478ffdacde8b96d6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"1c709b22d2c153c10c223ea332d77478609d3372","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a0342ddd_9e644880","updated":"2026-08-19 10:02:02.000000000","message":"run-DellEMC PowerFlex-v5 CI","commit_id":"e6f2a817220f9bbfdc7779d4478ffdacde8b96d6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"8dfc337c63a28c08868d972c9f5236a6f3c144d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a4f9d6cf_1366f458","updated":"2026-09-01 13:10:23.000000000","message":"run-DellEMC PowerFlex-v5 CI","commit_id":"e6f2a817220f9bbfdc7779d4478ffdacde8b96d6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"ce7a701d4e1300be0ed91c547f4b5ca238f3f6c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c6adef58_96bdc308","updated":"2026-08-19 08:00:47.000000000","message":"run-DellEMC PowerFlex-v5 CI","commit_id":"e6f2a817220f9bbfdc7779d4478ffdacde8b96d6"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"82fe38b3bdce7cb896c5090dd4202ca5ed5f6249","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"eae02965_89602257","updated":"2026-08-19 10:06:54.000000000","message":"run-DellEMC PowerFlex-v5 CI","commit_id":"e6f2a817220f9bbfdc7779d4478ffdacde8b96d6"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"0cf791afb4e210f1faa6e620e6fff2e0edeff196","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8d0ee219_65a5738f","in_reply_to":"0d42a4b9_ccc946f0","updated":"2026-09-23 12:15:30.000000000","message":"hi,\n\nnote, that the cherry pick isn\u0027t a clean cherry pick, it would be nice to indicate this in the commit message [1]. I\u0027ve also replied on the mail thread [2] that request stable policy exception to this backport.\n\n\n\n[1] conflicting files:\n\n    Conflicts:\n      cinder/tests/unit/volume/drivers/dell_emc/powerflex/test_powerflex_client.py\n      cinder/volume/drivers/dell_emc/powerflex/driver.py\n      cinder/volume/drivers/dell_emc/powerflex/rest_client.py\n\n[2] https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/7CMIH324DN66CEDTUT4YAWIVRNMVWCVY/","commit_id":"e6f2a817220f9bbfdc7779d4478ffdacde8b96d6"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"2105802b5b9d4029d5f2d084c0f6d5c4cb177abc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"885d3636_4fdcac85","in_reply_to":"24a53f39_bdf0bede","updated":"2026-11-04 06:09:01.000000000","message":"please do not resolve this.","commit_id":"e6f2a817220f9bbfdc7779d4478ffdacde8b96d6"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"4604ce976037a0252f903d60469565ff195cc9e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"24a53f39_bdf0bede","in_reply_to":"4808a9af_412f23db","updated":"2026-09-29 05:49:57.000000000","message":"Acknowledged","commit_id":"e6f2a817220f9bbfdc7779d4478ffdacde8b96d6"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"d4a9abba10c5496f0f42d63fadcead9efb632e55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"32b2c30e_831fdf90","in_reply_to":"512150c7_3a76eb97","updated":"2026-09-18 09:17:38.000000000","message":"Hi @erlon.rodrigues.cruz@canonical.com\nhttps://review.opendev.org/c/openstack/cinder/+/950546","commit_id":"e6f2a817220f9bbfdc7779d4478ffdacde8b96d6"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"d34620ec9b81b4ea01164bc89d9a852b11066f3e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4808a9af_412f23db","in_reply_to":"771fb3c7_cb39b810","updated":"2026-09-28 16:12:45.000000000","message":"thanks Siddharth! For the commit message update.\n\non the other hand now as I reviewed the change i see a couple of differences compared to the patch AND code on master branch :/ \n\nOn stable branches we don\u0027t really accept new code. (Only rare cases when there is something that needs refactoring due to missing features on stable branch). I don\u0027t really see why those changes are added. Even if they are improvements or increases test coverage, they needs to be merged first on master branch, then be backported to stable branches.\nCan you please elaborate?\n\n(Note that I\u0027m not familiar with cinder code base in that extent, but looking at the code from general stable maintainer point of view.)","commit_id":"e6f2a817220f9bbfdc7779d4478ffdacde8b96d6"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"193dcc85473e2bbec73864dea498f1661b7d480d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0d42a4b9_ccc946f0","in_reply_to":"88d4846f_6025e9f5","updated":"2026-09-23 10:14:54.000000000","message":"Hi Amit,\n \nPatchset 3 addresses your feedback. The two non-gated code\npaths are now behind check_powerflex_ec_version() — 4.x\nbehavior is unchanged.\n \nDell CI on PS3: v4 SUCCESS, v5 SUCCESS.","commit_id":"e6f2a817220f9bbfdc7779d4478ffdacde8b96d6"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"d793a0b614911ee09ae81f49e6c91c83d3dafbc5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"771fb3c7_cb39b810","in_reply_to":"8d0ee219_65a5738f","updated":"2026-09-28 06:32:20.000000000","message":"@elod.illes@est.tech  \nAddressed.","commit_id":"e6f2a817220f9bbfdc7779d4478ffdacde8b96d6"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"4bc8e68a6b0c014f305de774ef0b52da08533b6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ef6bc290_ea810b5a","updated":"2026-09-24 07:26:00.000000000","message":"run-DellEMC PowerFlex-v5 CI","commit_id":"9bf613eb8dc2278085951ebc7770cae34a8cd0d5"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"01707f03a6cc76b8f9bb40973071f8f236732ecd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f59d9d7a_205ee3cc","updated":"2026-09-24 07:13:09.000000000","message":"run-DellEMC PowerFlex-v5 CI","commit_id":"9bf613eb8dc2278085951ebc7770cae34a8cd0d5"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"4604ce976037a0252f903d60469565ff195cc9e3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"650ff973_b5f0d72d","updated":"2026-09-29 05:49:57.000000000","message":"Thanks for the review @elod.illes@est.tech and @jayaanand.borra@netapp.com\n\nThe additional changes in PS5 were made to address jayaanand’s valid technical comments on PS4. However, as Elod pointed out, those fixes are not present on master and should not be introduced directly in this stable backport. They have therefore been reverted, and this patch now matches the original master commit apart from the documented cherry-pick conflict resolutions. We will submit the fixes as a bug-fix patch on master first and backport them afterward through the normal stable-branch process.","commit_id":"54c072ba764e7af46d96e22edee89e2647ad6c76"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"d34620ec9b81b4ea01164bc89d9a852b11066f3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1b68b945_cbabf34b","updated":"2026-09-28 16:12:45.000000000","message":"please see my comments inline.","commit_id":"54c072ba764e7af46d96e22edee89e2647ad6c76"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"56394b90779e2053fcc76aad1004b10827f4027c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f4293221_9f7b0098","updated":"2026-09-28 07:59:33.000000000","message":"run-DellEMC PowerFlex-v4 CI","commit_id":"54c072ba764e7af46d96e22edee89e2647ad6c76"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"6569cf7fbbf246a6a953e22dc24f2883c302c216","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a1725830_f794992f","in_reply_to":"344f3153_e44e3be2","updated":"2026-09-29 12:05:58.000000000","message":"Thanks, too, now it looks OK to me!\nGiven the team is waiting to discuss this on Cinder meeting [1] I\u0027m only adding +1 for now, otherwise I think this should be good to go.\n\n[1] https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/7CMIH324DN66CEDTUT4YAWIVRNMVWCVY/","commit_id":"54c072ba764e7af46d96e22edee89e2647ad6c76"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"e5d8e9d4b1c7c3089797e698f8e5c2706cee1e7b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6955eed2_aa000db0","in_reply_to":"650ff973_b5f0d72d","updated":"2026-09-29 07:22:11.000000000","message":"Thanks Siddharth, that sounds like the perfect way forward!\n(I see still some minor differences in one of the files, see my comments inline, otherwise this should be OK. giving -1 to highlight those)","commit_id":"54c072ba764e7af46d96e22edee89e2647ad6c76"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"f299c82dfee8ce9cf904fbc467bd04379cdb95c9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"344f3153_e44e3be2","in_reply_to":"6955eed2_aa000db0","updated":"2026-09-29 10:42:07.000000000","message":"Thanks for catching this. Removed it in the latest patchset.","commit_id":"54c072ba764e7af46d96e22edee89e2647ad6c76"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"b625b4e7b8d4e24ad91b8b6911ce2b0412cffdfc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"38e2e796_07fdf440","updated":"2026-10-08 11:23:35.000000000","message":"Hi @elod.illes@est.tech \n\nTo keep this backport clean, I have proposed the PowerFlex v4 regression fix separately on master:\n\nLP bug: https://bugs.launchpad.net/cinder/+bug/2169929\nMaster fix: https://review.opendev.org/c/openstack/cinder/+/1009439\nWould it be acceptable to track this fix separately and backport it to Gazpacho after the master change merges? This would allow the current PowerFlex feature backport to proceed independently and merge into its proposed stable branch without mixing the follow-up fix.\n\nOnce the master change is merged, I can propose the corresponding clean backport to Gazpacho and any other affected stable branches.","commit_id":"02126479482fec444231a6a52b77d06d097d67b5"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"3ed34f5284ecf4c4c358bd21fe0206a37af3a712","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5ff544c9_4ab3401a","updated":"2026-09-30 09:33:51.000000000","message":"Hi @elod.illes@est.tech Please help on this.\n\nThough, we agreed with the stable-branch policy concern raised in PS6.\n\nHowever, the `check_powerflex_ec_version()` guard is required to keep the PowerFlex generation-specific behavior isolated:\n \n- PowerFlex v5/EC requires the updated volume-size handling.\n- PowerFlex v4/Mirroring must retain the existing size model-update behavior.\n- Without the guard, the EC-specific logic is also applied to v4 volumes.\n\nThis was the concern raised by Amit in PS2 regarding the non-gated code paths. With the guard present, both PowerFlex v4 and v5 CI passed from PS3 through PS6. After the guard was removed in PS7, the v4 job began failing again.\n \nThe latest PS7 v4 trigger failed:\n \n- `cinder_tempest_plugin.scenario.test_volume_encrypted.TestEncryptedCinderVolumes.test_boot_cloned_encrypted_volume`\n- `tempest.scenario.test_volume_boot_pattern.TestVolumeBootPatternV346.test_instance_boot_after_snapshot_deletion`\n \nPrevious PS7 v4 runs also failed:\n \n- `tempest.scenario.test_volume_boot_pattern.TestVolumeBootPattern.test_volume_boot_pattern`\n \nThe latest PS7 v5 CI passed.\n \nGiven that this guard is necessary to preserve v4 behavior while enabling the v5/EC changes, should we restore it in PS8, or should this change continue through the Hibiscus-\u003eGazpacho downstream backport path?","commit_id":"02126479482fec444231a6a52b77d06d097d67b5"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"301743d5d9f1274e3fabbecd597018030e642e3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1c472494_d44234b7","updated":"2026-10-28 21:50:32.000000000","message":"Hi Amit,\n\nWe discussed this change in the Cinder meeting on September 23[1]. This change is too significant to be considered a bug fix and poses a regression risk to stable branches. According to Cinder\u0027s stable branches policy, backporting features like this is not allowed.\n\nYou can bring this topic up in the next meeting to explore other alternatives, such as splitting this into a targeted patch, to see if that is an option the stable core team considers acceptable.\n\n[1] https://meetings.opendev.org/meetings/cinder/2026/cinder.2026-09-23-14.06.log.html#l-82","commit_id":"02126479482fec444231a6a52b77d06d097d67b5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2d9541b5783da44acbc349bd7417dd6400db3fee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"fcd17832_4ccdcdcd","updated":"2026-11-09 16:11:03.000000000","message":"Just want to make it clear that the cinder project team (in the meeting Erlon mentioned in an earlier comment) decided not to backport this.  There was some discussion on the patch about it being convenient for downstream CI for it not to be abandoned; if that no longer applies, please abandon it.  Thanks!","commit_id":"02126479482fec444231a6a52b77d06d097d67b5"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"2416dfbc9026a6d07757d7caa55c97d447364e44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8a6ef68f_8391f661","updated":"2026-09-29 12:51:27.000000000","message":"run-DellEMC PowerFlex-v4 CI","commit_id":"02126479482fec444231a6a52b77d06d097d67b5"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"20725f302210a7ee86d05159eaa02c49f039ec1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f43b6261_d8daeb71","updated":"2026-09-30 07:28:53.000000000","message":"run-DellEMC PowerFlex-v4 CI","commit_id":"02126479482fec444231a6a52b77d06d097d67b5"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"96d82e2cf584206b0c9c5355c18b1f5ab0327767","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1851affb_d362968e","updated":"2026-09-30 05:49:53.000000000","message":"run-DellEMC PowerFlex-v5 CI","commit_id":"02126479482fec444231a6a52b77d06d097d67b5"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"aa6104b7ed2f475790c63c5190a8184ddc4be271","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"bbc99d4b_21a12e7d","in_reply_to":"1c472494_d44234b7","updated":"2026-10-30 13:40:42.000000000","message":"understood, thanks Erlon and Cinder team for the careful consideration. (there can be exceptions, but as I said, it always have to be weighed by the team based on benefit / regression risks. Stable series should be kept stable as much as possible!)","commit_id":"02126479482fec444231a6a52b77d06d097d67b5"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"6512341d74acecea411049cbd349c6711cdbe6ab","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a458a68d_e15d009a","in_reply_to":"38e2e796_07fdf440","updated":"2026-10-08 14:34:25.000000000","message":"thanks @siddharth.kumar1@dell.com !\nThe question is what the impact is on consumers: if this patch without the follow-up bug fix could cause issues to them, then i\u0027d say it\u0027s better to wait with the merge to the follow up. on the other hand, if merging this without the follow-up has more benefit, then probably it\u0027s okay to merge this ASAP.","commit_id":"02126479482fec444231a6a52b77d06d097d67b5"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"8971db5fc9d75678a8556d017012c76d5de3d2e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d4429802_89429c5d","in_reply_to":"449624a5_e32a6ab8","updated":"2026-10-01 05:38:31.000000000","message":"@elod.illes@est.tech\nMakes sense, we can do that.","commit_id":"02126479482fec444231a6a52b77d06d097d67b5"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"8b051c3af4bcada9ea06e832be168fdbd35030da","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"449624a5_e32a6ab8","in_reply_to":"5ff544c9_4ab3401a","updated":"2026-09-30 09:46:34.000000000","message":"Hi @siddharth.kumar1@dell.com ,\n\nI guess folks who use 2026.2 Hibiscus (or 2027.1 Indri) could also have the issue with PowerFlex v4, so I suggest to add this extra code to master branch as a separate patch, and when that merged then backport it to this branch. (It can be squashed to this patch if needed)\nIs this feasible?","commit_id":"02126479482fec444231a6a52b77d06d097d67b5"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"7efb507d00c7c3a314521ec682ce0d4fddfd21f3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"acdb19d5_a370b5da","in_reply_to":"a458a68d_e15d009a","updated":"2026-10-15 06:22:39.000000000","message":"Hi @elod.illes@est.tech\nThanks for raising this. Our validation shows that the missing follow-up fix affects only specific PowerFlex v4 Mirroring regression scenarios; PowerFlex v5/EC workflows continue to work.\n\nThe current backport is needed to unblock customers waiting for the PowerFlex v5 functionality. The v4 fix is already proposed separately on master in Change 1009439 under LP #2169929, and we can backport it cleanly to stable/2026.1 after the master change merges.\n\nTherefore, I would request that Change 993565 be merged so we can unblock the affected customers while continuing to track and backport the v4 fix separately.","commit_id":"02126479482fec444231a6a52b77d06d097d67b5"}],"cinder/tests/unit/volume/drivers/dell_emc/powerflex/test_create_volume.py":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"d34620ec9b81b4ea01164bc89d9a852b11066f3e","unresolved":true,"context_lines":[{"line_number":95,"context_line":"        self.driver.primary_client.powerflex_gen_type \u003d \"EC\""},{"line_number":96,"context_line":"        self.volume.size \u003d 14"},{"line_number":97,"context_line":"        model_update \u003d self.driver.create_volume(self.volume)"},{"line_number":98,"context_line":"        self.assertNotIn(\u0027size\u0027, model_update)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_create_volume_badstatus_response(self):"},{"line_number":101,"context_line":"        self.set_https_response_mode(self.RESPONSE_MODE.BadStatus)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa782694_35779501","line":98,"updated":"2026-09-28 16:12:45.000000000","message":"why isn\u0027t this present on master branch?","commit_id":"54c072ba764e7af46d96e22edee89e2647ad6c76"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"4604ce976037a0252f903d60469565ff195cc9e3","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        self.driver.primary_client.powerflex_gen_type \u003d \"EC\""},{"line_number":96,"context_line":"        self.volume.size \u003d 14"},{"line_number":97,"context_line":"        model_update \u003d self.driver.create_volume(self.volume)"},{"line_number":98,"context_line":"        self.assertNotIn(\u0027size\u0027, model_update)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_create_volume_badstatus_response(self):"},{"line_number":101,"context_line":"        self.set_https_response_mode(self.RESPONSE_MODE.BadStatus)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fca498bc_6565e7b4","line":98,"in_reply_to":"fa782694_35779501","updated":"2026-09-29 05:49:57.000000000","message":"Done","commit_id":"54c072ba764e7af46d96e22edee89e2647ad6c76"}],"cinder/tests/unit/volume/drivers/dell_emc/powerflex/test_misc.py":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"d34620ec9b81b4ea01164bc89d9a852b11066f3e","unresolved":true,"context_lines":[{"line_number":405,"context_line":"        self.assertEqual(free, 50)"},{"line_number":406,"context_line":"        self.assertEqual(provisioned, 200)"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"    @mock.patch(\u0027cinder.volume.drivers.dell_emc.powerflex.rest_client.\u0027"},{"line_number":409,"context_line":"                \u0027RestClient.execute_powerflex_post_request\u0027)"},{"line_number":410,"context_line":"    @mock.patch(\u0027cinder.volume.drivers.dell_emc.powerflex.\u0027"},{"line_number":411,"context_line":"                \u0027driver.PowerFlexDriver._get_client\u0027)"},{"line_number":412,"context_line":"    def test_get_ec_queryable_statistics_invalid_response("},{"line_number":413,"context_line":"            self, mock_get_client, mock_execute_post):"},{"line_number":414,"context_line":"        mock_client \u003d mock.Mock()"},{"line_number":415,"context_line":"        mock_get_client.return_value \u003d mock_client"},{"line_number":416,"context_line":"        mock_client.execute_powerflex_post_request \u003d mock_execute_post"},{"line_number":417,"context_line":"        invalid_responses \u003d ["},{"line_number":418,"context_line":"            None,"},{"line_number":419,"context_line":"            {},"},{"line_number":420,"context_line":"            {\"resources\": {}},"},{"line_number":421,"context_line":"            {\"resources\": []},"},{"line_number":422,"context_line":"            {\"resources\": [{}]},"},{"line_number":423,"context_line":"            {\"resources\": [{\"metrics\": []}]},"},{"line_number":424,"context_line":"            {\"resources\": [{\"metrics\": ["},{"line_number":425,"context_line":"                {\"name\": \"physical_total\", \"values\": []}"},{"line_number":426,"context_line":"            ]}]},"},{"line_number":427,"context_line":"            {\"resources\": [{\"metrics\": ["},{"line_number":428,"context_line":"                {\"name\": \"physical_total\", \"values\": [1]},"},{"line_number":429,"context_line":"                {\"name\": \"physical_free\", \"values\": [2]},"},{"line_number":430,"context_line":"            ]}]},"},{"line_number":431,"context_line":"            {\"resources\": [{\"metrics\": ["},{"line_number":432,"context_line":"                {\"name\": \"physical_total\", \"values\": [\"invalid\"]},"},{"line_number":433,"context_line":"                {\"name\": \"physical_free\", \"values\": [2]},"},{"line_number":434,"context_line":"                {\"name\": \"logical_provisioned\", \"values\": [3]},"},{"line_number":435,"context_line":"            ]}]},"},{"line_number":436,"context_line":"        ]"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"        for response in invalid_responses:"},{"line_number":439,"context_line":"            mock_execute_post.return_value \u003d ("},{"line_number":440,"context_line":"                mock.Mock(status_code\u003d200), response)"},{"line_number":441,"context_line":"            self.assertRaises("},{"line_number":442,"context_line":"                exception.VolumeBackendAPIException,"},{"line_number":443,"context_line":"                self.driver._get_ec_queryable_statistics,"},{"line_number":444,"context_line":"                \u0027pool123\u0027, \u0027TestPool\u0027)"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"    @mock.patch(\u0027cinder.volume.drivers.dell_emc.\u0027"},{"line_number":447,"context_line":"                \u0027powerflex.driver.PowerFlexDriver._get_client\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"851958ca_58029219","line":444,"range":{"start_line":408,"start_character":0,"end_line":444,"end_character":38},"updated":"2026-09-28 16:12:45.000000000","message":"why is this added only here in this branch?","commit_id":"54c072ba764e7af46d96e22edee89e2647ad6c76"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"4604ce976037a0252f903d60469565ff195cc9e3","unresolved":false,"context_lines":[{"line_number":405,"context_line":"        self.assertEqual(free, 50)"},{"line_number":406,"context_line":"        self.assertEqual(provisioned, 200)"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"    @mock.patch(\u0027cinder.volume.drivers.dell_emc.powerflex.rest_client.\u0027"},{"line_number":409,"context_line":"                \u0027RestClient.execute_powerflex_post_request\u0027)"},{"line_number":410,"context_line":"    @mock.patch(\u0027cinder.volume.drivers.dell_emc.powerflex.\u0027"},{"line_number":411,"context_line":"                \u0027driver.PowerFlexDriver._get_client\u0027)"},{"line_number":412,"context_line":"    def test_get_ec_queryable_statistics_invalid_response("},{"line_number":413,"context_line":"            self, mock_get_client, mock_execute_post):"},{"line_number":414,"context_line":"        mock_client \u003d mock.Mock()"},{"line_number":415,"context_line":"        mock_get_client.return_value \u003d mock_client"},{"line_number":416,"context_line":"        mock_client.execute_powerflex_post_request \u003d mock_execute_post"},{"line_number":417,"context_line":"        invalid_responses \u003d ["},{"line_number":418,"context_line":"            None,"},{"line_number":419,"context_line":"            {},"},{"line_number":420,"context_line":"            {\"resources\": {}},"},{"line_number":421,"context_line":"            {\"resources\": []},"},{"line_number":422,"context_line":"            {\"resources\": [{}]},"},{"line_number":423,"context_line":"            {\"resources\": [{\"metrics\": []}]},"},{"line_number":424,"context_line":"            {\"resources\": [{\"metrics\": ["},{"line_number":425,"context_line":"                {\"name\": \"physical_total\", \"values\": []}"},{"line_number":426,"context_line":"            ]}]},"},{"line_number":427,"context_line":"            {\"resources\": [{\"metrics\": ["},{"line_number":428,"context_line":"                {\"name\": \"physical_total\", \"values\": [1]},"},{"line_number":429,"context_line":"                {\"name\": \"physical_free\", \"values\": [2]},"},{"line_number":430,"context_line":"            ]}]},"},{"line_number":431,"context_line":"            {\"resources\": [{\"metrics\": ["},{"line_number":432,"context_line":"                {\"name\": \"physical_total\", \"values\": [\"invalid\"]},"},{"line_number":433,"context_line":"                {\"name\": \"physical_free\", \"values\": [2]},"},{"line_number":434,"context_line":"                {\"name\": \"logical_provisioned\", \"values\": [3]},"},{"line_number":435,"context_line":"            ]}]},"},{"line_number":436,"context_line":"        ]"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"        for response in invalid_responses:"},{"line_number":439,"context_line":"            mock_execute_post.return_value \u003d ("},{"line_number":440,"context_line":"                mock.Mock(status_code\u003d200), response)"},{"line_number":441,"context_line":"            self.assertRaises("},{"line_number":442,"context_line":"                exception.VolumeBackendAPIException,"},{"line_number":443,"context_line":"                self.driver._get_ec_queryable_statistics,"},{"line_number":444,"context_line":"                \u0027pool123\u0027, \u0027TestPool\u0027)"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"    @mock.patch(\u0027cinder.volume.drivers.dell_emc.\u0027"},{"line_number":447,"context_line":"                \u0027powerflex.driver.PowerFlexDriver._get_client\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"26dd9a21_5ff0c12d","line":444,"range":{"start_line":408,"start_character":0,"end_line":444,"end_character":38},"in_reply_to":"851958ca_58029219","updated":"2026-09-29 05:49:57.000000000","message":"Done","commit_id":"54c072ba764e7af46d96e22edee89e2647ad6c76"}],"cinder/tests/unit/volume/drivers/dell_emc/powerflex/test_replication.py":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"d34620ec9b81b4ea01164bc89d9a852b11066f3e","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        super(powerflex.mocks.PowerFlexDriver, self.driver).do_setup({})"},{"line_number":61,"context_line":"        self.driver.check_for_setup_error()"},{"line_number":62,"context_line":"        self.assertTrue(self.driver.secondary_client.is_configured)"},{"line_number":63,"context_line":"        self.assertEqual(\"EC\", self.driver.primary_client.powerflex_gen_type)"},{"line_number":64,"context_line":"        self.assertEqual(\"EC\", self.driver.secondary_client.powerflex_gen_type)"},{"line_number":65,"context_line":"        self.assertTrue(self.driver.replication_enabled)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_failover_completed_initializes_active_client(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"4cf56993_4020234b","line":64,"range":{"start_line":63,"start_character":0,"end_line":64,"end_character":79},"updated":"2026-09-28 16:12:45.000000000","message":"this is not present on master branch","commit_id":"54c072ba764e7af46d96e22edee89e2647ad6c76"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"4604ce976037a0252f903d60469565ff195cc9e3","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        super(powerflex.mocks.PowerFlexDriver, self.driver).do_setup({})"},{"line_number":61,"context_line":"        self.driver.check_for_setup_error()"},{"line_number":62,"context_line":"        self.assertTrue(self.driver.secondary_client.is_configured)"},{"line_number":63,"context_line":"        self.assertEqual(\"EC\", self.driver.primary_client.powerflex_gen_type)"},{"line_number":64,"context_line":"        self.assertEqual(\"EC\", self.driver.secondary_client.powerflex_gen_type)"},{"line_number":65,"context_line":"        self.assertTrue(self.driver.replication_enabled)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_failover_completed_initializes_active_client(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"0e16e1e3_a957eb55","line":64,"range":{"start_line":63,"start_character":0,"end_line":64,"end_character":79},"in_reply_to":"4cf56993_4020234b","updated":"2026-09-29 05:49:57.000000000","message":"Done","commit_id":"54c072ba764e7af46d96e22edee89e2647ad6c76"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"d34620ec9b81b4ea01164bc89d9a852b11066f3e","unresolved":true,"context_lines":[{"line_number":64,"context_line":"        self.assertEqual(\"EC\", self.driver.secondary_client.powerflex_gen_type)"},{"line_number":65,"context_line":"        self.assertTrue(self.driver.replication_enabled)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_failover_completed_initializes_active_client(self):"},{"line_number":68,"context_line":"        self.test_do_setup_already_failed_over()"},{"line_number":69,"context_line":"        self.driver.primary_client.powerflex_gen_type \u003d None"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        self.driver.failover_completed({})"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        self.assertEqual(\"EC\", self.driver.primary_client.powerflex_gen_type)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @ddt.data("},{"line_number":76,"context_line":"        ["}],"source_content_type":"text/x-python","patch_set":5,"id":"ee9e03b9_9c5efd7e","line":73,"range":{"start_line":67,"start_character":0,"end_line":73,"end_character":77},"updated":"2026-09-28 16:12:45.000000000","message":"neither this.","commit_id":"54c072ba764e7af46d96e22edee89e2647ad6c76"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"4604ce976037a0252f903d60469565ff195cc9e3","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.assertEqual(\"EC\", self.driver.secondary_client.powerflex_gen_type)"},{"line_number":65,"context_line":"        self.assertTrue(self.driver.replication_enabled)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_failover_completed_initializes_active_client(self):"},{"line_number":68,"context_line":"        self.test_do_setup_already_failed_over()"},{"line_number":69,"context_line":"        self.driver.primary_client.powerflex_gen_type \u003d None"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        self.driver.failover_completed({})"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        self.assertEqual(\"EC\", self.driver.primary_client.powerflex_gen_type)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @ddt.data("},{"line_number":76,"context_line":"        ["}],"source_content_type":"text/x-python","patch_set":5,"id":"ddb66397_9669485c","line":73,"range":{"start_line":67,"start_character":0,"end_line":73,"end_character":77},"in_reply_to":"ee9e03b9_9c5efd7e","updated":"2026-09-29 05:49:57.000000000","message":"Done","commit_id":"54c072ba764e7af46d96e22edee89e2647ad6c76"}],"cinder/volume/drivers/dell_emc/powerflex/driver.py":[{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"21a17e22704bca935cd04de1c424daaa171a3731","unresolved":true,"context_lines":[{"line_number":223,"context_line":"        # Checking only the first pool is sufficient because the backend"},{"line_number":224,"context_line":"        # enforces a consistent gentype across all pools."},{"line_number":225,"context_line":"        first_pd \u003d self.storage_pools[0].split(\":\")[0]"},{"line_number":226,"context_line":"        client.init_powerflex_gen_type(first_pd)"},{"line_number":227,"context_line":"        # validate the storage pools and check if zero padding is enabled"},{"line_number":228,"context_line":"        for pool in self.storage_pools:"},{"line_number":229,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"6d47b516_9dfd64ba","line":226,"updated":"2026-09-27 16:48:01.000000000","message":"init_powerflex_gen_type() runs only on _get_client(). secondary_client is a different RestClient. powerflex_gen_type is set to None in RestClient.__init__ (rest_client.py:68) and is never set on that object, so check_powerflex_ec_version() is false there (rest_client.py:909-911).\n\nWhile the backend is not failed over, _get_client(secondary\u003dTrue) is the secondary client (driver.py:167-172). _setup_volume_replication() creates the remote volume with it (driver.py:385-391). RestClient.create_volume() removes compressionMethod only when that client\u0027s own check is true (rest_client.py:252-253), so an EC target still receives compressionMethod.\n\nfailover_completed() (driver.py:474-497) only changes active_backend_id. VolumeManager.failover and VolumeManager.failover_completed do not call check_for_setup_error() again. After a failover in this process, _get_client() is the uninitialized secondary client, so create, snapshot, extend, stats, and backup_use_temp_snapshot() (driver.py:2163-2164) use the Mirroring behavior until restart.\n\nA restart initializes whichever client is active at startup. Failback in the same process is fine only if this process started on the primary, because that client was initialized then. If the process started already failed over, the primary client was never initialized, and failback uses that uninitialized client.\n\nCall init_powerflex_gen_type() on secondary_client only when secondary_client.is_configured is true. do_setup() returns at rest_client.py:82-83 without setting that flag when replication_device is unset; it sets the flag at rest_client.py:146. Call it again from failover_completed() for the client that just became active.","commit_id":"9bf613eb8dc2278085951ebc7770cae34a8cd0d5"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"d793a0b614911ee09ae81f49e6c91c83d3dafbc5","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        # Checking only the first pool is sufficient because the backend"},{"line_number":224,"context_line":"        # enforces a consistent gentype across all pools."},{"line_number":225,"context_line":"        first_pd \u003d self.storage_pools[0].split(\":\")[0]"},{"line_number":226,"context_line":"        client.init_powerflex_gen_type(first_pd)"},{"line_number":227,"context_line":"        # validate the storage pools and check if zero padding is enabled"},{"line_number":228,"context_line":"        for pool in self.storage_pools:"},{"line_number":229,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1401f3ab_c113035b","line":226,"in_reply_to":"6d47b516_9dfd64ba","updated":"2026-09-28 06:32:20.000000000","message":"Done","commit_id":"9bf613eb8dc2278085951ebc7770cae34a8cd0d5"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"21a17e22704bca935cd04de1c424daaa171a3731","unresolved":true,"context_lines":[{"line_number":678,"context_line":"            # with the virtual_size."},{"line_number":679,"context_line":"            # Check if volume has glance_metadata as an indicator of"},{"line_number":680,"context_line":"            # image creation."},{"line_number":681,"context_line":"            if not volume.glance_metadata:"},{"line_number":682,"context_line":"                model_updates[\"size\"] \u003d real_size"},{"line_number":683,"context_line":"        else:"},{"line_number":684,"context_line":"            model_updates[\"size\"] \u003d real_size"}],"source_content_type":"text/x-python","patch_set":4,"id":"18d96429_dfc1a6cb","line":681,"updated":"2026-09-27 16:48:01.000000000","message":"volume.glance_metadata does not mean the volume is being created from an image. _handle_bootable_volume_glance_meta() copies the image properties after create_volume() returns (cinder/volume/flows/manager/create_volume.py:1148-1150 on stable/2026.1).\n\nVolume._get_expected_attrs() does not load glance_metadata (cinder/objects/volume.py:149-155). The create flow does not read volume.glance_metadata before the driver, so this access lazy-loads (cinder/objects/volume.py:464-474).\n\nThe only row that can exist at this point is signature_verified, written at create_volume.py:992-1002 when verify_glance_signatures !\u003d \u0027disabled\u0027. The default is enabled (cinder/image/glance.py:53-55). An unsigned image makes verify_glance_image_signature() return False (cinder/image/image_utils.py:636-642) and the row is still written. The lazy load then sees a non-empty dict, and size is omitted. With the default, this branch does not overwrite the restored size.\n\nWith verify_glance_signatures\u003ddisabled, no row is written, the lazy load stores {}, and this branch sets size. The only path that changes volume.size before create_volume() and then puts it back is image-cache entry creation:\n\ncreate_volume.py:1011-1014 sets volume.size to virtual_size and saves it when should_create_cache_entry is true and virtual_size !\u003d original_size.\nOn EC, _get_actual_vol_size() returns that value unchanged (driver.py:627-629), so model_updates[\"size\"] is virtual_size.\ncreate_volume.py:1064-1069 extends the backend to original_size and saves that size.\nCreateVolumeFromSpecTask.execute() applies the same model_update at create_volume.py:1268-1271 and writes virtual_size back over original_size.\nA normal image download does not do this. volume.size stays at the requested size unless should_create_cache_entry is true.","commit_id":"9bf613eb8dc2278085951ebc7770cae34a8cd0d5"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"d793a0b614911ee09ae81f49e6c91c83d3dafbc5","unresolved":false,"context_lines":[{"line_number":678,"context_line":"            # with the virtual_size."},{"line_number":679,"context_line":"            # Check if volume has glance_metadata as an indicator of"},{"line_number":680,"context_line":"            # image creation."},{"line_number":681,"context_line":"            if not volume.glance_metadata:"},{"line_number":682,"context_line":"                model_updates[\"size\"] \u003d real_size"},{"line_number":683,"context_line":"        else:"},{"line_number":684,"context_line":"            model_updates[\"size\"] \u003d real_size"}],"source_content_type":"text/x-python","patch_set":4,"id":"92736014_1db17274","line":681,"in_reply_to":"18d96429_dfc1a6cb","updated":"2026-09-28 06:32:20.000000000","message":"Done","commit_id":"9bf613eb8dc2278085951ebc7770cae34a8cd0d5"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"21a17e22704bca935cd04de1c424daaa171a3731","unresolved":true,"context_lines":[{"line_number":1397,"context_line":"            msg \u003d (_(\"Failed to query stats for Storage Pool %s: %s\")"},{"line_number":1398,"context_line":"                   % (pool_name, r.text))"},{"line_number":1399,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":1400,"context_line":"        results \u003d response.get(\"resources\")"},{"line_number":1401,"context_line":"        if not results:"},{"line_number":1402,"context_line":"            msg \u003d (_(\"No resources found in metrics response for \""},{"line_number":1403,"context_line":"                     \"Storage Pool %(pool)s. Response data: %(response)s\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"71e48e1d_b458b6af","line":1400,"updated":"2026-09-27 16:48:01.000000000","message":"execute_powerflex_post_request() sets response \u003d None when r.json() raises ValueError (rest_client.py:557-560). Line 1396 raises before this line when the status is not OK. When the status is OK and the body is not JSON, response is None and response.get(\"resources\") raises AttributeError.\n\nIf resources[0] has no metrics key, line 1406 raises KeyError. If values is empty, line 1408 raises IndexError. If physical_total, physical_free, or logical_provisioned is absent, .get() returns None. _update_volume_stats() then runs backend_free_capacity +\u003d free_capacity_gb at line 1315 and raises TypeError, so the periodic capacity update fails.\n\nRaise VolumeBackendAPIException unless response is a dict, resources[0][\"metrics\"] exists, and all three metric names are present. Do not return None.","commit_id":"9bf613eb8dc2278085951ebc7770cae34a8cd0d5"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"d793a0b614911ee09ae81f49e6c91c83d3dafbc5","unresolved":false,"context_lines":[{"line_number":1397,"context_line":"            msg \u003d (_(\"Failed to query stats for Storage Pool %s: %s\")"},{"line_number":1398,"context_line":"                   % (pool_name, r.text))"},{"line_number":1399,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":1400,"context_line":"        results \u003d response.get(\"resources\")"},{"line_number":1401,"context_line":"        if not results:"},{"line_number":1402,"context_line":"            msg \u003d (_(\"No resources found in metrics response for \""},{"line_number":1403,"context_line":"                     \"Storage Pool %(pool)s. Response data: %(response)s\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"7e730433_ca7c2dfa","line":1400,"in_reply_to":"71e48e1d_b458b6af","updated":"2026-09-28 06:32:20.000000000","message":"Done","commit_id":"9bf613eb8dc2278085951ebc7770cae34a8cd0d5"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"d34620ec9b81b4ea01164bc89d9a852b11066f3e","unresolved":true,"context_lines":[{"line_number":224,"context_line":"        # enforces a consistent gentype across all pools."},{"line_number":225,"context_line":"        first_pd \u003d self.storage_pools[0].split(\":\")[0]"},{"line_number":226,"context_line":"        client.init_powerflex_gen_type(first_pd)"},{"line_number":227,"context_line":"        if (self.secondary_client.is_configured and"},{"line_number":228,"context_line":"                self.secondary_client is not client):"},{"line_number":229,"context_line":"            self.secondary_client.init_powerflex_gen_type(first_pd)"},{"line_number":230,"context_line":"        # validate the storage pools and check if zero padding is enabled"},{"line_number":231,"context_line":"        for pool in self.storage_pools:"},{"line_number":232,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"17dd3536_f3358a06","line":229,"range":{"start_line":227,"start_character":0,"end_line":229,"end_character":67},"updated":"2026-09-28 16:12:45.000000000","message":"why isn\u0027t this present on newer branches?","commit_id":"54c072ba764e7af46d96e22edee89e2647ad6c76"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"4604ce976037a0252f903d60469565ff195cc9e3","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        # enforces a consistent gentype across all pools."},{"line_number":225,"context_line":"        first_pd \u003d self.storage_pools[0].split(\":\")[0]"},{"line_number":226,"context_line":"        client.init_powerflex_gen_type(first_pd)"},{"line_number":227,"context_line":"        if (self.secondary_client.is_configured and"},{"line_number":228,"context_line":"                self.secondary_client is not client):"},{"line_number":229,"context_line":"            self.secondary_client.init_powerflex_gen_type(first_pd)"},{"line_number":230,"context_line":"        # validate the storage pools and check if zero padding is enabled"},{"line_number":231,"context_line":"        for pool in self.storage_pools:"},{"line_number":232,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"0ac3b08e_388fd626","line":229,"range":{"start_line":227,"start_character":0,"end_line":229,"end_character":67},"in_reply_to":"17dd3536_f3358a06","updated":"2026-09-29 05:49:57.000000000","message":"Done","commit_id":"54c072ba764e7af46d96e22edee89e2647ad6c76"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"d34620ec9b81b4ea01164bc89d9a852b11066f3e","unresolved":true,"context_lines":[{"line_number":494,"context_line":"            LOG.error(msg)"},{"line_number":495,"context_line":"            raise exception.InvalidReplicationTarget(reason\u003dmsg)"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"        active_client \u003d self._get_client()"},{"line_number":498,"context_line":"        if active_client.is_configured:"},{"line_number":499,"context_line":"            first_pd \u003d self.storage_pools[0].split(\":\")[0]"},{"line_number":500,"context_line":"            active_client.init_powerflex_gen_type(first_pd)"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"        LOG.info(\"Failover completion completed: \""},{"line_number":503,"context_line":"                 \"active_backend_id \u003d %s, \""}],"source_content_type":"text/x-python","patch_set":5,"id":"799437cf_69beb91b","line":500,"range":{"start_line":497,"start_character":0,"end_line":500,"end_character":59},"updated":"2026-09-28 16:12:45.000000000","message":"any reason this is not present on master and stable/2026.2 branches but exists here?","commit_id":"54c072ba764e7af46d96e22edee89e2647ad6c76"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"4604ce976037a0252f903d60469565ff195cc9e3","unresolved":false,"context_lines":[{"line_number":494,"context_line":"            LOG.error(msg)"},{"line_number":495,"context_line":"            raise exception.InvalidReplicationTarget(reason\u003dmsg)"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"        active_client \u003d self._get_client()"},{"line_number":498,"context_line":"        if active_client.is_configured:"},{"line_number":499,"context_line":"            first_pd \u003d self.storage_pools[0].split(\":\")[0]"},{"line_number":500,"context_line":"            active_client.init_powerflex_gen_type(first_pd)"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"        LOG.info(\"Failover completion completed: \""},{"line_number":503,"context_line":"                 \"active_backend_id \u003d %s, \""}],"source_content_type":"text/x-python","patch_set":5,"id":"9c6ce5bd_4a8719a2","line":500,"range":{"start_line":497,"start_character":0,"end_line":500,"end_character":59},"in_reply_to":"799437cf_69beb91b","updated":"2026-09-29 05:49:57.000000000","message":"Done","commit_id":"54c072ba764e7af46d96e22edee89e2647ad6c76"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"d34620ec9b81b4ea01164bc89d9a852b11066f3e","unresolved":true,"context_lines":[{"line_number":678,"context_line":"            \"provider_id\": provider_id,"},{"line_number":679,"context_line":"            \"replication_status\": fields.ReplicationStatus.DISABLED,"},{"line_number":680,"context_line":"        }"},{"line_number":681,"context_line":"        if not client.check_powerflex_ec_version():"},{"line_number":682,"context_line":"            model_updates[\"size\"] \u003d real_size"},{"line_number":683,"context_line":"        LOG.info(\"Successfully created volume %(vol_id)s. \""},{"line_number":684,"context_line":"                 \"Volume size: %(size)s. PowerFlex volume name: %(vol_name)s, \""},{"line_number":685,"context_line":"                 \"id: %(provider_id)s.\","}],"source_content_type":"text/x-python","patch_set":5,"id":"a1251219_a98d6f4a","line":682,"range":{"start_line":681,"start_character":0,"end_line":682,"end_character":42},"updated":"2026-09-28 16:12:45.000000000","message":"originally here we have:\n\n        # Only return size in model_updates if the volume is not being created\n        # from an image download. When creating from image, Cinder will extend\n        # the volume to the original requested size after creation, and we\n        # should not override the database size with the virtual_size.\n        # Check if volume has glance_metadata as an indicator of\n        # image creation.\n        if not volume.glance_metadata:\n            model_updates[\"size\"] \u003d real_size\n\n\nwhy is the change needed?","commit_id":"54c072ba764e7af46d96e22edee89e2647ad6c76"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"4604ce976037a0252f903d60469565ff195cc9e3","unresolved":false,"context_lines":[{"line_number":678,"context_line":"            \"provider_id\": provider_id,"},{"line_number":679,"context_line":"            \"replication_status\": fields.ReplicationStatus.DISABLED,"},{"line_number":680,"context_line":"        }"},{"line_number":681,"context_line":"        if not client.check_powerflex_ec_version():"},{"line_number":682,"context_line":"            model_updates[\"size\"] \u003d real_size"},{"line_number":683,"context_line":"        LOG.info(\"Successfully created volume %(vol_id)s. \""},{"line_number":684,"context_line":"                 \"Volume size: %(size)s. PowerFlex volume name: %(vol_name)s, \""},{"line_number":685,"context_line":"                 \"id: %(provider_id)s.\","}],"source_content_type":"text/x-python","patch_set":5,"id":"e435e344_1913144f","line":682,"range":{"start_line":681,"start_character":0,"end_line":682,"end_character":42},"in_reply_to":"a1251219_a98d6f4a","updated":"2026-09-29 05:49:57.000000000","message":"Done","commit_id":"54c072ba764e7af46d96e22edee89e2647ad6c76"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"d34620ec9b81b4ea01164bc89d9a852b11066f3e","unresolved":true,"context_lines":[{"line_number":805,"context_line":"            source_size \u003d source.size"},{"line_number":806,"context_line":"        if volume.size \u003e source_size:"},{"line_number":807,"context_line":"            real_size \u003d self._get_actual_vol_size(volume.size)"},{"line_number":808,"context_line":"            client.extend_volume(provider_id, real_size)"},{"line_number":809,"context_line":"        if volume.is_replicated():"},{"line_number":810,"context_line":"            self._setup_volume_replication(volume, provider_id)"},{"line_number":811,"context_line":"            model_updates[\"replication_status\"] \u003d ("}],"source_content_type":"text/x-python","patch_set":5,"id":"ae9af6e4_3c6e8e81","line":808,"updated":"2026-09-28 16:12:45.000000000","message":"here we are missing code:\n\n        # Include the actual volume size in model_updates to ensure\n        # Cinder database reflects the correct size from PowerFlex\n        real_size \u003d int(self._get_actual_vol_size(volume.size))\n        model_updates[\"size\"] \u003d real_size","commit_id":"54c072ba764e7af46d96e22edee89e2647ad6c76"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"4604ce976037a0252f903d60469565ff195cc9e3","unresolved":false,"context_lines":[{"line_number":805,"context_line":"            source_size \u003d source.size"},{"line_number":806,"context_line":"        if volume.size \u003e source_size:"},{"line_number":807,"context_line":"            real_size \u003d self._get_actual_vol_size(volume.size)"},{"line_number":808,"context_line":"            client.extend_volume(provider_id, real_size)"},{"line_number":809,"context_line":"        if volume.is_replicated():"},{"line_number":810,"context_line":"            self._setup_volume_replication(volume, provider_id)"},{"line_number":811,"context_line":"            model_updates[\"replication_status\"] \u003d ("}],"source_content_type":"text/x-python","patch_set":5,"id":"f6cbd4a9_0eec3200","line":808,"in_reply_to":"ae9af6e4_3c6e8e81","updated":"2026-09-29 05:49:57.000000000","message":"Done","commit_id":"54c072ba764e7af46d96e22edee89e2647ad6c76"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"d34620ec9b81b4ea01164bc89d9a852b11066f3e","unresolved":true,"context_lines":[{"line_number":1370,"context_line":"        raw_pool_stats, \u003d response.values()"},{"line_number":1371,"context_line":"        return self._compute_pool_stats(raw_pool_stats)"},{"line_number":1372,"context_line":""},{"line_number":1373,"context_line":"    def _get_ec_queryable_statistics(self, pool_id, pool_name):"},{"line_number":1374,"context_line":"        client \u003d self._get_client()"},{"line_number":1375,"context_line":"        url \u003d \"/rest/v1/metrics/query\""},{"line_number":1376,"context_line":"        requested_metrics \u003d ["}],"source_content_type":"text/x-python","patch_set":5,"id":"accaf39f_ecd2e58e","line":1373,"updated":"2026-09-28 16:12:45.000000000","message":"this method is quite different from the one that exists on master and stable/2026.2. why?","commit_id":"54c072ba764e7af46d96e22edee89e2647ad6c76"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"4604ce976037a0252f903d60469565ff195cc9e3","unresolved":false,"context_lines":[{"line_number":1370,"context_line":"        raw_pool_stats, \u003d response.values()"},{"line_number":1371,"context_line":"        return self._compute_pool_stats(raw_pool_stats)"},{"line_number":1372,"context_line":""},{"line_number":1373,"context_line":"    def _get_ec_queryable_statistics(self, pool_id, pool_name):"},{"line_number":1374,"context_line":"        client \u003d self._get_client()"},{"line_number":1375,"context_line":"        url \u003d \"/rest/v1/metrics/query\""},{"line_number":1376,"context_line":"        requested_metrics \u003d ["}],"source_content_type":"text/x-python","patch_set":5,"id":"fd707a89_d59494df","line":1373,"in_reply_to":"accaf39f_ecd2e58e","updated":"2026-09-29 05:49:57.000000000","message":"Done","commit_id":"54c072ba764e7af46d96e22edee89e2647ad6c76"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"e5d8e9d4b1c7c3089797e698f8e5c2706cee1e7b","unresolved":true,"context_lines":[{"line_number":670,"context_line":"            \"provider_id\": provider_id,"},{"line_number":671,"context_line":"            \"replication_status\": fields.ReplicationStatus.DISABLED,"},{"line_number":672,"context_line":"        }"},{"line_number":673,"context_line":"        if client.check_powerflex_ec_version():"},{"line_number":674,"context_line":"            # Only return size in model_updates if the volume is not being"},{"line_number":675,"context_line":"            # created from an image download. When creating from image,"},{"line_number":676,"context_line":"            # Cinder will extend the volume to the original requested size"},{"line_number":677,"context_line":"            # after creation, and we should not override the database size"},{"line_number":678,"context_line":"            # with the virtual_size."},{"line_number":679,"context_line":"            # Check if volume has glance_metadata as an indicator of"},{"line_number":680,"context_line":"            # image creation."},{"line_number":681,"context_line":"            if not volume.glance_metadata:"},{"line_number":682,"context_line":"                model_updates[\"size\"] \u003d real_size"},{"line_number":683,"context_line":"        else:"},{"line_number":684,"context_line":"            model_updates[\"size\"] \u003d real_size"},{"line_number":685,"context_line":"        LOG.info(\"Successfully created volume %(vol_id)s. \""},{"line_number":686,"context_line":"                 \"Volume size: %(size)s. PowerFlex volume name: %(vol_name)s, \""},{"line_number":687,"context_line":"                 \"id: %(provider_id)s.\","}],"source_content_type":"text/x-python","patch_set":6,"id":"02cbe55d_683d4cce","line":684,"range":{"start_line":673,"start_character":0,"end_line":684,"end_character":45},"updated":"2026-09-29 07:22:11.000000000","message":"there is here still an extra if-statement, that wasn\u0027t part of the original patch","commit_id":"13a0daebd800700b66dfac6ca293d7bf61b8e945"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"808834c4dce3df44cfc8e3b2f8e9612aecb9bfd2","unresolved":false,"context_lines":[{"line_number":670,"context_line":"            \"provider_id\": provider_id,"},{"line_number":671,"context_line":"            \"replication_status\": fields.ReplicationStatus.DISABLED,"},{"line_number":672,"context_line":"        }"},{"line_number":673,"context_line":"        if client.check_powerflex_ec_version():"},{"line_number":674,"context_line":"            # Only return size in model_updates if the volume is not being"},{"line_number":675,"context_line":"            # created from an image download. When creating from image,"},{"line_number":676,"context_line":"            # Cinder will extend the volume to the original requested size"},{"line_number":677,"context_line":"            # after creation, and we should not override the database size"},{"line_number":678,"context_line":"            # with the virtual_size."},{"line_number":679,"context_line":"            # Check if volume has glance_metadata as an indicator of"},{"line_number":680,"context_line":"            # image creation."},{"line_number":681,"context_line":"            if not volume.glance_metadata:"},{"line_number":682,"context_line":"                model_updates[\"size\"] \u003d real_size"},{"line_number":683,"context_line":"        else:"},{"line_number":684,"context_line":"            model_updates[\"size\"] \u003d real_size"},{"line_number":685,"context_line":"        LOG.info(\"Successfully created volume %(vol_id)s. \""},{"line_number":686,"context_line":"                 \"Volume size: %(size)s. PowerFlex volume name: %(vol_name)s, \""},{"line_number":687,"context_line":"                 \"id: %(provider_id)s.\","}],"source_content_type":"text/x-python","patch_set":6,"id":"10f013f3_e5807a5e","line":684,"range":{"start_line":673,"start_character":0,"end_line":684,"end_character":45},"in_reply_to":"02cbe55d_683d4cce","updated":"2026-09-29 10:42:19.000000000","message":"Done","commit_id":"13a0daebd800700b66dfac6ca293d7bf61b8e945"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"e5d8e9d4b1c7c3089797e698f8e5c2706cee1e7b","unresolved":true,"context_lines":[{"line_number":808,"context_line":"        if volume.size \u003e source_size:"},{"line_number":809,"context_line":"            real_size \u003d self._get_actual_vol_size(volume.size)"},{"line_number":810,"context_line":"            client.extend_volume(provider_id, real_size)"},{"line_number":811,"context_line":"        if client.check_powerflex_ec_version():"},{"line_number":812,"context_line":"            # Include the actual volume size in model_updates to ensure"},{"line_number":813,"context_line":"            # Cinder database reflects the correct size from PowerFlex"},{"line_number":814,"context_line":"            real_size \u003d int(self._get_actual_vol_size(volume.size))"},{"line_number":815,"context_line":"            model_updates[\"size\"] \u003d real_size"},{"line_number":816,"context_line":"        if volume.is_replicated():"},{"line_number":817,"context_line":"            self._setup_volume_replication(volume, provider_id)"},{"line_number":818,"context_line":"            model_updates[\"replication_status\"] \u003d ("}],"source_content_type":"text/x-python","patch_set":6,"id":"2657ad9d_45287387","line":815,"range":{"start_line":811,"start_character":0,"end_line":815,"end_character":45},"updated":"2026-09-29 07:22:11.000000000","message":"ditto","commit_id":"13a0daebd800700b66dfac6ca293d7bf61b8e945"},{"author":{"_account_id":38286,"name":"Siddharth Kumar","display_name":"Siddharth","email":"siddharth.kumar1@dell.com","username":"siddhvrth"},"change_message_id":"808834c4dce3df44cfc8e3b2f8e9612aecb9bfd2","unresolved":false,"context_lines":[{"line_number":808,"context_line":"        if volume.size \u003e source_size:"},{"line_number":809,"context_line":"            real_size \u003d self._get_actual_vol_size(volume.size)"},{"line_number":810,"context_line":"            client.extend_volume(provider_id, real_size)"},{"line_number":811,"context_line":"        if client.check_powerflex_ec_version():"},{"line_number":812,"context_line":"            # Include the actual volume size in model_updates to ensure"},{"line_number":813,"context_line":"            # Cinder database reflects the correct size from PowerFlex"},{"line_number":814,"context_line":"            real_size \u003d int(self._get_actual_vol_size(volume.size))"},{"line_number":815,"context_line":"            model_updates[\"size\"] \u003d real_size"},{"line_number":816,"context_line":"        if volume.is_replicated():"},{"line_number":817,"context_line":"            self._setup_volume_replication(volume, provider_id)"},{"line_number":818,"context_line":"            model_updates[\"replication_status\"] \u003d ("}],"source_content_type":"text/x-python","patch_set":6,"id":"7db923db_771fd4b3","line":815,"range":{"start_line":811,"start_character":0,"end_line":815,"end_character":45},"in_reply_to":"2657ad9d_45287387","updated":"2026-09-29 10:42:19.000000000","message":"Done","commit_id":"13a0daebd800700b66dfac6ca293d7bf61b8e945"}]}