)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"6194122c882fafd4d33b0469800fb4aa5f0c8294","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     anoop2 \u003canoop.shukla@netapp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-06-23 12:01:51 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[docs] add logging guidelines for contributer guide"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added logging guidelines discussed during ptg:"},{"line_number":10,"context_line":"https://etherpad.opendev.org/p/OpenStack_Cinder_Logging_Guidelines"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ea2d0404_cca8bdcb","line":7,"range":{"start_line":7,"start_character":34,"end_line":7,"end_character":45},"updated":"2026-06-25 13:38:35.000000000","message":"```suggestion\n[docs] add logging guidelines for contributor guide\n```","commit_id":"d1e11b3de0bf579ef365d93be8138121af4ae7b3"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"9e92b76ab87c9b19c7014f954171a938ceafa3c0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     anoop2 \u003canoop.shukla@netapp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2026-06-23 12:01:51 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[docs] add logging guidelines for contributer guide"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added logging guidelines discussed during ptg:"},{"line_number":10,"context_line":"https://etherpad.opendev.org/p/OpenStack_Cinder_Logging_Guidelines"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"2934e2c3_676f4697","line":7,"range":{"start_line":7,"start_character":34,"end_line":7,"end_character":45},"in_reply_to":"ea2d0404_cca8bdcb","updated":"2026-08-10 05:28:08.000000000","message":"Fixed.","commit_id":"d1e11b3de0bf579ef365d93be8138121af4ae7b3"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"ee43f95f787abdc514d2e22d1f2fa4ce6aff2155","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4be05b6a_7f7ab85e","updated":"2026-06-19 14:25:15.000000000","message":"Please review the Cinder Logging guidelines. This will be added as a link to contributor guide: https://review.opendev.org/c/openstack/cinder/+/994121","commit_id":"f12021bf886abe3d91f11d62da6616e11844d673"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"5823ed4327a51ef65d63246a852193afd09df34b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"66f4edc7_fa01e4d2","updated":"2026-06-24 04:53:49.000000000","message":"recheck","commit_id":"d1e11b3de0bf579ef365d93be8138121af4ae7b3"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"5e38c31421ede9f7347caf0e579c26aa6043881f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0c5ba5c4_7d6d2af2","updated":"2026-07-01 19:10:05.000000000","message":"Thanks for the review Eric. I have addressed the comments.","commit_id":"cbfaa70a82b289e6d83680fb3dea138e94052495"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"5dae6e2da3e621bd802b460a92b94bb53d440c0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1608f935_7127c01f","updated":"2026-07-01 19:10:12.000000000","message":"recheck","commit_id":"cbfaa70a82b289e6d83680fb3dea138e94052495"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"64053576b46e192e8ac5e9c916c89b19487f8bcf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2595afc4_d5d083c6","updated":"2026-07-29 05:26:22.000000000","message":"Thanks Anoop for working on this, doc looks good for me, added one comment.","commit_id":"ff3626c15367f985e3018bd1db5a0e067ce66465"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"a056259ea3a936aebefe6e51d6ced0b1a9ba8d8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0cbbbe88_6cf69121","updated":"2026-07-14 15:42:27.000000000","message":"recheck","commit_id":"ff3626c15367f985e3018bd1db5a0e067ce66465"}],"doc/source/contributor/logging_guidelines.rst":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"6194122c882fafd4d33b0469800fb4aa5f0c8294","unresolved":true,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"* Entire connector dictionaries."},{"line_number":113,"context_line":"* Vendor errors that may echo credentials or internal URLs, unless sanitized."},{"line_number":114,"context_line":"* Sensitive information like IPs, hostnames, or addresses unless required."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Only log explicitly safe fields when ``DEBUG`` truly requires context."},{"line_number":117,"context_line":"Automatic masking of some keywords and sensitive information is handled by"}],"source_content_type":"text/x-rst","patch_set":2,"id":"83f036c7_89e5f4f2","line":114,"range":{"start_line":114,"start_character":24,"end_line":114,"end_character":57},"updated":"2026-06-25 13:38:35.000000000","message":"I\u0027m not sure about this one, given that admins need this info.","commit_id":"d1e11b3de0bf579ef365d93be8138121af4ae7b3"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"5e38c31421ede9f7347caf0e579c26aa6043881f","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"* Entire connector dictionaries."},{"line_number":113,"context_line":"* Vendor errors that may echo credentials or internal URLs, unless sanitized."},{"line_number":114,"context_line":"* Sensitive information like IPs, hostnames, or addresses unless required."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"Only log explicitly safe fields when ``DEBUG`` truly requires context."},{"line_number":117,"context_line":"Automatic masking of some keywords and sensitive information is handled by"}],"source_content_type":"text/x-rst","patch_set":2,"id":"67240b59_564e3676","line":114,"range":{"start_line":114,"start_character":24,"end_line":114,"end_character":57},"in_reply_to":"83f036c7_89e5f4f2","updated":"2026-07-01 19:10:05.000000000","message":"Done","commit_id":"d1e11b3de0bf579ef365d93be8138121af4ae7b3"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"6194122c882fafd4d33b0469800fb4aa5f0c8294","unresolved":true,"context_lines":[{"line_number":166,"context_line":"* Use appropriate log levels."},{"line_number":167,"context_line":"* Include volume, snapshot, or group identifiers in failure messages."},{"line_number":168,"context_line":"* Mark user-visible exception messages appropriately."},{"line_number":169,"context_line":"* Avoid MD5 for security-related purposes and follow project rules for allowed"},{"line_number":170,"context_line":"  usage."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"Identify The Object"}],"source_content_type":"text/x-rst","patch_set":2,"id":"b63d44c6_a56cc9ab","line":169,"range":{"start_line":169,"start_character":2,"end_line":169,"end_character":11},"updated":"2026-06-25 13:38:35.000000000","message":"This probably belongs in a different doc","commit_id":"d1e11b3de0bf579ef365d93be8138121af4ae7b3"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"5e38c31421ede9f7347caf0e579c26aa6043881f","unresolved":false,"context_lines":[{"line_number":166,"context_line":"* Use appropriate log levels."},{"line_number":167,"context_line":"* Include volume, snapshot, or group identifiers in failure messages."},{"line_number":168,"context_line":"* Mark user-visible exception messages appropriately."},{"line_number":169,"context_line":"* Avoid MD5 for security-related purposes and follow project rules for allowed"},{"line_number":170,"context_line":"  usage."},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"Identify The Object"}],"source_content_type":"text/x-rst","patch_set":2,"id":"fa60a629_ea5ef6a9","line":169,"range":{"start_line":169,"start_character":2,"end_line":169,"end_character":11},"in_reply_to":"b63d44c6_a56cc9ab","updated":"2026-07-01 19:10:05.000000000","message":"Done","commit_id":"d1e11b3de0bf579ef365d93be8138121af4ae7b3"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"6194122c882fafd4d33b0469800fb4aa5f0c8294","unresolved":true,"context_lines":[{"line_number":228,"context_line":"* `OpenStack Security logging guidelines"},{"line_number":229,"context_line":"  \u003chttps://wiki.openstack.org/wiki/Security/Guidelines/logging_guidelines\u003e`_"},{"line_number":230,"context_line":"* `Nova Logging"},{"line_number":231,"context_line":"  \u003chttps://docs.openstack.org/nova/pike/admin/manage-logs.html\u003e`_"}],"source_content_type":"text/x-rst","patch_set":2,"id":"14685fa2_8415cb62","line":231,"range":{"start_line":231,"start_character":35,"end_line":231,"end_character":39},"updated":"2026-06-25 13:38:35.000000000","message":"Need a more current link","commit_id":"d1e11b3de0bf579ef365d93be8138121af4ae7b3"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"5e38c31421ede9f7347caf0e579c26aa6043881f","unresolved":false,"context_lines":[{"line_number":228,"context_line":"* `OpenStack Security logging guidelines"},{"line_number":229,"context_line":"  \u003chttps://wiki.openstack.org/wiki/Security/Guidelines/logging_guidelines\u003e`_"},{"line_number":230,"context_line":"* `Nova Logging"},{"line_number":231,"context_line":"  \u003chttps://docs.openstack.org/nova/pike/admin/manage-logs.html\u003e`_"}],"source_content_type":"text/x-rst","patch_set":2,"id":"c8f6f3d6_1d3d323c","line":231,"range":{"start_line":231,"start_character":35,"end_line":231,"end_character":39},"in_reply_to":"14685fa2_8415cb62","updated":"2026-07-01 19:10:05.000000000","message":"Done","commit_id":"d1e11b3de0bf579ef365d93be8138121af4ae7b3"},{"author":{"_account_id":36180,"name":"Gireesh Awasthi","display_name":"Gireesh","email":"gawasthi2010@gmail.com","username":"agireesh","status":"NetApp"},"change_message_id":"64053576b46e192e8ac5e9c916c89b19487f8bcf","unresolved":true,"context_lines":[{"line_number":25,"context_line":"* Avoid overwhelming clusters with excessive or noisy logs."},{"line_number":26,"context_line":"* Be consistent with logging behavior in other Cinder drivers."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"What To Log"},{"line_number":29,"context_line":"~~~~~~~~~~~"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Use the following as a driver-focused checklist for choosing log levels."},{"line_number":32,"context_line":"Oslo.log remains the baseline."},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"2181d102_cb06be8f","line":30,"range":{"start_line":28,"start_character":0,"end_line":30,"end_character":0},"updated":"2026-07-29 05:26:22.000000000","message":"We also support logging exception, can you add the info when and where user has to log the exception.","commit_id":"ff3626c15367f985e3018bd1db5a0e067ce66465"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"5e566f781c6214832fb9f9a3e35f6430488bf5ba","unresolved":false,"context_lines":[{"line_number":25,"context_line":"* Avoid overwhelming clusters with excessive or noisy logs."},{"line_number":26,"context_line":"* Be consistent with logging behavior in other Cinder drivers."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"What To Log"},{"line_number":29,"context_line":"~~~~~~~~~~~"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Use the following as a driver-focused checklist for choosing log levels."},{"line_number":32,"context_line":"Oslo.log remains the baseline."},{"line_number":33,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"b28c035c_c4eeb3f0","line":30,"range":{"start_line":28,"start_character":0,"end_line":30,"end_character":0},"in_reply_to":"2181d102_cb06be8f","updated":"2026-08-10 05:27:33.000000000","message":"Its covered in the ERROR section. Please see below.","commit_id":"ff3626c15367f985e3018bd1db5a0e067ce66465"}]}