)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"8af04620341c2a50cb737805b18338f1085d725d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"75fc94f1_93f4ecc8","updated":"2026-06-25 21:47:05.000000000","message":"This is part 2 of 2 for a fully passing volume drivers unit test run with native threading.","commit_id":"837599f172c64811bbf1440efaf26a5971b6b5e2"}],"cinder/tests/unit/volume/drivers/ibm/test_storwize_svc.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"be849601d24cebd693e5486d3c7a5cbd5cf5b5dc","unresolved":true,"context_lines":[{"line_number":3510,"context_line":"        self.mock_object(storwize_svc_common.StorwizeSVCCommonDriver,"},{"line_number":3511,"context_line":"                         \u0027_check_volume_copy_ops\u0027)"},{"line_number":3512,"context_line":"        self.mock_object(storwize_svc_common.StorwizeHelpers,"},{"line_number":3513,"context_line":"                         \u0027execute_cinder_cli\u0027, return_value\u003d\u0027\u0027)"},{"line_number":3514,"context_line":"        self.USESIM \u003d True"},{"line_number":3515,"context_line":"        if self.USESIM:"},{"line_number":3516,"context_line":"            self.iscsi_driver \u003d StorwizeSVCISCSIFakeDriver("}],"source_content_type":"text/x-python","patch_set":1,"id":"e90ad8d4_76a01d27","line":3513,"range":{"start_line":3513,"start_character":26,"end_line":3513,"end_character":44},"updated":"2026-06-29 13:22:42.000000000","message":"So, execute_cinder_cli also runs get_os_name (which interact is with the OS file system) and registerplugin, that runs an SSH call. I didn\u0027t see that on being mocked, but it might be somewhere since the test would just fail without it.\n\nIn any case I think it would be better if we would just mock register_cinder_plugin or check_for_callhome_enabled.","commit_id":"837599f172c64811bbf1440efaf26a5971b6b5e2"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"c79b16e78519248c72c72b4fe96ca44b4bd65f42","unresolved":true,"context_lines":[{"line_number":3510,"context_line":"        self.mock_object(storwize_svc_common.StorwizeSVCCommonDriver,"},{"line_number":3511,"context_line":"                         \u0027_check_volume_copy_ops\u0027)"},{"line_number":3512,"context_line":"        self.mock_object(storwize_svc_common.StorwizeHelpers,"},{"line_number":3513,"context_line":"                         \u0027execute_cinder_cli\u0027, return_value\u003d\u0027\u0027)"},{"line_number":3514,"context_line":"        self.USESIM \u003d True"},{"line_number":3515,"context_line":"        if self.USESIM:"},{"line_number":3516,"context_line":"            self.iscsi_driver \u003d StorwizeSVCISCSIFakeDriver("}],"source_content_type":"text/x-python","patch_set":1,"id":"7a55fe35_e3c26546","line":3513,"range":{"start_line":3513,"start_character":26,"end_line":3513,"end_character":44},"in_reply_to":"e90ad8d4_76a01d27","updated":"2026-07-09 09:18:10.000000000","message":"Yes, I agree. Mocking execute_cinder_cli works technically because it prevents the get_os_name and registerplugin/SSH path from running, but it is broader/lower-level than needed for this test.This test is not intended to validate execute_cinder_cli itself","commit_id":"837599f172c64811bbf1440efaf26a5971b6b5e2"}]}
