)]}'
{"cinder/tests/unit/policies/base.py":[{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bb1bb2a68219fc3fbbd483fc56d1e7130f794f04","unresolved":true,"context_lines":[{"line_number":48,"context_line":"        super().setUp(*args, **kwargs)"},{"line_number":49,"context_line":"        self.enforce_scope \u003d enforce_scope"},{"line_number":50,"context_line":"        self.enforce_new_defaults \u003d enforce_new_defaults"},{"line_number":51,"context_line":"        self.override_config(\u0027enforce_scope\u0027,"},{"line_number":52,"context_line":"                             enforce_scope, \u0027oslo_policy\u0027)"},{"line_number":53,"context_line":"        self.override_config(\u0027enforce_new_defaults\u0027,"},{"line_number":54,"context_line":"                             enforce_new_defaults, \u0027oslo_policy\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4876da7a_c84633c0","side":"PARENT","line":51,"updated":"2026-07-09 12:56:12.000000000","message":"Question: now that scope enforcement is always expected, should the policy test fixture include at least one true system-scoped context, for example system_scope\u003d\u0027all\u0027?\n\nCurrently system_admin still appears to be project-scoped in the test fixture, while policies such as system_admin_only are based on system_scope:all. If this is intentional, can we add a short comment explaining why system-scoped personas remain disabled in these tests?","commit_id":"cd2a0c893cf55747c6d8c0ca8ab2ae92a2e28c30"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b9b3378b1c2e4a3308178309323b61c2342a4cec","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        super().setUp(*args, **kwargs)"},{"line_number":49,"context_line":"        self.enforce_scope \u003d enforce_scope"},{"line_number":50,"context_line":"        self.enforce_new_defaults \u003d enforce_new_defaults"},{"line_number":51,"context_line":"        self.override_config(\u0027enforce_scope\u0027,"},{"line_number":52,"context_line":"                             enforce_scope, \u0027oslo_policy\u0027)"},{"line_number":53,"context_line":"        self.override_config(\u0027enforce_new_defaults\u0027,"},{"line_number":54,"context_line":"                             enforce_new_defaults, \u0027oslo_policy\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"0216288d_7f0363f1","side":"PARENT","line":51,"in_reply_to":"4876da7a_c84633c0","updated":"2026-07-09 15:15:27.000000000","message":"yes, those context testing make sure we reject the system scoped token","commit_id":"cd2a0c893cf55747c6d8c0ca8ab2ae92a2e28c30"}],"cinder/tests/unit/policies/test_limits.py":[{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bb1bb2a68219fc3fbbd483fc56d1e7130f794f04","unresolved":true,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    unauthorized_exceptions \u003d []"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    # Basic policy test is with and deprecated rules enabled."},{"line_number":53,"context_line":"    def setUp(self, enforce_new_defaults\u003dFalse,"},{"line_number":54,"context_line":"              *args, **kwargs):"},{"line_number":55,"context_line":"        super().setUp(enforce_new_defaults, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"6bf8d596_79eef8a3","line":52,"updated":"2026-07-09 12:56:12.000000000","message":"\"and\" can be removed","commit_id":"46db971a1e568628e910e5ed83de08b2d906f91b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b9b3378b1c2e4a3308178309323b61c2342a4cec","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    unauthorized_exceptions \u003d []"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    # Basic policy test is with and deprecated rules enabled."},{"line_number":53,"context_line":"    def setUp(self, enforce_new_defaults\u003dFalse,"},{"line_number":54,"context_line":"              *args, **kwargs):"},{"line_number":55,"context_line":"        super().setUp(enforce_new_defaults, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"8aacbae2_17e31cd5","line":52,"in_reply_to":"6bf8d596_79eef8a3","updated":"2026-07-09 15:15:27.000000000","message":"yes, but we need to keep them until old defaults are there. these tests will start failing once old defaults are gone so these needs to be reomoved togehther.","commit_id":"46db971a1e568628e910e5ed83de08b2d906f91b"}],"cinder/tests/unit/test_policy.py":[{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"bb1bb2a68219fc3fbbd483fc56d1e7130f794f04","unresolved":true,"context_lines":[{"line_number":134,"context_line":"        policy.authorize(admin_context, uppercase_action, self.target)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def test_enforce_properly_handles_invalid_scope_exception(self):"},{"line_number":137,"context_line":"        self.fixture.config(enforce_scope\u003dTrue, group\u003d\u0027oslo_policy\u0027)"},{"line_number":138,"context_line":"        project_context \u003d context.RequestContext(project_id\u003d\u0027fake-project-id\u0027,"},{"line_number":139,"context_line":"                                                 roles\u003d[\u0027bar\u0027])"},{"line_number":140,"context_line":"        policy.reset()"}],"source_content_type":"text/x-python","patch_set":1,"id":"e76450f1_b5d021a8","side":"PARENT","line":137,"updated":"2026-07-09 12:56:12.000000000","message":"The deleted test was validating the old enforce_scope\u003dFalse behavior, so deleting it makes sense because oslo.policy is removing that configuration path.\n\nHowever, can we add or point to an existing test that validates the new expected behavior: a project-scoped context should be rejected for a rule with scope_types\u003d[\u0027system\u0027]?\n\nThat would make the transition explicit and ensure Cinder still verifies scope mismatch handling once scope enforcement is always enabled.","commit_id":"cd2a0c893cf55747c6d8c0ca8ab2ae92a2e28c30"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b9b3378b1c2e4a3308178309323b61c2342a4cec","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        policy.authorize(admin_context, uppercase_action, self.target)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def test_enforce_properly_handles_invalid_scope_exception(self):"},{"line_number":137,"context_line":"        self.fixture.config(enforce_scope\u003dTrue, group\u003d\u0027oslo_policy\u0027)"},{"line_number":138,"context_line":"        project_context \u003d context.RequestContext(project_id\u003d\u0027fake-project-id\u0027,"},{"line_number":139,"context_line":"                                                 roles\u003d[\u0027bar\u0027])"},{"line_number":140,"context_line":"        policy.reset()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a784e0a_b3cbb506","side":"PARENT","line":137,"in_reply_to":"e76450f1_b5d021a8","updated":"2026-07-09 15:15:27.000000000","message":"those exist in all the existing tests with new or old defaults tests.","commit_id":"cd2a0c893cf55747c6d8c0ca8ab2ae92a2e28c30"}]}