)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"c2a594f687f40a21f83b6a4dc065e018f1304f82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b3e39823_414dda4e","updated":"2026-07-08 05:55:31.000000000","message":"run-DellEMC PowerFlex-v5 CI","commit_id":"5be00203149376112ccc4adf68c2b5e3318d7f2a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"904ec6ad4897ac121a434194439972b9c09b55d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"924d20b2_1500c300","updated":"2026-07-08 12:50:33.000000000","message":"Mostly looks good; a few comments inline.","commit_id":"f8c7349c496d53099899afd8f535a8accc059019"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"9d3a858afeeaa130b70edac5ef25a7ca71f10ee6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b40b2961_2adc5bfb","updated":"2026-07-08 08:14:46.000000000","message":"Please do a review when you get time.","commit_id":"f8c7349c496d53099899afd8f535a8accc059019"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"5009d2926f771724e2917c440bde1aaef717deb5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ca748b01_72166bf4","updated":"2026-07-08 13:41:40.000000000","message":"Thanks @rosmaita.fossdev@gmail.com for the review, update the code.","commit_id":"f8c7349c496d53099899afd8f535a8accc059019"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"c9bedfe61208fe5e77ac3f3ac0b585af144368eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7b348a05_73b87fef","updated":"2026-07-08 09:48:14.000000000","message":"run-DellEMC PowerFlex-v4 CI","commit_id":"f8c7349c496d53099899afd8f535a8accc059019"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"05b279ff06fb259910c1b420859e4ec1f18db7fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8ec17ed9_c2593230","updated":"2026-07-09 13:19:28.000000000","message":"Revisions LGTM and Dell CI is reporting green for both PF 4 and PF 5.","commit_id":"c030919d33b6af390b79d5aebc39d5434eaabdc1"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"336dd8467cf0cb868d348f76e73f9f9362f6e3d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5b015d14_c17ba005","updated":"2026-07-08 13:44:08.000000000","message":"run-DellEMC PowerFlex-v4 CI","commit_id":"c030919d33b6af390b79d5aebc39d5434eaabdc1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a3d67f5eec0f06dbbe52d33c5f17367880b1b06b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0e41ab2e_94b7d1b2","updated":"2026-07-08 18:14:06.000000000","message":"run-DellEMC PowerFlex-v5 CI","commit_id":"c030919d33b6af390b79d5aebc39d5434eaabdc1"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"2f42d5302ca7d4f580dc379e4cf15e4d9c0ebb41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dbcfcce6_d4eea71f","updated":"2026-07-08 13:44:17.000000000","message":"run-DellEMC PowerFlex-v5 CI","commit_id":"c030919d33b6af390b79d5aebc39d5434eaabdc1"}],"cinder/tests/unit/volume/drivers/dell_emc/powerflex/test_nvme.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"904ec6ad4897ac121a434194439972b9c09b55d1","unresolved":true,"context_lines":[{"line_number":271,"context_line":"        (\"edpm-compute1.ctlplane.openstack.local\","},{"line_number":272,"context_line":"         \"edpm-compute2.ctlplane.openstack.local\"),"},{"line_number":273,"context_line":"        (\"host-a-\" + \"x\" * 30,"},{"line_number":274,"context_line":"         \"host-b-\" + \"x\" * 30),"},{"line_number":275,"context_line":"    )"},{"line_number":276,"context_line":"    @ddt.unpack"},{"line_number":277,"context_line":"    def test_different_long_inputs_produce_different_results("}],"source_content_type":"text/x-python","patch_set":2,"id":"5ea26ee5_46ff8ff6","line":274,"updated":"2026-07-08 12:50:33.000000000","message":"nit: I think in the testdata for this, you want say the first 40 chars to be identical and then a difference to show up later in the long input, e.g., \n\n```\n(\u0027host-\u0027 + \u0027x\u0027 * 40 + \u00271\u0027 + \u0027a\u0027 * 5,\n \u0027host-\u0027 + \u0027x\u0027 * 40 + \u00272\u0027 + \u0027a\u0027 * 5)\n```\n\nThat way, you know the uniqueness isn\u0027t coming from the original name, but from the truncated name + hash.","commit_id":"f8c7349c496d53099899afd8f535a8accc059019"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"5009d2926f771724e2917c440bde1aaef717deb5","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        (\"edpm-compute1.ctlplane.openstack.local\","},{"line_number":272,"context_line":"         \"edpm-compute2.ctlplane.openstack.local\"),"},{"line_number":273,"context_line":"        (\"host-a-\" + \"x\" * 30,"},{"line_number":274,"context_line":"         \"host-b-\" + \"x\" * 30),"},{"line_number":275,"context_line":"    )"},{"line_number":276,"context_line":"    @ddt.unpack"},{"line_number":277,"context_line":"    def test_different_long_inputs_produce_different_results("}],"source_content_type":"text/x-python","patch_set":2,"id":"4392b651_ef3f682c","line":274,"in_reply_to":"5ea26ee5_46ff8ff6","updated":"2026-07-08 13:41:40.000000000","message":"Done","commit_id":"f8c7349c496d53099899afd8f535a8accc059019"}],"cinder/volume/drivers/dell_emc/powerflex/driver.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"904ec6ad4897ac121a434194439972b9c09b55d1","unresolved":true,"context_lines":[{"line_number":2296,"context_line":"        \"\"\""},{"line_number":2297,"context_line":"        host_id \u003d self._get_client().query_host_by_nqn(nqn)"},{"line_number":2298,"context_line":"        if not host_id:"},{"line_number":2299,"context_line":"            host_name \u003d self._truncate_host_name(connector[\"host\"])"},{"line_number":2300,"context_line":"            LOG.debug(\"Create PowerFlex host %(host_name)s. \""},{"line_number":2301,"context_line":"                      \"nqn: %(nqn)s.\","},{"line_number":2302,"context_line":"                      {"}],"source_content_type":"text/x-python","patch_set":2,"id":"b4dd0be1_8a617aaf","line":2299,"range":{"start_line":2299,"start_character":12,"end_line":2299,"end_character":21},"updated":"2026-07-08 12:50:33.000000000","message":"Question: the old code returned a name in the format \u0027{host}-{protocol}\u0027, which maybe was useful for debugging ... do we really not care about having the protocol in the name?","commit_id":"f8c7349c496d53099899afd8f535a8accc059019"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"5009d2926f771724e2917c440bde1aaef717deb5","unresolved":false,"context_lines":[{"line_number":2296,"context_line":"        \"\"\""},{"line_number":2297,"context_line":"        host_id \u003d self._get_client().query_host_by_nqn(nqn)"},{"line_number":2298,"context_line":"        if not host_id:"},{"line_number":2299,"context_line":"            host_name \u003d self._truncate_host_name(connector[\"host\"])"},{"line_number":2300,"context_line":"            LOG.debug(\"Create PowerFlex host %(host_name)s. \""},{"line_number":2301,"context_line":"                      \"nqn: %(nqn)s.\","},{"line_number":2302,"context_line":"                      {"}],"source_content_type":"text/x-python","patch_set":2,"id":"c4e28b4b_16dd87af","line":2299,"range":{"start_line":2299,"start_character":12,"end_line":2299,"end_character":21},"in_reply_to":"b4dd0be1_8a617aaf","updated":"2026-07-08 13:41:40.000000000","message":"As discussed with team we decided not to add suffix protocol.","commit_id":"f8c7349c496d53099899afd8f535a8accc059019"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"904ec6ad4897ac121a434194439972b9c09b55d1","unresolved":true,"context_lines":[{"line_number":2335,"context_line":"            return host_name"},{"line_number":2336,"context_line":""},{"line_number":2337,"context_line":"        name_hash \u003d hashlib.md5("},{"line_number":2338,"context_line":"            host_name.encode(\u0027utf-8\u0027)"},{"line_number":2339,"context_line":"        ).hexdigest()[:8]"},{"line_number":2340,"context_line":"        available \u003d MAX_POWERFLEX_HOST_NAME_LENGTH - len(name_hash) - 1"},{"line_number":2341,"context_line":"        truncated \u003d host_name[:available] + \"-\" + name_hash"}],"source_content_type":"text/x-python","patch_set":2,"id":"d489b0f6_15c086e1","line":2338,"updated":"2026-07-08 12:50:33.000000000","message":"-1: please add the \u0027usedforsecurity\u003dFalse\u0027 argument to this call","commit_id":"f8c7349c496d53099899afd8f535a8accc059019"},{"author":{"_account_id":36725,"name":"Nilesh Thathagar","display_name":"Nilesh Thathagar","email":"nilesh.thathagar@dell.com","username":"NileshT"},"change_message_id":"5009d2926f771724e2917c440bde1aaef717deb5","unresolved":false,"context_lines":[{"line_number":2335,"context_line":"            return host_name"},{"line_number":2336,"context_line":""},{"line_number":2337,"context_line":"        name_hash \u003d hashlib.md5("},{"line_number":2338,"context_line":"            host_name.encode(\u0027utf-8\u0027)"},{"line_number":2339,"context_line":"        ).hexdigest()[:8]"},{"line_number":2340,"context_line":"        available \u003d MAX_POWERFLEX_HOST_NAME_LENGTH - len(name_hash) - 1"},{"line_number":2341,"context_line":"        truncated \u003d host_name[:available] + \"-\" + name_hash"}],"source_content_type":"text/x-python","patch_set":2,"id":"713935d6_336be345","line":2338,"in_reply_to":"d489b0f6_15c086e1","updated":"2026-07-08 13:41:40.000000000","message":"Done","commit_id":"f8c7349c496d53099899afd8f535a8accc059019"}]}