)]}'
{"cliff/tests/test_app.py":[{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"fa9d501d99e1375c6cc372b4e28ae07fd50d6c82","unresolved":false,"context_lines":[{"line_number":45,"context_line":"def test_no_args_triggers_interactive_mode():"},{"line_number":46,"context_line":"    app, command \u003d make_app()"},{"line_number":47,"context_line":"    app.interact \u003d mock.MagicMock(name\u003d\u0027inspect\u0027)"},{"line_number":48,"context_line":"    app.run([])"},{"line_number":49,"context_line":"    app.interact.assert_called_once_with()"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_0820c299","line":48,"updated":"2014-09-05 03:15:34.000000000","message":"just like this.","commit_id":"1d5e28c13e66a8ff3e3aaf61a01623080f3bc6ef"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"0d47dd2bafc9332a4c62b15fd7f32451b6a3d381","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    app.clean_up \u003d mock.MagicMock(name\u003d\u0027clean_up\u0027)"},{"line_number":88,"context_line":"    app.run([\u0027error\u0027])"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    assert 1 \u003d\u003d app.clean_up.call_count"},{"line_number":91,"context_line":"    call_args \u003d app.clean_up.call_args_list[0]"},{"line_number":92,"context_line":"    assert call_args \u003d\u003d mock.call(mock.ANY, 1, mock.ANY)"},{"line_number":93,"context_line":"    args, kwargs \u003d call_args"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_82701441","line":90,"updated":"2014-09-04 23:52:19.000000000","message":"It is supposed to be assert_called_once_with()","commit_id":"1d5e28c13e66a8ff3e3aaf61a01623080f3bc6ef"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"8ee2d4dcfc21ef843e0ac1ff6f2cc3aa85923fc3","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    app.clean_up \u003d mock.MagicMock(name\u003d\u0027clean_up\u0027)"},{"line_number":88,"context_line":"    app.run([\u0027error\u0027])"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    assert 1 \u003d\u003d app.clean_up.call_count"},{"line_number":91,"context_line":"    call_args \u003d app.clean_up.call_args_list[0]"},{"line_number":92,"context_line":"    assert call_args \u003d\u003d mock.call(mock.ANY, 1, mock.ANY)"},{"line_number":93,"context_line":"    args, kwargs \u003d call_args"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_be637040","line":90,"in_reply_to":"fa98f980_2515af48","updated":"2014-09-05 23:49:58.000000000","message":"This file doesn\u0027t use unittest, only mock, so assertEqual isn\u0027t available - hence the use of assert everywhere.\n\nInstead I\u0027ve gone back to assert_called_once_with using mock.ANY since we don\u0027t actually care what is passed to clean_up.","commit_id":"1d5e28c13e66a8ff3e3aaf61a01623080f3bc6ef"},{"author":{"_account_id":8125,"name":"Michael Davies","email":"michael@the-davies.net","username":"mrda"},"change_message_id":"947c11db7bf5732d6e90e8c0756de930b7314eed","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    app.clean_up \u003d mock.MagicMock(name\u003d\u0027clean_up\u0027)"},{"line_number":88,"context_line":"    app.run([\u0027error\u0027])"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    assert 1 \u003d\u003d app.clean_up.call_count"},{"line_number":91,"context_line":"    call_args \u003d app.clean_up.call_args_list[0]"},{"line_number":92,"context_line":"    assert call_args \u003d\u003d mock.call(mock.ANY, 1, mock.ANY)"},{"line_number":93,"context_line":"    args, kwargs \u003d call_args"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_c2669c50","line":90,"in_reply_to":"fa98f980_82701441","updated":"2014-09-05 00:02:57.000000000","message":"Hi Terry - thanks for the review.\n\nI used call_count as the previous test did not check the rather large list of parameters, so I\u0027m assuming the exact content of them doesn\u0027t matter.  Consequently I just checked the number of times the mock was called instead.\n\nThere\u0027s no return value set for the clean_up mock, nor any params set up either to be passed through.\n\nDoes this test need to check the parameters passed to clean_up?","commit_id":"1d5e28c13e66a8ff3e3aaf61a01623080f3bc6ef"},{"author":{"_account_id":8736,"name":"Terry Howe","email":"terrylhowe@gmail.com","username":"terrylhowe"},"change_message_id":"fa9d501d99e1375c6cc372b4e28ae07fd50d6c82","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    app.clean_up \u003d mock.MagicMock(name\u003d\u0027clean_up\u0027)"},{"line_number":88,"context_line":"    app.run([\u0027error\u0027])"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    assert 1 \u003d\u003d app.clean_up.call_count"},{"line_number":91,"context_line":"    call_args \u003d app.clean_up.call_args_list[0]"},{"line_number":92,"context_line":"    assert call_args \u003d\u003d mock.call(mock.ANY, 1, mock.ANY)"},{"line_number":93,"context_line":"    args, kwargs \u003d call_args"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_2515af48","line":90,"in_reply_to":"fa98f980_c2669c50","updated":"2014-09-05 03:15:34.000000000","message":"What you have will work, but it rubs me the wrong way to use assert rather than unittest.  If you don\u0027t like assert_called_once_with(), it would be a bit more correct to use:\n\n    self.assertEqual(1, app.clean_up.call_count)\n\nThis test has a couple other calls to assert_called_once_with()","commit_id":"1d5e28c13e66a8ff3e3aaf61a01623080f3bc6ef"}]}