)]}'
{"cliff/commandmanager.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"ad941ddaa04f47b8ca7926f0c2f22eaa14de73cf","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        \"\"\""},{"line_number":64,"context_line":"        search_args \u003d argv[:]"},{"line_number":65,"context_line":"        name \u003d \u0027\u0027"},{"line_number":66,"context_line":"        argv \u003d [str(arg) for arg in argv]"},{"line_number":67,"context_line":"        while search_args:"},{"line_number":68,"context_line":"            if search_args[0].startswith(\u0027-\u0027):"},{"line_number":69,"context_line":"                name \u003d \u0027%s %s\u0027 % (name, search_args[0])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_e1f5cf56","line":66,"updated":"2016-01-29 20:09:44.000000000","message":"This will generate a unicode error if the user mistypes a command and then includes a unicode identifier string, won\u0027t it?","commit_id":"c5d4d6ebdbc4f81859ff05744ca711325d2d1bd6"},{"author":{"_account_id":19383,"name":"linwei wu","email":"wlwwu@cn.ibm.com","username":"linwwu"},"change_message_id":"addf05d86ee7dd981487d2f9f519c497de62e4a0","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        \"\"\""},{"line_number":64,"context_line":"        search_args \u003d argv[:]"},{"line_number":65,"context_line":"        name \u003d \u0027\u0027"},{"line_number":66,"context_line":"        argv \u003d [str(arg) for arg in argv]"},{"line_number":67,"context_line":"        while search_args:"},{"line_number":68,"context_line":"            if search_args[0].startswith(\u0027-\u0027):"},{"line_number":69,"context_line":"                name \u003d \u0027%s %s\u0027 % (name, search_args[0])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a5de9d1_c84a1626","line":66,"in_reply_to":"7a5de9d1_e1f5cf56","updated":"2016-02-01 01:54:49.000000000","message":"why do u think that it will generate unicode error? could you please try on your setup again?","commit_id":"c5d4d6ebdbc4f81859ff05744ca711325d2d1bd6"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"725232b06ed09a0c208fe193fde86ada8b89cb82","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                        cmd_factory \u003d cmd_ep.load()"},{"line_number":84,"context_line":"                return (cmd_factory, name, search_args)"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"            argv \u003d [str(arg) for arg in argv] "},{"line_number":87,"context_line":"            raise ValueError(\u0027Unknown command %r\u0027 %"},{"line_number":88,"context_line":"                             (argv,))"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_f63eebd8","line":86,"updated":"2016-02-22 07:48:51.000000000","message":"nit: extra space","commit_id":"51d61ba8866ee836c6b8b51eb6202a7eaea335ea"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"824b1d06a4d7742b825d02f93ebcad564106aa90","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                        cmd_factory \u003d cmd_ep.load()"},{"line_number":84,"context_line":"                return (cmd_factory, name, search_args)"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"            argv \u003d [str(arg) for arg in argv]"},{"line_number":87,"context_line":"            raise ValueError(\u0027Unknown command %r\u0027 %"},{"line_number":88,"context_line":"                             (argv,))"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_442d3efd","line":86,"updated":"2016-02-22 21:00:35.000000000","message":"This is going to fail if the unicode string can\u0027t be converted to ASCII. That should usually be possible, but since cliff may be used in tools where the command names are in languages where the default character set cannot be converted, we should catch encoding errors and fall back to using the unicode strings.","commit_id":"8ac661df273d4d32f054b096c3d2baad2e37c09d"},{"author":{"_account_id":19383,"name":"linwei wu","email":"wlwwu@cn.ibm.com","username":"linwwu"},"change_message_id":"5b772d3924749a782521c1d9ef28d9016b2c28a8","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                        cmd_factory \u003d cmd_ep.load()"},{"line_number":84,"context_line":"                return (cmd_factory, name, search_args)"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"            argv \u003d [str(arg) for arg in argv]"},{"line_number":87,"context_line":"            raise ValueError(\u0027Unknown command %r\u0027 %"},{"line_number":88,"context_line":"                             (argv,))"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_5c9d0abb","line":86,"in_reply_to":"bae84128_442d3efd","updated":"2016-02-23 02:15:29.000000000","message":"thanks for your comments. what you mean is that if we type an language,which can\u0027t be converted to string, right?  I can just add detect before convertion, is that okay?  or do you have better suggestion??","commit_id":"8ac661df273d4d32f054b096c3d2baad2e37c09d"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"9185ee3a6f633427085e414557c8cadb97602afc","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                        cmd_factory \u003d cmd_ep.load()"},{"line_number":84,"context_line":"                return (cmd_factory, name, search_args)"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"            argv \u003d [str(arg) for arg in argv]"},{"line_number":87,"context_line":"            raise ValueError(\u0027Unknown command %r\u0027 %"},{"line_number":88,"context_line":"                             (argv,))"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_5d5561c4","line":86,"in_reply_to":"bae84128_5003980d","updated":"2016-02-25 12:52:10.000000000","message":"I think what you actually want to do is make the exception below handle unicode. If argv contains unicode objects, that will allow the exception to be reported properly. If argv contains ASCII strings, those can be promoted to unicode objects automatically.","commit_id":"8ac661df273d4d32f054b096c3d2baad2e37c09d"},{"author":{"_account_id":19383,"name":"linwei wu","email":"wlwwu@cn.ibm.com","username":"linwwu"},"change_message_id":"6d23d8600dedb1742964f2c016cdf40d9196109e","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                        cmd_factory \u003d cmd_ep.load()"},{"line_number":84,"context_line":"                return (cmd_factory, name, search_args)"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"            argv \u003d [str(arg) for arg in argv]"},{"line_number":87,"context_line":"            raise ValueError(\u0027Unknown command %r\u0027 %"},{"line_number":88,"context_line":"                             (argv,))"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_5003980d","line":86,"in_reply_to":"bae84128_5c9d0abb","updated":"2016-02-25 08:02:29.000000000","message":"any comments","commit_id":"8ac661df273d4d32f054b096c3d2baad2e37c09d"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"2ff885ba793d925484edd735e25934944301c467","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                        cmd_factory \u003d cmd_ep.load()"},{"line_number":84,"context_line":"                return (cmd_factory, name, search_args)"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"            argv \u003d [str(arg) for arg in argv]"},{"line_number":87,"context_line":"            raise ValueError(\u0027Unknown command %r\u0027 %"},{"line_number":88,"context_line":"                             (argv,))"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_e15aaa29","line":86,"in_reply_to":"bae84128_5d5561c4","updated":"2016-03-30 01:49:48.000000000","message":"I actually like what Doug pointed out here...\nUsers are not limited to Unicode inputs. They can provide ASCII strings as well.\n\nSo maybe you can just check if the input is an instance of string(py2)/byte(py3) or Unicode and only then proceed for the conversion if it is infact in Unicode","commit_id":"8ac661df273d4d32f054b096c3d2baad2e37c09d"}]}