)]}'
{"cliff/command.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"aea0702d939d496da30ac370de9d5a8ef7284121","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        :class:`Lister` and :class:`ShowOne`) should override this"},{"line_number":53,"context_line":"        method to wrap :meth:`take_action`."},{"line_number":54,"context_line":"        \"\"\""},{"line_number":55,"context_line":"        return self.take_action(parsed_args)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_c6fd263d","line":55,"updated":"2016-06-15 18:14:03.000000000","message":"I expect there are a lot of take_action() methods that don\u0027t return anything, since it\u0027s not documented that they should. So how about making this \n\n  response \u003d self.take_action(parsed_args) or 0\n\nand then updating the docstring for take_action() to indicate that if a numerical value is returned it will be used otherwise the program returns 0 if there is no error.","commit_id":"5782acce6983818906afa5bb008c7061866bc4dd"}],"cliff/tests/test_command.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"3fb15a923b85e713131342ab20f364f6df6eb0bf","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    \"\"\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    def take_action(self, parsed_args):"},{"line_number":10,"context_line":"        return 42"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"def test_get_description():"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_70be8501","line":10,"updated":"2016-06-16 11:33:17.000000000","message":"I suggest a unit test for no return value as well.","commit_id":"a4dc4549bc398bb57ce5d2605b662a4a5eeb516b"}]}