)]}'
{"cliff/formatters/table.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"ce54c1e8d6a4fe4bc13c4f15968ead0c3c9f8ff0","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        group.add_argument("},{"line_number":27,"context_line":"            \u0027--max-width\u0027,"},{"line_number":28,"context_line":"            metavar\u003d\u0027\u003cinteger\u003e\u0027,"},{"line_number":29,"context_line":"            default\u003dos.environ.get(\u0027OS_MAX_TERM_WIDTH\u0027, 0),"},{"line_number":30,"context_line":"            type\u003dint,"},{"line_number":31,"context_line":"            help\u003d\u0027Maximum display width, 0 to disable\u0027,"},{"line_number":32,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_2853ce3a","line":29,"updated":"2016-05-04 12:38:56.000000000","message":"Unfortunately because cliff isn\u0027t openstack-specific we can\u0027t use OS_ as the prefix here. You could go with CLIFF_ or we could work out a way for the formatter to ask the app for a prefix name so that the openstack client app can tell it to use OS_. I can work with you to design that, since it looks like we\u0027ll have to change the formatter API to pass the app to it somewhere.\n\nYou\u0027ll also want to wrap the os.environ.get() call with int() so the value passed to add_argument is always an integer.","commit_id":"0300289e7d0cfc845de3257d5ef7429aaa336fc1"},{"author":{"_account_id":16318,"name":"Vincent Legoll","email":"vincent.legoll@iphc.cnrs.fr","username":"vincentleg"},"change_message_id":"d72df9c918e916419657462134f7e807471dc6e7","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        group.add_argument("},{"line_number":27,"context_line":"            \u0027--max-width\u0027,"},{"line_number":28,"context_line":"            metavar\u003d\u0027\u003cinteger\u003e\u0027,"},{"line_number":29,"context_line":"            default\u003dos.environ.get(\u0027OS_MAX_TERM_WIDTH\u0027, 0),"},{"line_number":30,"context_line":"            type\u003dint,"},{"line_number":31,"context_line":"            help\u003d\u0027Maximum display width, 0 to disable\u0027,"},{"line_number":32,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_feafcc28","line":29,"in_reply_to":"1a122d0e_2853ce3a","updated":"2016-05-04 13:14:00.000000000","message":"Could we go the \"CLIFF_\" way to avoid delaying the fix ?\n\nAnd then when the new API has materialized, we can change it to per-application, defaulting then to \"CLIFF_\" to keep early users happy.\n\nApplications that specifically want their envvars to be consistent can call the new API, and then document the potential breakage in their own release notes.","commit_id":"0300289e7d0cfc845de3257d5ef7429aaa336fc1"},{"author":{"_account_id":16318,"name":"Vincent Legoll","email":"vincent.legoll@iphc.cnrs.fr","username":"vincentleg"},"change_message_id":"067f14a290070eccbc58de9fcab98b1f2b50084b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        group.add_argument("},{"line_number":27,"context_line":"            \u0027--max-width\u0027,"},{"line_number":28,"context_line":"            metavar\u003d\u0027\u003cinteger\u003e\u0027,"},{"line_number":29,"context_line":"            default\u003dos.environ.get(\u0027OS_MAX_TERM_WIDTH\u0027, 0),"},{"line_number":30,"context_line":"            type\u003dint,"},{"line_number":31,"context_line":"            help\u003d\u0027Maximum display width, 0 to disable\u0027,"},{"line_number":32,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_2ca03343","line":29,"in_reply_to":"1a122d0e_feafcc28","updated":"2016-05-17 11:23:34.000000000","message":"Done","commit_id":"0300289e7d0cfc845de3257d5ef7429aaa336fc1"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"ce54c1e8d6a4fe4bc13c4f15968ead0c3c9f8ff0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"            metavar\u003d\u0027\u003cinteger\u003e\u0027,"},{"line_number":29,"context_line":"            default\u003dos.environ.get(\u0027OS_MAX_TERM_WIDTH\u0027, 0),"},{"line_number":30,"context_line":"            type\u003dint,"},{"line_number":31,"context_line":"            help\u003d\u0027Maximum display width, 0 to disable\u0027,"},{"line_number":32,"context_line":"        )"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def emit_list(self, column_names, data, stdout, parsed_args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_082532c1","line":31,"updated":"2016-05-04 12:38:56.000000000","message":"The help text should mention the name of the variable that controls the default.","commit_id":"0300289e7d0cfc845de3257d5ef7429aaa336fc1"},{"author":{"_account_id":16318,"name":"Vincent Legoll","email":"vincent.legoll@iphc.cnrs.fr","username":"vincentleg"},"change_message_id":"d72df9c918e916419657462134f7e807471dc6e7","unresolved":false,"context_lines":[{"line_number":28,"context_line":"            metavar\u003d\u0027\u003cinteger\u003e\u0027,"},{"line_number":29,"context_line":"            default\u003dos.environ.get(\u0027OS_MAX_TERM_WIDTH\u0027, 0),"},{"line_number":30,"context_line":"            type\u003dint,"},{"line_number":31,"context_line":"            help\u003d\u0027Maximum display width, 0 to disable\u0027,"},{"line_number":32,"context_line":"        )"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def emit_list(self, column_names, data, stdout, parsed_args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_9e6fb8fb","line":31,"in_reply_to":"1a122d0e_082532c1","updated":"2016-05-04 13:14:00.000000000","message":"Done, will be in the next patch iteration","commit_id":"0300289e7d0cfc845de3257d5ef7429aaa336fc1"},{"author":{"_account_id":16318,"name":"Vincent Legoll","email":"vincent.legoll@iphc.cnrs.fr","username":"vincentleg"},"change_message_id":"067f14a290070eccbc58de9fcab98b1f2b50084b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"            metavar\u003d\u0027\u003cinteger\u003e\u0027,"},{"line_number":29,"context_line":"            default\u003dos.environ.get(\u0027OS_MAX_TERM_WIDTH\u0027, 0),"},{"line_number":30,"context_line":"            type\u003dint,"},{"line_number":31,"context_line":"            help\u003d\u0027Maximum display width, 0 to disable\u0027,"},{"line_number":32,"context_line":"        )"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def emit_list(self, column_names, data, stdout, parsed_args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_0ca3af50","line":31,"in_reply_to":"1a122d0e_9e6fb8fb","updated":"2016-05-17 11:23:34.000000000","message":"Done","commit_id":"0300289e7d0cfc845de3257d5ef7429aaa336fc1"},{"author":{"_account_id":16318,"name":"Vincent Legoll","email":"vincent.legoll@iphc.cnrs.fr","username":"vincentleg"},"change_message_id":"5af708e0717dd05ad63775f33d29434e049b6cdd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1a122d0e_1c78957d","updated":"2016-05-05 15:03:07.000000000","message":"I\u0027ll need help to add testing, I\u0027ve got problem with the os.environ mocking, I\u0027ve tried and failed to make a working test...","commit_id":"7c8468cfce3ee190954a333ae8e54e67f11b7633"},{"author":{"_account_id":16318,"name":"Vincent Legoll","email":"vincent.legoll@iphc.cnrs.fr","username":"vincentleg"},"change_message_id":"98359c832f198b487738961071e88ffdd526f292","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dab17558_296dc698","in_reply_to":"1a122d0e_1c78957d","updated":"2016-05-07 11:05:10.000000000","message":"Done","commit_id":"7c8468cfce3ee190954a333ae8e54e67f11b7633"},{"author":{"_account_id":16318,"name":"Vincent Legoll","email":"vincent.legoll@iphc.cnrs.fr","username":"vincentleg"},"change_message_id":"d79487630aa943d58569d4c9fb512d7ea761693d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1a122d0e_893bc49b","in_reply_to":"1a122d0e_1c78957d","updated":"2016-05-05 15:28:59.000000000","message":"I\u0027ve tried to replace \n\n@mock.patch(\u0027cliff.utils.terminal_width\u0027)\n\nby\n\n@mock.patch.dict(os.environ, {\u0027CLIFF_MAX_TERM_WIDTH\u0027: \u002745\u0027})\n\nbut that does not work...","commit_id":"7c8468cfce3ee190954a333ae8e54e67f11b7633"},{"author":{"_account_id":16318,"name":"Vincent Legoll","email":"vincent.legoll@iphc.cnrs.fr","username":"vincentleg"},"change_message_id":"98359c832f198b487738961071e88ffdd526f292","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dab17558_096a8280","in_reply_to":"1a122d0e_893bc49b","updated":"2016-05-07 11:05:10.000000000","message":"Done","commit_id":"7c8468cfce3ee190954a333ae8e54e67f11b7633"}],"cliff/tests/test_formatters_table.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"fc3c2c0470b194d8a4b62e4e19bcac6966254b8d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"def test_table_formatter_cli_param(tw):"},{"line_number":45,"context_line":"    tw.return_value \u003d 80"},{"line_number":46,"context_line":"    sf \u003d table.TableFormatter()"},{"line_number":47,"context_line":"    import argparse"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    parser \u003d argparse.ArgumentParser(description\u003d\u0027Testing...\u0027)"},{"line_number":50,"context_line":"    sf.add_argument_group(parser)"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_c808ef2a","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":19},"updated":"2016-05-11 07:01:45.000000000","message":"you can import this on line 6 instead of repeating it for every test","commit_id":"c59f04465cff2d2d147491d5ec521e8b769bd377"},{"author":{"_account_id":16318,"name":"Vincent Legoll","email":"vincent.legoll@iphc.cnrs.fr","username":"vincentleg"},"change_message_id":"6a6929e1ccf78f5b3ba6503067cf1765eeae8c05","unresolved":false,"context_lines":[{"line_number":44,"context_line":"def test_table_formatter_cli_param(tw):"},{"line_number":45,"context_line":"    tw.return_value \u003d 80"},{"line_number":46,"context_line":"    sf \u003d table.TableFormatter()"},{"line_number":47,"context_line":"    import argparse"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    parser \u003d argparse.ArgumentParser(description\u003d\u0027Testing...\u0027)"},{"line_number":50,"context_line":"    sf.add_argument_group(parser)"}],"source_content_type":"text/x-python","patch_set":6,"id":"dab17558_e1ea20d7","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":19},"in_reply_to":"dab17558_c808ef2a","updated":"2016-05-17 11:22:36.000000000","message":"Done","commit_id":"c59f04465cff2d2d147491d5ec521e8b769bd377"}]}