)]}'
{"cliff/tests/test_formatters_table.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"a6cbd7dbdf0cc107ee19ce548b541289f2907b92","unresolved":false,"context_lines":[{"line_number":17,"context_line":"            self.max_width \u003d int(os.environ.get(\u0027CLIFF_MAX_TERM_WIDTH\u0027, 0))"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def _table_tester_helper(c, d, single_row\u003dFalse, argums\u003dNone):"},{"line_number":21,"context_line":"    sf \u003d table.TableFormatter()"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    if argums is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_4b561dd3","line":20,"range":{"start_line":20,"start_character":4,"end_line":20,"end_character":24},"updated":"2016-05-13 18:45:24.000000000","message":"a docstring here describing what the function does and what the arguments are would make this much easier to understand and read.","commit_id":"4c54333a8f26c52c9666f781f52b7b7108ebc9aa"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"a6cbd7dbdf0cc107ee19ce548b541289f2907b92","unresolved":false,"context_lines":[{"line_number":17,"context_line":"            self.max_width \u003d int(os.environ.get(\u0027CLIFF_MAX_TERM_WIDTH\u0027, 0))"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def _table_tester_helper(c, d, single_row\u003dFalse, argums\u003dNone):"},{"line_number":21,"context_line":"    sf \u003d table.TableFormatter()"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    if argums is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_cb0faddf","line":20,"range":{"start_line":20,"start_character":25,"end_line":20,"end_character":29},"updated":"2016-05-13 18:45:24.000000000","message":"also \u0027c\u0027 and \u0027d\u0027 are awful parameter names, i know you were just following the convention, but if we are changing things up we can take this opportunity to clean things up a bit more :)\n\n(we don\u0027t have to change them in the tests, but at least in the method signature)","commit_id":"4c54333a8f26c52c9666f781f52b7b7108ebc9aa"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"a6cbd7dbdf0cc107ee19ce548b541289f2907b92","unresolved":false,"context_lines":[{"line_number":17,"context_line":"            self.max_width \u003d int(os.environ.get(\u0027CLIFF_MAX_TERM_WIDTH\u0027, 0))"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def _table_tester_helper(c, d, single_row\u003dFalse, argums\u003dNone):"},{"line_number":21,"context_line":"    sf \u003d table.TableFormatter()"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    if argums is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_8b8f6522","line":20,"range":{"start_line":20,"start_character":49,"end_line":20,"end_character":55},"updated":"2016-05-13 18:45:24.000000000","message":"argum is a funny name, can we use something more clear? options? extra_args?","commit_id":"4c54333a8f26c52c9666f781f52b7b7108ebc9aa"},{"author":{"_account_id":16318,"name":"Vincent Legoll","email":"vincent.legoll@iphc.cnrs.fr","username":"vincentleg"},"change_message_id":"096fe9bf9f19611ae87a06919b01491c33da7913","unresolved":false,"context_lines":[{"line_number":17,"context_line":"            self.max_width \u003d int(os.environ.get(\u0027CLIFF_MAX_TERM_WIDTH\u0027, 0))"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def _table_tester_helper(c, d, single_row\u003dFalse, argums\u003dNone):"},{"line_number":21,"context_line":"    sf \u003d table.TableFormatter()"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    if argums is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_5407de1b","line":20,"range":{"start_line":20,"start_character":4,"end_line":20,"end_character":24},"in_reply_to":"dab17558_4b561dd3","updated":"2016-05-13 20:11:36.000000000","message":"Done","commit_id":"4c54333a8f26c52c9666f781f52b7b7108ebc9aa"},{"author":{"_account_id":16318,"name":"Vincent Legoll","email":"vincent.legoll@iphc.cnrs.fr","username":"vincentleg"},"change_message_id":"096fe9bf9f19611ae87a06919b01491c33da7913","unresolved":false,"context_lines":[{"line_number":17,"context_line":"            self.max_width \u003d int(os.environ.get(\u0027CLIFF_MAX_TERM_WIDTH\u0027, 0))"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def _table_tester_helper(c, d, single_row\u003dFalse, argums\u003dNone):"},{"line_number":21,"context_line":"    sf \u003d table.TableFormatter()"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    if argums is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_34021a0c","line":20,"range":{"start_line":20,"start_character":49,"end_line":20,"end_character":55},"in_reply_to":"dab17558_8b8f6522","updated":"2016-05-13 20:11:36.000000000","message":"Done","commit_id":"4c54333a8f26c52c9666f781f52b7b7108ebc9aa"},{"author":{"_account_id":16318,"name":"Vincent Legoll","email":"vincent.legoll@iphc.cnrs.fr","username":"vincentleg"},"change_message_id":"096fe9bf9f19611ae87a06919b01491c33da7913","unresolved":false,"context_lines":[{"line_number":17,"context_line":"            self.max_width \u003d int(os.environ.get(\u0027CLIFF_MAX_TERM_WIDTH\u0027, 0))"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"def _table_tester_helper(c, d, single_row\u003dFalse, argums\u003dNone):"},{"line_number":21,"context_line":"    sf \u003d table.TableFormatter()"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    if argums is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_7f02bb0a","line":20,"range":{"start_line":20,"start_character":25,"end_line":20,"end_character":29},"in_reply_to":"dab17558_cb0faddf","updated":"2016-05-13 20:11:36.000000000","message":"Done","commit_id":"4c54333a8f26c52c9666f781f52b7b7108ebc9aa"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"a6cbd7dbdf0cc107ee19ce548b541289f2907b92","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        parsed_args \u003d parser.parse_args(argums)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    output \u003d StringIO()"},{"line_number":33,"context_line":"    emitter \u003d sf.emit_list"},{"line_number":34,"context_line":"    if single_row:"},{"line_number":35,"context_line":"        emitter \u003d sf.emit_one"},{"line_number":36,"context_line":"    emitter(c, d, output, parsed_args)"},{"line_number":37,"context_line":"    return output.getvalue()"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_2bed99ef","line":35,"range":{"start_line":33,"start_character":4,"end_line":35,"end_character":29},"updated":"2016-05-13 18:45:24.000000000","message":"this can be condense to:\n\n  emitter \u003d sf.emit_one if single_row else sf.emit_list","commit_id":"4c54333a8f26c52c9666f781f52b7b7108ebc9aa"},{"author":{"_account_id":16318,"name":"Vincent Legoll","email":"vincent.legoll@iphc.cnrs.fr","username":"vincentleg"},"change_message_id":"096fe9bf9f19611ae87a06919b01491c33da7913","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        parsed_args \u003d parser.parse_args(argums)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    output \u003d StringIO()"},{"line_number":33,"context_line":"    emitter \u003d sf.emit_list"},{"line_number":34,"context_line":"    if single_row:"},{"line_number":35,"context_line":"        emitter \u003d sf.emit_one"},{"line_number":36,"context_line":"    emitter(c, d, output, parsed_args)"},{"line_number":37,"context_line":"    return output.getvalue()"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_df09272e","line":35,"range":{"start_line":33,"start_character":4,"end_line":35,"end_character":29},"in_reply_to":"dab17558_2bed99ef","updated":"2016-05-13 20:11:36.000000000","message":"Done","commit_id":"4c54333a8f26c52c9666f781f52b7b7108ebc9aa"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"ae7dccb6df1277b930d21096f6d036333299cb7b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        parsed_args \u003d parser.parse_args(extra_args)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    output \u003d StringIO()"},{"line_number":45,"context_line":"    emitter \u003d sf.emit_list if type(data) is list else sf.emit_one"},{"line_number":46,"context_line":"    emitter(tags, data, output, parsed_args)"},{"line_number":47,"context_line":"    return output.getvalue()"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_9f379faf","line":45,"range":{"start_line":45,"start_character":27,"end_line":45,"end_character":40},"updated":"2016-05-13 20:18:25.000000000","message":"nice job getting rid of `single_row` :)","commit_id":"365bc52d4412eac298a5ab6de88d56439c6cd892"}]}
