)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20354,"name":"Shoham Peller","email":"shohamp@gmail.com","username":"shoham.peller"},"change_message_id":"e151d76d80b891e7a7bb5a4d64893212dc0d8c63","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix command order"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    When there are two commands: one \u0027foo\u0027, that expect a positional"},{"line_number":10,"context_line":"    argument, and a second command \u0027foo bar\u0027. If the hash of the first"},{"line_number":11,"context_line":"    is smaller than the hash of the second, the dict iteration"},{"line_number":12,"context_line":"    will insert it first to the cmd parsing list."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_f9e5bb08","line":9,"updated":"2016-08-30 08:23:14.000000000","message":"redundant indentation?","commit_id":"aa9cb601d851330029b68e1d16631cce345153bc"},{"author":{"_account_id":20354,"name":"Shoham Peller","email":"shohamp@gmail.com","username":"shoham.peller"},"change_message_id":"376f1ad6bd08aa28a8e42f44288aca0a76bfa177","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix command order"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    When there are two commands: one \u0027foo\u0027, that expect a positional"},{"line_number":10,"context_line":"    argument, and a second command \u0027foo bar\u0027. If the hash of the first"},{"line_number":11,"context_line":"    is smaller than the hash of the second, the dict iteration"},{"line_number":12,"context_line":"    will insert it first to the cmd parsing list."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa7ab95a_84d6024d","line":9,"updated":"2016-08-30 08:36:53.000000000","message":"redundant indentation","commit_id":"3e7fe944e40bc90291d79df062c7651407f17194"}],"cliff/commandmanager.py":[{"author":{"_account_id":20354,"name":"Shoham Peller","email":"shohamp@gmail.com","username":"shoham.peller"},"change_message_id":"e151d76d80b891e7a7bb5a4d64893212dc0d8c63","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        return the processor and any remaining arguments."},{"line_number":63,"context_line":"        \"\"\""},{"line_number":64,"context_line":"        i \u003d len(argv)"},{"line_number":65,"context_line":"        while i \u003e 0:"},{"line_number":66,"context_line":"            name \u003d \u0027 \u0027.join(argv[:i])"},{"line_number":67,"context_line":"            search_args \u003d argv[i:]"},{"line_number":68,"context_line":"            if name in self.commands:"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_793d2b8e","line":65,"updated":"2016-08-30 08:23:14.000000000","message":"for i in xrange(len(argv), 0, -1)?","commit_id":"aa9cb601d851330029b68e1d16631cce345153bc"},{"author":{"_account_id":20354,"name":"Shoham Peller","email":"shohamp@gmail.com","username":"shoham.peller"},"change_message_id":"376f1ad6bd08aa28a8e42f44288aca0a76bfa177","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                    else:"},{"line_number":78,"context_line":"                        cmd_factory \u003d cmd_ep.load()"},{"line_number":79,"context_line":"                return (cmd_factory, name, search_args)"},{"line_number":80,"context_line":"        else:"},{"line_number":81,"context_line":"            raise ValueError(\u0027Unknown command %r\u0027 %"},{"line_number":82,"context_line":"                             (argv,))"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_04dcb271","line":80,"updated":"2016-08-30 08:36:53.000000000","message":"now the else here is not good, you need to remove the else, and put the code with no identation","commit_id":"3e7fe944e40bc90291d79df062c7651407f17194"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"975e46730b92fe28bde342843c21eb6249b56fa3","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        return the processor and any remaining arguments."},{"line_number":64,"context_line":"        \"\"\""},{"line_number":65,"context_line":"        start \u003d self._get_last_possible_command_index(argv)"},{"line_number":66,"context_line":"        for i in six.moves.range(start, 0, -1):"},{"line_number":67,"context_line":"            name \u003d \u0027 \u0027.join(argv[:i])"},{"line_number":68,"context_line":"            search_args \u003d argv[i:]"},{"line_number":69,"context_line":"            if name in self.commands:"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba5201f7_8d2b0b82","line":66,"updated":"2017-01-02 19:47:55.000000000","message":"You can just use range(). No command line is going to have enough elements to make the memory consumption under Python 2 worth worrying about.","commit_id":"a9e86b14e277c87543ef3a99af0593f9d897b047"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"975e46730b92fe28bde342843c21eb6249b56fa3","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        \"\"\"Returns the index after the last argument"},{"line_number":88,"context_line":"        in argv that can be a command word"},{"line_number":89,"context_line":"        \"\"\""},{"line_number":90,"context_line":"        return next((i for i, arg in enumerate(argv) if arg.startswith(\u0027-\u0027)),"},{"line_number":91,"context_line":"                    len(argv))"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba5201f7_ad20cf9c","line":90,"updated":"2017-01-02 19:47:55.000000000","message":"Using an iterator here instead of a regular for loop also seems like unnecessary optimization that causes some obfuscation.\n\n  for i, arg in enumerate(argv):\n    if arg.startswith(\u0027-\u0027):\n      return i\n  return len(argv)","commit_id":"a9e86b14e277c87543ef3a99af0593f9d897b047"}],"cliff/tests/test_commandmanager.py":[{"author":{"_account_id":20354,"name":"Shoham Peller","email":"shohamp@gmail.com","username":"shoham.peller"},"change_message_id":"d6025969dd4621905afd37f6d8b477ae8a1ccb69","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    assert found_cmd is mock_cmd"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"def test_add_command_find():"},{"line_number":74,"context_line":"    def foo(arg):"},{"line_number":75,"context_line":"        pass"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_99e66fe6","line":73,"updated":"2016-08-30 08:24:06.000000000","message":"Need better name IMO - test_intersected_commands?","commit_id":"aa9cb601d851330029b68e1d16631cce345153bc"}]}