)]}'
{"cliff/formatters/shell.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"7a0b02380187c46c8ca8a6f1421bb61824615319","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                value \u003d (six.text_type(value.machine_readable())"},{"line_number":54,"context_line":"                         if isinstance(value, columns.FormattableColumn)"},{"line_number":55,"context_line":"                         else value)"},{"line_number":56,"context_line":"                if isinstance(value, six.string_types):"},{"line_number":57,"context_line":"                    value \u003d value.replace(\u0027\"\u0027, \u0027\\\\\"\u0027)"},{"line_number":58,"context_line":"                # Colons and dashes may appear as a resource property but are"},{"line_number":59,"context_line":"                # invalid to use in a shell, replace them with an underscore."}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_8944a01b","line":56,"updated":"2016-11-09 19:20:28.000000000","message":"I think you want to indent those new changes under this test to avoid having issues with commands that return non-string values.","commit_id":"fa6abdf44ac55113c8696e0807464bf00aed5641"},{"author":{"_account_id":7217,"name":"Hugh Saunders","email":"hugh@wherenow.org","username":"hughsaunders"},"change_message_id":"64acfc498d6bc50bfb4943288cf23b4e9f056834","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                value \u003d (six.text_type(value.machine_readable())"},{"line_number":54,"context_line":"                         if isinstance(value, columns.FormattableColumn)"},{"line_number":55,"context_line":"                         else value)"},{"line_number":56,"context_line":"                if isinstance(value, six.string_types):"},{"line_number":57,"context_line":"                    value \u003d value.replace(\u0027\"\u0027, \u0027\\\\\"\u0027)"},{"line_number":58,"context_line":"                # Colons and dashes may appear as a resource property but are"},{"line_number":59,"context_line":"                # invalid to use in a shell, replace them with an underscore."}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_dfcc816c","line":56,"in_reply_to":"9a629dbe_690aec7a","updated":"2016-11-09 22:50:50.000000000","message":"Non-string keys are very unlikely to produce valid bash identifiers, so its probably an error to throw a non-string key at a shell formatter?","commit_id":"fa6abdf44ac55113c8696e0807464bf00aed5641"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"f80397b6b3282b9f554882a6dc4f6a17a80098e5","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                value \u003d (six.text_type(value.machine_readable())"},{"line_number":54,"context_line":"                         if isinstance(value, columns.FormattableColumn)"},{"line_number":55,"context_line":"                         else value)"},{"line_number":56,"context_line":"                if isinstance(value, six.string_types):"},{"line_number":57,"context_line":"                    value \u003d value.replace(\u0027\"\u0027, \u0027\\\\\"\u0027)"},{"line_number":58,"context_line":"                # Colons and dashes may appear as a resource property but are"},{"line_number":59,"context_line":"                # invalid to use in a shell, replace them with an underscore."}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_690aec7a","line":56,"in_reply_to":"9a629dbe_8944a01b","updated":"2016-11-09 19:30:53.000000000","message":"but that tests \"values\", i could do a similar check for \"name\" as well.","commit_id":"fa6abdf44ac55113c8696e0807464bf00aed5641"}]}