)]}'
{"cliff/complete.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"68f67e3120ed0054055a7a728d17ad4957bfdfec","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    log \u003d logging.getLogger(__name__ + \u0027.CompleteCommand\u0027)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def __init__(self, app, app_args, cmd_name\u003dNone):"},{"line_number":171,"context_line":"        super(CompleteCommand, self).__init__(app, app_args, cmd_name)"},{"line_number":172,"context_line":"        self._formatters \u003d stevedore.ExtensionManager("},{"line_number":173,"context_line":"            namespace\u003d\u0027cliff.formatter.completion\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_38d689f3","line":170,"range":{"start_line":170,"start_character":23,"end_line":170,"end_character":51},"updated":"2017-06-07 12:32:47.000000000","message":"nit: I guess you could just use *args and **kwargs to prevent this in the future?","commit_id":"cdc5c0ce2401f3f9c94e99cac2f933eb79a74009"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"60326684a6e947bff6bc38eac49506033296ed0f","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    log \u003d logging.getLogger(__name__ + \u0027.CompleteCommand\u0027)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def __init__(self, app, app_args, cmd_name\u003dNone):"},{"line_number":171,"context_line":"        super(CompleteCommand, self).__init__(app, app_args, cmd_name)"},{"line_number":172,"context_line":"        self._formatters \u003d stevedore.ExtensionManager("},{"line_number":173,"context_line":"            namespace\u003d\u0027cliff.formatter.completion\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_3eef91b1","line":170,"range":{"start_line":170,"start_character":23,"end_line":170,"end_character":51},"in_reply_to":"df140735_38d689f3","updated":"2017-06-07 13:26:28.000000000","message":"Or more thorough testing. :-)","commit_id":"cdc5c0ce2401f3f9c94e99cac2f933eb79a74009"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8f9b817e9ddc93aba088f9aedc339eb60fb27174","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    log \u003d logging.getLogger(__name__ + \u0027.CompleteCommand\u0027)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def __init__(self, app, app_args, cmd_name\u003dNone):"},{"line_number":171,"context_line":"        super(CompleteCommand, self).__init__(app, app_args, cmd_name)"},{"line_number":172,"context_line":"        self._formatters \u003d stevedore.ExtensionManager("},{"line_number":173,"context_line":"            namespace\u003d\u0027cliff.formatter.completion\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_7e7504cc","line":170,"range":{"start_line":170,"start_character":23,"end_line":170,"end_character":51},"in_reply_to":"df140735_3eef91b1","updated":"2017-06-07 15:43:47.000000000","message":"As a library, i prefer to specifying arguments explicitly as much as possible. *args or **kwargs makes things a bit messy.\n\nIn this case, the method signature matches with command.Command, so it looks fine to me.","commit_id":"cdc5c0ce2401f3f9c94e99cac2f933eb79a74009"}]}